Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7448/?format=api
{ "id": 7448, "url": "https://patches.dpdk.org/api/patches/7448/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444067692-29645-9-git-send-email-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444067692-29645-9-git-send-email-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444067692-29645-9-git-send-email-adrien.mazarguil@6wind.com", "date": "2015-10-05T17:54:43", "name": "[dpdk-dev,08/17] mlx5: use alternate method to configure promiscuous mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ab7c5ce88c0b2e1f26b4a5353731046a4f4d1836", "submitter": { "id": 165, "url": "https://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444067692-29645-9-git-send-email-adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7448/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7448/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F1E8593D8;\n\tMon, 5 Oct 2015 19:55:32 +0200 (CEST)", "from mail-wi0-f170.google.com (mail-wi0-f170.google.com\n\t[209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 0289D9238\n\tfor <dev@dpdk.org>; Mon, 5 Oct 2015 19:55:30 +0200 (CEST)", "by wicgb1 with SMTP id gb1so130861780wic.1\n\tfor <dev@dpdk.org>; Mon, 05 Oct 2015 10:55:30 -0700 (PDT)", "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tgc8sm15843768wib.2.2015.10.05.10.55.30\n\t(version=TLSv1.2 cipher=RC4-SHA bits=128/128);\n\tMon, 05 Oct 2015 10:55:30 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=NKliCOAryyrdc3noCJL/6qdNewZ/HKVAiZ97wO93h/4=;\n\tb=ELncy5XD/yPb0RhFRqXEAgcmLTNZmvjUMrTasFukOgrfHEsim8JhrWuo1dyZGR0g94\n\tMHmgyeFUHQvKYBep3RYvfO2d+SfZSQROWmg2rb1ctB4y/D/6O7xDY8EZeMTJ/tqk5sSH\n\tKcSHGMYU3H5oifgzQueS3kjKsywp6o6BWgyLJIi194NGVaK/RKscrsK9gvEmLM+rnSR2\n\tP03rlM8HM2822lD8JMxDEmJVWP9fQx0DpJRVZv4W8XJUzOd56jhZtQjCqC7qm5YWchIc\n\tCfYGSSAWEu/DV9rzUn+tkPsX7Fjdq2KWBxZR0SoRh6CvYU1iBQCqKk5FSE8cMm8ExOBD\n\tzvaQ==", "X-Gm-Message-State": "ALoCoQmLeUVIas3tTxeQv7PwzRpyBWgSi3jvC6CPB5gfqyAgc3vKRRq1k8zxy+jZiIRVosAVGXkG", "X-Received": "by 10.195.11.40 with SMTP id ef8mr31666594wjd.103.1444067730798; \n\tMon, 05 Oct 2015 10:55:30 -0700 (PDT)", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 5 Oct 2015 19:54:43 +0200", "Message-Id": "<1444067692-29645-9-git-send-email-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1444067692-29645-1-git-send-email-adrien.mazarguil@6wind.com>", "References": "<1444067692-29645-1-git-send-email-adrien.mazarguil@6wind.com>", "Subject": "[dpdk-dev] [PATCH 08/17] mlx5: use alternate method to configure\n\tpromiscuous mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Olga Shern <olgas@mellanox.com>\n\nPromiscuous mode was historically enabled by adding a specific flow with\ntype IBV_FLOW_ATTR_ALL_DEFAULT to each hash RX queue, but this method is\ndeprecated. It is now simply enabled by omitting destination MAC addresses\nfrom basic flow specifications.\n\nSigned-off-by: Olga Shern <olgas@mellanox.com>\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_rxmode.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c\nindex 7fe7f0e..aab38ee 100644\n--- a/drivers/net/mlx5/mlx5_rxmode.c\n+++ b/drivers/net/mlx5/mlx5_rxmode.c\n@@ -74,20 +74,21 @@ static int\n hash_rxq_promiscuous_enable(struct hash_rxq *hash_rxq)\n {\n \tstruct ibv_flow *flow;\n-\tstruct ibv_flow_attr attr = {\n-\t\t.type = IBV_FLOW_ATTR_ALL_DEFAULT,\n-\t\t.num_of_specs = 0,\n-\t\t.port = hash_rxq->priv->port,\n-\t\t.flags = 0\n-\t};\n+\tstruct priv *priv = hash_rxq->priv;\n+\tFLOW_ATTR_SPEC_ETH(data, priv_populate_flow_attr(priv, NULL, 0,\n+\t\t\t\t\t\t\t hash_rxq->type));\n+\tstruct ibv_flow_attr *attr = &data->attr;\n \n \tif (hash_rxq->priv->vf)\n \t\treturn 0;\n \tDEBUG(\"%p: enabling promiscuous mode\", (void *)hash_rxq);\n \tif (hash_rxq->promisc_flow != NULL)\n \t\treturn EBUSY;\n+\t/* Promiscuous flows only differ from normal flows by not filtering\n+\t * on specific MAC addresses. */\n+\tpriv_populate_flow_attr(priv, attr, sizeof(data), hash_rxq->type);\n \terrno = 0;\n-\tflow = ibv_create_flow(hash_rxq->qp, &attr);\n+\tflow = ibv_create_flow(hash_rxq->qp, attr);\n \tif (flow == NULL) {\n \t\t/* It's not clear whether errno is always set in this case. */\n \t\tERROR(\"%p: flow configuration failed, errno=%d: %s\",\n", "prefixes": [ "dpdk-dev", "08/17" ] }