List comments

GET /api/patches/74477/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116300,
        "web_url": "https://patches.dpdk.org/comment/116300/",
        "msgid": "<AM0PR05MB6707447CDF1EC8709FD801B9C27B0@AM0PR05MB6707.eurprd05.prod.outlook.com>",
        "date": "2020-07-20T12:14:32",
        "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix the compatibility with MISC4",
        "submitter": {
            "id": 513,
            "url": "https://patches.dpdk.org/api/people/513/",
            "name": "Raslan Darawsheh",
            "email": "rasland@mellanox.com"
        },
        "content": "Hi,\n\n> -----Original Message-----\n> From: Bing Zhao <bingz@mellanox.com>\n> Sent: Monday, July 20, 2020 12:04 PM\n> To: Ori Kam <orika@mellanox.com>; Slava Ovsiienko\n> <viacheslavo@mellanox.com>\n> Cc: Raslan Darawsheh <rasland@mellanox.com>; Matan Azrad\n> <matan@mellanox.com>; dev@dpdk.org\n> Subject: [PATCH] net/mlx5: fix the compatibility with MISC4\n> \n> When eCPRI offloading is introduced, the support for misc parameters\n> 4 of flow table entry (FTE) match set is needed. The structure of\n> \"mlx5_ifc_fte_match_param_bits\" is extended with\n> \"mlx5_ifc_fte_match_set_misc4_bits\" at the end of it. The total size\n> of the FTE match set will be changed into 384 bytes from 320 bytes.\n> Low level user space driver (rdma-core) will have the validation of\n> the length of FTE match set. In the old release that no MISC4\n> supported in the rdma-core, the validation will fail, and this will\n> break the backward compatibility, even if the MISC4 is not used in\n> most cases.\n> In order to make new mlx5 PMD work well with old rdma-core, the\n> length adjustment needs to be done. When creating a flow, the lengths\n> of the matcher and value are both set to 320 without MISC4. There is\n> no need to change the structure definition, all bytes of the MISC4\n> will be discarded if it is not needed. Or else, like in eCPRI\n> matching, the lengths will be adjusted to 384 for matcher creation\n> and value matching.\n> \n> Fixes: afa8556c873c (\"net/mlx5: add flow translation of eCPRI header\")\n> \n> Signed-off-by: Bing Zhao <bingz@mellanox.com>\n> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> ---\n>  drivers/net/mlx5/mlx5_flow_dv.c | 17 +++++++++++++++--\n>  1 file changed, 15 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c\n> b/drivers/net/mlx5/mlx5_flow_dv.c\n> index ee66a44..778a766 100644\n> --- a/drivers/net/mlx5/mlx5_flow_dv.c\n> +++ b/drivers/net/mlx5/mlx5_flow_dv.c\n> @@ -5765,7 +5765,15 @@ struct field_modify_info modify_tcp[] = {\n>  \tdev_flow = &((struct mlx5_flow *)priv->inter_flows)[priv-\n> >flow_idx++];\n>  \tdev_flow->handle = dev_handle;\n>  \tdev_flow->handle_idx = handle_idx;\n> -\tdev_flow->dv.value.size = MLX5_ST_SZ_BYTES(fte_match_param);\n> +\t/*\n> +\t * In some old rdma-core releases, before continuing, a check of the\n> +\t * length of matching parameter will be done at first. It needs to use\n> +\t * the length without misc4 param. If the flow has misc4 support,\n> then\n> +\t * the length needs to be adjusted accordingly. Each param member\n> is\n> +\t * aligned with a 64B boundary naturally.\n> +\t */\n> +\tdev_flow->dv.value.size = MLX5_ST_SZ_BYTES(fte_match_param) -\n> +\t\t\t\t  MLX5_ST_SZ_BYTES(fte_match_set_misc4);\n>  \t/*\n>  \t * The matching value needs to be cleared to 0 before using. In the\n>  \t * past, it will be automatically cleared when using rte_*alloc\n> @@ -7986,7 +7994,8 @@ struct field_modify_info modify_tcp[] = {\n>  \tuint64_t priority = attr->priority;\n>  \tstruct mlx5_flow_dv_matcher matcher = {\n>  \t\t.mask = {\n> -\t\t\t.size = sizeof(matcher.mask.buf),\n> +\t\t\t.size = sizeof(matcher.mask.buf) -\n> +\t\t\t\tMLX5_ST_SZ_BYTES(fte_match_set_misc4),\n>  \t\t},\n>  \t};\n>  \tint actions_n = 0;\n> @@ -8678,6 +8687,10 @@ struct field_modify_info modify_tcp[] = {\n>  \t\t\t\t\t\tNULL,\n>  \t\t\t\t\t\t\"cannot create eCPRI\n> parser\");\n>  \t\t\t}\n> +\t\t\t/* Adjust the length matcher and device flow value.\n> */\n> +\t\t\tmatcher.mask.size =\n> MLX5_ST_SZ_BYTES(fte_match_param);\n> +\t\t\tdev_flow->dv.value.size =\n> +\n> \tMLX5_ST_SZ_BYTES(fte_match_param);\n>  \t\t\tflow_dv_translate_item_ecpri(dev, match_mask,\n>  \t\t\t\t\t\t     match_value, items);\n>  \t\t\t/* No other protocol should follow eCPRI layer. */\n> --\n> 1.8.3.1\n\nPatch squashed into relevant commit in master-net-mlx,\n\nKindest regards,\nRaslan Darawsheh",
        "headers": {
            "Accept-Language": "en-US",
            "X-Mailman-Version": "2.1.15",
            "x-ms-oob-tlc-oobclassifiers": "OLM:1923;",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR05MB3460",
            "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;",
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "x-ms-exchange-senderadcheck": "1",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix the compatibility with MISC4",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05E05A0540;\n\tMon, 20 Jul 2020 14:14:35 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7929E1023;\n\tMon, 20 Jul 2020 14:14:34 +0200 (CEST)",
                "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80])\n by dpdk.org (Postfix) with ESMTP id 2A92AA69\n for <dev@dpdk.org>; Mon, 20 Jul 2020 14:14:33 +0200 (CEST)",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM4PR05MB3460.eurprd05.prod.outlook.com (2603:10a6:205:6::25) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Mon, 20 Jul\n 2020 12:14:32 +0000",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020\n 12:14:32 +0000"
            ],
            "x-originating-ip": "[84.242.49.134]",
            "x-microsoft-antispam": "BCL:0;",
            "x-ms-exchange-transport-forked": "True",
            "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N+EPFgcQZ9o3c9uQqUa1XN4jBKtNGKVRYcggZTHnUUU=;\n b=RcqyM0ElbF5ThEaKAce92eCPCafy1gQG4kBdSWeiVd32d8wO/HEHIA0BjYVUqSfhPHIDPc0Xf+F91EmBPPz9PA+7gCfTEojsHmQSV94DmA7FEO2UaIXpi+6TBiBNYe9aF3sGO5FeJhZ4gaoVTugI+UEylzUEEwhUuvEtleIUyqTkq9WQk0Ym0nzHJkX5d0x7L5dUrpW0iwzXsSRrH/earHMEHi7qG0q62Rt1lxLGCt5EQVKxCuw0KUPP/mauxil98oo1UCyGrBsseJYfaHQ28OrLtq3lpshWOmDmm56eiwlyHBc6RdZDDMhSLW4QX6Afs/Nf11sBfJQ921As2ryIRA==",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N+EPFgcQZ9o3c9uQqUa1XN4jBKtNGKVRYcggZTHnUUU=;\n b=hXq6pBa0A8ZjYG/tWCPimX6BRSWVMJy4w2sSQMSZaF6ZreiWAah1bKLVjcA1VheYWQfxEQBk0TX6Ab8mrJGRymSiwjyPdFXLLIVJaC7UdnskvS9h3TWs87/l1zrTfYfhPryVS5uLNF44ajJ4fDbK5oGx1eymoVinDFqTdQECiNU=",
            "Message-ID": "\n <AM0PR05MB6707447CDF1EC8709FD801B9C27B0@AM0PR05MB6707.eurprd05.prod.outlook.com>",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n +G1hYQOpt53wTs9zZhy/HW4yZCqcTVbzZtt/65Q8F55c5CW2Ubd85rBz2T/AXax7jxrhjmK8XRxBqCKFC8/Cyg==",
            "To": "Bing Zhao <bingz@mellanox.com>, Ori Kam <orika@mellanox.com>, Slava\n Ovsiienko <viacheslavo@mellanox.com>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "From": "Raslan Darawsheh <rasland@mellanox.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "x-ms-publictraffictype": "Email",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none",
            "X-MS-TNEF-Correlator": "",
            "Thread-Index": "AQHWXnSy/tIYKaf6N0W3yg4bZYKkfakQYXsg",
            "CC": "Matan Azrad <matan@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "X-OriginatorOrg": "Mellanox.com",
            "Thread-Topic": "[PATCH] net/mlx5: fix the compatibility with MISC4",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "x-microsoft-antispam-message-info": "\n QYhzdegMjVJTJZ+m002GHrMR6P39VkDMqbl404BRh2iYPj5djSWx27/5MesuJvk7AuZdpAduoHtBC2dK2MnTCuM+0449EKE5E2J9pJoUnAYKWDU8x2t64r7qDV3/IAsTFuuj33Q0w6V5CzJ4Q7NiYx6/z+V85HQyisXLdamxkgKwhWr3Vi5iG8GfiN+Wc7fMSotLSaW0Uqikxx6ama5MqwnTFVHPAbLJLpUY2e/r5/QNJ1EAEl2QSD2VYX0HLgcATc+Awrs4Hu3352IWB6s0xWL0ODgWwAkuOaYilcWc6JugQ2Pg1JkULzIPkXOoauhj",
            "x-ms-office365-filtering-ht": "Tenant",
            "MIME-Version": "1.0",
            "In-Reply-To": "<1595235822-114874-1-git-send-email-bingz@mellanox.com>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1595235822-114874-1-git-send-email-bingz@mellanox.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "x-ms-office365-filtering-correlation-id": "b4a9767f-379c-4673-2bf3-08d82ca675ac",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b4a9767f-379c-4673-2bf3-08d82ca675ac",
            "Date": "Mon, 20 Jul 2020 12:14:32 +0000",
            "Content-Transfer-Encoding": "quoted-printable",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(366004)(4326008)(9686003)(478600001)(86362001)(54906003)(110136005)(52536014)(186003)(2906002)(76116006)(64756008)(66556008)(66476007)(66946007)(6636002)(316002)(8936002)(8676002)(7696005)(66446008)(53546011)(6506007)(71200400001)(83380400001)(26005)(55016002)(5660300002)(33656002);\n DIR:OUT; SFP:1101;",
            "X-MS-Has-Attach": "",
            "x-ms-traffictypediagnostic": "AM4PR05MB3460:",
            "x-ms-exchange-antispam-messagedata": "\n IwG86OKtuGE9cwsqHvehJHHcXWvOJcgFLLc5ORnYzQZ9JUVE7sSLr8bXUZJxSzoAe69wY+v0mEH9pyUB1oTTSdtoFYvP9v3ONejq/9a45u1ebL+/rMrdZwEbs4F2Rln7mnHPUhm8GMyq0Di850xgIZpJkAZYzUI584akS1iPvo68xKRb7M9tuFWtRLo3TpketTKJixxsbdyYafN5mrW13FFd1HLcQdSRosyy7fYvFACLqpoHefGimwkiZItEARlhFFq3Nceb523SIRPWrH9kO3NutFKpHmCrnNO8wEGc9vhrY1iqWlb0PZ9g+j38ieyfbUrtuQLFf0GAp/ZVaDvQ8ReXtgToUrVB8Hb3O7MUze4Y2tvmv4Jv6KWD3BpxZiezg925R08IE5BW2O6jHIo/7NEGOVtQnpqShHfXSNiW/82WpxCiZu9/tZp3Pv/FDCvaCyN3lqrni47oDaP6FUvtnMXoWz5Zr6q+DNijghOsUbRLoLycxN0phFC4RtG0Cpm7",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "20 Jul 2020 12:14:32.2410 (UTC)",
            "Content-Language": "en-US",
            "Errors-To": "dev-bounces@dpdk.org",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=IXhwD+G4roudDkSzupUkYIue/gKlUWibMA+8Wp9mUzRYK53dbPMztA4MqJrwcH5BDCoHxWzFWBL8I9PFyDFxF84soFMMvKV3YZX3B6X8nCZJL5CeXJDyaFxWl9Pqs7gNIGBGBcJkRgRYkA06PrVp0Y8TFAP7jM8ilQqhw5VqPqiGsIpqacFTrPdTTqpqqWi2hRxJMO/UmHikX254/s2T/uY/F30+8HSzq2b/hwoV87Svn8RZ7EG6NuhfoxqC0Hksfh7JYUn/1ztL/IcQY0lwxH1fDgWIcyfEJ6qV72qmvxz3LlwuS8LD7R6NxrNICnboBjDpgTHCLFm/K704QqvgFA==",
            "x-microsoft-antispam-prvs": "\n <AM4PR05MB3460D8D241D052D2C26A666DC27B0@AM4PR05MB3460.eurprd05.prod.outlook.com>"
        }
    }
]