Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74475/?format=api
{ "id": 74475, "url": "https://patches.dpdk.org/api/patches/74475/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200720065938.4108436-1-junfeng.guo@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200720065938.4108436-1-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200720065938.4108436-1-junfeng.guo@intel.com", "date": "2020-07-20T06:59:38", "name": "net/ice/base: free memory for GTP-U before return status", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4d9e3b69f10ef39560d5c167b13cf72173a3b338", "submitter": { "id": 1785, "url": "https://patches.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200720065938.4108436-1-junfeng.guo@intel.com/mbox/", "series": [ { "id": 11161, "url": "https://patches.dpdk.org/api/series/11161/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11161", "date": "2020-07-20T06:59:38", "name": "net/ice/base: free memory for GTP-U before return status", "version": 1, "mbox": "https://patches.dpdk.org/series/11161/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74475/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/74475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A2A0A0540;\n\tMon, 20 Jul 2020 09:01:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 04DC91BF0B;\n\tMon, 20 Jul 2020 09:01:26 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 7753D1BEE3\n for <dev@dpdk.org>; Mon, 20 Jul 2020 09:01:23 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 00:01:22 -0700", "from dpdk-junfengguo-v3.sh.intel.com ([10.67.119.146])\n by fmsmga004.fm.intel.com with ESMTP; 20 Jul 2020 00:01:20 -0700" ], "IronPort-SDR": [ "\n N0bK8yYLJGbz5F42nG94KizjKzrjB23KFBJaTUZ67FCqWLLNTotkdRe37NJAwHPOn5Alvnvgvl\n +cxHR8vgrKtg==", "\n uV/YYS98JfiW38UeqoksqaDmtxb6kK6fsTnfOlfjHMGc82lrUHVh6bjaj40aN+8Hte4e75saBi\n pM9oV5Ok/hKw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9687\"; a=\"149848868\"", "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"149848868\"", "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"309735293\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com,\n\tbeilei.xing@intel.com", "Cc": "dev@dpdk.org, jia.guo@intel.com, junfeng.guo@intel.com, simei.su@intel.com", "Date": "Mon, 20 Jul 2020 14:59:38 +0800", "Message-Id": "<20200720065938.4108436-1-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/ice/base: free memory for GTP-U before\n\treturn status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add memory space free logic for adding and removing GTP-U before return\nsuccess status, to aviod memory leak issue.\n\nFixes: bed9bb3139ef (\"net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist\")\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 094f5370a..6035bdfcf 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -3586,8 +3586,10 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,\n \n \t/* don't do RSS for GTPU outer */\n \tif (segs_cnt == ICE_RSS_OUTER_HEADERS &&\n-\t segs[segs_cnt - 1].hdrs & ICE_FLOW_SEG_HDR_GTPU)\n-\t\treturn ICE_SUCCESS;\n+\t segs[segs_cnt - 1].hdrs & ICE_FLOW_SEG_HDR_GTPU) {\n+\t\tstatus = ICE_SUCCESS;\n+\t\tgoto exit;\n+\t}\n \n \t/* Search for a flow profile that has matching headers, hash fields\n \t * and has the input VSI associated to it. If found, no further\n@@ -3746,8 +3748,10 @@ ice_rem_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,\n \t\tgoto out;\n \n \tif (segs_cnt == ICE_RSS_OUTER_HEADERS &&\n-\t segs[segs_cnt - 1].hdrs & ICE_FLOW_SEG_HDR_GTPU)\n-\t\treturn ICE_SUCCESS;\n+\t segs[segs_cnt - 1].hdrs & ICE_FLOW_SEG_HDR_GTPU) {\n+\t\tstatus = ICE_SUCCESS;\n+\t\tgoto out;\n+\t}\n \n \tprof = ice_flow_find_prof_conds(hw, blk, ICE_FLOW_RX, segs, segs_cnt,\n \t\t\t\t\tvsi_handle,\n", "prefixes": [] }