List comments

GET /api/patches/74457/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116275,
        "web_url": "https://patches.dpdk.org/comment/116275/",
        "msgid": "<cee43abd-81f1-d794-647c-9ac183b4dd77@intel.com>",
        "date": "2020-07-20T08:56:59",
        "subject": "Re: [dpdk-dev] [DPDK] net/i40e: add the VLAN capabilities of NIC",
        "submitter": {
            "id": 507,
            "url": "https://patches.dpdk.org/api/people/507/",
            "name": "Guo, Jia",
            "email": "jia.guo@intel.com"
        },
        "content": "hi,  zhihong\n\nOn 7/20/2020 10:42 AM, zhihongx.peng@intel.com wrote:\n> From: Peng Zhihong <zhihongx.peng@intel.com>\n>\n> The rte_eth_dev_set_vlan_offload function will check whether the NIC has\n> the set vlan feature. If it has not, it will return failure. So need\n\n\n\"...has the set vlan feature...\" , that need to refine.\n\n\n> to add all the vlan feature flags of the NIC.\n>\n> Fixes: e0cb96204b71 (net/i40e: add support for representor ports)\n> Cc: declan.doherty@intel.com\n>\n> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>\n> ---\n>   drivers/net/i40e/i40e_vf_representor.c | 3 ++-\n>   1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c\n> index b07b35c03..083bc1a5f 100644\n> --- a/drivers/net/i40e/i40e_vf_representor.c\n> +++ b/drivers/net/i40e/i40e_vf_representor.c\n> @@ -46,7 +46,8 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,\n>   \t\tDEV_RX_OFFLOAD_QINQ_STRIP |\n>   \t\tDEV_RX_OFFLOAD_IPV4_CKSUM |\n>   \t\tDEV_RX_OFFLOAD_UDP_CKSUM |\n> -\t\tDEV_RX_OFFLOAD_TCP_CKSUM;\n> +\t\tDEV_RX_OFFLOAD_TCP_CKSUM |\n> +\t\tDEV_RX_OFFLOAD_VLAN_FILTER;\n>   \tdev_info->tx_offload_capa =\n>   \t\tDEV_TX_OFFLOAD_MULTI_SEGS  |\n>   \t\tDEV_TX_OFFLOAD_VLAN_INSERT |",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9687\"; a=\"137973955\"",
                "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"137973955\"",
                "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"431543383\""
            ],
            "IronPort-SDR": [
                "\n AAHMmAG5huD9VCoDX2lT0eY6QdbDZKepKQGGHGRsJA9mui8RbnP6d23mBhXnCCFyArHT3x8dpn\n 74mHgPSZWDyw==",
                "\n JHfxH390Lj4gmTDFH6Blg6XLsKIWrxIFcMD98+vtCD6sYN5cb+XxLP+irsxJ4yngSb5AgOZo0Y\n FjJE5JTi71CA=="
            ],
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "X-Mailman-Version": "2.1.15",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "MIME-Version": "1.0",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<20200720024214.13972-1-zhihongx.peng@intel.com>",
            "Subject": "Re: [dpdk-dev] [DPDK] net/i40e: add the VLAN capabilities of NIC",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "From": "Jeff Guo <jia.guo@intel.com>",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7FBFBA0540;\n\tMon, 20 Jul 2020 10:57:05 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 88FAE25B3;\n\tMon, 20 Jul 2020 10:57:04 +0200 (CEST)",
                "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 64EA31DBB\n for <dev@dpdk.org>; Mon, 20 Jul 2020 10:57:02 +0200 (CEST)",
                "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 01:57:01 -0700",
                "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.178])\n ([10.67.68.178])\n by orsmga004.jf.intel.com with ESMTP; 20 Jul 2020 01:56:59 -0700"
            ],
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "<cee43abd-81f1-d794-647c-9ac183b4dd77@intel.com>",
            "Date": "Mon, 20 Jul 2020 16:56:59 +0800",
            "Content-Transfer-Encoding": "8bit",
            "To": "zhihongx.peng@intel.com, beilei.xing@intel.com",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "In-Reply-To": "<20200720024214.13972-1-zhihongx.peng@intel.com>",
            "Cc": "dev@dpdk.org, declan.doherty@intel.com",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Content-Language": "en-US"
        }
    }
]