Patch Comment List
List patch comments
GET /api/patches/74456/comments/?format=api
[ { "id": 116256, "web_url": "https://patches.dpdk.org/comment/116256/", "msgid": "<MWHPR11MB139104139FC4CC29E332EC92B77B0@MWHPR11MB1391.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/MWHPR11MB139104139FC4CC29E332EC92B77B0@MWHPR11MB1391.namprd11.prod.outlook.com", "date": "2020-07-20T01:59:32", "subject": "Re: [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC", "submitter": { "id": 495, "url": "https://patches.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "content": "Hi, \n\n> -----Original Message-----\n> From: Peng, ZhihongX <zhihongx.peng@intel.com>\n> Sent: Monday, July 20, 2020 9:47 AM\n> To: Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia <jia.guo@intel.com>\n> Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>;\n> wei.dai@intel.com\n> Subject: [DPDK] net/e1000: add the VLAN capabilities of NIC\n> \n> From: Peng Zhihong <zhihongx.peng@intel.com>\n> \n> The rte_eth_dev_set_vlan_offload function will check whether the NIC has the\n> set vlan feature. If it has not, it will return failure. So need to add all the vlan\n> feature flags of the NIC.\n> \n> Fixes: ef990fb56e55 (\"net/e1000: convert to new Rx offloads API\")\n> Cc: wei.dai@intel.com\n\n\nyou should cc stable not wei.dai\n\n> \n> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>\n> ---\n> drivers/net/e1000/igb_rxtx.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index\n> 5717cdb70..966df3f20 100644\n> --- a/drivers/net/e1000/igb_rxtx.c\n> +++ b/drivers/net/e1000/igb_rxtx.c\n> @@ -1647,7 +1647,8 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev\n> *dev)\n> \t\t\t DEV_RX_OFFLOAD_JUMBO_FRAME |\n> \t\t\t DEV_RX_OFFLOAD_KEEP_CRC |\n> \t\t\t DEV_RX_OFFLOAD_SCATTER |\n> -\t\t\t DEV_RX_OFFLOAD_RSS_HASH;\n> +\t\t\t DEV_RX_OFFLOAD_RSS_HASH |\n> +\t\t\t DEV_RX_OFFLOAD_VLAN_EXTEND;\n> \n> \treturn rx_offload_capa;\n> }\n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2791CA0540;\n\tMon, 20 Jul 2020 03:59:40 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4439C2B9C;\n\tMon, 20 Jul 2020 03:59:39 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 8AAC02B9C\n for <dev@dpdk.org>; Mon, 20 Jul 2020 03:59:37 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Jul 2020 18:59:36 -0700", "from orsmsx105.amr.corp.intel.com ([10.22.225.132])\n by fmsmga002.fm.intel.com with ESMTP; 19 Jul 2020 18:59:36 -0700", "from ORSEDG002.ED.cps.intel.com (10.7.248.5) by\n ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Sun, 19 Jul 2020 18:59:35 -0700", "from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.59) by\n edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Sun, 19 Jul 2020 18:59:36 -0700", "from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15)\n by MWHPR11MB2014.namprd11.prod.outlook.com (2603:10b6:300:25::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Mon, 20 Jul\n 2020 01:59:32 +0000", "from MWHPR11MB1391.namprd11.prod.outlook.com\n ([fe80::f8f5:b48c:be92:ac17]) by MWHPR11MB1391.namprd11.prod.outlook.com\n ([fe80::f8f5:b48c:be92:ac17%3]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020\n 01:59:32 +0000" ], "IronPort-SDR": [ "\n ys+Dw2NO2WuLNQ8NeA/sOTbjfe8XWaF6fQQ+FCyOS5JycZ+I2aItNovfmQ7ibwU0bODGp4LXNj\n pkqUSyICc4ag==", "\n QtrOV6FnUA8iKZ+g7A/ypWAHbB5l4XX7o6X8JCFVRNsF3NbVduH8imavH9gaDhEJ1pRlSPBQ5O\n VhrY80Dj+zPw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9687\"; a=\"148995140\"", "E=Sophos;i=\"5.75,373,1589266800\"; d=\"scan'208\";a=\"148995140\"", "E=Sophos;i=\"5.75,373,1589266800\"; d=\"scan'208\";a=\"319374373\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=kSvO3Tk1QyQPzTsKCy32/eWkwYBRX/K3zWx9phBloQl3y8mK4lTq8OvvKBl8sk5IZNGnPZlTogGiUtkuLjTfSB40u1yUefqJDtjbWk2hQVHkEUHXPqAOF9lDK0Ar8QFrfSREr5kknMDus2/wKBOpWaHFLPM9r+I5cvNz7Rr6wBdyJpUl//WZ394o8Pl9WQyIzGdDMFtiCEf6+1NmUN+J6Q4tzYihvohiRasx43qsBCp5aRczKNyjeoPWUj6mkcQRkbRkuyH7Tn2EkAArz9JFxObw26KAcKqeYaiaXSSZesnMB4xDdR1Pb1X3Zq9wcC7M1OZ5uR/FvafuqqrMwGa59g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N9zcP+HNrvIKHLc1f294MzmbBS4q1CZkQGs0wbwWa1k=;\n b=bGpjI4lCD1DPMyMveoZV1jrejXHs1lVWl6NiBXNMq51waLr79BXl4hMWuya3aZSlcmMiEPm35ZDsVVPBdx9L/NT4RIcZfUQRNXEHahFMLc1FX6ZcJJS8k/BOUXkXXdEq2O4qyk2rAeNJTIAhxSfSw4uZdYfxIrL6WkcmQJpMT6wvUhM/YOln87grck8fqhHgzRpwwnMNcR/NyAkkI6kpiQSRh2dSN2KOfaMJPk9z3c5WMTuS335DLrDoJBWEHxLgOWXnG6btEB0UhdrKx8XcJrrZKtU2fendX+4wRv7zM3nvj1oEQe6h6S37Uy03mK0FH6NP1eMFFJ6Rs2mmRDM6IA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N9zcP+HNrvIKHLc1f294MzmbBS4q1CZkQGs0wbwWa1k=;\n b=a/veobSoksN8BaYq2uVmLF2RTv4hY35axTEHDleDmFTvEVq07xteInUPF1j+ZzgKqw3omHu7C9u7nFJAvoFJ1KY/6F/DcBd3gK8ELeH0L7c51IdOd6KegIvxDAEcEgV8rliI6M3pjjIyTWFIQUaBC+jNYoNG9OvAfcJwHDG77Qc=", "From": "\"Zhao1, Wei\" <wei.zhao1@intel.com>", "To": "\"Peng, ZhihongX\" <zhihongx.peng@intel.com>, \"Guo, Jia\" <jia.guo@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"wei.dai@intel.com\" <wei.dai@intel.com>", "Thread-Topic": "[DPDK] net/e1000: add the VLAN capabilities of NIC", "Thread-Index": "AQHWXjgv0/nCBWPqOUmGj46MvbCepqkPtgug", "Date": "Mon, 20 Jul 2020 01:59:32 +0000", "Message-ID": "\n <MWHPR11MB139104139FC4CC29E332EC92B77B0@MWHPR11MB1391.namprd11.prod.outlook.com>", "References": "<20200720014636.13145-1-zhihongx.peng@intel.com>", "In-Reply-To": "<20200720014636.13145-1-zhihongx.peng@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "\n eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2JlMmE5OWQtMmZhMi00MDYxLWFmNjgtNDdmOTgwMDEzZDExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZWJ1N0lyVnlSZHJHblwvb2NhMllIQkVkVHYrYUJCVnh3ZjhyOXFFYU1pRzQyVEhzT1UwbmpqOGF6RGJyaUZ6UUcifQ==", "dlp-version": "11.0.600.7", "dlp-product": "dlpe-windows", "x-ctpclassification": "CTP_NT", "dlp-reaction": "no-action", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.198.147.205]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "cf6089b2-657b-4452-7827-08d82c508bcb", "x-ms-traffictypediagnostic": "MWHPR11MB2014:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <MWHPR11MB20141FC35ACD04B2332D088DB77B0@MWHPR11MB2014.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:773;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n 1eJ/JI0npn27P9AJs8fc+fQCL1p6rFEm/GFL6/AX+aPPHmP+TuP+HXvw5B77K+73kaHdMsqZP8T/koGsCjEkdxVVCiyCKMJ7GpzcD9gWKoT/QX+bUJhV6dQwjrwmsGedo2jrQ2el5q19OCcPReQ6bMVpRJ9aWkZrb/iTf53ySHLdDGj4QFQ8+0d80BniL99Jwq4uhBCFijGHKzGZOmLW0FVS0KyhqglWQ0sXADsb7xNoOsg6XiVAtak0uoX6Nk7WZBNvF7NnNYYfswiksk/TK4/nGFvpA4o/Ud8vpu2KR/i3PBqQMvzW8RZ2SVr3MUXSfHPtvagCru5rGUGfc03qNg==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(366004)(76116006)(8676002)(6636002)(66946007)(66556008)(64756008)(66446008)(66476007)(2906002)(71200400001)(8936002)(55016002)(9686003)(52536014)(86362001)(83380400001)(5660300002)(26005)(186003)(53546011)(6506007)(7696005)(498600001)(107886003)(4326008)(110136005)(33656002)(54906003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n KJ4ANmpa8SbbyN0prwl4ACxCIV51i8WkiZSpVoX/xdqX4oYvV1BAl045Um8Rrj7ncIO3ZFQEVSN6M00e3QGA9RODvEc8siAuU73GsGoJC4CHaBhvwamRV+0BXEJe3nn2Hi9mmu7dCXy5TdWXRHkdTVlX9zrDuLvGS8F8auxChQXUPPyXJahpFxTSkUzijszc51Fb8QspI2kTGM5Y6uUQMzupyXPqOs3DCztWwxH+fLdVQdwLP7pE9I8mhhSzPdRHUOhQWifE2ghEzIptJkwSbZ4+T2azFyEHs9Y1KzwFXtfupncKAc37RokbxEAb2IgAUryjvAiKAPeh/ysEGiTP5Z4ekD2tTHQKXdsBAMblOJE2SU8BAn9fz5T14ilRg2kyIEAUVmsPki4D4UK273zllITqzcp3VvGTiTOTnWy7zXAx+9kgTNQk2lT4B03Jf9wKu3RVhAyrMQExd9D/AgIba+iwNikwxVpzZdrwbWQLzufHX6DCWRg6k7iVAYxCd10x", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "MWHPR11MB1391.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n cf6089b2-657b-4452-7827-08d82c508bcb", "X-MS-Exchange-CrossTenant-originalarrivaltime": "20 Jul 2020 01:59:32.4299 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 8gLyHCeKWxweOBU9s3NtdDaWFOwEJ5bo9q5R/smYHeh595nN3u/7u7PkpSbWzKrxTXvyGCBQ2JwILFYnvSaSJQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR11MB2014", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]