Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7441,
    "url": "https://patches.dpdk.org/api/patches/7441/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444067692-29645-2-git-send-email-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1444067692-29645-2-git-send-email-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1444067692-29645-2-git-send-email-adrien.mazarguil@6wind.com",
    "date": "2015-10-05T17:54:36",
    "name": "[dpdk-dev,01/17] mlx5: use fast Verbs interface for scattered RX operation",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7b42c04017ac134ed2c653fe7ccac3602919c837",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444067692-29645-2-git-send-email-adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7441/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7441/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 139A39224;\n\tMon,  5 Oct 2015 19:55:15 +0200 (CEST)",
            "from mail-wi0-f170.google.com (mail-wi0-f170.google.com\n\t[209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 739139224\n\tfor <dev@dpdk.org>; Mon,  5 Oct 2015 19:55:13 +0200 (CEST)",
            "by wiclk2 with SMTP id lk2so126006444wic.1\n\tfor <dev@dpdk.org>; Mon, 05 Oct 2015 10:55:13 -0700 (PDT)",
            "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tex17sm15785533wid.23.2015.10.05.10.55.12\n\t(version=TLSv1.2 cipher=RC4-SHA bits=128/128);\n\tMon, 05 Oct 2015 10:55:12 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=HUcOQWJhuovCXlukKew7FtQOuoBki4eVKGauJW718uo=;\n\tb=XzwVEAa8mFNBlK+IbxCB0H44RJAPm+9TGdstSb2Kd+AXTiTJr/GSzQh6DrGSjdD0wN\n\tAqPS+8vSUSib2fLkQJUtODpY/0sHA+PZolhJhbpXFpx5m1s+PpEj7epDzUqktlAM8StQ\n\tmKr41kNLohMsZunNT8Ucks2XoTI/aHn6LVkfXorX2vj36nvI6Gc01azcRBcy2TwM+jHm\n\tGBcYcBWSNJBWiL/C6x+4D0IBJu/LW6dQ3JeZGGwjnTY8hKIZGdr+NOfuUpr9KtjPlIPJ\n\t2eu6IZ8u6DMcg1WpCz5nFQfv7CtJHgSJKHuH171p2vwwWaP7lFMEkzDLD5qqZGG2TBCR\n\tZyYg==",
        "X-Gm-Message-State": "ALoCoQlKBokt4GvHlFLJoYxhjKORxlMxprxdeDwk1krNX1V9JUiMj+UVNxoeQutmclliT0I4EKZx",
        "X-Received": "by 10.180.19.68 with SMTP id c4mr13635219wie.50.1444067713337;\n\tMon, 05 Oct 2015 10:55:13 -0700 (PDT)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  5 Oct 2015 19:54:36 +0200",
        "Message-Id": "<1444067692-29645-2-git-send-email-adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "In-Reply-To": "<1444067692-29645-1-git-send-email-adrien.mazarguil@6wind.com>",
        "References": "<1444067692-29645-1-git-send-email-adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 01/17] mlx5: use fast Verbs interface for\n\tscattered RX operation",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This commit updates mlx5_rx_burst_sp() to use the fast verbs interface for\nposting RX buffers just like mlx5_rx_burst(). Doing so avoids a loop in\nlibmlx5 and an indirect function call through libibverbs.\n\nNote: recv_sg_list() is not implemented in the QP burst API, this commit is\nonly to prepare transition to the WQ-based API.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 33 ++++++++++-----------------------\n 1 file changed, 10 insertions(+), 23 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex 668aff0..8db4f3f 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -600,9 +600,6 @@ mlx5_rx_burst_sp(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \tstruct rxq_elt_sp (*elts)[rxq->elts_n] = rxq->elts.sp;\n \tconst unsigned int elts_n = rxq->elts_n;\n \tunsigned int elts_head = rxq->elts_head;\n-\tstruct ibv_recv_wr head;\n-\tstruct ibv_recv_wr **next = &head.next;\n-\tstruct ibv_recv_wr *bad_wr;\n \tunsigned int i;\n \tunsigned int pkts_ret = 0;\n \tint ret;\n@@ -660,9 +657,6 @@ mlx5_rx_burst_sp(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\t\t\t/* Increment dropped packets counter. */\n \t\t\t\t++rxq->stats.idropped;\n #endif\n-\t\t\t\t/* Link completed WRs together for repost. */\n-\t\t\t\t*next = wr;\n-\t\t\t\tnext = &wr->next;\n \t\t\t\tgoto repost;\n \t\t\t}\n \t\t\tret = wc.byte_len;\n@@ -671,9 +665,6 @@ mlx5_rx_burst_sp(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\t\tbreak;\n \t\tlen = ret;\n \t\tpkt_buf_len = len;\n-\t\t/* Link completed WRs together for repost. */\n-\t\t*next = wr;\n-\t\tnext = &wr->next;\n \t\t/*\n \t\t * Replace spent segments with new ones, concatenate and\n \t\t * return them as pkt_buf.\n@@ -770,26 +761,22 @@ mlx5_rx_burst_sp(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\trxq->stats.ibytes += pkt_buf_len;\n #endif\n repost:\n+\t\tret = rxq->if_qp->recv_sg_list(rxq->qp,\n+\t\t\t\t\t       elt->sges,\n+\t\t\t\t\t       RTE_DIM(elt->sges));\n+\t\tif (unlikely(ret)) {\n+\t\t\t/* Inability to repost WRs is fatal. */\n+\t\t\tDEBUG(\"%p: recv_sg_list(): failed (ret=%d)\",\n+\t\t\t      (void *)rxq->priv,\n+\t\t\t      ret);\n+\t\t\tabort();\n+\t\t}\n \t\tif (++elts_head >= elts_n)\n \t\t\telts_head = 0;\n \t\tcontinue;\n \t}\n \tif (unlikely(i == 0))\n \t\treturn 0;\n-\t*next = NULL;\n-\t/* Repost WRs. */\n-#ifdef DEBUG_RECV\n-\tDEBUG(\"%p: reposting %d WRs\", (void *)rxq, i);\n-#endif\n-\tret = ibv_post_recv(rxq->qp, head.next, &bad_wr);\n-\tif (unlikely(ret)) {\n-\t\t/* Inability to repost WRs is fatal. */\n-\t\tDEBUG(\"%p: ibv_post_recv(): failed for WR %p: %s\",\n-\t\t      (void *)rxq->priv,\n-\t\t      (void *)bad_wr,\n-\t\t      strerror(ret));\n-\t\tabort();\n-\t}\n \trxq->elts_head = elts_head;\n #ifdef MLX5_PMD_SOFT_COUNTERS\n \t/* Increment packets counter. */\n",
    "prefixes": [
        "dpdk-dev",
        "01/17"
    ]
}