Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74264/?format=api
{ "id": 74264, "url": "https://patches.dpdk.org/api/patches/74264/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200716153436.65862-1-david.coyle@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200716153436.65862-1-david.coyle@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200716153436.65862-1-david.coyle@intel.com", "date": "2020-07-16T15:34:36", "name": "[v1] crypto/qat: use better variable names in CRC functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5aacff303d34a07fe8b4daa2d6ec44e2a9cea5e8", "submitter": { "id": 961, "url": "https://patches.dpdk.org/api/people/961/?format=api", "name": "Coyle, David", "email": "david.coyle@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200716153436.65862-1-david.coyle@intel.com/mbox/", "series": [ { "id": 11107, "url": "https://patches.dpdk.org/api/series/11107/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11107", "date": "2020-07-16T15:34:36", "name": "[v1] crypto/qat: use better variable names in CRC functions", "version": 1, "mbox": "https://patches.dpdk.org/series/11107/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74264/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74264/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C8681A0546;\n\tThu, 16 Jul 2020 17:58:50 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A10964F9A;\n\tThu, 16 Jul 2020 17:58:50 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 0BFA22B9A\n for <dev@dpdk.org>; Thu, 16 Jul 2020 17:58:48 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Jul 2020 08:58:48 -0700", "from silpixa00399912.ir.intel.com (HELO\n silpixa00399912.ger.corp.intel.com) ([10.237.223.64])\n by fmsmga006.fm.intel.com with ESMTP; 16 Jul 2020 08:58:41 -0700" ], "IronPort-SDR": [ "\n ac5V22XmSL6hl0r4towAbQnVrUwHUmftgYZXbo66X082YF407c55onctKCSQqG5jZThXkHnSnT\n DGCXrIzXgGLQ==", "\n sApf7vRG8do8wgeED09U4+0WlN36i6jYIy29wTQ/ERULCxy7P2WmzE3baWQVPhNuhWsksyQRFR\n dU36Y2nukflw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9684\"; a=\"128986316\"", "E=Sophos;i=\"5.75,359,1589266800\"; d=\"scan'208\";a=\"128986316\"", "E=Sophos;i=\"5.75,359,1589266800\"; d=\"scan'208\";a=\"486151768\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "David Coyle <david.coyle@intel.com>", "To": "akhil.goyal@nxp.com,\n\tdeclan.doherty@intel.com,\n\tfiona.trahe@intel.com", "Cc": "dev@dpdk.org, brendan.ryan@intel.com, mairtin.oloingsigh@intel.com,\n pablo.de.lara.guarch@intel.com, David Coyle <david.coyle@intel.com>", "Date": "Thu, 16 Jul 2020 16:34:36 +0100", "Message-Id": "<20200716153436.65862-1-david.coyle@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v1] crypto/qat: use better variable names in CRC\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The variable names crc_length and crc_offset have been changed to\ncrc_data_len and crc_data_ofs respectively, to make it clearer as to\ntheir use i.e. the length and offset of the data over which the CRC is\ncalculated.\n\nFixes: 6f0ef237404b (\"crypto/qat: support DOCSIS protocol\")\n\nSigned-off-by: David Coyle <david.coyle@intel.com>\n---\n drivers/crypto/qat/qat_sym.c | 8 ++++----\n drivers/crypto/qat/qat_sym.h | 13 +++++++------\n 2 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c\nindex 6d568ab8f..fe5c85c34 100644\n--- a/drivers/crypto/qat/qat_sym.c\n+++ b/drivers/crypto/qat/qat_sym.c\n@@ -108,18 +108,18 @@ qat_crc_generate(struct qat_sym_session *ctx,\n \t\t\tstruct rte_crypto_op *op)\n {\n \tstruct rte_crypto_sym_op *sym_op = op->sym;\n-\tuint32_t *crc, crc_length;\n+\tuint32_t *crc, crc_data_len;\n \tuint8_t *crc_data;\n \n \tif (ctx->qat_dir == ICP_QAT_HW_CIPHER_ENCRYPT &&\n \t\t\tsym_op->auth.data.length != 0) {\n \n-\t\tcrc_length = sym_op->auth.data.length;\n+\t\tcrc_data_len = sym_op->auth.data.length;\n \t\tcrc_data = rte_pktmbuf_mtod_offset(sym_op->m_src, uint8_t *,\n \t\t\t\tsym_op->auth.data.offset);\n-\t\tcrc = (uint32_t *)(crc_data + crc_length);\n+\t\tcrc = (uint32_t *)(crc_data + crc_data_len);\n \n-\t\t*crc = rte_net_crc_calc(crc_data, crc_length,\n+\t\t*crc = rte_net_crc_calc(crc_data, crc_data_len,\n \t\t\t\tRTE_NET_CRC32_ETH);\n \t}\n }\ndiff --git a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h\nindex dbca74efb..7934dd478 100644\n--- a/drivers/crypto/qat/qat_sym.h\n+++ b/drivers/crypto/qat/qat_sym.h\n@@ -140,20 +140,21 @@ static inline void\n qat_crc_verify(struct qat_sym_session *ctx, struct rte_crypto_op *op)\n {\n \tstruct rte_crypto_sym_op *sym_op = op->sym;\n-\tuint32_t crc_offset, crc_length, crc;\n+\tuint32_t crc_data_ofs, crc_data_len, crc;\n \tuint8_t *crc_data;\n \n \tif (ctx->qat_dir == ICP_QAT_HW_CIPHER_DECRYPT &&\n \t\t\tsym_op->auth.data.length != 0) {\n \n-\t\tcrc_offset = sym_op->auth.data.offset;\n-\t\tcrc_length = sym_op->auth.data.length;\n+\t\tcrc_data_ofs = sym_op->auth.data.offset;\n+\t\tcrc_data_len = sym_op->auth.data.length;\n \t\tcrc_data = rte_pktmbuf_mtod_offset(sym_op->m_src, uint8_t *,\n-\t\t\t\tcrc_offset);\n+\t\t\t\tcrc_data_ofs);\n \n-\t\tcrc = rte_net_crc_calc(crc_data, crc_length, RTE_NET_CRC32_ETH);\n+\t\tcrc = rte_net_crc_calc(crc_data, crc_data_len,\n+\t\t\t\tRTE_NET_CRC32_ETH);\n \n-\t\tif (crc != *(uint32_t *)(crc_data + crc_length))\n+\t\tif (crc != *(uint32_t *)(crc_data + crc_data_len))\n \t\t\top->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;\n \t}\n }\n", "prefixes": [ "v1" ] }