Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7409/?format=api
{ "id": 7409, "url": "https://patches.dpdk.org/api/patches/7409/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444041035-4936-8-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444041035-4936-8-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444041035-4936-8-git-send-email-bernard.iremonger@intel.com", "date": "2015-10-05T10:30:22", "name": "[dpdk-dev,v2,07/20] pcap: remove pci device driver", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3c742da1353c02d260956bbdedf53838af4807bc", "submitter": { "id": 91, "url": "https://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444041035-4936-8-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7409/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7409/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4318C91AD;\n\tMon, 5 Oct 2015 12:30:56 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 3A9B58E93\n\tfor <dev@dpdk.org>; Mon, 5 Oct 2015 12:30:49 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Oct 2015 03:30:48 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Oct 2015 03:30:47 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt95AUlsB014552; Mon, 5 Oct 2015 11:30:47 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id t95AUkgV007432;\n\tMon, 5 Oct 2015 11:30:46 +0100", "(from bairemon@localhost)\n\tby sivswdev01.ir.intel.com with id t95AUkI6007427;\n\tMon, 5 Oct 2015 11:30:46 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,638,1437462000\"; d=\"scan'208\";a=\"819605990\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 5 Oct 2015 11:30:22 +0100", "Message-Id": "<1444041035-4936-8-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1444041035-4936-1-git-send-email-bernard.iremonger@intel.com>", "References": "<PATCH v2>\n\t<1444041035-4936-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 07/20] pcap: remove pci device driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "remove rte_pcap_pmd and pci_dev.\ninitialise dev_flags, driver, drv_name, kdrv and numa_node fields in eth_dev data\n\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n drivers/net/pcap/rte_eth_pcap.c | 31 +++++++++----------------------\n 1 file changed, 9 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex f2e4634..5f416f4 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -1,7 +1,7 @@\n /*-\n * BSD LICENSE\n *\n- * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.\n+ * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.\n * Copyright(c) 2014 6WIND S.A.\n * All rights reserved.\n *\n@@ -617,13 +617,6 @@ static const struct eth_dev_ops ops = {\n \t.stats_reset = eth_stats_reset,\n };\n \n-static struct eth_driver rte_pcap_pmd = {\n-\t.pci_drv = {\n-\t\t.name = \"rte_pcap_pmd\",\n-\t\t.drv_flags = RTE_PCI_DRV_DETACHABLE,\n-\t},\n-};\n-\n /*\n * Function handler that opens the pcap file for reading a stores a\n * reference of it for use it later on.\n@@ -806,7 +799,6 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,\n \t\tstruct rte_kvargs *kvlist)\n {\n \tstruct rte_eth_dev_data *data = NULL;\n-\tstruct rte_pci_device *pci_dev = NULL;\n \tunsigned k_idx;\n \tstruct rte_kvargs_pair *pair = NULL;\n \n@@ -819,17 +811,13 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,\n \tRTE_LOG(INFO, PMD,\n \t\t\t\"Creating pcap-backed ethdev on numa socket %u\\n\", numa_node);\n \n-\t/* now do all data allocation - for eth_dev structure, dummy pci driver\n+\t/* now do all data allocation - for eth_dev structure\n \t * and internal (private) data\n \t */\n \tdata = rte_zmalloc_socket(name, sizeof(*data), 0, numa_node);\n \tif (data == NULL)\n \t\tgoto error;\n \n-\tpci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);\n-\tif (pci_dev == NULL)\n-\t\tgoto error;\n-\n \t*internals = rte_zmalloc_socket(name, sizeof(**internals), 0, numa_node);\n \tif (*internals == NULL)\n \t\tgoto error;\n@@ -845,8 +833,8 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,\n \n \t/* now put it all together\n \t * - store queue data in internals,\n-\t * - store numa_node info in pci_driver\n-\t * - point eth_dev_data to internals and pci_driver\n+\t * - store numa_node info in eth_dev\n+\t * - point eth_dev_data to internals\n \t * - and point eth_dev structure to new eth_dev_data structure\n \t */\n \t/* NOTE: we'll replace the data element, of originally allocated eth_dev\n@@ -860,8 +848,6 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,\n \telse\n \t\t(*internals)->if_index = if_nametoindex(pair->value);\n \n-\tpci_dev->numa_node = numa_node;\n-\n \tdata->dev_private = *internals;\n \tdata->port_id = (*eth_dev)->data->port_id;\n \tsnprintf(data->name, sizeof(data->name), \"%s\", (*eth_dev)->data->name);\n@@ -874,14 +860,16 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,\n \n \t(*eth_dev)->data = data;\n \t(*eth_dev)->dev_ops = &ops;\n-\t(*eth_dev)->pci_dev = pci_dev;\n-\t(*eth_dev)->driver = &rte_pcap_pmd;\n+\t(*eth_dev)->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\t(*eth_dev)->driver = NULL;\n+\t(*eth_dev)->data->kdrv = RTE_KDRV_NONE;\n+\t(*eth_dev)->data->drv_name = NULL;\n+\t(*eth_dev)->data->numa_node = numa_node;\n \n \treturn 0;\n \n error:\n \trte_free(data);\n-\trte_free(pci_dev);\n \trte_free(*internals);\n \n \treturn -1;\n@@ -1096,7 +1084,6 @@ rte_pmd_pcap_devuninit(const char *name)\n \n \trte_free(eth_dev->data->dev_private);\n \trte_free(eth_dev->data);\n-\trte_free(eth_dev->pci_dev);\n \n \trte_eth_dev_release_port(eth_dev);\n \n", "prefixes": [ "dpdk-dev", "v2", "07/20" ] }