Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7407/?format=api
{ "id": 7407, "url": "https://patches.dpdk.org/api/patches/7407/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444041035-4936-6-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444041035-4936-6-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444041035-4936-6-git-send-email-bernard.iremonger@intel.com", "date": "2015-10-05T10:30:20", "name": "[dpdk-dev,v2,05/20] ring: remove pci device driver", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1f09aca086af098d06d5a5329c7fc71ed2820480", "submitter": { "id": 91, "url": "https://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444041035-4936-6-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7407/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7407/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id EFAFF8F9D;\n\tMon, 5 Oct 2015 12:30:52 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id AD3DE8E92\n\tfor <dev@dpdk.org>; Mon, 5 Oct 2015 12:30:47 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 05 Oct 2015 03:30:47 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 05 Oct 2015 03:30:47 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt95AUjOG014546; Mon, 5 Oct 2015 11:30:45 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id t95AUj2h007343;\n\tMon, 5 Oct 2015 11:30:45 +0100", "(from bairemon@localhost)\n\tby sivswdev01.ir.intel.com with id t95AUjk1007335;\n\tMon, 5 Oct 2015 11:30:45 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,638,1437462000\"; d=\"scan'208\";a=\"658036028\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 5 Oct 2015 11:30:20 +0100", "Message-Id": "<1444041035-4936-6-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1444041035-4936-1-git-send-email-bernard.iremonger@intel.com>", "References": "<PATCH v2>\n\t<1444041035-4936-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 05/20] ring: remove pci device driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "remove rte_ring_pmd and pci_dev.\ninitialise dev_flags, driver, drv_name, kdrv and numa_node fields in eth_dev data.\n\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n drivers/net/ring/rte_eth_ring.c | 37 ++++++++-----------------------------\n 1 file changed, 8 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 0ba36d5..65608b2 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -44,8 +44,6 @@\n #define ETH_RING_ACTION_CREATE\t\t\"CREATE\"\n #define ETH_RING_ACTION_ATTACH\t\t\"ATTACH\"\n \n-static const char *ring_ethdev_driver_name = \"Ring PMD\";\n-\n static const char *valid_arguments[] = {\n \tETH_RING_NUMA_NODE_ACTION_ARG,\n \tNULL\n@@ -252,15 +250,6 @@ static const struct eth_dev_ops ops = {\n \t.mac_addr_add = eth_mac_addr_add,\n };\n \n-static struct eth_driver rte_ring_pmd = {\n-\t.pci_drv = {\n-\t\t.name = \"rte_ring_pmd\",\n-\t\t.drv_flags = RTE_PCI_DRV_DETACHABLE,\n-\t},\n-};\n-\n-static struct rte_pci_id id_table;\n-\n int\n rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \t\tconst unsigned nb_rx_queues,\n@@ -269,7 +258,6 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \t\tconst unsigned numa_node)\n {\n \tstruct rte_eth_dev_data *data = NULL;\n-\tstruct rte_pci_device *pci_dev = NULL;\n \tstruct pmd_internals *internals = NULL;\n \tstruct rte_eth_dev *eth_dev = NULL;\n \n@@ -291,10 +279,6 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \tif (data == NULL)\n \t\tgoto error;\n \n-\tpci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);\n-\tif (pci_dev == NULL)\n-\t\tgoto error;\n-\n \tinternals = rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node);\n \tif (internals == NULL)\n \t\tgoto error;\n@@ -304,11 +288,10 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \tif (eth_dev == NULL)\n \t\tgoto error;\n \n-\n \t/* now put it all together\n \t * - store queue data in internals,\n-\t * - store numa_node info in pci_driver\n-\t * - point eth_dev_data to internals and pci_driver\n+\t * - store numa_node info in eth_dev_data\n+\t * - point eth_dev_data to internals\n \t * - and point eth_dev structure to new eth_dev_data structure\n \t */\n \t/* NOTE: we'll replace the data element, of originally allocated eth_dev\n@@ -323,12 +306,6 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \t\tinternals->tx_ring_queues[i].rng = tx_queues[i];\n \t}\n \n-\trte_ring_pmd.pci_drv.name = ring_ethdev_driver_name;\n-\trte_ring_pmd.pci_drv.id_table = &id_table;\n-\n-\tpci_dev->numa_node = numa_node;\n-\tpci_dev->driver = &rte_ring_pmd.pci_drv;\n-\n \tdata->dev_private = internals;\n \tdata->port_id = eth_dev->data->port_id;\n \tmemmove(data->name, eth_dev->data->name, sizeof(data->name));\n@@ -338,9 +315,13 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \tdata->mac_addrs = &internals->address;\n \n \teth_dev->data = data;\n-\teth_dev->driver = &rte_ring_pmd;\n+\teth_dev->driver = NULL;\n \teth_dev->dev_ops = &ops;\n-\teth_dev->pci_dev = pci_dev;\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->kdrv = RTE_KDRV_NONE;\n+\teth_dev->data->drv_name = NULL;\n+\teth_dev->data->numa_node = numa_node;\n+\n \tTAILQ_INIT(&(eth_dev->link_intr_cbs));\n \n \t/* finally assign rx and tx ops */\n@@ -351,7 +332,6 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \n error:\n \trte_free(data);\n-\trte_free(pci_dev);\n \trte_free(internals);\n \n \treturn -1;\n@@ -561,7 +541,6 @@ rte_pmd_ring_devuninit(const char *name)\n \teth_dev_stop(eth_dev);\n \trte_free(eth_dev->data->dev_private);\n \trte_free(eth_dev->data);\n-\trte_free(eth_dev->pci_dev);\n \n \trte_eth_dev_release_port(eth_dev);\n \treturn 0;\n", "prefixes": [ "dpdk-dev", "v2", "05/20" ] }