Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7406,
    "url": "https://patches.dpdk.org/api/patches/7406/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444041035-4936-5-git-send-email-bernard.iremonger@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1444041035-4936-5-git-send-email-bernard.iremonger@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1444041035-4936-5-git-send-email-bernard.iremonger@intel.com",
    "date": "2015-10-05T10:30:19",
    "name": "[dpdk-dev,v2,04/20] null: remove pci device driver",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "437d03e916a6b240ef7fa0e8f3599a77387ef6b2",
    "submitter": {
        "id": 91,
        "url": "https://patches.dpdk.org/api/people/91/?format=api",
        "name": "Iremonger, Bernard",
        "email": "bernard.iremonger@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444041035-4936-5-git-send-email-bernard.iremonger@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7406/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7406/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D84318D97;\n\tMon,  5 Oct 2015 12:30:51 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id C4D438E93\n\tfor <dev@dpdk.org>; Mon,  5 Oct 2015 12:30:47 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Oct 2015 03:30:46 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Oct 2015 03:30:45 -0700",
            "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt95AUixk014543; Mon, 5 Oct 2015 11:30:44 +0100",
            "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id t95AUiDG007286;\n\tMon, 5 Oct 2015 11:30:44 +0100",
            "(from bairemon@localhost)\n\tby sivswdev01.ir.intel.com with  id t95AUiVU007277;\n\tMon, 5 Oct 2015 11:30:44 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,638,1437462000\"; d=\"scan'208\";a=\"819605951\"",
        "From": "Bernard Iremonger <bernard.iremonger@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  5 Oct 2015 11:30:19 +0100",
        "Message-Id": "<1444041035-4936-5-git-send-email-bernard.iremonger@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1444041035-4936-1-git-send-email-bernard.iremonger@intel.com>",
        "References": "<PATCH v2>\n\t<1444041035-4936-1-git-send-email-bernard.iremonger@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 04/20] null: remove pci device driver",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "remove rte_null_pmd and pci_dev.\ninitialise dev_flags, driver, drv_name, kdrv and numa_node fields in eth_dev data\n\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n drivers/net/null/rte_eth_null.c | 28 +++++++---------------------\n 1 file changed, 7 insertions(+), 21 deletions(-)",
    "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex e244595..fb7473f 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -340,13 +340,6 @@ eth_stats_reset(struct rte_eth_dev *dev)\n \t}\n }\n \n-static struct eth_driver rte_null_pmd = {\n-\t.pci_drv = {\n-\t\t.name = \"rte_null_pmd\",\n-\t\t.drv_flags = RTE_PCI_DRV_DETACHABLE,\n-\t},\n-};\n-\n static void\n eth_queue_release(void *q)\n {\n@@ -386,7 +379,6 @@ eth_dev_null_create(const char *name,\n \tconst unsigned nb_rx_queues = 1;\n \tconst unsigned nb_tx_queues = 1;\n \tstruct rte_eth_dev_data *data = NULL;\n-\tstruct rte_pci_device *pci_dev = NULL;\n \tstruct pmd_internals *internals = NULL;\n \tstruct rte_eth_dev *eth_dev = NULL;\n \n@@ -403,10 +395,6 @@ eth_dev_null_create(const char *name,\n \tif (data == NULL)\n \t\tgoto error;\n \n-\tpci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);\n-\tif (pci_dev == NULL)\n-\t\tgoto error;\n-\n \tinternals = rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node);\n \tif (internals == NULL)\n \t\tgoto error;\n@@ -418,8 +406,7 @@ eth_dev_null_create(const char *name,\n \n \t/* now put it all together\n \t * - store queue data in internals,\n-\t * - store numa_node info in pci_driver\n-\t * - point eth_dev_data to internals and pci_driver\n+\t * - point eth_dev_data to internals\n \t * - and point eth_dev structure to new eth_dev_data structure\n \t */\n \t/* NOTE: we'll replace the data element, of originally allocated eth_dev\n@@ -431,8 +418,6 @@ eth_dev_null_create(const char *name,\n \tinternals->packet_copy = packet_copy;\n \tinternals->numa_node = numa_node;\n \n-\tpci_dev->numa_node = numa_node;\n-\n \tdata->dev_private = internals;\n \tdata->port_id = eth_dev->data->port_id;\n \tdata->nb_rx_queues = (uint16_t)nb_rx_queues;\n@@ -443,8 +428,11 @@ eth_dev_null_create(const char *name,\n \n \teth_dev->data = data;\n \teth_dev->dev_ops = &ops;\n-\teth_dev->pci_dev = pci_dev;\n-\teth_dev->driver = &rte_null_pmd;\n+\teth_dev->driver = NULL;\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->kdrv = RTE_KDRV_NONE;\n+\teth_dev->data->drv_name = NULL;\n+\teth_dev->data->numa_node = numa_node;\n \n \t/* finally assign rx and tx ops */\n \tif (packet_copy) {\n@@ -459,7 +447,6 @@ eth_dev_null_create(const char *name,\n \n error:\n \trte_free(data);\n-\trte_free(pci_dev);\n \trte_free(internals);\n \n \treturn -1;\n@@ -562,14 +549,13 @@ rte_pmd_null_devuninit(const char *name)\n \tRTE_LOG(INFO, PMD, \"Closing null ethdev on numa socket %u\\n\",\n \t\t\trte_socket_id());\n \n-\t/* reserve an ethdev entry */\n+\t/* find the ethdev entry */\n \teth_dev = rte_eth_dev_allocated(name);\n \tif (eth_dev == NULL)\n \t\treturn -1;\n \n \trte_free(eth_dev->data->dev_private);\n \trte_free(eth_dev->data);\n-\trte_free(eth_dev->pci_dev);\n \n \trte_eth_dev_release_port(eth_dev);\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "04/20"
    ]
}