Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73690/?format=api
{ "id": 73690, "url": "https://patches.dpdk.org/api/patches/73690/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200710070226.6045-7-i.dyukov@samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200710070226.6045-7-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200710070226.6045-7-i.dyukov@samsung.com", "date": "2020-07-10T07:02:04", "name": "[v7,06/25] net/i40e: return unknown speed in status", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "718e3460f36747ce7312e7673a12d40342a32105", "submitter": { "id": 783, "url": "https://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200710070226.6045-7-i.dyukov@samsung.com/mbox/", "series": [ { "id": 10941, "url": "https://patches.dpdk.org/api/series/10941/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10941", "date": "2020-07-10T07:01:58", "name": "ethdev: allow unknown link speed", "version": 7, "mbox": "https://patches.dpdk.org/series/10941/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73690/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73690/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 90332A0526;\n\tFri, 10 Jul 2020 09:03:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5DF771DC11;\n\tFri, 10 Jul 2020 09:02:55 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id D66DF1DC11\n for <dev@dpdk.org>; Fri, 10 Jul 2020 09:02:53 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200710070253euoutp0167d80b133aa2129faa74c1c9886bcf99~gUiHl_9YP1892318923euoutp01k;\n Fri, 10 Jul 2020 07:02:53 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200710070253eucas1p232cb59feca5410e77fab57bbf7b2b910~gUiHP8pPq1909319093eucas1p2a;\n Fri, 10 Jul 2020 07:02:53 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges3new.samsung.com (EUCPMTA) with SMTP id 45.31.06318.D92180F5; Fri, 10\n Jul 2020 08:02:53 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822~gUiGyZjsl0824408244eucas1p1b;\n Fri, 10 Jul 2020 07:02:52 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200710070252eusmtrp20386bc25eb0d8fb28253b8d30e6ecf3a~gUiGxhOye2959129591eusmtrp26;\n Fri, 10 Jul 2020 07:02:52 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 0E.74.06314.C92180F5; Fri, 10\n Jul 2020 08:02:52 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200710070250eusmtip126d76716ff2e644c7091205e365bd942~gUiFCQwNs1602216022eusmtip1H;\n Fri, 10 Jul 2020 07:02:50 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200710070253euoutp0167d80b133aa2129faa74c1c9886bcf99~gUiHl_9YP1892318923euoutp01k", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1594364573;\n bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=;\n h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From;\n b=XO09GYznzkwopdb2zxOXaMqRzxywKIoN/vxkkVuLqgxgoGm/hsUxnInJs3oTViZIn\n ZrCFqu+OVeF5jt4dwwNmdpnXJsRKHp1rWYUJkS9X0JCIUKqdRn8pzZCS/xe2UGEd19\n 4i3Hb6QYkTLSmzuHrmGS3kB2fuuidBf6qPzl8f2U=", "X-AuditID": "cbfec7f5-371ff700000018ae-8f-5f08129dfd5f", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com,\n thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com,\n mb@smartsharesystems.com, stephen@networkplumber.org,\n nicolas.chautru@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com,\n skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com,\n kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com,\n xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com,\n jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com", "Date": "Fri, 10 Jul 2020 10:02:04 +0300", "Message-Id": "<20200710070226.6045-7-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200710070226.6045-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA0WSbUxTZxTHfe69vffSUHK9YjxxRrOqiS7zLZh4Fh1OM5dLfP3iFxOtVW7w\n BdC1otNlCZLZ1KIoiBuiAlJNgToRWtqKDJHEUmzVQSIviyLDF6bTCmij1qKjvTV++53/Of9z\n nnPy8LRYzE7mt2fvkQ3Z+kwtq2Zc3ne355wVed38wYdqrA2UERzos9LYX3yfxfyhXynsqVmK\n Te4zKix6kEthQdEwhe4qC4vP+/MYDI64Kbz3p5/D0s48DkdaBzk8euc0wcHIMxpPVbwieKes\n QYXvrjey+DJSyWBB+C7BY04fwbYjwwwWX/EQNFkEHKq2cWi9NxVH+n0M+nsdHF4MddDYEBgl\n WNhWS/CW6aPquy+lcMUFlWRtekpJJ8510JK39zdOOtJeRkl1QQ8lvWy+y0oFzhoi3RzIpyX7\n o7fsOvUG9ZJ0OXP7XtkwL3Wzepu5429u919JP7kaK6hccjbRQhJ4EBZClz2fsxA1LwpVBMKe\n S/HgNYHC8mZKCV4R8NrtYxk+Zgn+sVbRbQROVQ/FHSECnoMuNtqXFWaB31wWcycLdSy4I91U\n NDFBWA52a1eMGWEmXKvPo6OsERDMgSZaedQ0sF9uiXGC8A0cslRyURaFqdBd/jrWFAQfD55/\n HIxi+B7O9d6gFJ4Az9qcnMJT4OOV8rj+M7yp7+YUs5lAX+WheNFScP53O7YbLcyG2sZ5irwM\n uk42EmXlJOh5MT4q02NY5PqdVmQNmE2iUq2FlvbOuAww+j5+XgkevDkcv08TgVBfL3ucTCv9\n PKuCkBoySc4xZmXIxpRsed9coz7LmJOdMXfrrqx6MvZX/R/aQh7SHNnSSgSeaBM1m0dZnajS\n 7zXuz2olwNPaZM3yW/5NoiZdv/+AbNilM+RkysZW8gXPaCdpUiqfbhSFDP0eeacs75YNn7IU\n nzA5l5i3lqQlHncnlqaaprRP/KH7cerR+evTg1+bmEVWxwrbyKr1Kbbn+bZl3jRHyQDnG/dL\n qm7mwqurd/b40tIb3H2utWsWhcLhH1e0lCQ9jqzhOofvz1kccGxM3vft23/Pp1QJziVurW4H\n 21WouzFD/JD5pO5RILip+szo1YFL3gsrTdO1jHGbfsFXtMGo/x+NsSxNpwMAAA==", "\n H4sIAAAAAAAAAzWSeUgUcRTH+83MzozSyrQq/TC6NoLoGBvN9hmVYf0xEXT+IXTpVJNu7SE7\n u5EVZFIq61Vmp7Vt3mlheReatomWq5RFdqdIEHZ4VmhZ5mb99+F93vvy4D2W1HyjAli9ySpb\n TJJBS3tT7t/Nbxdd0rCRi3+OLYDSVgeC7ne5JHRlvaUhpf84AS+Kw6C2+pIKMjvjCUjPHCCg\n ushOw+euBAp6B6sJeFPnZuDikwQGBl0fGEh7lI3gw+hHEi44hxA8clSqYOTeHRr6RnMoSP/x\n DEFGxQMEzakDFGTdrkGQaOeg/1ohA7lvZsBg1wMK3C/LGbj+rZ2EytZfCE41lyJoSxxTrZot\n /nDmq8Tc2h5CPH21nRSbXp5lxNSHDkK81VtDiH13n9FiekUxElu6U0ix5P0wvdF7K7/cYrZZ\n 5VkxZsW6QrtNgCBeCAU+aEkoLwTrdiwLCtEGrly+RzboD8iWwJVRfExy+ysm9rHPwao7TiIe\n XZ5sRyyLuSW498YGO/JmNVw+wvc724iJOsaf3pN25DWOvni0w05P9Awh3Pn6i8ojaG4edic7\n CI/w417T+GnSMcojfLlwXJLbQXiY4ubi+rKEv0lqDnBya+2/1Jm45GbDX/biQvEJew7jYQ0X\n g139BWiCZ+DnV74SJ5GPE00qRn6yTTFGGxWBVySjYjNF87vNxjI0fvKqppHyGvTk1hYX4lik\n nayuGaMjNSrpgBJndCHMklo/dXibe6dGvUeKOyRbzJEWm0FWXChkfMFTZID/bvP4A5mskUKI\n oINQQResC14K2qnqZO7edg0XLVnl/bIcK1v+zxGsV0A8uhhRf/65f8v3hsYhMuzLi82GwTDp\n cIqxb23Eap7R7P15uTLv6Jok1te/UTis39SUVsXyC89+zhGndRHDZ2KFSe7GdZk6ZvMRk2ND\n njRlv2XXr211RYHlHWVOe0VWwZzCFFtwXcvwesNoxqpP09VxPUXnmqOO7NNHdV9JGykdKM7W\n UkqMJMwnLYr0B/ZB/mQIAwAA" ], "X-CMS-MailID": "20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822", "References": "<20200427095737.11082-1-i.dyukov@samsung.com>\n <20200710070226.6045-1-i.dyukov@samsung.com>\n <CGME20200710070252eucas1p111c3c4698edfd5a44b376c63e9b62822@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v7 06/25] net/i40e: return unknown speed in status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "i.dyukov@samsung.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_ethdev has declared new NUM_UNKNOWN speed which\ncould be used in case when no speed information is available and\nlink is up. NUM_NONE should be returned, if link is down.\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\nAcked-by: Jeff Guo <jia.guo@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 5 ++++-\n drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++-----\n 2 files changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 472ce2a9e..f718356b5 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link,\n \t\tlink->link_speed = ETH_SPEED_NUM_40G;\n \t\tbreak;\n \tdefault:\n-\t\tlink->link_speed = ETH_SPEED_NUM_NONE;\n+\t\tif (link->link_status)\n+\t\t\tlink->link_speed = ETH_SPEED_NUM_UNKNOWN;\n+\t\telse\n+\t\t\tlink->link_speed = ETH_SPEED_NUM_NONE;\n \t\tbreak;\n \t}\n }\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex eca716a6a..cf931bf9c 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,\n \t\tnew_link.link_speed = ETH_SPEED_NUM_40G;\n \t\tbreak;\n \tdefault:\n-\t\tnew_link.link_speed = ETH_SPEED_NUM_NONE;\n+\t\tif (vf->link_up)\n+\t\t\tnew_link.link_speed = ETH_SPEED_NUM_UNKNOWN;\n+\t\telse\n+\t\t\tnew_link.link_speed = ETH_SPEED_NUM_NONE;\n \t\tbreak;\n \t}\n \t/* full duplex only */\n \tnew_link.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\tnew_link.link_status = vf->link_up &&\n-\t\t\t\tnew_link.link_speed != ETH_SPEED_NUM_NONE\n-\t\t\t\t? ETH_LINK_UP\n-\t\t\t\t: ETH_LINK_DOWN;\n+\tnew_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN;\n \tnew_link.link_autoneg =\n \t\t!(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED);\n \n", "prefixes": [ "v7", "06/25" ] }