Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73681/?format=api
{ "id": 73681, "url": "https://patches.dpdk.org/api/patches/73681/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1594351775-30864-1-git-send-email-luyicai@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594351775-30864-1-git-send-email-luyicai@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594351775-30864-1-git-send-email-luyicai@huawei.com", "date": "2020-07-10T03:29:35", "name": "[V2] net/bonding: fix lacp negotiation failed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d14bf2205e00a597983e34ed9049fc10d8b67704", "submitter": { "id": 1719, "url": "https://patches.dpdk.org/api/people/1719/?format=api", "name": "Yicai Lu", "email": "luyicai@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1594351775-30864-1-git-send-email-luyicai@huawei.com/mbox/", "series": [ { "id": 10938, "url": "https://patches.dpdk.org/api/series/10938/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10938", "date": "2020-07-10T03:29:35", "name": "[V2] net/bonding: fix lacp negotiation failed", "version": 2, "mbox": "https://patches.dpdk.org/series/10938/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73681/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/73681/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DAE7DA0526;\n\tFri, 10 Jul 2020 05:29:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6C2F71DC44;\n\tFri, 10 Jul 2020 05:29:46 +0200 (CEST)", "from huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by dpdk.org (Postfix) with ESMTP id 65F5F1DC3E;\n Fri, 10 Jul 2020 05:29:45 +0200 (CEST)", "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id 5EC0A60F5F9B77516CD7;\n Fri, 10 Jul 2020 11:29:44 +0800 (CST)", "from localhost (10.174.186.46) by DGGEMS402-HUB.china.huawei.com\n (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Fri, 10 Jul 2020\n 11:29:38 +0800" ], "From": "luyicai <luyicai@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<chas3@att.com>, <xavier.huwei@huawei.com>, <zhangliang@bigo.sg>,\n <chenchanghu@huawei.com>, <jerry.lilijun@huawei.com>,\n <haifeng.lin@huawei.com>, <guohongzhi1@huawei.com>, Yicai Lu\n <luyicai@huawei.com>, <stable@dpdk.org>", "Date": "Fri, 10 Jul 2020 11:29:35 +0800", "Message-ID": "<1594351775-30864-1-git-send-email-luyicai@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "In-Reply-To": "<1589887092-26360-1>", "References": "<1589887092-26360-1>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.186.46]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yicai Lu <luyicai@huawei.com>\n\nWhen two host is connected directly without any devices like switch,\nrx_machine_update would recieving partner lacp negotiation packets,\nand partner's port mac is filled with zeros in this packet,\nwhich is different with internal's mode4 mac. So in this situation,\nit would never go rx_machine branch and then execute mac swap for negotiation!\nThus bond mode 4 will negotiation failed.\n\nFixes: 56cbc0817399 (\"net/bonding: fix LACP negotiation\")\nCc: stable@dpdk.org\n\nSigned-off-by: luyicai <luyicai@huawei.com>\n---\nv1 -> v2: Adjust commit info style\n---\n drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex b77a37d..2002ec0 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -798,7 +798,8 @@\n \t\tRTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);\n \n \t\tpartner = &lacp->lacpdu.partner;\n-\t\tif (rte_is_same_ether_addr(&partner->port_params.system,\n+\t\tif (rte_is_zero_ether_addr(&partner->port_params.system) ||\n+\t\t\trte_is_same_ether_addr(&partner->port_params.system,\n \t\t\t&internals->mode4.mac_addr)) {\n \t\t\t/* This LACP frame is sending to the bonding port\n \t\t\t * so pass it to rx_machine.\n", "prefixes": [ "V2" ] }