Patch Comment List
List patch comments
GET /api/patches/73620/comments/?format=api
[ { "id": 115600, "web_url": "https://patches.dpdk.org/comment/115600/", "msgid": "<BYAPR11MB3477E5A303C29236B15695AFE3640@BYAPR11MB3477.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB3477E5A303C29236B15695AFE3640@BYAPR11MB3477.namprd11.prod.outlook.com", "date": "2020-07-09T08:59:21", "subject": "Re: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: fix NIOS SPI initial", "submitter": { "id": 987, "url": "https://patches.dpdk.org/api/people/987/?format=api", "name": "Zhang, Tianfei", "email": "tianfei.zhang@intel.com" }, "content": "The message include \"master\", it suggested that replace by \" primary \", I will send the V2.\n\n-----Original Message-----\nFrom: Zhang, Tianfei <tianfei.zhang@intel.com> \nSent: Friday, July 10, 2020 12:36 AM\nTo: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>\nCc: Zhang, Tianfei <tianfei.zhang@intel.com>; stable@dpdk.org\nSubject: [PATCH v1 2/2] raw/ifpga/base: fix NIOS SPI initial\n\nFrom: Tianfei Zhang <tianfei.zhang@intel.com>\n\nAdd fecmode setting on NIOS SPI master initialization.\nthis SPI is shared by NIOS core inside FPGA, NIOS will use this SPI master to do some one time initialization after power up, and then release the control to DPDK.\n\nFix the timeout initialization for polling the NIOS_INIT_DONE.\n\nFixes: bc44402f (\"raw/ifpga/base: configure FEC mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tianfei Zhang <tianfei.zhang@intel.com>\n---\n drivers/raw/ifpga/base/ifpga_fme.c | 27 ++++++++++++++++++++------- drivers/raw/ifpga/base/opae_spi.h | 1 +\n 2 files changed, 21 insertions(+), 7 deletions(-)\n\ndiff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c\nindex c31a94cf8..9057087b5 100644\n--- a/drivers/raw/ifpga/base/ifpga_fme.c\n+++ b/drivers/raw/ifpga/base/ifpga_fme.c\n@@ -979,28 +979,32 @@ struct ifpga_feature_ops fme_spi_master_ops = { static int nios_spi_wait_init_done(struct altera_spi_device *dev) {\n \tu32 val = 0;\n-\tunsigned long timeout = msecs_to_timer_cycles(10000);\n+\tunsigned long timeout = rte_get_timer_cycles() +\n+\t\t\tmsecs_to_timer_cycles(10000);\n \tunsigned long ticks;\n \tint major_version;\n+\tint fecmode = FEC_MODE_NO;\n \n \tif (spi_reg_read(dev, NIOS_VERSION, &val))\n \t\treturn -EIO;\n \n-\tmajor_version = (val >> NIOS_VERSION_MAJOR_SHIFT) &\n-\t\tNIOS_VERSION_MAJOR;\n-\tdev_debug(dev, \"A10 NIOS FW version %d\\n\", major_version);\n+\tmajor_version =\n+\t\t(val & NIOS_VERSION_MAJOR) >> NIOS_VERSION_MAJOR_SHIFT;\n+\tdev_info(dev, \"A10 NIOS FW version %d\\n\", major_version);\n \n \tif (major_version >= 3) {\n \t\t/* read NIOS_INIT to check if PKVL INIT done or not */\n \t\tif (spi_reg_read(dev, NIOS_INIT, &val))\n \t\t\treturn -EIO;\n \n+\t\tdev_debug(dev, \"read NIOS_INIT: 0x%x\\n\", val);\n+\n \t\t/* check if PKVLs are initialized already */\n \t\tif (val & NIOS_INIT_DONE || val & NIOS_INIT_START)\n \t\t\tgoto nios_init_done;\n \n \t\t/* start to config the default FEC mode */\n-\t\tval = NIOS_INIT_START;\n+\t\tval = fecmode | NIOS_INIT_START;\n \n \t\tif (spi_reg_write(dev, NIOS_INIT, val))\n \t\t\treturn -EIO;\n@@ -1010,14 +1014,23 @@ static int nios_spi_wait_init_done(struct altera_spi_device *dev)\n \tdo {\n \t\tif (spi_reg_read(dev, NIOS_INIT, &val))\n \t\t\treturn -EIO;\n-\t\tif (val)\n+\t\tif (val & NIOS_INIT_DONE)\n \t\t\tbreak;\n \n \t\tticks = rte_get_timer_cycles();\n \t\tif (time_after(ticks, timeout))\n \t\t\treturn -ETIMEDOUT;\n \t\tmsleep(100);\n-\t} while (!val);\n+\t} while (1);\n+\n+\t/* get the fecmode */\n+\tif (spi_reg_read(dev, NIOS_INIT, &val))\n+\t\treturn -EIO;\n+\tdev_debug(dev, \"read NIOS_INIT: 0x%x\\n\", val);\n+\tfecmode = (val & REQ_FEC_MODE) >> REQ_FEC_MODE_SHIFT;\n+\tdev_info(dev, \"fecmode: 0x%x, %s\\n\", fecmode,\n+\t\t\t(fecmode == FEC_MODE_KR) ? \"kr\" :\n+\t\t\t((fecmode == FEC_MODE_RS) ? \"rs\" : \"no\"));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/base/opae_spi.h b/drivers/raw/ifpga/base/opae_spi.h\nindex d20a4c3ed..73a227673 100644\n--- a/drivers/raw/ifpga/base/opae_spi.h\n+++ b/drivers/raw/ifpga/base/opae_spi.h\n@@ -153,6 +153,7 @@ int spi_reg_read(struct altera_spi_device *dev, u32 reg, u32 *val);\n \n #define NIOS_INIT\t\t0x1000\n #define REQ_FEC_MODE\t\tGENMASK(23, 8)\n+#define REQ_FEC_MODE_SHIFT 8\n #define FEC_MODE_NO\t\t0x0\n #define FEC_MODE_KR\t\t0x5555\n #define FEC_MODE_RS\t\t0xaaaa\n--\n2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86187A0526;\n\tThu, 9 Jul 2020 10:59:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5C40B1DEE0;\n\tThu, 9 Jul 2020 10:59:27 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 23DB81DED4;\n Thu, 9 Jul 2020 10:59:24 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jul 2020 01:59:24 -0700", "from fmsmsx603.amr.corp.intel.com ([10.18.126.83])\n by orsmga006.jf.intel.com with ESMTP; 09 Jul 2020 01:59:23 -0700", "from fmsmsx612.amr.corp.intel.com (10.18.126.92) by\n fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Thu, 9 Jul 2020 01:59:23 -0700", "from FMSEDG002.ED.cps.intel.com (10.1.192.134) by\n fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Thu, 9 Jul 2020 01:59:23 -0700", "from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by\n edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Thu, 9 Jul 2020 01:59:23 -0700", "from BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28)\n by BYAPR11MB2952.namprd11.prod.outlook.com (2603:10b6:a03:82::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21; Thu, 9 Jul\n 2020 08:59:21 +0000", "from BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a]) by BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a%3]) with mapi id 15.20.3174.022; Thu, 9 Jul 2020\n 08:59:21 +0000" ], "IronPort-SDR": [ "\n cx2VOtGB2otq/BHzb/vF39sSoR4dCXsjp73I3lG/VzBp/9V+WFaxAETg7gv+Nj9ZOMxZ+m+LPA\n nmjrxdbZC8qw==", "\n za8NESIHO7ejKid9gtQWzxrV4T3ZFcqj5QPHgcuohDHo97LdKPxScC0Gb4wvToEjC2mrnCZ1Qk\n A6GzKKtO7i/Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"145453852\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"145453852\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"284082281\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=W2wfgDCNryVhOjW3BMpnFlUuOy2hMJZvTZwyPy2XJHx59SVeuIUUMMP7oEMBXsgxebean1WT2nanCMRrgXBwGEAcAfhz1O+2E/erN3odr03tV8nxFejhOZPvfBHC1k8ree5tn60RrtZ1EI53ENJnuxDLLcx233e91lz25MZwH/o4Oj6xNjnXRaHc7ClLXtfxPw23BWw1L+DsWPRsyhNQAkQDU/7fvtChH7hPWyQoOUwEKCG5XggzMCCbeD0Wb0F9aJz7H2lHcKHQaP07K1sr42xsQHx10XuE8U+k4JvqGnxiGrFOnwtrjCFI/oUSi27khqTGNZxvKX8qVMOMbbQwEw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AirdsQv7w4j9HYkV4FLMyb8ihFmkAUDGgj/mEQWeyYM=;\n b=Y55PyVtwAx7nbspBb/g9PHOHNM1D72WMGnrjQYS6b8SgKZLCqVZ8IQAnhaU8+vODCdLkFTj3KcH1yHdF6CSZm6ETY4zpeq7R0kZ7kdCKsXNv6p1HAC/ycT7Q/qeIXzog0hGZFHWzxj00K8ma3R9e+UQp1/a8BqQNnhtUoxpugj7pOHqH7VL28uYgMedruT0SeA3lP0ICWIsbV5nV2pkHr3dMvn9ZhrIcvs3wn1Z99/2/m5R0LnFDtaxheByiCNBn9Qsj+eEw+uBz+XZMiXb1jxfMnxmY2AHCP8sXcF1cZ1xhfhxkZOgfyqC++FL6p2Wtw6uT1DVH48qNA2b9RU7v9A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AirdsQv7w4j9HYkV4FLMyb8ihFmkAUDGgj/mEQWeyYM=;\n b=JO4ZbYHUWRIcvnkeYz98/F0rZllKrfBxqynfPkkCbRBJ++atnlgQqiiwi22Uc1wi/X3zYNOtFmswGDGXipinvR60c9Z2DuGG5gIDUpbSuwtEpBxgePtPYeN9k93Yzi4zjUJDJoRSZiDl3VUmr61O5xc0WMhX8+6J3JptFkKnH34=", "From": "\"Zhang, Tianfei\" <tianfei.zhang@intel.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Xu, Rosen\" <rosen.xu@intel.com>", "CC": "\"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH v1 2/2] raw/ifpga/base: fix NIOS SPI initial", "Thread-Index": "AQHWVc2QMS+F+U1Ib0+ym+PpHmwqb6j+8mrA", "Date": "Thu, 9 Jul 2020 08:59:21 +0000", "Message-ID": "\n <BYAPR11MB3477E5A303C29236B15695AFE3640@BYAPR11MB3477.namprd11.prod.outlook.com>", "References": "<20200709163603.8798-1-tianfei.zhang@intel.com>", "In-Reply-To": "<20200709163603.8798-1-tianfei.zhang@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-version": "11.2.0.6", "dlp-reaction": "no-action", "authentication-results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.198.147.194]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "ad0ee686-b3f5-494b-55d7-08d823e65ef5", "x-ms-traffictypediagnostic": "BYAPR11MB2952:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BYAPR11MB2952D4A4B70E2549434A027FE3640@BYAPR11MB2952.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:3513;", "x-forefront-prvs": "04599F3534", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n syKHAuDde1XSSJLHoxGudARYg+XpTzOz9w7CuDUP53yspPCihUKDnI55WzofW27LYTcvOnMsZFGPSXRV5tq9k1lKQkXAj7QByRCV4iVqprdJ/1LHw3LvIknjDXK0AKJd7T/lRwOBXKu5G7WWqYodEmvMxey0JcrrC8pu/gCm3f7sRw6G5Q9QUAVEf89gfZC0v8xiL/3Y+j8/mMlKspqLMaDzMX7WPrC9N6+BimBp+J2z07M+5tqb2/+2+HJvl/MANUinSeOTGrtkfIJOczVDlHrXYBdbFQnCITK9A+gxblzh+eGMQGkD7DfPfMb3sq04lich3q+OFsvxuR/1I2h22w==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3477.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(396003)(346002)(376002)(366004)(136003)(478600001)(83380400001)(316002)(110136005)(8936002)(7696005)(66476007)(86362001)(52536014)(8676002)(450100002)(33656002)(2906002)(71200400001)(6506007)(5660300002)(4326008)(53546011)(9686003)(186003)(55016002)(66946007)(6636002)(76116006)(64756008)(66446008)(66556008)(26005);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n UVZvkI7KZB6qBnd31ltAGU0sBDajmIYI4PjSNCrWQsl10lKsoHBOowe4K7vnS/li1ONkoVY0ECUrSZgdpVHDz6rxoWwWAJU39MJQpcrZUkNPtQtP+jj5FHqSyTTQzo3XiWY8LnmP5WnS/gT6eQcEO8HRg1nKSmcH9P79yKvKyjIVjxVz809+JSigyTVGj1isvBnqmSQATWpj4ITT9WEp2BgWV+lUQo29Zuh8dutWADAb2C0DhmmSnH9nUkhQLZkWsPJKoBE37kyvQyJPxjwmIe041gr66t8h31FUqHFTLcIB9XHStc/ghqhOni5TAbbvvdQwbalLnuIZ/uzQgrYuh1PSlsQHAXCOi9f9TF62wQAc0ZKV//poIqZaN3ZOV9XuXtWjh2cHp3cu1d3t8ORicd9qHZeQX/a+qvLVIxwOXPK6rpzUfrBWCWynBuf2urJMstBY/cAa35B/ytlMiNjtGEsg0GhMQOBldjAy0p/doQkx/l5jO2XYerPWICZUbc/B", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3477.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ad0ee686-b3f5-494b-55d7-08d823e65ef5", "X-MS-Exchange-CrossTenant-originalarrivaltime": "09 Jul 2020 08:59:21.3203 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n XrA7pCfYgivhLxs9DucmKNKSJJ0F0scRUuIBkhFjaqhXc1JmMPcl1FvVw9cmJPiC4WoejboXg07ukMn5b69luw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR11MB2952", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: fix NIOS SPI initial", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]