Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73617/?format=api
{ "id": 73617, "url": "https://patches.dpdk.org/api/patches/73617/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200709081504.12336-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200709081504.12336-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200709081504.12336-1-david.marchand@redhat.com", "date": "2020-07-09T08:15:04", "name": "net/bnxt: fix build issue", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a40c74f4913b0ff97341b97a9eabce82d604a0fe", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200709081504.12336-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 10916, "url": "https://patches.dpdk.org/api/series/10916/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10916", "date": "2020-07-09T08:15:04", "name": "net/bnxt: fix build issue", "version": 1, "mbox": "https://patches.dpdk.org/series/10916/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73617/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73617/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4A7FCA0526;\n\tThu, 9 Jul 2020 10:17:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D73011DD79;\n\tThu, 9 Jul 2020 10:15:21 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0ED401DD0C\n for <dev@dpdk.org>; Thu, 9 Jul 2020 10:15:19 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-182-Sn-7DxYbMsCXqXb4BflMuA-1; Thu, 09 Jul 2020 04:15:15 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51FCD18FF662;\n Thu, 9 Jul 2020 08:15:14 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.195.188])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 78F6F6FED4;\n Thu, 9 Jul 2020 08:15:11 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594282519;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=cmOCrnN5iogF17mST0M9DEsHrmKNgQGGnXEYAdaFFJQ=;\n b=LwiJCOTr6S7HtODPFi+uoOzkBOqhftX06cCvodw7kdvNxPtrfWyA0th875NvPSkJPRmEVL\n 9bgWnZeHoRWo27ksRSKdLaQ0b5C+MQTEiBLjQFtFjt0dcUd1cg96y+gQ3buapOUYypfKaM\n bfFciCXHTC2OOUj0t2inFXHkqt3yINQ=", "X-MC-Unique": "Sn-7DxYbMsCXqXb4BflMuA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, thomas@monjalon.net,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Randy Schacher <stuart.schacher@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n Peter Spreadborough <peter.spreadborough@broadcom.com>", "Date": "Thu, 9 Jul 2020 10:15:04 +0200", "Message-Id": "<20200709081504.12336-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/bnxt: fix build issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset.\nTesting against a n value does not work and we end up with a link issue:\n\n/usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc':\n.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference\n to `tf_em_ext_alloc'\n/usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free':\n.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference\n to `tf_em_ext_free'\ncollect2: error: ld returned 1 exit status\ngmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]\n Error 1\ngmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2\n\nFixes: b2da02480cb7 (\"net/bnxt: support EEM system memory\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/bnxt/tf_core/Makefile | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/Makefile b/drivers/net/bnxt/tf_core/Makefile\nindex b4fbdd00fc..806471427c 100644\n--- a/drivers/net/bnxt/tf_core/Makefile\n+++ b/drivers/net/bnxt/tf_core/Makefile\n@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c\n-ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n)\n-SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c\n+ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y)\n+SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c\n else\n-SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c\n+SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c\n endif\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c\n SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c\n", "prefixes": [] }