Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73609/?format=api
https://patches.dpdk.org/api/patches/73609/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-13-guinanx.sun@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200709080046.65879-13-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200709080046.65879-13-guinanx.sun@intel.com", "date": "2020-07-09T08:00:39", "name": "[v3,12/19] net/ixgbe/base: remove unnecessary log message FC autonego", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fb0c2fe78a636cb7ac59277b910cf5279f12af29", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-13-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10915, "url": "https://patches.dpdk.org/api/series/10915/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10915", "date": "2020-07-09T08:00:27", "name": "update ixgbe base code", "version": 3, "mbox": "https://patches.dpdk.org/series/10915/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73609/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73609/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2B3DFA0526;\n\tThu, 9 Jul 2020 10:16:16 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D1B71DE6D;\n\tThu, 9 Jul 2020 10:14:30 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id C74D61DE91\n for <dev@dpdk.org>; Thu, 9 Jul 2020 10:14:17 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jul 2020 01:14:17 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 09 Jul 2020 01:14:14 -0700" ], "IronPort-SDR": [ "\n JhJFHm8qwBFhS4VCRWfvuVguXyfF4MIM2LeGT8dlgjkQ6xP17pkuo8UAxPk5uv5uMNsfC+46Fi\n m3XyNnmG2cGA==", "\n 9qQy0d6TAs4FnHtef/OT/kAE4rIlRrTNVc8BbZHIBofteg/B3yD7IhwyAcFHu6N6oy1FgzcxU/\n 20iICHCVW57A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"212869378\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"212869378\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"297989248\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Jeff Guo <jia.guo@intel.com>, Zhao1 Wei <wei.zhao1@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>,\n Zalfresso-Jundzillo <marekx.zalfresso-jundzillo@intel.com>", "Date": "Thu, 9 Jul 2020 08:00:39 +0000", "Message-Id": "<20200709080046.65879-13-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200709080046.65879-1-guinanx.sun@intel.com>", "References": "<20200702031329.4495-1-guinanx.sun@intel.com>\n <20200709080046.65879-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 12/19] net/ixgbe/base: remove unnecessary log\n\tmessage FC autonego", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function ixgbe_device_supports_autoneg_fc is checking whether\na particular device and medium configuration is supporting\nFlow Control Autonegotiation. In case of non-support, the message\nis always logged which is confusing.\nThe fix is removing unnecessary log entry.\n\nSigned-off-by: Zalfresso-Jundzillo <marekx.zalfresso-jundzillo@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\nReviewed-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex 4e5d909ca..927877b6a 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -186,10 +186,6 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)\n \t\tbreak;\n \t}\n \n-\tif (!supported)\n-\t\tERROR_REPORT2(IXGBE_ERROR_UNSUPPORTED,\n-\t\t\t \"Device %x does not support flow control autoneg\",\n-\t\t\t hw->device_id);\n \treturn supported;\n }\n \n", "prefixes": [ "v3", "12/19" ] }{ "id": 73609, "url": "