Show a patch.

GET /api/patches/73608/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 73608,
    "url": "https://patches.dpdk.org/api/patches/73608/?format=api",
    "web_url": "https://patches.dpdk.org/patch/73608/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<20200709080046.65879-12-guinanx.sun@intel.com>",
    "date": "2020-07-09T08:00:38",
    "name": "[v3,11/19] net/ixgbe/base: remove unnecessary return value check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "04867c7eeeebad70a8f4688a56ce2d03d11f2bb2",
    "submitter": {
        "id": 1476,
        "url": "https://patches.dpdk.org/api/people/1476/?format=api",
        "name": "Guinan Sun",
        "email": "guinanx.sun@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "https://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "https://patches.dpdk.org/patch/73608/mbox/",
    "series": [
        {
            "id": 10915,
            "url": "https://patches.dpdk.org/api/series/10915/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10915",
            "date": "2020-07-09T08:00:27",
            "name": "update ixgbe base code",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/10915/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/73608/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/73608/checks/",
    "tags": {},
    "headers": {
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9676\"; a=\"212869372\"",
            "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"212869372\"",
            "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"297989228\""
        ],
        "IronPort-SDR": [
            "\n hHVljtJH6EItdWa3J/i3lnPgOa8EH4lJrFG+1/MrzmnA0lV1Hf+bolCzTY7h6FmcFQ6DXJ4v5N\n 0g0BKboHFCDQ==",
            "\n Anj+aJlhjRWIq0nzwQadwN8tBdHU4tHWXi/TBqQfPaJzDyusftouh7efGne9uflmU1X3f7j0sk\n 1iuprGQJTRBw=="
        ],
        "X-Amp-File-Uploaded": "False",
        "Precedence": "list",
        "X-Mailman-Version": "2.1.15",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "X-BeenThere": "dev@dpdk.org",
        "References": "<20200702031329.4495-1-guinanx.sun@intel.com>\n <20200709080046.65879-1-guinanx.sun@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 11/19] net/ixgbe/base: remove unnecessary\n\treturn value check",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 162CEA0526;\n\tThu,  9 Jul 2020 10:16:02 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B25751DEEB;\n\tThu,  9 Jul 2020 10:14:19 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 9FCF71DE1F\n for <dev@dpdk.org>; Thu,  9 Jul 2020 10:14:14 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jul 2020 01:14:14 -0700",
            "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 09 Jul 2020 01:14:12 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "X-Mailer": "git-send-email 2.17.1",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "X-ExtLoop1": "1",
        "Date": "Thu,  9 Jul 2020 08:00:38 +0000",
        "To": "dev@dpdk.org",
        "From": "Guinan Sun <guinanx.sun@intel.com>",
        "In-Reply-To": "<20200709080046.65879-1-guinanx.sun@intel.com>",
        "Cc": "Jeff Guo <jia.guo@intel.com>, Zhao1 Wei <wei.zhao1@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>,\n Jakub Chylkowski <jakubx.chylkowski@intel.com>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Message-Id": "<20200709080046.65879-12-guinanx.sun@intel.com>",
        "Return-Path": "<dev-bounces@dpdk.org>"
    },
    "content": "Remove unnecessary return value check.\n\nSigned-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\nReviewed-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_82599.c  |  4 +---\n drivers/net/ixgbe/base/ixgbe_common.c |  4 +---\n drivers/net/ixgbe/base/ixgbe_common.h |  2 +-\n drivers/net/ixgbe/base/ixgbe_phy.c    | 25 +++++++------------------\n drivers/net/ixgbe/base/ixgbe_x540.c   |  2 +-\n 5 files changed, 11 insertions(+), 26 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c\nindex 38ab58d54..e425f28af 100644\n--- a/drivers/net/ixgbe/base/ixgbe_82599.c\n+++ b/drivers/net/ixgbe/base/ixgbe_82599.c\n@@ -2093,9 +2093,7 @@ s32 ixgbe_start_hw_82599(struct ixgbe_hw *hw)\n \tif (ret_val != IXGBE_SUCCESS)\n \t\tgoto out;\n \n-\tret_val = ixgbe_start_hw_gen2(hw);\n-\tif (ret_val != IXGBE_SUCCESS)\n-\t\tgoto out;\n+\tixgbe_start_hw_gen2(hw);\n \n \t/* We need to run link autotry after the driver loads */\n \thw->mac.autotry_restart = true;\ndiff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex a53286eb0..4e5d909ca 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -421,7 +421,7 @@ s32 ixgbe_start_hw_generic(struct ixgbe_hw *hw)\n  *    82599\n  *    X540\n  **/\n-s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw)\n+void ixgbe_start_hw_gen2(struct ixgbe_hw *hw)\n {\n \tu32 i;\n \tu32 regval;\n@@ -446,8 +446,6 @@ s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw)\n \t\t\t    IXGBE_DCA_RXCTRL_HEAD_WRO_EN);\n \t\tIXGBE_WRITE_REG(hw, IXGBE_DCA_RXCTRL(i), regval);\n \t}\n-\n-\treturn IXGBE_SUCCESS;\n }\n \n /**\ndiff --git a/drivers/net/ixgbe/base/ixgbe_common.h b/drivers/net/ixgbe/base/ixgbe_common.h\nindex 7a31f088c..5bdb48440 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.h\n+++ b/drivers/net/ixgbe/base/ixgbe_common.h\n@@ -23,7 +23,7 @@ u16 ixgbe_get_pcie_msix_count_generic(struct ixgbe_hw *hw);\n s32 ixgbe_init_ops_generic(struct ixgbe_hw *hw);\n s32 ixgbe_init_hw_generic(struct ixgbe_hw *hw);\n s32 ixgbe_start_hw_generic(struct ixgbe_hw *hw);\n-s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw);\n+void ixgbe_start_hw_gen2(struct ixgbe_hw *hw);\n s32 ixgbe_clear_hw_cntrs_generic(struct ixgbe_hw *hw);\n s32 ixgbe_read_pba_num_generic(struct ixgbe_hw *hw, u32 *pba_num);\n s32 ixgbe_read_pba_string_generic(struct ixgbe_hw *hw, u8 *pba_num,\ndiff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c\nindex 620154a41..f859b152e 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.c\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.c\n@@ -8,10 +8,10 @@\n \n STATIC void ixgbe_i2c_start(struct ixgbe_hw *hw);\n STATIC void ixgbe_i2c_stop(struct ixgbe_hw *hw);\n-STATIC s32 ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data);\n+STATIC void ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data);\n STATIC s32 ixgbe_clock_out_i2c_byte(struct ixgbe_hw *hw, u8 data);\n STATIC s32 ixgbe_get_i2c_ack(struct ixgbe_hw *hw);\n-STATIC s32 ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data);\n+STATIC void ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data);\n STATIC s32 ixgbe_clock_out_i2c_bit(struct ixgbe_hw *hw, bool data);\n STATIC void ixgbe_raise_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl);\n STATIC void ixgbe_lower_i2c_clk(struct ixgbe_hw *hw, u32 *i2cctl);\n@@ -46,11 +46,7 @@ STATIC s32 ixgbe_out_i2c_byte_ack(struct ixgbe_hw *hw, u8 byte)\n  */\n STATIC s32 ixgbe_in_i2c_byte_ack(struct ixgbe_hw *hw, u8 *byte)\n {\n-\ts32 status;\n-\n-\tstatus = ixgbe_clock_in_i2c_byte(hw, byte);\n-\tif (status)\n-\t\treturn status;\n+\tixgbe_clock_in_i2c_byte(hw, byte);\n \t/* ACK */\n \treturn ixgbe_clock_out_i2c_bit(hw, false);\n }\n@@ -123,8 +119,7 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *hw, u8 addr, u16 reg,\n \t\tif (ixgbe_in_i2c_byte_ack(hw, &low_bits))\n \t\t\tgoto fail;\n \t\t/* Get csum */\n-\t\tif (ixgbe_clock_in_i2c_byte(hw, &csum_byte))\n-\t\t\tgoto fail;\n+\t\tixgbe_clock_in_i2c_byte(hw, &csum_byte);\n \t\t/* NACK */\n \t\tif (ixgbe_clock_out_i2c_bit(hw, false))\n \t\t\tgoto fail;\n@@ -2034,9 +2029,7 @@ STATIC s32 ixgbe_read_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n \t\tif (status != IXGBE_SUCCESS)\n \t\t\tgoto fail;\n \n-\t\tstatus = ixgbe_clock_in_i2c_byte(hw, data);\n-\t\tif (status != IXGBE_SUCCESS)\n-\t\t\tgoto fail;\n+\t\tixgbe_clock_in_i2c_byte(hw, data);\n \n \t\tstatus = ixgbe_clock_out_i2c_bit(hw, nack);\n \t\tif (status != IXGBE_SUCCESS)\n@@ -2281,7 +2274,7 @@ STATIC void ixgbe_i2c_stop(struct ixgbe_hw *hw)\n  *\n  * Clocks in one byte data via I2C data/clock\n  **/\n-STATIC s32 ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data)\n+STATIC void ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data)\n {\n \ts32 i;\n \tbool bit = 0;\n@@ -2293,8 +2286,6 @@ STATIC s32 ixgbe_clock_in_i2c_byte(struct ixgbe_hw *hw, u8 *data)\n \t\tixgbe_clock_in_i2c_bit(hw, &bit);\n \t\t*data |= bit << i;\n \t}\n-\n-\treturn IXGBE_SUCCESS;\n }\n \n /**\n@@ -2390,7 +2381,7 @@ STATIC s32 ixgbe_get_i2c_ack(struct ixgbe_hw *hw)\n  *\n  * Clocks in one bit via I2C data/clock\n  **/\n-STATIC s32 ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data)\n+STATIC void ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data)\n {\n \tu32 i2cctl = IXGBE_READ_REG(hw, IXGBE_I2CCTL_BY_MAC(hw));\n \tu32 data_oe_bit = IXGBE_I2C_DATA_OE_N_EN_BY_MAC(hw);\n@@ -2415,8 +2406,6 @@ STATIC s32 ixgbe_clock_in_i2c_bit(struct ixgbe_hw *hw, bool *data)\n \n \t/* Minimum low period of clock is 4.7 us */\n \tusec_delay(IXGBE_I2C_T_LOW);\n-\n-\treturn IXGBE_SUCCESS;\n }\n \n /**\ndiff --git a/drivers/net/ixgbe/base/ixgbe_x540.c b/drivers/net/ixgbe/base/ixgbe_x540.c\nindex 838bfc8b5..4cea16a81 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x540.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x540.c\n@@ -288,7 +288,7 @@ s32 ixgbe_start_hw_X540(struct ixgbe_hw *hw)\n \tif (ret_val != IXGBE_SUCCESS)\n \t\tgoto out;\n \n-\tret_val = ixgbe_start_hw_gen2(hw);\n+\tixgbe_start_hw_gen2(hw);\n \n out:\n \treturn ret_val;\n",
    "prefixes": [
        "v3",
        "11/19"
    ]
}