Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73607/?format=api
{ "id": 73607, "url": "https://patches.dpdk.org/api/patches/73607/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-11-guinanx.sun@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200709080046.65879-11-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200709080046.65879-11-guinanx.sun@intel.com", "date": "2020-07-09T08:00:37", "name": "[v3,10/19] net/ixgbe/base: add typecast for type mismatch", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4f6a9b6de82f17fd818f5bdf1ca124b22fb100cc", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-11-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10915, "url": "https://patches.dpdk.org/api/series/10915/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10915", "date": "2020-07-09T08:00:27", "name": "update ixgbe base code", "version": 3, "mbox": "https://patches.dpdk.org/series/10915/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73607/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A26F6A0526;\n\tThu, 9 Jul 2020 10:15:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 97B2A1DE7A;\n\tThu, 9 Jul 2020 10:14:17 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 58C531DA3B\n for <dev@dpdk.org>; Thu, 9 Jul 2020 10:14:12 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jul 2020 01:14:12 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 09 Jul 2020 01:14:10 -0700" ], "IronPort-SDR": [ "\n 6G0eIfmXhim0a/DSe/rJzQRkqi9ERz9+ZXRL5npf+V99eufxMT3p16FKr0fsAC/lI6PPA3TdbJ\n BpHiPHdkT6FA==", "\n cxXk/N+05gYd4tfR0T9L3Cav6wTA5CiVm7p3ngeEr7mPBMoO8KoodNa/mBnqZvcgKXmj5AmXRJ\n pb64NLWCZ1+w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"212869369\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"212869369\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"297989191\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Jeff Guo <jia.guo@intel.com>, Zhao1 Wei <wei.zhao1@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>,\n Jakub Chylkowski <jakubx.chylkowski@intel.com>", "Date": "Thu, 9 Jul 2020 08:00:37 +0000", "Message-Id": "<20200709080046.65879-11-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200709080046.65879-1-guinanx.sun@intel.com>", "References": "<20200702031329.4495-1-guinanx.sun@intel.com>\n <20200709080046.65879-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 10/19] net/ixgbe/base: add typecast for type\n\tmismatch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add typecast for type mismatch.\n\nSigned-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\nReviewed-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_82599.c | 8 ++++----\n drivers/net/ixgbe/base/ixgbe_common.c | 2 +-\n drivers/net/ixgbe/base/ixgbe_dcb_82598.c | 2 +-\n drivers/net/ixgbe/base/ixgbe_dcb_82599.c | 2 +-\n drivers/net/ixgbe/base/ixgbe_x550.c | 2 +-\n 5 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c\nindex 193233746..38ab58d54 100644\n--- a/drivers/net/ixgbe/base/ixgbe_82599.c\n+++ b/drivers/net/ixgbe/base/ixgbe_82599.c\n@@ -1547,7 +1547,7 @@ void ixgbe_fdir_add_signature_filter_82599(struct ixgbe_hw *hw,\n \t * is for FDIRCMD. Then do a 64-bit register write from FDIRHASH.\n \t */\n \tfdirhashcmd = (u64)fdircmd << 32;\n-\tfdirhashcmd |= ixgbe_atr_compute_sig_hash_82599(input, common);\n+\tfdirhashcmd |= (u64)ixgbe_atr_compute_sig_hash_82599(input, common);\n \tIXGBE_WRITE_REG64(hw, IXGBE_FDIRHASH, fdirhashcmd);\n \n \tDEBUGOUT2(\"Tx Queue=%x hash=%x\\n\", queue, (u32)fdirhashcmd);\n@@ -1636,7 +1636,7 @@ STATIC u32 ixgbe_get_fdirtcpm_82599(union ixgbe_atr_input *input_mask)\n {\n \tu32 mask = IXGBE_NTOHS(input_mask->formatted.dst_port);\n \tmask <<= IXGBE_FDIRTCPM_DPORTM_SHIFT;\n-\tmask |= IXGBE_NTOHS(input_mask->formatted.src_port);\n+\tmask |= (u32)IXGBE_NTOHS(input_mask->formatted.src_port);\n \tmask = ((mask & 0x55555555) << 1) | ((mask & 0xAAAAAAAA) >> 1);\n \tmask = ((mask & 0x33333333) << 2) | ((mask & 0xCCCCCCCC) >> 2);\n \tmask = ((mask & 0x0F0F0F0F) << 4) | ((mask & 0xF0F0F0F0) >> 4);\n@@ -1868,14 +1868,14 @@ s32 ixgbe_fdir_write_perfect_filter_82599(struct ixgbe_hw *hw,\n \t\t/* record source and destination port (little-endian)*/\n \t\tfdirport = IXGBE_NTOHS(input->formatted.dst_port);\n \t\tfdirport <<= IXGBE_FDIRPORT_DESTINATION_SHIFT;\n-\t\tfdirport |= IXGBE_NTOHS(input->formatted.src_port);\n+\t\tfdirport |= (u32)IXGBE_NTOHS(input->formatted.src_port);\n \t\tIXGBE_WRITE_REG(hw, IXGBE_FDIRPORT, fdirport);\n \t}\n \n \t/* record VLAN (little-endian) and flex_bytes(big-endian) */\n \tfdirvlan = IXGBE_STORE_AS_BE16(input->formatted.flex_bytes);\n \tfdirvlan <<= IXGBE_FDIRVLAN_FLEX_SHIFT;\n-\tfdirvlan |= IXGBE_NTOHS(input->formatted.vlan_id);\n+\tfdirvlan |= (u32)IXGBE_NTOHS(input->formatted.vlan_id);\n \tIXGBE_WRITE_REG(hw, IXGBE_FDIRVLAN, fdirvlan);\n \n \tif (cloud_mode) {\ndiff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex 459498c7d..a53286eb0 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -738,7 +738,7 @@ s32 ixgbe_read_pba_num_generic(struct ixgbe_hw *hw, u32 *pba_num)\n \t\tDEBUGOUT(\"NVM Read Error\\n\");\n \t\treturn ret_val;\n \t}\n-\t*pba_num |= data;\n+\t*pba_num |= (u32)data;\n \n \treturn IXGBE_SUCCESS;\n }\ndiff --git a/drivers/net/ixgbe/base/ixgbe_dcb_82598.c b/drivers/net/ixgbe/base/ixgbe_dcb_82598.c\nindex bb309e28f..3a049b749 100644\n--- a/drivers/net/ixgbe/base/ixgbe_dcb_82598.c\n+++ b/drivers/net/ixgbe/base/ixgbe_dcb_82598.c\n@@ -167,7 +167,7 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw,\n \tfor (i = 0; i < IXGBE_DCB_MAX_TRAFFIC_CLASS; i++) {\n \t\tmax_credits = max[i];\n \t\treg = max_credits << IXGBE_TDTQ2TCCR_MCL_SHIFT;\n-\t\treg |= refill[i];\n+\t\treg |= (u32)(refill[i]);\n \t\treg |= (u32)(bwg_id[i]) << IXGBE_TDTQ2TCCR_BWG_SHIFT;\n \n \t\tif (tsa[i] == ixgbe_dcb_tsa_group_strict_cee)\ndiff --git a/drivers/net/ixgbe/base/ixgbe_dcb_82599.c b/drivers/net/ixgbe/base/ixgbe_dcb_82599.c\nindex 04e0d1fb7..c26aaab91 100644\n--- a/drivers/net/ixgbe/base/ixgbe_dcb_82599.c\n+++ b/drivers/net/ixgbe/base/ixgbe_dcb_82599.c\n@@ -166,7 +166,7 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82599(struct ixgbe_hw *hw, u16 *refill,\n \tfor (i = 0; i < IXGBE_DCB_MAX_TRAFFIC_CLASS; i++) {\n \t\tmax_credits = max[i];\n \t\treg = max_credits << IXGBE_RTTDT2C_MCL_SHIFT;\n-\t\treg |= refill[i];\n+\t\treg |= (u32)(refill[i]);\n \t\treg |= (u32)(bwg_id[i]) << IXGBE_RTTDT2C_BWG_SHIFT;\n \n \t\tif (tsa[i] == ixgbe_dcb_tsa_group_strict_cee)\ndiff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex 5750f79eb..d3363ff1d 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -699,7 +699,7 @@ static s32 ixgbe_setup_fw_link(struct ixgbe_hw *hw)\n \n \tfor (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) {\n \t\tif (hw->phy.autoneg_advertised & ixgbe_fw_map[i].phy_speed)\n-\t\t\tsetup[0] |= ixgbe_fw_map[i].fw_speed;\n+\t\t\tsetup[0] |= (u32)(ixgbe_fw_map[i].fw_speed);\n \t}\n \tsetup[0] |= FW_PHY_ACT_SETUP_LINK_HP | FW_PHY_ACT_SETUP_LINK_AN;\n \n", "prefixes": [ "v3", "10/19" ] }