Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73598/?format=api
{ "id": 73598, "url": "https://patches.dpdk.org/api/patches/73598/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-2-guinanx.sun@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200709080046.65879-2-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200709080046.65879-2-guinanx.sun@intel.com", "date": "2020-07-09T08:00:28", "name": "[v3,01/19] net/ixgbe/base: fix host interface shadow RAM read", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7cfee06fe76a2320b8de73bae3071521d4dccccc", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200709080046.65879-2-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10915, "url": "https://patches.dpdk.org/api/series/10915/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10915", "date": "2020-07-09T08:00:27", "name": "update ixgbe base code", "version": 3, "mbox": "https://patches.dpdk.org/series/10915/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73598/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48798A0526;\n\tThu, 9 Jul 2020 10:13:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1CDFC1DB81;\n\tThu, 9 Jul 2020 10:13:54 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id E20311DA3B;\n Thu, 9 Jul 2020 10:13:49 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jul 2020 01:13:49 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 09 Jul 2020 01:13:47 -0700" ], "IronPort-SDR": [ "\n 8ErkqkyhuryxVfokrDKFOSC3qJoS/4P5fsnZnR1flVzOyef3Ka77MLsimpJhJOQgqBmO79lwnX\n uxUpuBebww0w==", "\n wOUQmhsXnvnfDbLl2R/LibYhkXnJCGpgehA2T7eguEkdDXwoOnS/QaN+mcvCteSdGE90zQYI4F\n gghqhu/m07Gw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"212869320\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"212869320\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"297988970\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Jeff Guo <jia.guo@intel.com>, Zhao1 Wei <wei.zhao1@intel.com>,\n Guinan Sun <guinanx.sun@intel.com>, stable@dpdk.org,\n Mateusz Kowalski <mateusz.kowalski@intel.com>", "Date": "Thu, 9 Jul 2020 08:00:28 +0000", "Message-Id": "<20200709080046.65879-2-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200709080046.65879-1-guinanx.sun@intel.com>", "References": "<20200702031329.4495-1-guinanx.sun@intel.com>\n <20200709080046.65879-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 01/19] net/ixgbe/base: fix host interface\n\tshadow RAM read", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Host interface Shadow RAM Read (0x31) command response\nbuffer length should be stored in two bytes, instead of one byte.\nThis patch fixes it.\n\nFixes: e6102361b1d4 (\"net/ixgbe/base: use 2 bytes for flash read command\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mateusz Kowalski <mateusz.kowalski@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\nReviewed-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 3 ++-\n drivers/net/ixgbe/base/ixgbe_type.h | 12 ++++++++++++\n 2 files changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex 4eb98dc19..5889410f9 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -4600,7 +4600,8 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer,\n \t * Read Flash command requires reading buffer length from\n \t * two byes instead of one byte\n \t */\n-\tif (resp->cmd == 0x30) {\n+\tif (resp->cmd == IXGBE_HOST_INTERFACE_FLASH_READ_CMD ||\n+\t resp->cmd == IXGBE_HOST_INTERFACE_SHADOW_RAM_READ_CMD) {\n \t\tfor (; bi < dword_len + 2; bi++) {\n \t\t\tbuffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG,\n \t\t\t\t\t\t\t bi);\ndiff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h\nindex 15e937010..bc927a34e 100644\n--- a/drivers/net/ixgbe/base/ixgbe_type.h\n+++ b/drivers/net/ixgbe/base/ixgbe_type.h\n@@ -4364,4 +4364,16 @@ struct ixgbe_hw {\n #define IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD\t\\\n \t\t\t\t(0x1F << IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD_SHIFT)\n \n+/* Code Command (Flash I/F Interface) */\n+#define IXGBE_HOST_INTERFACE_FLASH_READ_CMD\t\t\t0x30\n+#define IXGBE_HOST_INTERFACE_SHADOW_RAM_READ_CMD\t\t0x31\n+#define IXGBE_HOST_INTERFACE_FLASH_WRITE_CMD\t\t\t0x32\n+#define IXGBE_HOST_INTERFACE_SHADOW_RAM_WRITE_CMD\t\t0x33\n+#define IXGBE_HOST_INTERFACE_FLASH_MODULE_UPDATE_CMD\t\t0x34\n+#define IXGBE_HOST_INTERFACE_FLASH_BLOCK_EREASE_CMD\t\t0x35\n+#define IXGBE_HOST_INTERFACE_SHADOW_RAM_DUMP_CMD\t\t0x36\n+#define IXGBE_HOST_INTERFACE_FLASH_INFO_CMD\t\t\t0x37\n+#define IXGBE_HOST_INTERFACE_APPLY_UPDATE_CMD\t\t\t0x38\n+#define IXGBE_HOST_INTERFACE_MASK_CMD\t\t\t\t0x000000FF\n+\n #endif /* _IXGBE_TYPE_H_ */\n", "prefixes": [ "v3", "01/19" ] }