Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73592/?format=api
{ "id": 73592, "url": "https://patches.dpdk.org/api/patches/73592/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1594281020-457174-1-git-send-email-simei.su@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594281020-457174-1-git-send-email-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594281020-457174-1-git-send-email-simei.su@intel.com", "date": "2020-07-09T07:50:20", "name": "[v2] net/ice: fix invalid RSS type", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7c3c4cd30c3980f5737be76ff5834f28f5d5c33e", "submitter": { "id": 1298, "url": "https://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1594281020-457174-1-git-send-email-simei.su@intel.com/mbox/", "series": [ { "id": 10913, "url": "https://patches.dpdk.org/api/series/10913/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10913", "date": "2020-07-09T07:50:20", "name": "[v2] net/ice: fix invalid RSS type", "version": 2, "mbox": "https://patches.dpdk.org/series/10913/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73592/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73592/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DEF8A0526;\n\tThu, 9 Jul 2020 09:51:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5FD021DCD1;\n\tThu, 9 Jul 2020 09:51:42 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id D91CB1DCAE\n for <dev@dpdk.org>; Thu, 9 Jul 2020 09:51:40 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jul 2020 00:51:39 -0700", "from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com)\n ([10.67.110.178])\n by fmsmga004.fm.intel.com with ESMTP; 09 Jul 2020 00:51:38 -0700" ], "IronPort-SDR": [ "\n H96u/lKhUzZdLDVp8zmjxzApCUN01q5SwBgY6/KGZRSOMSUlOaGXR+H8J3Wq9N8s2uIvv8m0QH\n IAe+7RIxvm2Q==", "\n LlHz9snO+41yiLG9YvNM01kxbozjO3MbkJHJyscaf38CDPQfeJ22sV2sODRckKPbCZLi8xRAsx\n 0+LSrMTXXpbA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"147027943\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"147027943\"", "E=Sophos;i=\"5.75,331,1589266800\"; d=\"scan'208\";a=\"306340524\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tjia.guo@intel.com,\n\tSimei Su <simei.su@intel.com>", "Date": "Thu, 9 Jul 2020 15:50:20 +0800", "Message-Id": "<1594281020-457174-1-git-send-email-simei.su@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1594275994-318254-1-git-send-email-simei.su@intel.com>", "References": "<1594275994-318254-1-git-send-email-simei.su@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/ice: fix invalid RSS type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a RSS rule with only RSS type modifier L2/L3/L4 SRC/DST_ONLY,\nit should return failure. This patch adds invalid RSS type check.\n\nFixes: dfaedcf20170 (\"net/ice: refactor PF hash flow\")\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n\nv2:\n* Add specific macro value in check rather than hard code.\n---\n drivers/net/ice/ice_hash.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex cbd6116..2c79458 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -722,6 +722,17 @@ struct ice_hash_match_type ice_hash_type_list[] = {\n \t\t\t */\n \t\t\trss_type = rte_eth_rss_hf_refine(rss_type);\n \n+\t\t\t/* Check if only L2/L3/L4 SRC/DST_ONLY exists. */\n+\t\t\tif ((rss_type & ~(ETH_RSS_L2_SRC_ONLY |\n+\t\t\t\t\t ETH_RSS_L2_DST_ONLY |\n+\t\t\t\t\t ETH_RSS_L3_SRC_ONLY |\n+\t\t\t\t\t ETH_RSS_L3_DST_ONLY |\n+\t\t\t\t\t ETH_RSS_L4_SRC_ONLY |\n+\t\t\t\t\t ETH_RSS_L4_DST_ONLY)) == 0)\n+\t\t\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\t\"rss type with only L2/L3/L4 src/dst only is invalid\");\n+\n \t\t\tcombine_type = ETH_RSS_L2_SRC_ONLY |\n \t\t\t\t\tETH_RSS_L2_DST_ONLY |\n \t\t\t\t\tETH_RSS_L3_SRC_ONLY |\n", "prefixes": [ "v2" ] }