Patch Comment List
List patch comments
GET /api/patches/73581/comments/?format=api
[ { "id": 118935, "web_url": "https://patches.dpdk.org/comment/118935/", "msgid": "<aebbff984eea4708b0e5471ee8e0fd5f@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/aebbff984eea4708b0e5471ee8e0fd5f@pantheon.tech", "date": "2020-09-17T11:08:19", "subject": "Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "submitter": { "id": 1626, "url": "https://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "content": "> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Phil Yang\n> Sent: Thursday, July 9, 2020 8:53 AM\n> To: david.marchand@redhat.com; dev@dpdk.org\n> Cc: Honnappa.Nagarahalli@arm.com; Ruifeng.Wang@arm.com; nd@arm.com\n> Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR\n> path\n> \n> If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative path.\n> This will break ninja in the ABI check test.\n> \n\nThe commit message is not very clear. The problem is we're specifying ninja's destination dir in variable DESTDIR when invoking ninja install. If the DESTDIR is not an absolute path, ninja complains (when invoking install). This isn't directly related to DPDK_ABI_REF_DIR, it's more a problem with how we call install_target.\n\n> Fixes: 777014e56d07 (\"devtools: add ABI checks\")\n> \n> Signed-off-by: Phil Yang <phil.yang@arm.com>\n> ---\n> devtools/test-meson-builds.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index\n> a87de63..2bfcaca 100755\n> --- a/devtools/test-meson-builds.sh\n> +++ b/devtools/test-meson-builds.sh\n> @@ -143,7 +143,7 @@ build () # <directory> <target compiler | cross file>\n> <meson options>\n> \tconfig $srcdir $builds_dir/$targetdir $cross --werror $*\n> \tcompile $builds_dir/$targetdir\n> \tif [ -n \"$DPDK_ABI_REF_VERSION\" ]; then\n> -\t\tabirefdir=${DPDK_ABI_REF_DIR:-\n> reference}/$DPDK_ABI_REF_VERSION\n> +\t\tabirefdir=${DPDK_ABI_REF_DIR:-\n> $(pwd)/reference}/$DPDK_ABI_REF_VERSION\n> \t\tif [ ! -d $abirefdir/$targetdir ]; then\n> \t\t\t# clone current sources\n> \t\t\tif [ ! -d $abirefdir/src ]; then\n> --\n> 2.7.4\n> \n\ninstall_target on line 160 is called improperly. Let's fix it so that it matches line 169:\ninstall_target $abirefdir/build $(readlink -f $abirefdir/$targetdir)\n\nThis way we don't need to add $(pwd).", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 502EDA04B6;\n\tThu, 17 Sep 2020 13:08:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CA45A1D5FA;\n\tThu, 17 Sep 2020 13:08:21 +0200 (CEST)", "from mailgw02.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26])\n by dpdk.org (Postfix) with ESMTP id 121E01D5F1\n for <dev@dpdk.org>; Thu, 17 Sep 2020 13:08:20 +0200 (CEST)", "from mailgw02.pantheon.sk (localhost.localdomain [127.0.0.1])\n by mailgw02.pantheon.sk (Proxmox) with ESMTP id AC612182D9D;\n Thu, 17 Sep 2020 13:08:19 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech;\n h=cc:cc:content-transfer-encoding:content-type:content-type\n :date:from:from:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=dkim; bh=AOWkqrYH0S4XrQsT+eYS\n m8zWJootRQTtZoDM5VbBe/I=; b=nqGMbolJTtXx9Kl/lN2Ca6fP4AYn+4li2XWu\n Ef5YLTSEY4drYcTzrE345n7f3RklHRLts5or8gaOnkMOAEkiO/84vHietJg+pnNp\n Xtobh9KKHtCmgO06SF4R2/Pfr9i5EzlL+nmE+r7wQluBtaaBjFkL3tWUIDCTrjg1\n 5/w6jLJi9OILDUBx0MUkehgOOPPTOuwyk96+0YTHWKHvnef+1n/AfxAjcBDag4pL\n EcwM6uSP6wJfl6zmvJS/goTp7127zhdykREM8UOjHjrqkGSj3VStUNzHQYDSnBjP\n NnEcXyHsoGATH/Q4/AQ0FSD7WQvOatB1RlRxgyd0qyMbUVchAw==", "From": "=?iso-8859-2?q?Juraj_Linke=B9?= <juraj.linkes@pantheon.tech>", "To": "Phil Yang <phil.yang@arm.com>, \"david.marchand@redhat.com\"\n <david.marchand@redhat.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Honnappa.Nagarahalli@arm.com\" <Honnappa.Nagarahalli@arm.com>,\n \"Ruifeng.Wang@arm.com\" <Ruifeng.Wang@arm.com>, \"nd@arm.com\" <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "Thread-Index": "AQHWVb2kRcH6C/VVVkqEID1E/cG8sqltF+1Q", "Date": "Thu, 17 Sep 2020 11:08:19 +0000", "Message-ID": "<aebbff984eea4708b0e5471ee8e0fd5f@pantheon.tech>", "References": "<1594277585-15281-1-git-send-email-phil.yang@arm.com>", "In-Reply-To": "<1594277585-15281-1-git-send-email-phil.yang@arm.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.101.4.10]", "Content-Type": "text/plain; charset=\"iso-8859-2\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 119144, "web_url": "https://patches.dpdk.org/comment/119144/", "msgid": "<DB7PR08MB3865E13F00E7EEE7DD715963E93D0@DB7PR08MB3865.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/DB7PR08MB3865E13F00E7EEE7DD715963E93D0@DB7PR08MB3865.eurprd08.prod.outlook.com", "date": "2020-09-20T09:32:19", "subject": "Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "submitter": { "id": 833, "url": "https://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "content": "Juraj Linkeš <juraj.linkes@pantheon.tech> writes:\n\n> > Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n> DESTDIR\n> > path\n> >\n> > If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative path.\n> > This will break ninja in the ABI check test.\n> >\n> \n> The commit message is not very clear. The problem is we're specifying ninja's\n> destination dir in variable DESTDIR when invoking ninja install. If the DESTDIR\n> is not an absolute path, ninja complains (when invoking install). This isn't\nYes, this defect is due to 'ninja install' not happy with the relative path. \nWill reword the commit message in the next version.\n\n> directly related to DPDK_ABI_REF_DIR, it's more a problem with how we call\n> install_target.\nIf we have set 'DPDK_ABI_REF_DIR' before the test, 'abiref' should be an absolute path, but the default 'abiref' value is a relative path.\nSo should we keep them align?\n\n> \n> > Fixes: 777014e56d07 (\"devtools: add ABI checks\")\n> >\n> > Signed-off-by: Phil Yang <phil.yang@arm.com>\n> > ---\n> > devtools/test-meson-builds.sh | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-\n> builds.sh index\n> > a87de63..2bfcaca 100755\n> > --- a/devtools/test-meson-builds.sh\n> > +++ b/devtools/test-meson-builds.sh\n> > @@ -143,7 +143,7 @@ build () # <directory> <target compiler | cross file>\n> > <meson options>\n> > \tconfig $srcdir $builds_dir/$targetdir $cross --werror $*\n> > \tcompile $builds_dir/$targetdir\n> > \tif [ -n \"$DPDK_ABI_REF_VERSION\" ]; then\n> > -\t\tabirefdir=${DPDK_ABI_REF_DIR:-\n> > reference}/$DPDK_ABI_REF_VERSION\n> > +\t\tabirefdir=${DPDK_ABI_REF_DIR:-\n> > $(pwd)/reference}/$DPDK_ABI_REF_VERSION\n> > \t\tif [ ! -d $abirefdir/$targetdir ]; then\n> > \t\t\t# clone current sources\n> > \t\t\tif [ ! -d $abirefdir/src ]; then\n> > --\n> > 2.7.4\n> >\n> \n> install_target on line 160 is called improperly. Let's fix it so that it matches line\n> 169:\n> install_target $abirefdir/build $(readlink -f $abirefdir/$targetdir)\n\nIf so we need to call readlink at line #161 as well as it does at line #171.\n\n> \n> This way we don't need to add $(pwd).\n\nIf you don't prefer $(pwd), we can do it like this:\nabirefdir=$(readlink -f ${DPDK_ABI_REF_DIR:- reference}/$DPDK_ABI_REF_VERSION)\n\nThanks,\nPhil", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5A868A04B7;\n\tSun, 20 Sep 2020 11:32:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 15DA71D9AC;\n\tSun, 20 Sep 2020 11:32:34 +0200 (CEST)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr130054.outbound.protection.outlook.com [40.107.13.54])\n by dpdk.org (Postfix) with ESMTP id CF4D71D9AA\n for <dev@dpdk.org>; Sun, 20 Sep 2020 11:32:31 +0200 (CEST)", "from AM5PR0701CA0023.eurprd07.prod.outlook.com\n (2603:10a6:203:51::33) by VI1PR0802MB2605.eurprd08.prod.outlook.com\n (2603:10a6:800:b0::22) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Sun, 20 Sep\n 2020 09:32:29 +0000", "from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com\n (2603:10a6:203:51:cafe::a2) by AM5PR0701CA0023.outlook.office365.com\n (2603:10a6:203:51::33) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.6 via Frontend\n Transport; Sun, 20 Sep 2020 09:32:29 +0000", "from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by\n VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with\n Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3391.15 via Frontend Transport; Sun, 20 Sep 2020 09:32:29 +0000", "(\"Tessian outbound 34b830c8a0ef:v64\");\n Sun, 20 Sep 2020 09:32:28 +0000", "from 77c4409551ce.2\n by 64aa7808-outbound-1.mta.getcheckrecipient.com id\n C6DB051D-F3CB-4826-B1C4-4237E878B913.1;\n Sun, 20 Sep 2020 09:32:23 +0000", "from EUR02-VE1-obe.outbound.protection.outlook.com\n by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id\n 77c4409551ce.2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);\n Sun, 20 Sep 2020 09:32:23 +0000", "from DB7PR08MB3865.eurprd08.prod.outlook.com (2603:10a6:10:74::25)\n by DB6PR0801MB2088.eurprd08.prod.outlook.com (2603:10a6:4:78::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Sun, 20 Sep\n 2020 09:32:19 +0000", "from DB7PR08MB3865.eurprd08.prod.outlook.com\n ([fe80::519c:72bd:e189:625b]) by DB7PR08MB3865.eurprd08.prod.outlook.com\n ([fe80::519c:72bd:e189:625b%7]) with mapi id 15.20.3391.011; Sun, 20 Sep 2020\n 09:32:19 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=c5O6fxWyPgdkInnpfuvNLt4mDKgw37dAnCOZNijfPNk=;\n b=cSiVaBNpxr6ltiQeaWzV+nyeL69Vy6vDkM+LzkYQjyya0Kc9E06GjN4OyKUORLqTJLnJE+3Ps7ZeErADNkj/GL2xhJoG7qWRCyHUY6MiEbB5yHhEvFF4lIzlgEkMO0kkYMQatJqDEbogFVRARMhTI/DcmdULofRJwttm3JsCykI=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=c5O6fxWyPgdkInnpfuvNLt4mDKgw37dAnCOZNijfPNk=;\n b=cSiVaBNpxr6ltiQeaWzV+nyeL69Vy6vDkM+LzkYQjyya0Kc9E06GjN4OyKUORLqTJLnJE+3Ps7ZeErADNkj/GL2xhJoG7qWRCyHUY6MiEbB5yHhEvFF4lIzlgEkMO0kkYMQatJqDEbogFVRARMhTI/DcmdULofRJwttm3JsCykI=" ], "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 63.35.35.123)\n smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)\n header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none\n header.from=arm.com;", "Received-SPF": "Pass (protection.outlook.com: domain of arm.com designates\n 63.35.35.123 as permitted sender) receiver=protection.outlook.com;\n client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;", "X-CR-MTA-TID": "64aa7808", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dvwjkKNk3D+mhLAFglg9z8BiA5CzL1T5BLeLQy4D2mcoXoWnlEMoWnZaFw0pl7t+B/vIpj7IEqGcaYTDDeoyLRn5ogizjqjkylMsLppfadho8lpGwazGs7FXxvxqYFgzhoCDGKkof/Ztb2FUtDtQe6c3/D7R1lflYPrHPgZIWWNiwPTaKTIUer4hSbQ0R90bOzENwWjkvqJqSFNtVgM/YpGdG9UumQAL8mdAyBTBKC0NTVqJcDnmPbhqag3IL5KW6NH+QBBjbZ4byAXEF1ytUli+/8k06AYFMpq3nLvTTbzDWJtKK+6M6pxBcl9r8mVR1WNAaI1VT/IRAEDnfOESkg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=c5O6fxWyPgdkInnpfuvNLt4mDKgw37dAnCOZNijfPNk=;\n b=DjHR6DUZypNwD0EFtYSSnQvZF2XEdvAXaJ0Ix8NDR+MxbyMV9wNUb5blueeE7oaM9RNjpGAIJk/VqD9VVxTcHfPiQtg2MWNvMKNyVZUSqpY0jun1OOYN/TgcWTJ95whBJaL2keAXlDX782Za6xXFGQAsC+fuqpShzMSBsDUnPh7696TQ7o1XrzTust2gPXnM0dATmGmxiy2Y0TZGG6O8AYtXQ2hCxIm6d9lhKlfDJUa+ZF3jwU60WmiqW+ULSzaODmG1o8VSNAaOBOQ+By/sEww4D4vGxrlqUw9Y0KjMuWkEukVR9TQG/0Yyfk1K7rfNgttr8oXgxCba/DIG3Q12yw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass\n header.d=arm.com; arc=none", "From": "Phil Yang <Phil.Yang@arm.com>", "To": "=?iso-8859-2?q?Juraj_Linke=B9?= <juraj.linkes@pantheon.tech>,\n \"david.marchand@redhat.com\" <david.marchand@redhat.com>,\n \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Ruifeng Wang\n <Ruifeng.Wang@arm.com>, nd <nd@arm.com>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "Thread-Index": "AQHWVb2nZiqMRXKQk0KXYp1FraKqM6ltGjeAgASTOlA=", "Date": "Sun, 20 Sep 2020 09:32:19 +0000", "Message-ID": "\n <DB7PR08MB3865E13F00E7EEE7DD715963E93D0@DB7PR08MB3865.eurprd08.prod.outlook.com>", "References": "<1594277585-15281-1-git-send-email-phil.yang@arm.com>\n <aebbff984eea4708b0e5471ee8e0fd5f@pantheon.tech>", "In-Reply-To": "<aebbff984eea4708b0e5471ee8e0fd5f@pantheon.tech>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-ts-tracking-id": "BEEE35333990404EBEDC69C788B39E12.0", "x-checkrecipientchecked": "true", "Authentication-Results-Original": "pantheon.tech; dkim=none (message not signed)\n header.d=none; pantheon.tech;\n dmarc=none action=none header.from=arm.com;", "x-originating-ip": "[114.85.108.161]", "x-ms-publictraffictype": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "4af81bbd-d2d2-4afe-08ce-08d85d4817da", "x-ms-traffictypediagnostic": "DB6PR0801MB2088:|VI1PR0802MB2605:", "x-ms-exchange-transport-forked": "True", "X-Microsoft-Antispam-PRVS": "\n <VI1PR0802MB260544A056D1C8CEC3712756E93D0@VI1PR0802MB2605.eurprd08.prod.outlook.com>", "x-checkrecipientrouted": "true", "nodisclaimer": "true", "x-ms-oob-tlc-oobclassifiers": "OLM:5516;OLM:5516;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam-Untrusted": "BCL:0;", "X-Microsoft-Antispam-Message-Info-Original": "\n Gr0cdc4B6mTT9q4VADftUcjVmFEpR6XqaWNeKSU5TCBfiwnOLcXLqCohxD6SVBnUPejsXYvTNRdrLwCI3iLpygUEzCiTn6bXDNOZTu8ZciBgpCSkDlHjCGaUVWOuW43wySIWE8gCRZT+hC6CFmLuQm5wlYhZRs4+tKWGGvXTIobwzMLz/elz1Ce1o13nAQ69H2oy/aRrTd1IGB95WxUR07SyMcrF0RzbL4WyBQ1NUBL4SQpTRMW8hAaKPh5APWPiIMazDNGvsa4+HSUVZSen9G0BnoYbBg9gPGjUCC4CeVIR5CO/DgnERGl6qeNcurdiBe2c2wXs2SSgEvBy7ygSfA==", "X-Forefront-Antispam-Report-Untrusted": "CIP:255.255.255.255; CTRY:; LANG:en;\n SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR08MB3865.eurprd08.prod.outlook.com;\n PTR:; CAT:NONE;\n SFS:(4636009)(39850400004)(346002)(396003)(376002)(136003)(366004)(110136005)(33656002)(316002)(26005)(52536014)(86362001)(54906003)(5660300002)(478600001)(9686003)(8936002)(66946007)(2906002)(4326008)(64756008)(66556008)(186003)(55016002)(66446008)(71200400001)(76116006)(6506007)(7696005)(83380400001)(66476007);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n 7zsdmmMFbA2IybmR3hMQrpVWurBlffuKE0rfSacF3wg1q4iI+I3s5wWPETPRx6wZWwFY/70OSsE82RHq1D4CzMmVungt5yXXetdI75bPFL/W+tg8DXxR4Wne1AEGMkFt6yROVBJEOsF9xRUOoTD1FmnjQeC3eIz9mx1QIxiOuTJBFj/TNuWzvevx/D/JDfiJpC4rTUZkjhagnTFx1Jg16i7wAt6xrWgaHzhqKnH14GPMNi+UgvWngXTb4yoE8vjRLSPUXLw0Hqr23VVh0g/+8uZZhSrOWKAZr+bDhk4ZtvGCLAduN8SZ7lNKRN9aTnHzkAZJRsHquI8RKgJcycchpZJkj67Z5NhmruvDe7PJaCckTRxE7vJr1Da9qhwfQ9UZF1laMWtqiO9QUVCO44pIdnRzjjgGaARvfkJcg+AjTfb1WQEZXJrG3X9hIu28oxHMnzAisLDKd588oV8q4WqS1UMJCqQu1Z4Mfxhg4MlUnH40qyRAO1nQrU9kka1TW06TnQ6hBMG03iEpOiqVZKTJiRjvss2Ibtfsdea24Nt23EJoXPdu5uPDD2uG6sODYnfPCukP1PTKgEyJsqEb33GEU0M1iOgPAGcUuV4WIao10iCh7nuTdpNQSr7NDYR84K2Edd/VDDnCiRuMxY7lgLhhRg==", "Content-Type": "text/plain; charset=\"iso-8859-2\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": [ "DB6PR0801MB2088", "VI1PR0802MB2605" ], "Original-Authentication-Results": "pantheon.tech; dkim=none (message not signed)\n header.d=none; pantheon.tech;\n dmarc=none action=none header.from=arm.com;", "X-EOPAttributedMessage": "0", "X-MS-Exchange-Transport-CrossTenantHeadersStripped": "\n VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com", "X-MS-Office365-Filtering-Correlation-Id-Prvs": "\n f1f2b6cd-5213-4f33-c59f-08d85d48122c", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n CvYpYmv4rxQXie1lb3Pn2sYMHTw8dd9yUr1l6Pn6ym0fnDr0r84WTSwyV2U40HBrY+sqHpjGKzS0OLmtW3JLInUK6vGSKJaIRkx8ShCplZpnrT336v60hjWPc2PJirFdgzowE/puuep91/rCc1+7QDC9857BvDsuWA9goXHyuVm8KT39pMpmkWotw7V/pZTuVM5wZn8abpwebZaW/iawY7l4oV+3Vd+tnh1w54o0H5Z1IwJkAY2pmpFcaadZ+cHelYPaku+9A4IN8xNIN3RXZAZI2tKDhWQv7ISdU2hidQvbfnIaYyA/pS2KMAxwJ0Z+A2uwuzJiZMI7TH+BtUcPUu2Lb15nOpVpZvJvuxAW+lTj1+yxz69ZE6HqXlv5/xHHEuI0EnNhsn3Lyh6HTfmT0g==", "X-Forefront-Antispam-Report": "CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;\n PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE;\n SFS:(4636009)(376002)(39850400004)(396003)(136003)(346002)(46966005)(186003)(47076004)(356005)(4326008)(82310400003)(83380400001)(81166007)(7696005)(70206006)(2906002)(6506007)(70586007)(8936002)(86362001)(55016002)(82740400003)(26005)(9686003)(33656002)(52536014)(478600001)(5660300002)(110136005)(316002)(336012)(54906003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Sep 2020 09:32:29.0949 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4af81bbd-d2d2-4afe-08ce-08d85d4817da", "X-MS-Exchange-CrossTenant-Id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];\n Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "Subject": "Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 119161, "web_url": "https://patches.dpdk.org/comment/119161/", "msgid": "<7256fccd84d8416ea46285e20ad6c99c@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/7256fccd84d8416ea46285e20ad6c99c@pantheon.tech", "date": "2020-09-21T06:19:36", "subject": "Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "submitter": { "id": 1626, "url": "https://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "content": "> -----Original Message-----\n> From: Phil Yang <Phil.Yang@arm.com>\n> Sent: Sunday, September 20, 2020 11:32 AM\n> To: Juraj Linkeš <juraj.linkes@pantheon.tech>; david.marchand@redhat.com;\n> dev@dpdk.org\n> Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang\n> <Ruifeng.Wang@arm.com>; nd <nd@arm.com>; nd <nd@arm.com>\n> Subject: RE: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR\n> path\n> \n> Juraj Linkeš <juraj.linkes@pantheon.tech> writes:\n> \n> > > Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n> > DESTDIR\n> > > path\n> > >\n> > > If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative path.\n> > > This will break ninja in the ABI check test.\n> > >\n> >\n> > The commit message is not very clear. The problem is we're specifying\n> > ninja's destination dir in variable DESTDIR when invoking ninja\n> > install. If the DESTDIR is not an absolute path, ninja complains (when\n> > invoking install). This isn't\n> Yes, this defect is due to 'ninja install' not happy with the relative path.\n> Will reword the commit message in the next version.\n> \n> > directly related to DPDK_ABI_REF_DIR, it's more a problem with how we\n> > call install_target.\n> If we have set 'DPDK_ABI_REF_DIR' before the test, 'abiref' should be an\n> absolute path, but the default 'abiref' value is a relative path.\n> So should we keep them align?\n> \n> >\n> > > Fixes: 777014e56d07 (\"devtools: add ABI checks\")\n> > >\n> > > Signed-off-by: Phil Yang <phil.yang@arm.com>\n> > > ---\n> > > devtools/test-meson-builds.sh | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-\n> > builds.sh index\n> > > a87de63..2bfcaca 100755\n> > > --- a/devtools/test-meson-builds.sh\n> > > +++ b/devtools/test-meson-builds.sh\n> > > @@ -143,7 +143,7 @@ build () # <directory> <target compiler | cross\n> > > file> <meson options>\n> > > \tconfig $srcdir $builds_dir/$targetdir $cross --werror $*\n> > > \tcompile $builds_dir/$targetdir\n> > > \tif [ -n \"$DPDK_ABI_REF_VERSION\" ]; then\n> > > -\t\tabirefdir=${DPDK_ABI_REF_DIR:-\n> > > reference}/$DPDK_ABI_REF_VERSION\n> > > +\t\tabirefdir=${DPDK_ABI_REF_DIR:-\n> > > $(pwd)/reference}/$DPDK_ABI_REF_VERSION\n> > > \t\tif [ ! -d $abirefdir/$targetdir ]; then\n> > > \t\t\t# clone current sources\n> > > \t\t\tif [ ! -d $abirefdir/src ]; then\n> > > --\n> > > 2.7.4\n> > >\n> >\n> > install_target on line 160 is called improperly. Let's fix it so that\n> > it matches line\n> > 169:\n> > install_target $abirefdir/build $(readlink -f $abirefdir/$targetdir)\n> \n> If so we need to call readlink at line #161 as well as it does at line #171.\n> \n> >\n> > This way we don't need to add $(pwd).\n> \n> If you don't prefer $(pwd), we can do it like this:\n> abirefdir=$(readlink -f ${DPDK_ABI_REF_DIR:-\n> reference}/$DPDK_ABI_REF_VERSION)\n> \n\nI mostly wanted the code to be consistent and since readlink was already in the code I pointed that out. I think your last proposal is the best of the two worlds, but let's change the code everywhere (i.e. lines 170-174 as well).\n\n> Thanks,\n> Phil\n> \n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF295A04B7;\n\tMon, 21 Sep 2020 08:19:40 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 911491D8CC;\n\tMon, 21 Sep 2020 08:19:39 +0200 (CEST)", "from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26])\n by dpdk.org (Postfix) with ESMTP id 954351C0DB\n for <dev@dpdk.org>; Mon, 21 Sep 2020 08:19:37 +0200 (CEST)", "from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1])\n by mailgw01.pantheon.sk (Proxmox) with ESMTP id 4D6302022AC;\n Mon, 21 Sep 2020 08:19:37 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech;\n h=cc:cc:content-transfer-encoding:content-type:content-type\n :date:from:from:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=dkim; bh=MEgE2yf/n5IQHR2RC2ib\n zLQarOOoCVX2MvvfkkCQ04k=; b=oG9FQIoaurOuwKg3xKYxFYGrXph267qxsivj\n ++5dwqGJI7Ep/31zi667YAwhgJOuQd9kqlh+pZfK49mkD/+yAj6Am0+U17qR5Lz+\n yuwfxlfUgqzF4caeH4//b5JyQaCwTWMaJBi8dU0b/apSfm/DtI2udMwcyZcmSfLt\n 0yMyOZS9KJYlIyIPSk9RRBv2R+JbmzWw/5M9yJgixB1SvKqm8medeO/w95Ciizao\n y4bhEA5t8SJteOaRnzWNCXC83ZGCuRyuDT4tGbvYHePSoX/5KOpNkZwIc0VENXsY\n 2CHZodZK6nuLTKhknajPTx+FRD93QIAUFq7JdI10mPloeKPU4Q==", "From": "=?iso-8859-2?q?Juraj_Linke=B9?= <juraj.linkes@pantheon.tech>", "To": "Phil Yang <Phil.Yang@arm.com>, \"david.marchand@redhat.com\"\n <david.marchand@redhat.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Ruifeng Wang\n <Ruifeng.Wang@arm.com>, nd <nd@arm.com>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "Thread-Index": "AQHWVb2kRcH6C/VVVkqEID1E/cG8sqltF+1QgAR874CAAX0rEA==", "Date": "Mon, 21 Sep 2020 06:19:36 +0000", "Message-ID": "<7256fccd84d8416ea46285e20ad6c99c@pantheon.tech>", "References": "<1594277585-15281-1-git-send-email-phil.yang@arm.com>\n <aebbff984eea4708b0e5471ee8e0fd5f@pantheon.tech>\n <DB7PR08MB3865E13F00E7EEE7DD715963E93D0@DB7PR08MB3865.eurprd08.prod.outlook.com>", "In-Reply-To": "\n <DB7PR08MB3865E13F00E7EEE7DD715963E93D0@DB7PR08MB3865.eurprd08.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.101.4.10]", "Content-Type": "text/plain; charset=\"iso-8859-2\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default\n DESTDIR\tpath", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]