Patch Detail
Show a patch.
GET /api/patches/73578/
{ "id": 73578, "url": "https://patches.dpdk.org/api/patches/73578/", "web_url": "https://patches.dpdk.org/patch/73578/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk" }, "msgid": "<1594275688-283889-1-git-send-email-simei.su@intel.com>", "date": "2020-07-09T06:21:28", "name": "net/ice: fix incomplete protocol header for PPPoE", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7b1003af4ab6e695ab4ffcad219ccebe60f457b2", "submitter": { "id": 1298, "url": "https://patches.dpdk.org/api/people/1298/", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/patch/73578/mbox/", "series": [ { "id": 10908, "url": "https://patches.dpdk.org/api/series/10908/", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10908", "date": "2020-07-09T06:21:28", "name": "net/ice: fix incomplete protocol header for PPPoE", "version": 1, "mbox": "https://patches.dpdk.org/series/10908/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73578/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73578/checks/", "tags": {}, "headers": { "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "Return-Path": "<dev-bounces@dpdk.org>", "IronPort-SDR": [ "\n WbTiyraM+YP6Fkq00MC1z3JyDKolxqhnT53URp2jnMBkcGPb3H/z+wBMcZ1fDNdw89aq8js+1i\n KFIeDc7ViBxQ==", "\n F2smb4GuA4ELJQgYsc8SnhpJkwods0TCeqJuAes9RA1HrZa5iSJBAPimaFURqUG6gXkTsv8/Wn\n sRxLyzwz3w4A==" ], "X-Mailer": "git-send-email 1.8.3.1", "To": "qi.z.zhang@intel.com", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F433A0526;\n\tThu, 9 Jul 2020 08:22:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 23F3F1DAD8;\n\tThu, 9 Jul 2020 08:22:56 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 337831DACA\n for <dev@dpdk.org>; Thu, 9 Jul 2020 08:22:53 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Jul 2020 23:22:52 -0700", "from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com)\n ([10.67.110.178])\n by orsmga003.jf.intel.com with ESMTP; 08 Jul 2020 23:22:47 -0700" ], "X-BeenThere": "dev@dpdk.org", "X-Amp-File-Uploaded": "False", "Subject": "[dpdk-dev] [PATCH] net/ice: fix incomplete protocol header for PPPoE", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "X-Amp-Result": "SKIPPED(no attachment in message)", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Post": "<mailto:dev@dpdk.org>", "Cc": "dev@dpdk.org,\n\tjia.guo@intel.com,\n\tSimei Su <simei.su@intel.com>", "X-ExtLoop1": "1", "Precedence": "list", "From": "Simei Su <simei.su@intel.com>", "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"232819838\"", "E=Sophos;i=\"5.75,330,1589266800\"; d=\"scan'208\";a=\"232819838\"", "E=Sophos;i=\"5.75,330,1589266800\"; d=\"scan'208\";a=\"280196290\"" ], "X-Original-To": "patchwork@inbox.dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>", "Errors-To": "dev-bounces@dpdk.org", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "Message-Id": "<1594275688-283889-1-git-send-email-simei.su@intel.com>", "Delivered-To": "patchwork@inbox.dpdk.org", "Date": "Thu, 9 Jul 2020 14:21:28 +0800", "X-Mailman-Version": "2.1.15" }, "content": "When adding a RSS rule with pattern MAC_PPPOE_IPV4_UDP and input\nset SRC/DST IPV4, because of incomplete protocol header fields,\nthe rule can't do hash with inner src/dst ipv4. PPPOE_IPV4_TCP/SCTP\nand PPPOE_IPV6_UDP/TCP/SCTP also have similar issues. This patch\ncomplements protocol header fields for PPPOE data packets.\n\nFixes: dfaedcf20170 (\"net/ice: refactor PF hash flow\")\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/net/ice/ice_hash.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex a10734a..cbd6116 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -113,16 +113,20 @@ struct rss_type_match_hdr hint_eth_ipv4_gtpu_eh_ipv4_tcp = {\n \tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP,\n \tETH_RSS_GTPU | ETH_RSS_NONFRAG_IPV4_TCP};\n struct rss_type_match_hdr hint_eth_pppoes_ipv4 = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_IPV4};\n struct rss_type_match_hdr hint_eth_pppoes_ipv4_udp = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_UDP,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_UDP};\n struct rss_type_match_hdr hint_eth_pppoes_ipv4_tcp = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_TCP};\n struct rss_type_match_hdr hint_eth_pppoes_ipv4_sctp = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_SCTP};\n struct rss_type_match_hdr hint_eth_ipv4_esp = {\n \tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n@@ -218,16 +222,20 @@ struct rss_type_match_hdr hint_eth_vlan_ipv6_sctp = {\n \tETH_RSS_ETH | ETH_RSS_C_VLAN |\n \tETH_RSS_NONFRAG_IPV6_SCTP};\n struct rss_type_match_hdr hint_eth_pppoes_ipv6 = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_IPV6};\n struct rss_type_match_hdr hint_eth_pppoes_ipv6_udp = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_UDP,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV6_UDP};\n struct rss_type_match_hdr hint_eth_pppoes_ipv6_tcp = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV6_TCP};\n struct rss_type_match_hdr hint_eth_pppoes_ipv6_sctp = {\n-\tICE_FLOW_SEG_HDR_PPPOE,\n+\tICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV6_SCTP};\n struct rss_type_match_hdr hint_eth_pppoes = {\n \tICE_FLOW_SEG_HDR_PPPOE,\n", "prefixes": [] }