Patch Comment List
List patch comments
GET /api/patches/73561/comments/?format=api
[ { "id": 115568, "web_url": "https://patches.dpdk.org/comment/115568/", "msgid": "<8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com", "date": "2020-07-08T22:27:28", "subject": "Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient\n privileges for hugepages", "submitter": { "id": 1235, "url": "https://patches.dpdk.org/api/people/1235/?format=api", "name": "Menon, Ranjit", "email": "ranjit.menon@intel.com" }, "content": "On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote:\n> AdjustTokenPrivileges() succeeds even if no requested privileges have\n> been granted; this behavior is documented. Check last error code in\n> addition to return value to detect such case.\n>\n> Make error messages more specific and add troubleshooting hint.\n>\n> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n> ---\n>\n> v2:\n> Improve error reporting (Tal Shnaiderman).\n>\n> lib/librte_eal/windows/eal_hugepages.c | 10 ++++++++--\n> 1 file changed, 8 insertions(+), 2 deletions(-)\n>\n> diff --git a/lib/librte_eal/windows/eal_hugepages.c b/lib/librte_eal/windows/eal_hugepages.c\n> index 5779cd325..7f8a7dfca 100644\n> --- a/lib/librte_eal/windows/eal_hugepages.c\n> +++ b/lib/librte_eal/windows/eal_hugepages.c\n> @@ -41,6 +41,10 @@ hugepage_claim_privilege(void)\n> \t\tgoto exit;\n> \t}\n> \n> +\t/* AdjustTokenPrivileges() may succeed with ERROR_NOT_ALL_ASSIGNED. */\n> +\tif (GetLastError() != ERROR_SUCCESS)\n> +\t\tgoto exit;\n> +\n> \tret = 0;\n> \n> exit:\n> @@ -98,12 +102,14 @@ int\n> eal_hugepage_info_init(void)\n> {\n> \tif (hugepage_claim_privilege() < 0) {\n> -\t\tRTE_LOG(ERR, EAL, \"Cannot claim hugepage privilege\\n\");\n> +\t\tRTE_LOG(ERR, EAL, \"Cannot claim hugepage privilege\\n\"\n> +\t\t\t\"Verify that large-page support privilege \"\n> +\t\t\t\"is assigned to the current user\\n\");\n> \t\treturn -1;\n> \t}\n> \n> \tif (hugepage_info_init() < 0) {\n> -\t\tRTE_LOG(ERR, EAL, \"Cannot get hugepage information\\n\");\n> +\t\tRTE_LOG(ERR, EAL, \"Cannot discover available hugepages\\n\");\n> \t\treturn -1;\n> \t}\n> \n\n\nAcked-by: Ranjit Menon <ranjit.menon@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C90FA0526;\n\tThu, 9 Jul 2020 00:27:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CDD831DDBE;\n\tThu, 9 Jul 2020 00:27:31 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id B4D271DDB4\n for <dev@dpdk.org>; Thu, 9 Jul 2020 00:27:29 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Jul 2020 15:27:28 -0700", "from orsmsx101.amr.corp.intel.com ([10.22.225.128])\n by orsmga005.jf.intel.com with ESMTP; 08 Jul 2020 15:27:28 -0700", "from [10.166.30.253] (10.166.30.253) by ORSMSX101.amr.corp.intel.com\n (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0;\n Wed, 8 Jul 2020 15:27:28 -0700" ], "IronPort-SDR": [ "\n KJuoW0TqjpB2n1np/KJEkWsSJSzjw8N2hIscKBnJbt8F1+IZ6/T3PQvzVzF2KF2dpTEuhrkgyZ\n U2oCoAeMHrgw==", "\n ChsUJKTrgFuK0OxumBPuxafc4dueutkRrs1tjStxT2YUqvMq2SBNgIJftOEe6N31seVGEp5HoR\n yLPgDVsaBXbg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"147904591\"", "E=Sophos;i=\"5.75,329,1589266800\"; d=\"scan'208\";a=\"147904591\"", "E=Sophos;i=\"5.75,329,1589266800\"; d=\"scan'208\";a=\"457669569\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, <dev@dpdk.org>", "CC": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Pallavi Kadam\n <pallavi.kadam@intel.com>, Tal Shnaiderman <talshn@mellanox.com>", "References": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>\n <20200708214843.3080-1-dmitry.kozliuk@gmail.com>", "From": "Ranjit Menon <ranjit.menon@intel.com>", "Message-ID": "<8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com>", "Date": "Wed, 8 Jul 2020 15:27:28 -0700", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200708214843.3080-1-dmitry.kozliuk@gmail.com>", "Content-Type": "text/plain; charset=\"utf-8\"; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "X-Originating-IP": "[10.166.30.253]", "Subject": "Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient\n privileges for hugepages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115756, "web_url": "https://patches.dpdk.org/comment/115756/", "msgid": "<11310226.gcHsNcSAOl@thomas>", "list_archive_url": "https://inbox.dpdk.org/dev/11310226.gcHsNcSAOl@thomas", "date": "2020-07-10T21:25:13", "subject": "Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient\n\tprivileges for hugepages", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "09/07/2020 00:27, Ranjit Menon:\n> On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote:\n> > AdjustTokenPrivileges() succeeds even if no requested privileges have\n> > been granted; this behavior is documented. Check last error code in\n> > addition to return value to detect such case.\n> >\n> > Make error messages more specific and add troubleshooting hint.\n> >\n> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n[...]\n> > \tif (hugepage_claim_privilege() < 0) {\n> > -\t\tRTE_LOG(ERR, EAL, \"Cannot claim hugepage privilege\\n\");\n> > +\t\tRTE_LOG(ERR, EAL, \"Cannot claim hugepage privilege\\n\"\n> > +\t\t\t\"Verify that large-page support privilege \"\n> > +\t\t\t\"is assigned to the current user\\n\");\n\nThe error message can be searched in the code,\nso it is better not to break lines.\n\n> Acked-by: Ranjit Menon <ranjit.menon@intel.com>\n\nApplied with merged log lines, thanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 59ADAA052A;\n\tFri, 10 Jul 2020 23:25:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFBC41DAAA;\n\tFri, 10 Jul 2020 23:25:17 +0200 (CEST)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 5553D1DA6A\n for <dev@dpdk.org>; Fri, 10 Jul 2020 23:25:16 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id CDBC95C012F;\n Fri, 10 Jul 2020 17:25:15 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Fri, 10 Jul 2020 17:25:15 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id AC05230600B2;\n Fri, 10 Jul 2020 17:25:14 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=fm1; bh=\n 5gzb7G0nib/S2cShhs4TGkcgN0YiODKPBzLMOWfBRE0=; b=AWfz7a4LnQigLaYP\n KpQ4b//qE+tG5D0K20+4RHx6qt+Bj8XLMDBynvfSxH8QD/HEG6O7D9pwoXs4lw7H\n QWZJzIlOIgT0Rao0qnL+YbnGih8k/yYJalTZfFQv66bD/yHXmz1IMFkE8CoXVprV\n 2vH4wMsaMvRl8WCdSzHoWdWoR+owb/adteG0GE7ldZfFzvtS8eVxpLrX+kDjIhE7\n 1lGjPsYFrK8QI+5BygdqpbrClTUx5nldqtB3nHvyzz4Nf17Cay3iz4106Y219KZ7\n 2d6D3KfXy6g+NpMrI39VUCAzeGdYBv6Z4wu9cmxdPYIxWYrA8iInnQqUZxuCOgc4\n qV01iA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:content-type\n :date:from:in-reply-to:message-id:mime-version:references\n :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm3; bh=5gzb7G0nib/S2cShhs4TGkcgN0YiODKPBzLMOWfBR\n E0=; b=HPS1T1seTv+wGv4FV4x76GMEf6ZOZa39WGyRCQohPR85v69mKliM3mrqN\n APZlpMHUExYOe1keMbOrO3yVzmYUwQQ4FYTVm1IiCxQ7n9QABg/SL5TDkIeAnTfm\n GxPfCNkztbjXr6aT2Ec4/rS+384mZhXpd+MfRd3P7TD3mWsXXrpQ7f5E3lNkscqY\n 3Ag/q+QwVx8D9Vn8JPh+Vt6N3IRMahNx8SGhqoNQjhOdLGg7ZjGT7UbDmvkgRBOG\n 70iipZ+4EG2MbPSARsW/CVrxJ1POsGx7YkVuty6PxiWRTEyf6HHEbN3Ha8HY0iJI\n U8EfYlnohtIBj/415bBdAC6a2lR9Q==" ], "X-ME-Sender": "<xms:u9wIX11EuJwveOw3abE7GVZq5d2LRBGKEPlSdrzZSOd_cU2GQ0L8TQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrvddugdduieehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu\n ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:u9wIX8HFkjtDIuKFKBGeRNDKR9Bjs1thGnIsINqjuVl7gBGYRHwZWQ>\n <xmx:u9wIX17xdd5TjPD6yt96aRvJ1_J25-GGdbhYDNW1dTEZlZ_Y3GdAEg>\n <xmx:u9wIXy2lnfquIhWtmQC-2VKdkvZjqURkCR8YEpk0Qpt_D2JkI6Lrkw>\n <xmx:u9wIX9SC8ELtXiXk2aCw3RuiXJeYBbMjlE8FaYDyc2qgyxS-A-l6aw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Cc": "dev@dpdk.org, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Tal Shnaiderman <talshn@mellanox.com>,\n Ranjit Menon <ranjit.menon@intel.com>", "Date": "Fri, 10 Jul 2020 23:25:13 +0200", "Message-ID": "<11310226.gcHsNcSAOl@thomas>", "In-Reply-To": "<8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com>", "References": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>\n <20200708214843.3080-1-dmitry.kozliuk@gmail.com>\n <8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient\n\tprivileges for hugepages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]