Patch Comment List
List patch comments
GET /api/patches/73551/comments/?format=api&order=id
[ { "id": 116410, "web_url": "https://patches.dpdk.org/comment/116410/", "msgid": "<20200721140411.GE735@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721140411.GE735@bricha3-MOBL.ger.corp.intel.com", "date": "2020-07-21T14:04:11", "subject": "Re: [dpdk-dev] [PATCH v4 2/4] build: use Python pmdinfogen", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Thu, Jul 09, 2020 at 12:23:33AM +0300, Dmitry Kozlyuk wrote:\n> Like for other build scripts, use Python interpreter to run pmdinfogen.\n> Adjust wrapper script accordingly and also don't suppress stderr from ar\n> and pmdinfogen.\n> \n> Add python3-pyelftools to CI configuration.\n> \n> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n> ---\n> .travis.yml | 2 +-\n> GNUmakefile | 2 +-\n> buildtools/Makefile | 9 ---------\n> buildtools/gen-pmdinfo-cfile.sh | 6 +++---\n> buildtools/meson.build | 1 +\n> drivers/meson.build | 2 +-\n> meson.build | 1 -\n> mk/internal/rte.compile-pre.mk | 2 +-\n> mk/rte.sdkinstall.mk | 2 --\n> 9 files changed, 8 insertions(+), 19 deletions(-)\n> delete mode 100644 buildtools/Makefile\n> \n> diff --git a/.travis.yml b/.travis.yml\n> index 14f812423..28b559a25 100644\n> --- a/.travis.yml\n> +++ b/.travis.yml\n> @@ -14,7 +14,7 @@ addons:\n> apt:\n> update: true\n> packages: &required_packages\n> - - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-build]\n> + - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, python3-pyelftools, ninja-build]\n> - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson-dev]\n> \n> _aarch64_packages: &aarch64_packages\n> diff --git a/GNUmakefile b/GNUmakefile\n> index e8de422df..242d30d2e 100644\n> --- a/GNUmakefile\n> +++ b/GNUmakefile\n> @@ -12,6 +12,6 @@ export RTE_SDK\n> # directory list\n> #\n> \n> -ROOTDIRS-y := buildtools lib kernel drivers app\n> +ROOTDIRS-y := lib kernel drivers app\n> \n> include $(RTE_SDK)/mk/rte.sdkroot.mk\n> diff --git a/buildtools/Makefile b/buildtools/Makefile\n> deleted file mode 100644\n> index 7f76fd7d6..000000000\n> --- a/buildtools/Makefile\n> +++ /dev/null\n> @@ -1,9 +0,0 @@\n> -# SPDX-License-Identifier: BSD-3-Clause\n> -# Copyright(c) 2016 Neil Horman <nhorman@tuxdriver.com>\n> -# All rights reserved.\n> -\n> -include $(RTE_SDK)/mk/rte.vars.mk\n> -\n> -DIRS-y += pmdinfogen\n> -\n> -include $(RTE_SDK)/mk/rte.subdir.mk\n> diff --git a/buildtools/gen-pmdinfo-cfile.sh b/buildtools/gen-pmdinfo-cfile.sh\n> index 43059cf36..109ee461e 100755\n> --- a/buildtools/gen-pmdinfo-cfile.sh\n> +++ b/buildtools/gen-pmdinfo-cfile.sh\n> @@ -4,11 +4,11 @@\n> \n> arfile=$1\n> output=$2\n> -pmdinfogen=$3\n> +shift 2\n> +pmdinfogen=$*\n> \n> # The generated file must not be empty if compiled in pedantic mode\n> echo 'static __attribute__((unused)) const char *generator = \"'$0'\";' > $output\n> for ofile in `ar t $arfile` ; do\n> -\tar p $arfile $ofile | $pmdinfogen - - >> $output 2> /dev/null\n> +\tar p $arfile $ofile | $pmdinfogen - - >> $output\n> done\n> -exit 0\n\nFor 20.11, since make build system is being removed, I think we should look\nto merge this into the python script rather than having an extra layer of\nwrapper and having meson pass the command from one script to another.\nHowever, since out-of-the-box python doesn't seem to have support for\nreading .a files, this is fine for now.\n\n\n> diff --git a/buildtools/meson.build b/buildtools/meson.build\n> index 04808dabc..3a64b28b7 100644\n> --- a/buildtools/meson.build\n> +++ b/buildtools/meson.build\n> @@ -17,3 +17,4 @@ else\n> endif\n> map_to_win_cmd = py3 + files('map_to_win.py')\n> sphinx_wrapper = py3 + files('call-sphinx-build.py')\n> +pmdinfogen = py3 + files('pmdinfogen.py')\n> diff --git a/drivers/meson.build b/drivers/meson.build\n> index 161cfda04..3c4d4b700 100644\n> --- a/drivers/meson.build\n> +++ b/drivers/meson.build\n> @@ -119,7 +119,7 @@ foreach class:dpdk_driver_classes\n> \t\t\t\t\t\tcommand: [pmdinfo, tmp_lib.full_path(),\n> \t\t\t\t\t\t\t'@OUTPUT@', pmdinfogen],\n> \t\t\t\t\t\toutput: out_filename,\n> -\t\t\t\t\t\tdepends: [pmdinfogen, tmp_lib])\n> +\t\t\t\t\t\tdepends: [tmp_lib])\n> \t\t\tendif\n> \n> \t\t\t# now build the static driver\n> diff --git a/meson.build b/meson.build\n> index 61d9a4f5f..a6e8c09c2 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -45,7 +45,6 @@ subdir('buildtools')\n> subdir('config')\n> \n> # build libs and drivers\n> -subdir('buildtools/pmdinfogen')\n> subdir('lib')\n> subdir('drivers')\n> \n> diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk\n> index df05b5576..bb2ab0725 100644\n> --- a/mk/internal/rte.compile-pre.mk\n> +++ b/mk/internal/rte.compile-pre.mk\n> @@ -59,7 +59,7 @@ endif\n> CHECK_SYMBOLS_SCRIPT = $(RTE_SDK)/buildtools/check-symbols.sh\n> CHECK_SYMBOLS = $(CHECK_SYMBOLS_SCRIPT) $(SRCDIR)/$(EXPORT_MAP) $@\n> \n> -PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c\n> +PMDINFO_GEN = $(RTE_SDK)/buildtools/pmdinfogen.py $@ $@.pmd.c\n> PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -c -o $@.pmd.o $@.pmd.c\n> PMDINFO_LD = $(CROSS)ld -r $(filter-out -export-dynamic,$(LDFLAGS)) -o $@.o $@.pmd.o $@\n> PMDINFO_TO_O = if grep -q 'RTE_PMD_REGISTER_.*(.*)' $<; then \\\n> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\n> index 32bed5d95..875a64f04 100644\n> --- a/mk/rte.sdkinstall.mk\n> +++ b/mk/rte.sdkinstall.mk\n> @@ -98,7 +98,6 @@ install-runtime:\n> \t$(Q)cp $(CP_FLAGS) $O/lib/* $(DESTDIR)$(libdir)\n> \t$(Q)$(call rte_mkdir, $(DESTDIR)$(bindir))\n> \t$(Q)tar -cf - -C $O --exclude 'app/*.map' \\\n> -\t\t--exclude app/dpdk-pmdinfogen \\\n> \t\t--exclude 'app/cmdline*' --exclude app/test \\\n> \t\t--exclude app/testacl --exclude app/testpipeline app | \\\n> \t tar -xf - -C $(DESTDIR)$(bindir) $(TAR_X_FLAGS)\n> @@ -134,7 +133,6 @@ install-sdk:\n> \t$(Q)cp $(CP_FLAGS) $(RTE_SDK)/buildtools $(DESTDIR)$(sdkdir)\n> \t$(Q)$(call rte_mkdir, $(DESTDIR)$(targetdir)/app)\n> \t$(Q)cp $(CP_FLAGS) $O/.config $(DESTDIR)$(targetdir)\n> -\t$(Q)cp $(CP_FLAGS) $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app\n> \t$(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include)\n> \t$(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib)\n> \n> -- \n> 2.25.4\n> \n\nFor the meson build changes here:\n\nReviewed-by: Bruce Richardson <bruce.richardson@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 767B6A0526;\n\tTue, 21 Jul 2020 16:04:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 22E571BFEB;\n\tTue, 21 Jul 2020 16:04:21 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id CDA451BFE9\n for <dev@dpdk.org>; Tue, 21 Jul 2020 16:04:18 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 07:04:17 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.252.9.114])\n by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;\n 21 Jul 2020 07:04:15 -0700" ], "IronPort-SDR": [ "\n GDAFKey6GDeUxvI5DX1D1q10SpmlxCpQwitRL6qhORB/zodu7RL9nn+6r3qSD6HgdJs+gF9zC4\n EQwIcoM41xDA==", "\n YcTW7inayeDdn+FK/3ENZa5+B6wgwiS51xU/vKy/ZPxr5sOZ7UrdKZR8ISBCGkzfTeb9jEXx6J\n xFF/Uh4gEtrQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"138221225\"", "E=Sophos;i=\"5.75,379,1589266800\"; d=\"scan'208\";a=\"138221225\"", "E=Sophos;i=\"5.75,379,1589266800\"; d=\"scan'208\";a=\"432007167\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "Date": "Tue, 21 Jul 2020 15:04:11 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Cc": "dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>,\n Thomas Monjalon <thomas@monjalon.net>, robin.jarry@6wind.com,\n Jie Zhou <jizh@microsoft.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Aaron Conole <aconole@redhat.com>,\n Michael Santana <maicolgabriel@hotmail.com>", "Message-ID": "<20200721140411.GE735@bricha3-MOBL.ger.corp.intel.com>", "References": "<20200708005355.7102-1-dmitry.kozliuk@gmail.com>\n <20200708212335.25338-1-dmitry.kozliuk@gmail.com>\n <20200708212335.25338-3-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20200708212335.25338-3-dmitry.kozliuk@gmail.com>", "Subject": "Re: [dpdk-dev] [PATCH v4 2/4] build: use Python pmdinfogen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116419, "web_url": "https://patches.dpdk.org/comment/116419/", "msgid": "<20200721175907.609ef040@sovereign>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721175907.609ef040@sovereign", "date": "2020-07-21T14:59:07", "subject": "Re: [dpdk-dev] [PATCH v4 2/4] build: use Python pmdinfogen", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "content": "On Tue, 21 Jul 2020 15:04:11 +0100, Bruce Richardson wrote:\n> On Thu, Jul 09, 2020 at 12:23:33AM +0300, Dmitry Kozlyuk wrote:\n[snip]\n> > diff --git a/buildtools/gen-pmdinfo-cfile.sh b/buildtools/gen-pmdinfo-cfile.sh\n> > index 43059cf36..109ee461e 100755\n> > --- a/buildtools/gen-pmdinfo-cfile.sh\n> > +++ b/buildtools/gen-pmdinfo-cfile.sh\n> > @@ -4,11 +4,11 @@\n> > \n> > arfile=$1\n> > output=$2\n> > -pmdinfogen=$3\n> > +shift 2\n> > +pmdinfogen=$*\n> > \n> > # The generated file must not be empty if compiled in pedantic mode\n> > echo 'static __attribute__((unused)) const char *generator = \"'$0'\";' > $output\n> > for ofile in `ar t $arfile` ; do\n> > -\tar p $arfile $ofile | $pmdinfogen - - >> $output 2> /dev/null\n> > +\tar p $arfile $ofile | $pmdinfogen - - >> $output\n> > done\n> > -exit 0 \n> \n> For 20.11, since make build system is being removed, I think we should look\n> to merge this into the python script rather than having an extra layer of\n> wrapper and having meson pass the command from one script to another.\n> However, since out-of-the-box python doesn't seem to have support for\n> reading .a files, this is fine for now.\n\nOr Meson can only tell the Python script whether to process ELF of COFF and\nthe path to an archiver tool (ar or lib.exe). This way we'd get rid of shell\n(which is non-portable to Windows) and need no libraries to read .a or .lib.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF4B6A0526;\n\tTue, 21 Jul 2020 16:59:17 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFEFA1C000;\n\tTue, 21 Jul 2020 16:59:17 +0200 (CEST)", "from mail-lf1-f66.google.com (mail-lf1-f66.google.com\n [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id BE50B1BFE7\n for <dev@dpdk.org>; Tue, 21 Jul 2020 16:59:15 +0200 (CEST)", "by mail-lf1-f66.google.com with SMTP id o4so11859117lfi.7\n for <dev@dpdk.org>; Tue, 21 Jul 2020 07:59:15 -0700 (PDT)", "from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id h15sm4577911ljj.105.2020.07.21.07.59.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Jul 2020 07:59:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=date:from:to:cc:subject:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=jTnkZyF9N+vVdkd9pfIA+atbDc1100FUfEK+YCdF3K8=;\n b=Qq5PwgF6LrpGreU1fTDRQqHiHbnn8+hazQjDCCImVVqyZ3mvURLxhGbCaXFy8d2nvT\n IQpJizO9a4kLXs+hEGGb71NewwZMKktdoBDG1Ga0akUr5Q4jnmq0xehfdM8DksBMIZ79\n mPeZFB7yaUxg9j0bfkFeMUYEtBakqW7lPLIeQzECGN2HSdlbmFLo/vj4uVKdx+JNQ11x\n JUfK3GK/en0rri0Ltz4lA+eGcYQrccZj5CqiYWdb0l24Aw99b+DOsPJQO2PAbsD3L1Q5\n fyAnwjsoq7PRdvzjVO9l0ByTjWccxDvInVrwEcXFLRbXRI+D/Iw/aKFO+2xUcKIvdgN+\n PZIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=jTnkZyF9N+vVdkd9pfIA+atbDc1100FUfEK+YCdF3K8=;\n b=r6acqX1NACzB0ZNCik1j8E879XU6m8ziWcZliqmuaNF0DH21OV/QKFKKX2SQEkP36f\n IbTAg9qVF3JrVGFC6sEP5ZeciweI8o0bisX8pITLisUFhIM0H6rt4gapixhOkjTHu4CF\n mLHljzOWva3t844wwGs6HxA8zOyCf/5Qszh8tkCyJ1AIJdBpwEy9W/iw1/9GS9sdkK6X\n y7qbiADMU4GZdBwVPyUgq4OjO35HP3PMupRen+G31q+CAK9AdW+lIgBVvu4LkgiTgqmz\n rX6ZZ1oeAHZ5MO5fRwXtCC5BMn+l5r1TbLP8Gxqt+jv467XEvGp/9AuRJRgCxI7YpLPM\n 3LhQ==", "X-Gm-Message-State": "AOAM531lZgPJkk9Z6GoGiu9VNIBBhrtS1GAqmH/HcHVft3ONXgQG4dg4\n +ziQgWiqSd6ylV4dvhTK/Kc=", "X-Google-Smtp-Source": "\n ABdhPJwQk8EUpZvjAZUwPE+pLR38DpKuUFFzxM+NAojcUU9DnLER0V21hPFmmXxQPVSNrP8xXSx2Iw==", "X-Received": "by 2002:a05:6512:3150:: with SMTP id\n s16mr13735424lfi.47.1595343555250;\n Tue, 21 Jul 2020 07:59:15 -0700 (PDT)", "Date": "Tue, 21 Jul 2020 17:59:07 +0300", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>, Thomas Monjalon\n <thomas@monjalon.net>, robin.jarry@6wind.com, Jie Zhou\n <jizh@microsoft.com>, Tal Shnaiderman <talshn@mellanox.com>, Aaron Conole\n <aconole@redhat.com>, Michael Santana <maicolgabriel@hotmail.com>", "Message-ID": "<20200721175907.609ef040@sovereign>", "In-Reply-To": "<20200721140411.GE735@bricha3-MOBL.ger.corp.intel.com>", "References": "<20200708005355.7102-1-dmitry.kozliuk@gmail.com>\n <20200708212335.25338-1-dmitry.kozliuk@gmail.com>\n <20200708212335.25338-3-dmitry.kozliuk@gmail.com>\n <20200721140411.GE735@bricha3-MOBL.ger.corp.intel.com>", "X-Mailer": "Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-suse-linux-gnu)", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v4 2/4] build: use Python pmdinfogen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]