Patch Comment List
List patch comments
GET /api/patches/73529/comments/?format=api
[ { "id": 115543, "web_url": "https://patches.dpdk.org/comment/115543/", "msgid": "<BYAPR11MB3143C1108734B55D30E26B37D7670@BYAPR11MB3143.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB3143C1108734B55D30E26B37D7670@BYAPR11MB3143.namprd11.prod.outlook.com", "date": "2020-07-08T14:52:11", "subject": "Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "content": "> -----Original Message-----\n> From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n> Sent: Wednesday, July 8, 2020 2:38 PM\n> To: Van Haaren, Harry <harry.van.haaren@intel.com>; Jerin Jacob\n> <jerin.jacob@caviumnetworks.com>\n> Cc: dev@dpdk.org; l.wojciechow@partner.samsung.com; stable@dpdk.org\n> Subject: [PATCH v2] eal: fix lcore state bug\n> \n> The rte_service_lcore_reset_all function stops execution of services\n> on all lcores and switches them back from ROLE_SERVICE to ROLE_RTE.\n> However the thread loop for slave lcores (eal_thread_loop) distincts these\n> roles to set lcore state after processing delegated function.\n> It sets WAIT state for ROLE_SERVICE, but FINISHED for ROLE_RTE.\n> So changing the role to RTE before stopping work in slave lcores\n> causes lcores to end in FINISHED state. That is why the rte_eal_lcore_wait\n> must be run after rte_service_lcore_reset_all to bring back lcores to\n> launchable (WAIT) state.\n> This has been fixed in test app and clarified in API documentation.\n> \n> Setting the state to WAIT in rte_service_runner_func is premature\n> as the rte_service_runner_func function is still a part of the lcore\n> function delegated to slave lcore. The state is overwritten anyway in\n> slave lcore thread loop. This premature setting state to WAIT might\n> however cause rte_eal_lcore_wait, that was called by the application,\n> to return before slave lcore thread set the FINISHED state. That's\n> why it is removed from librte_eal rte_service_runner_func function.\n> \n> Bugzilla ID: 464\n> Fixes: 21698354c832 (\"service: introduce service cores concept\")\n> Fixes: f038a81e1c56 (\"service: add unit tests\")\n> Cc: harry.van.haaren@intel.com\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n\nThanks for v2, applies cleanly. Tested patch with unit tests, bug description,\nservice_cores sample app, and testpmd running (idle) service cores in bg, all fine;\n\nAcked-by: Harry van Haaren <harry.van.haaren@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 04606A0527;\n\tWed, 8 Jul 2020 16:52:24 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CD2D61DBC2;\n\tWed, 8 Jul 2020 16:52:23 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 5F6511DB54;\n Wed, 8 Jul 2020 16:52:22 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Jul 2020 07:52:14 -0700", "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n by fmsmga004.fm.intel.com with ESMTP; 08 Jul 2020 07:52:14 -0700", "from fmsmsx117.amr.corp.intel.com (10.18.116.17) by\n FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Wed, 8 Jul 2020 07:52:14 -0700", "from FMSEDG001.ED.cps.intel.com (10.1.192.133) by\n fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Wed, 8 Jul 2020 07:52:13 -0700", "from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by\n edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Wed, 8 Jul 2020 07:52:13 -0700", "from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32)\n by BYAPR11MB3687.namprd11.prod.outlook.com (2603:10b6:a03:ff::26)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Wed, 8 Jul\n 2020 14:52:11 +0000", "from BYAPR11MB3143.namprd11.prod.outlook.com\n ([fe80::9c6b:5ce:b551:8678]) by BYAPR11MB3143.namprd11.prod.outlook.com\n ([fe80::9c6b:5ce:b551:8678%4]) with mapi id 15.20.3174.021; Wed, 8 Jul 2020\n 14:52:11 +0000" ], "IronPort-SDR": [ "\n m87eh0fa7fBcirCtRSULpcovrmA7Hb4URYDh6NnSAscQPKsevRBlfaA8Bw9sfnsKm6kFJ/Xryx\n Rqd2WZX3+nfw==", "\n PSUq+VRaVfpeSJWpwpapkoqvWqUrE4MUygnYujYMBt8GQtHLI2SG4eaVKQxR/IRmYZmPasL5/L\n u06y5YqT1OOw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9676\"; a=\"209342299\"", "E=Sophos;i=\"5.75,327,1589266800\"; d=\"scan'208\";a=\"209342299\"", "E=Sophos;i=\"5.75,327,1589266800\"; d=\"scan'208\";a=\"306069462\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=XPrJ1qh5Wr/FtWAP3BgpggKpBW+5vuZDW76mAyBSY66HEHpg9OQS7KtjiNV9yeyG7bQVBP2pd31NCVj9h6Y1vKS1uU/LFxffr310iApMYKpJMWNispxK4jeS6RqRQwQHb9VGilP7Xk1h8/rCVNU1KJ6SR8D4o8y9/lvVf+8FOrNzfI1e4EXXcxH8Oqd9wQC8n9lSWF1mTZugp/9YIg0MCT8qgiTfew10oKfJEO6oH48RY/sB4dZvct+09lABJbs9F8xNQWRiSp0RntCpde70NenoR+PX8aGTepm52So/AYx/2K5xLjAU8JkcpEXUOXSeoRc4lSy8mX1O3x97MZcy5A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=vQJs3zFPRq8S1mRcO/bRoDLkIWutfKPQrnSLUrxyG+8=;\n b=lkbEI8xe67yvVZp085cJ2jtCwnY9Vd5R4koIUlZPaekKwjTZebHr8EliEwj3CG9QaGRR19UKmmbZHZrqk5m+zVZ/HoMW1QRnNFqeyRqB3V0ROYJUTxloPll5nCKQ1etYyJk/sNJKbSaAqNAIbSCiS5nGPSQl3RJjCpcZKpcM6/tii8McamJflhRZ/7ubDAAtxQzqblbABHX19uQuCTDy8w/kp2icP/EttEobqP1IZNAyjzTUYjUQiGmILp0nzG62vt4RgJ1MIFA62LQgt5LZvD8u/ncGFLRaL19Jfqe49bozEIxH7ZySrnmoRhAM8BlE9RQlaki85FXGV+sQThDn8g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=vQJs3zFPRq8S1mRcO/bRoDLkIWutfKPQrnSLUrxyG+8=;\n b=SLltEjNGZ/+2GC4i91vJE2tKGNJP58h4WAYISo6qjANDy5DW4XyCMJn1xl7StA1b05WddF2N0t+pV3oHhma9dKLmCt/59KgoCrP7E209iOi7d0S97FcCGrZevYMAjPXpRWUsUaG8EWNH8O9g9qlSt9twqgaYSOVZ11NT0Fpq588=", "From": "\"Van Haaren, Harry\" <harry.van.haaren@intel.com>", "To": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>, Jerin Jacob\n <jerin.jacob@caviumnetworks.com>, David Marchand <david.marchand@redhat.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH v2] eal: fix lcore state bug", "Thread-Index": "AQHWVS0GEaRwncs8OkG9CZWNoVCrcKj9w4QA", "Date": "Wed, 8 Jul 2020 14:52:11 +0000", "Message-ID": "\n <BYAPR11MB3143C1108734B55D30E26B37D7670@BYAPR11MB3143.namprd11.prod.outlook.com>", "References": "<20200428012139.32196-1-l.wojciechow@partner.samsung.com>\n <CGME20200708133748eucas1p2dbe34d8605d8f618559daee9cbeaa73d@eucas1p2.samsung.com>\n <20200708133733.29468-1-l.wojciechow@partner.samsung.com>", "In-Reply-To": "<20200708133733.29468-1-l.wojciechow@partner.samsung.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-reaction": "no-action", "dlp-version": "11.2.0.6", "authentication-results": "partner.samsung.com; dkim=none (message not signed)\n header.d=none;partner.samsung.com; dmarc=none action=none\n header.from=intel.com;", "x-originating-ip": "[192.198.151.190]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "73a88ddf-e06d-46ca-8f19-08d8234e7f07", "x-ms-traffictypediagnostic": "BYAPR11MB3687:", "x-microsoft-antispam-prvs": "\n <BYAPR11MB3687FBAF7BA3FF2D5101BCD3D7670@BYAPR11MB3687.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:9508;", "x-forefront-prvs": "04583CED1A", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n z9zxt43e//FFuIe9hDVFYVsGwca4G5vO/u3fZtvc9khzSMsLoLr4Fui/JYTCaGiHYVZRmzHSju4HcXJ80I7WM9B1N/cWAch5pj8MpsoVxS/2AHkFdObH/YV3HfUT9Rul5yy/BK3zLbNvBMBaAh+TjaFgNx2b06e/HsKBIprXzWNnnSDkBFWDgZguCRJ4qrTkPcheYRvNUsqitnDr/cwueFDyWLMt1jY/Ertpae9nNgCd8nBMlBFUEbneB0IMFGMU4vtyWTo4P7CY4swsD6Qdconzgws7GZadBt9bRiuYi6XNNtD4Bk69yzQdP8ej17/yLlCaIUiksjBMhIlYTFeNhQ==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(396003)(366004)(136003)(346002)(39860400002)(53546011)(26005)(33656002)(8676002)(186003)(83380400001)(7696005)(2906002)(110136005)(478600001)(54906003)(86362001)(55016002)(9686003)(6506007)(71200400001)(316002)(4326008)(8936002)(52536014)(76116006)(66476007)(66556008)(64756008)(66446008)(66946007)(5660300002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n EXa792e+GbiySSSfOV3pRqQjoSp+C7pFxzAZ/qi6+C+m6RhlM5WGmYTGuv/xU0y1yxOuSBH1rwWsLiPDFV46A+fJc2jEgEvpvkRuMX9miwkFbmrmIODIcF9OBjxjxPxjMr7AvDLR6L6zhMx3WaVihtCAwHFNNRSVDk2jhNDG6GlZJgDlVJb4UcLSxw5dEfjK5h+J1vlDFNTwsuBLYm3A2dCOY1QIZiRbBZcgBKnoD6FJr6pE9fsZccpgbY8Pp+TVw02U8AYV+3qf52yQVlxtNrPZEuMvvQprovzof6qudMkidGfG0OivJ8PyDvi0p8sPUUGzhkVa6JQnrfl8QzUWfxFI2MJueZubAhlTn7cly8D7Gubt6ipJz9QtBmY3RjNHvrDitiSTelydn2x39Zk718PJoCHDG9Gv8b2bSPiOSqwn84ujoijc3v2Ay0nMf6sW7HKG2egYB5TCb5EoxnXi5AhpJkZ2DPsZQBnsS5AZ9pGqV/Rfd9U6BGAQwa/imSnq", "x-ms-exchange-transport-forked": "True", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3143.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 73a88ddf-e06d-46ca-8f19-08d8234e7f07", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Jul 2020 14:52:11.7219 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n /JGg66vuJD/OWF6Bt6gNLfj0iQ0o7cydBMhYiHlSFjL2C7oeJJBSFP6cyEIEZpKGjDDj5vV20jJX2vROIrwh9Ar67rxSYD6r/Wp6o0ep6N0=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR11MB3687", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115557, "web_url": "https://patches.dpdk.org/comment/115557/", "msgid": "<CAJFAV8xWa6WZy_GAZ2yrY6qrCWbyjGaMWYjLhXUjpDd2QnM+bQ@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8xWa6WZy_GAZ2yrY6qrCWbyjGaMWYjLhXUjpDd2QnM+bQ@mail.gmail.com", "date": "2020-07-08T17:10:14", "subject": "Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Wed, Jul 8, 2020 at 4:52 PM Van Haaren, Harry\n<harry.van.haaren@intel.com> wrote:\n> > The rte_service_lcore_reset_all function stops execution of services\n> > on all lcores and switches them back from ROLE_SERVICE to ROLE_RTE.\n> > However the thread loop for slave lcores (eal_thread_loop) distincts these\n> > roles to set lcore state after processing delegated function.\n> > It sets WAIT state for ROLE_SERVICE, but FINISHED for ROLE_RTE.\n> > So changing the role to RTE before stopping work in slave lcores\n> > causes lcores to end in FINISHED state. That is why the rte_eal_lcore_wait\n> > must be run after rte_service_lcore_reset_all to bring back lcores to\n> > launchable (WAIT) state.\n> > This has been fixed in test app and clarified in API documentation.\n> >\n> > Setting the state to WAIT in rte_service_runner_func is premature\n> > as the rte_service_runner_func function is still a part of the lcore\n> > function delegated to slave lcore. The state is overwritten anyway in\n> > slave lcore thread loop. This premature setting state to WAIT might\n> > however cause rte_eal_lcore_wait, that was called by the application,\n> > to return before slave lcore thread set the FINISHED state. That's\n> > why it is removed from librte_eal rte_service_runner_func function.\n\nThanks for the explanation and fix.\n\n> >\n> > Bugzilla ID: 464\n> > Fixes: 21698354c832 (\"service: introduce service cores concept\")\n> > Fixes: f038a81e1c56 (\"service: add unit tests\")\n> > Cc: stable@dpdk.org\n> >\n\nReported-by: Sarosh Arif <sarosh.arif@emumba.com>\n> > Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>\n\nApplied, thanks Lukasz.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E186CA0529;\n\tWed, 8 Jul 2020 19:10:31 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C21DC1DA6A;\n\tWed, 8 Jul 2020 19:10:30 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 31CA71DA2B\n for <dev@dpdk.org>; Wed, 8 Jul 2020 19:10:29 +0200 (CEST)", "from mail-ua1-f70.google.com (mail-ua1-f70.google.com\n [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-436-vPyJ3zSSM0C9-TyNdkm72Q-1; Wed, 08 Jul 2020 13:10:27 -0400", "by mail-ua1-f70.google.com with SMTP id n4so3218206uaq.17\n for <dev@dpdk.org>; Wed, 08 Jul 2020 10:10:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594228228;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=BWXJOIvfsrJ0LVmiL+5St+bLCSMjX9dLuMBqXMVGcic=;\n b=DhkMZDbXI27txNf952NDt9k4POSOJyJV8HwGq9PmjzmATHWTNxSckZ2cnk8qgM1zOitLeu\n swTwrUqIZu5nTQ2Pzv4dec8EdG8yRLlEA2qMlXi2eMzckUfwETrNsyEE4EVtmdvHgRYrWe\n K0RVS1vezHsVhXFROpWsuJ1dYgXy9zc=", "X-MC-Unique": "vPyJ3zSSM0C9-TyNdkm72Q-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=BWXJOIvfsrJ0LVmiL+5St+bLCSMjX9dLuMBqXMVGcic=;\n b=r0MgZ7DDCOxwUZWU1uiq8Lt1HMLTfmKnCzpM5mXRZYOHczZLzc6nTR2WtR4AJpJ3/z\n jQ9yb37HF+vrYotViZ5flvCkeciYVEy4mJlt9uDNKL8kg8gveOlyek8q0/yzS3oAHw+2\n W5g/WvfW/ot7EdCIkFbtXow2OdhzcVoYyTxVtSj2sCmTPGoqa9kUWvO0ADT7OLhYSLmU\n Ag8sjq7RjTUQwHH4LjwGkyT8Fsfp3lLsobNcwjx4iJypDzqssuv2fkV+X+AAJ+49klJn\n Oc0VJTueWVt1FXNxirooZPr3HTHfkMltfB0Chim7sB3aQlYnQF92rximheIZL9u/kyA0\n Ch2w==", "X-Gm-Message-State": "AOAM530lBa4QTafGRIUY35ULHnLv0+gzWnXivMwKI7QSwXaaNoMuDxdA\n Be+u5MhfSM2L9AVF8dfYyzJ8z+1HGVLf6euiCD0kF0p5JPvsgJHKcA57OQsfxSapCuTl5USKzoY\n jQ8WHCR04ngeWEk+TUoQ=", "X-Received": [ "by 2002:a67:c58c:: with SMTP id\n h12mr37563929vsk.141.1594228226537;\n Wed, 08 Jul 2020 10:10:26 -0700 (PDT)", "by 2002:a67:c58c:: with SMTP id\n h12mr37563912vsk.141.1594228226256;\n Wed, 08 Jul 2020 10:10:26 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJx+UYzYzefsHvJQhZdOHBcUPKQ939ao60tpYPF7Sr2Rk60e2FGcfe3VO4zrqaMaaPWVla7hY8oEwoRdPCFX+68=", "MIME-Version": "1.0", "References": "<20200428012139.32196-1-l.wojciechow@partner.samsung.com>\n <CGME20200708133748eucas1p2dbe34d8605d8f618559daee9cbeaa73d@eucas1p2.samsung.com>\n <20200708133733.29468-1-l.wojciechow@partner.samsung.com>\n <BYAPR11MB3143C1108734B55D30E26B37D7670@BYAPR11MB3143.namprd11.prod.outlook.com>", "In-Reply-To": "\n <BYAPR11MB3143C1108734B55D30E26B37D7670@BYAPR11MB3143.namprd11.prod.outlook.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Wed, 8 Jul 2020 19:10:14 +0200", "Message-ID": "\n <CAJFAV8xWa6WZy_GAZ2yrY6qrCWbyjGaMWYjLhXUjpDd2QnM+bQ@mail.gmail.com>", "To": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "Cc": "Jerin Jacob Kollanukkaran <jerinj@marvell.com>,\n \"dev@dpdk.org\" <dev@dpdk.org>,\n \"stable@dpdk.org\" <stable@dpdk.org>, \"Van Haaren,\n Harry\" <harry.van.haaren@intel.com>", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115561, "web_url": "https://patches.dpdk.org/comment/115561/", "msgid": "<0ea9101c-3248-22cb-85a1-1b1f08e44069@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/0ea9101c-3248-22cb-85a1-1b1f08e44069@partner.samsung.com", "date": "2020-07-08T19:37:20", "subject": "Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug", "submitter": { "id": 1628, "url": "https://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "content": "W dniu 08.07.2020 o 19:10, David Marchand pisze:\n> On Wed, Jul 8, 2020 at 4:52 PM Van Haaren, Harry\n> <harry.van.haaren@intel.com> wrote:\n>>> The rte_service_lcore_reset_all function stops execution of services\n>>> on all lcores and switches them back from ROLE_SERVICE to ROLE_RTE.\n>>> However the thread loop for slave lcores (eal_thread_loop) distincts these\n>>> roles to set lcore state after processing delegated function.\n>>> It sets WAIT state for ROLE_SERVICE, but FINISHED for ROLE_RTE.\n>>> So changing the role to RTE before stopping work in slave lcores\n>>> causes lcores to end in FINISHED state. That is why the rte_eal_lcore_wait\n>>> must be run after rte_service_lcore_reset_all to bring back lcores to\n>>> launchable (WAIT) state.\n>>> This has been fixed in test app and clarified in API documentation.\n>>>\n>>> Setting the state to WAIT in rte_service_runner_func is premature\n>>> as the rte_service_runner_func function is still a part of the lcore\n>>> function delegated to slave lcore. The state is overwritten anyway in\n>>> slave lcore thread loop. This premature setting state to WAIT might\n>>> however cause rte_eal_lcore_wait, that was called by the application,\n>>> to return before slave lcore thread set the FINISHED state. That's\n>>> why it is removed from librte_eal rte_service_runner_func function.\n> Thanks for the explanation and fix.\n>\n>>> Bugzilla ID: 464\n>>> Fixes: 21698354c832 (\"service: introduce service cores concept\")\n>>> Fixes: f038a81e1c56 (\"service: add unit tests\")\n>>> Cc: stable@dpdk.org\n>>>\n> Reported-by: Sarosh Arif <sarosh.arif@emumba.com>\n>>> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n>> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>\n> Applied, thanks Lukasz.\n>\nGreat, thank you", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C0E66A0526;\n\tWed, 8 Jul 2020 21:37:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B28681DAD8;\n\tWed, 8 Jul 2020 21:37:25 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id AF0DD1DA8E\n for <dev@dpdk.org>; Wed, 8 Jul 2020 21:37:23 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200708193722euoutp0127cc1557f57355d8b20cac04544555b6~f3iTCRFRm0988909889euoutp01y\n for <dev@dpdk.org>; Wed, 8 Jul 2020 19:37:22 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200708193722eucas1p252e9b2cdebf5ee6b2c1eb1ea521413d0~f3iSiz0HU1484514845eucas1p2H;\n Wed, 8 Jul 2020 19:37:22 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges3new.samsung.com (EUCPMTA) with SMTP id AA.15.06318.170260F5; Wed, 8\n Jul 2020 20:37:21 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200708193721eucas1p149082411b1921fdf5593e61a495f1c87~f3iSIOnxR1063210632eucas1p1E;\n Wed, 8 Jul 2020 19:37:21 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200708193721eusmtrp2c802b6bca51fba74fcdf8572e577ae43~f3iSHlXrW0717307173eusmtrp2O;\n Wed, 8 Jul 2020 19:37:21 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id AF.C0.06017.170260F5; Wed, 8\n Jul 2020 20:37:21 +0100 (BST)", "from [106.210.88.70] (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200708193721eusmtip1def486547d8059b5d74582fa005f87e8~f3iRmhZJZ0488204882eusmtip1e;\n Wed, 8 Jul 2020 19:37:20 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200708193722euoutp0127cc1557f57355d8b20cac04544555b6~f3iTCRFRm0988909889euoutp01y", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1594237042;\n bh=6Ln8LphgWmCl/SXnjS0y0PQAIGnka4s2BBgHXCFYg1s=;\n h=Subject:To:Cc:From:Date:In-Reply-To:References:From;\n b=Eib9l3rpDjEJhld7gxVkZV1dSuwpahQ5T1vCek3GNu1NmcHz71h/0f9emEZSaUs5x\n Z4w89xFM+DQ2yCkb2idLOozPA5hHwCM60kU0q2FJXh1DFI3MwJyh804CtN77wKdZbp\n KUXAWfRpeSADIKrkn025qCSLaUNLklmzK1G8eQp8=", "X-AuditID": "cbfec7f5-371ff700000018ae-5e-5f062071deba", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "Jerin Jacob Kollanukkaran <jerinj@marvell.com>, \"dev@dpdk.org\"\n <dev@dpdk.org>, \"stable@dpdk.org\" <stable@dpdk.org>, \"Van Haaren, Harry\"\n <harry.van.haaren@intel.com>", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "Message-ID": "<0ea9101c-3248-22cb-85a1-1b1f08e44069@partner.samsung.com>", "Date": "Wed, 8 Jul 2020 21:37:20 +0200", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "\n <CAJFAV8xWa6WZy_GAZ2yrY6qrCWbyjGaMWYjLhXUjpDd2QnM+bQ@mail.gmail.com>", "Content-Transfer-Encoding": "8bit", "Content-Language": "en-US", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA02Se0hTcRTH++3ebXfD2c9peNLAGAUmNA0Fh5ZYSMz+StD+SHxMvajkpu6q\n Zf+kSGE+0JQyN3M+KqcoxtKpYROW5GOZZFgWmCKaOdDQWuY7r1fJ/z7nnO95fOFQhFTP96BS\n NVm0VqNKkwnEpPnt2ujZzJOCOL+hnUBFl7FIoFha6eIp8sv+kIrSUT1SbBduCkP5yvW6Z3xl\n Y+8CT1lZ/4FQ/rSMC66S18Xnk+i01Bxa6xsSL04xmPKFGT1Hb9nsHSgPLTsVIREFOACmSw0C\n lqXYiKD+bxTHvxHYOr2LkHiXfyHoLq7iHTTcn6rkcYUmBHdfriAuWERgMo+RrMoV+8G8rppg\n 2Q3L4YHZRLIiArciaLW07YkE+AL0Vzv4RYiiJPgyLL/LYNMkPgVbq2OI5WM4FtoXuvY2S7AL\n DFXP7rWKcAR8sq8LWSawFxR06gmO3eHrrGHvOsDPhfDeNIHY+YDDoGBQyDlwBftAxz6fgJ2e\n A70ZwfjGGuKCPgSfS437qmB4s70hYAcR+Ay0v/Ll0heh/PEwyc13holFF+4GZ6gwVxFcWgKF\n 96ScWg5zJQ/RwdrNtlmyHMl0h5zpDrnRHXKj+7+3DpEtyJ3OZtTJNOOvoW/KGZWaydYkyxPT\n 1Sa0+zK27QFHN7JsJlgRppDMSfLDxI+T8lU5TK7aioAiZG6SSyO2WKkkSZV7m9amx2mz02jG\n ijwpUuYu8W9YiJHiZFUWfYOmM2jtQZVHiTzyUGVwf1lQvAEHXlt9UnenJ3RyrgWiB5u/GMM+\n yoZC7L21TycTSqUzqaIAn6ygaBMVbk3MfhQQMmNJavpWY+yeIvs94mvbKmpOR1mI+fXlhsjj\n P5oZvcuLIzHT363FnpleUY6IEZUgMrwh3NGn1A2UdDa+XkpcveJa4Gf2Ht5akZFMiuqcD6Fl\n VP8AQPnBXS4DAAA=", "\n H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t/xu7qFCmzxBnt75S22r+his3j3aTuT\n RWP/NxaL3vOzGS3+dfxhd2D1+LVgKavH4j0vmTwmL7zI7PF+31W2AJYoPZui/NKSVIWM/OIS\n W6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYz5mxrZC3byV5x+tYWxgfEj\n TxcjJ4eEgIlE5/3JTCC2kMBSRom+G7ZdjBxAcRmJD5cEIEqEJf5c62LrYuQCKnnNKHHm3RoW\n kISwgIHE81kzmUFsEQE9iYnbNrGAFDELrGGUuHlzOTtEx3smiV+Tz4JtYBOwlTgy8ysryAZe\n ATeJj2cKQMIsAioSf79fYgSxRQXiJJZvmc8OYvMKCEqcnPkEbBmnQKDEtVe/wOLMAmYS8zY/\n ZIaw5SWat86GssUlbj2ZzzSBUWgWkvZZSFpmIWmZhaRlASPLKkaR1NLi3PTcYiO94sTc4tK8\n dL3k/NxNjMC42nbs55YdjF3vgg8xCnAwKvHwvtjEGi/EmlhWXJl7iFGCg1lJhNfp7Ok4Id6U\n xMqq1KL8+KLSnNTiQ4ymQM9NZJYSTc4HxnxeSbyhqaG5haWhubG5sZmFkjhvh8DBGCGB9MSS\n 1OzU1ILUIpg+Jg5OqQZG5oBfrI1zN/KLvp2hufPK0Sen3zx8Fzpvy98kbq4DQgrLg0/c6y30\n O1loXBRgXF1cYt8hYbRy9hqbabPnHnmtPCHpp/gS073O/Uz3NHbN01tXd+yQasNciy+HGAxa\n 9k43Xf+gOKhVaVux93P7npA97QKHmIIW704//mKNpJNcdtVKpVunV5wsUmIpzkg01GIuKk4E\n AFdodbvBAgAA" ], "X-CMS-MailID": "20200708193721eucas1p149082411b1921fdf5593e61a495f1c87", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200708133748eucas1p2dbe34d8605d8f618559daee9cbeaa73d", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200708133748eucas1p2dbe34d8605d8f618559daee9cbeaa73d", "References": "<20200428012139.32196-1-l.wojciechow@partner.samsung.com>\n <CGME20200708133748eucas1p2dbe34d8605d8f618559daee9cbeaa73d@eucas1p2.samsung.com>\n <20200708133733.29468-1-l.wojciechow@partner.samsung.com>\n <BYAPR11MB3143C1108734B55D30E26B37D7670@BYAPR11MB3143.namprd11.prod.outlook.com>\n <CAJFAV8xWa6WZy_GAZ2yrY6qrCWbyjGaMWYjLhXUjpDd2QnM+bQ@mail.gmail.com>", "Subject": "Re: [dpdk-dev] [PATCH v2] eal: fix lcore state bug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]