Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73518/?format=api
{ "id": 73518, "url": "https://patches.dpdk.org/api/patches/73518/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200708090708.27182-1-ting.xu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200708090708.27182-1-ting.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200708090708.27182-1-ting.xu@intel.com", "date": "2020-07-08T09:07:08", "name": "[v1] net/ice: fix invalid symmetric RSS rule created", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4f9ac73de210f34b6d32559a75d0317f51392cf6", "submitter": { "id": 1363, "url": "https://patches.dpdk.org/api/people/1363/?format=api", "name": "Xu, Ting", "email": "ting.xu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200708090708.27182-1-ting.xu@intel.com/mbox/", "series": [ { "id": 10883, "url": "https://patches.dpdk.org/api/series/10883/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10883", "date": "2020-07-08T09:07:08", "name": "[v1] net/ice: fix invalid symmetric RSS rule created", "version": 1, "mbox": "https://patches.dpdk.org/series/10883/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73518/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6E27BA00BE;\n\tWed, 8 Jul 2020 11:07:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 348FB1DAF4;\n\tWed, 8 Jul 2020 11:07:29 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id AAF141DAE4;\n Wed, 8 Jul 2020 11:07:26 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Jul 2020 02:07:25 -0700", "from dpdk-xuting-main.sh.intel.com ([10.67.117.84])\n by orsmga001.jf.intel.com with ESMTP; 08 Jul 2020 02:07:23 -0700" ], "IronPort-SDR": [ "\n lOrGv2TB2GMLr/e/v8BOYc9kdBMndLHpH1YPZGGWoHfBhJzf7qUX/lT0mZPH3p0DQwsZZWImbe\n 4U+SzPMyFCJA==", "\n ewXTkBklMXH1OjkG3KAsnp05DgUhRBFgA51NVpm2Ysek+oSe+hnn8PEIY5oOolpNXc/aQ0CqU4\n KcTR4c5ggGyg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9675\"; a=\"135225858\"", "E=Sophos;i=\"5.75,327,1589266800\"; d=\"scan'208\";a=\"135225858\"", "E=Sophos;i=\"5.75,327,1589266800\"; d=\"scan'208\";a=\"358047154\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ting Xu <ting.xu@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com,\n\tqi.z.zhang@intel.com,\n\tstable@dpdk.org", "Date": "Wed, 8 Jul 2020 17:07:08 +0800", "Message-Id": "<20200708090708.27182-1-ting.xu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v1] net/ice: fix invalid symmetric RSS rule\n\tcreated", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flow rule with symmetric toeplitz hash function and SRC_ONLY\nor DST_ONLY RSS type together should not be created successfully.\nFix the RSS action parse function to stop the rule creation in\nthis situation.\n\nFixes: 5ad3db8d4bdd (\"net/ice: enable advanced RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ting Xu <ting.xu@intel.com>\n---\n drivers/net/ice/ice_hash.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex 3433cab28c..3c84a6a73f 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -1044,6 +1044,19 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n \t\t\t\t\tETH_RSS_L4_SRC_ONLY |\n \t\t\t\t\tETH_RSS_L4_DST_ONLY;\n \n+\t\t\t/**\n+\t\t\t * Check if SRC_ONLY or DST_ONLY is set for\n+\t\t\t * SYMMETRIC_TOEPLITZ hash function.\n+\t\t\t */\n+\t\t\tif (rss->func ==\n+\t\t\t\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {\n+\t\t\t\tif (rss_type & combine_type)\n+\t\t\t\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\tENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\taction, \"Not supported RSS types for \"\n+\t\t\t\t\t\"symmetric toeplitz hash\");\n+\t\t\t}\n+\n \t\t\t/* Check if rss types match pattern. */\n \t\t\tif (rss_type & ~combine_type & ~m->eth_rss_hint) {\n \t\t\t\treturn rte_flow_error_set(error,\n", "prefixes": [ "v1" ] }