Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73517/
{ "id": 73517, "url": "https://patches.dpdk.org/api/patches/73517/", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200708082525.28504-3-fady@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200708082525.28504-3-fady@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200708082525.28504-3-fady@mellanox.com", "date": "2020-07-08T08:25:24", "name": "[v3,2/3] net: replace htons with rte_cpu_to_be_16", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5a200f5bd865dcf460188f7e77f0f7a173351587", "submitter": { "id": 1650, "url": "https://patches.dpdk.org/api/people/1650/", "name": "Fady Bader", "email": "fady@mellanox.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200708082525.28504-3-fady@mellanox.com/mbox/", "series": [ { "id": 10882, "url": "https://patches.dpdk.org/api/series/10882/", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10882", "date": "2020-07-08T08:25:22", "name": "compile librte_net for windows", "version": 3, "mbox": "https://patches.dpdk.org/series/10882/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73517/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73517/checks/", "tags": {}, "related": [], "headers": { "Subject": "[dpdk-dev] [PATCH v3 2/3] net: replace htons with rte_cpu_to_be_16", "List-Post": "<mailto:dev@dpdk.org>", "X-Mailer": "git-send-email 2.16.1.windows.4", "X-Original-To": "patchwork@inbox.dpdk.org", "Cc": "thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com,\n yohadt@mellanox.com, dmitry.kozliuk@gmail.com,\n harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,\n pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "From": "Fady Bader <fady@mellanox.com>", "Return-Path": "<dev-bounces@dpdk.org>", "X-BeenThere": "dev@dpdk.org", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "Date": "Wed, 8 Jul 2020 11:25:24 +0300", "Precedence": "list", "In-Reply-To": "<20200708082525.28504-1-fady@mellanox.com>", "Message-Id": "<20200708082525.28504-3-fady@mellanox.com>", "X-Mailman-Version": "2.1.15", "Errors-To": "dev-bounces@dpdk.org", "References": "<20200610120040.17968-1-fady@mellanox.com>\n <20200708082525.28504-1-fady@mellanox.com>", "Delivered-To": "patchwork@inbox.dpdk.org", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46DDDA00BE;\n\tWed, 8 Jul 2020 10:25:59 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 50A0F1DC74;\n\tWed, 8 Jul 2020 10:25:46 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id EF2C11DC35\n for <dev@dpdk.org>; Wed, 8 Jul 2020 10:25:41 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n fady@mellanox.com) with SMTP; 8 Jul 2020 11:25:36 +0300", "from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx\n [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0688PamJ026821;\n Wed, 8 Jul 2020 11:25:36 +0300" ], "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "Sender": "\"dev\" <dev-bounces@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "To": "dev@dpdk.org" }, "content": "htons wasn't defined in Windows for the minGW compiler.\nhtons was replaced with rte_cpu_to_be_16 in order to compile\nunder Windows.\n\nSigned-off-by: Fady Bader <fady@mellanox.com>\n---\n lib/librte_net/rte_arp.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_net/rte_arp.c b/lib/librte_net/rte_arp.c\nindex 784b7f48fa..227a6396de 100644\n--- a/lib/librte_net/rte_arp.c\n+++ b/lib/librte_net/rte_arp.c\n@@ -2,9 +2,12 @@\n * Copyright(c) 2018 Intel Corporation\n */\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n #include <arpa/inet.h>\n+#endif\n \n #include <rte_arp.h>\n+#include <rte_byteorder.h>\n \n #define RARP_PKT_SIZE\t64\n struct rte_mbuf *\n@@ -32,15 +35,15 @@ rte_net_make_rarp_packet(struct rte_mempool *mpool,\n \t/* Ethernet header. */\n \tmemset(eth_hdr->d_addr.addr_bytes, 0xff, RTE_ETHER_ADDR_LEN);\n \trte_ether_addr_copy(mac, ð_hdr->s_addr);\n-\teth_hdr->ether_type = htons(RTE_ETHER_TYPE_RARP);\n+\teth_hdr->ether_type = rte_cpu_to_be_16(RTE_ETHER_TYPE_RARP);\n \n \t/* RARP header. */\n \trarp = (struct rte_arp_hdr *)(eth_hdr + 1);\n-\trarp->arp_hardware = htons(RTE_ARP_HRD_ETHER);\n-\trarp->arp_protocol = htons(RTE_ETHER_TYPE_IPV4);\n+\trarp->arp_hardware = rte_cpu_to_be_16(RTE_ARP_HRD_ETHER);\n+\trarp->arp_protocol = rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4);\n \trarp->arp_hlen = RTE_ETHER_ADDR_LEN;\n \trarp->arp_plen = 4;\n-\trarp->arp_opcode = htons(RTE_ARP_OP_REVREQUEST);\n+\trarp->arp_opcode = rte_cpu_to_be_16(RTE_ARP_OP_REVREQUEST);\n \n \trte_ether_addr_copy(mac, &rarp->arp_data.arp_sha);\n \trte_ether_addr_copy(mac, &rarp->arp_data.arp_tha);\n", "prefixes": [ "v3", "2/3" ] }