Patch Comment List
List patch comments
GET /api/patches/73515/comments/?format=api
[ { "id": 115871, "web_url": "https://patches.dpdk.org/comment/115871/", "msgid": "<20200713143847.GQ5869@platinum>", "list_archive_url": "https://inbox.dpdk.org/dev/20200713143847.GQ5869@platinum", "date": "2020-07-13T14:38:47", "subject": "Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in\n\tWindows", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "content": "Hi,\n\nOn Wed, Jul 08, 2020 at 11:25:23AM +0300, Fady Bader wrote:\n> s_addr in Windows is defined in windows.h so its\n\nIs it windows.h, or is it winsock.h or winsock2.h instead?\n\n> undefined in order to be defined as part of rte_ether_hdr.\n> \n> Signed-off-by: Fady Bader <fady@mellanox.com>\n> ---\n> lib/librte_net/rte_ether.h | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\n> index 0ae4e75b6c..f6e37d9e5e 100644\n> --- a/lib/librte_net/rte_ether.h\n> +++ b/lib/librte_net/rte_ether.h\n> @@ -23,6 +23,15 @@ extern \"C\" {\n> #include <rte_mbuf.h>\n> #include <rte_byteorder.h>\n> \n> +/*\n> + * s_addr in windows is defined in windows.h\n> + * it is undefined here to be defined as part of rte_ether_hdr\n> + */\n> +#ifdef RTE_EXEC_ENV_WINDOWS\n> +#undef s_addr\n> +#endif\n> +\n> +\n> #define RTE_ETHER_ADDR_LEN 6 /**< Length of Ethernet address. */\n> #define RTE_ETHER_TYPE_LEN 2 /**< Length of Ethernet type field. */\n> #define RTE_ETHER_CRC_LEN 4 /**< Length of Ethernet CRC. */\n> -- \n> 2.16.1.windows.4\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 357EEA0540;\n\tMon, 13 Jul 2020 16:38:51 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 094C11D8D7;\n\tMon, 13 Jul 2020 16:38:51 +0200 (CEST)", "from mail-wm1-f65.google.com (mail-wm1-f65.google.com\n [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 3E5DF1D734\n for <dev@dpdk.org>; Mon, 13 Jul 2020 16:38:50 +0200 (CEST)", "by mail-wm1-f65.google.com with SMTP id f18so13408158wml.3\n for <dev@dpdk.org>; Mon, 13 Jul 2020 07:38:50 -0700 (PDT)", "from 6wind.com\n (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr.\n [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0])\n by smtp.gmail.com with ESMTPSA id x1sm23396303wrp.10.2020.07.13.07.38.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Jul 2020 07:38:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=date:from:to:cc:subject:message-id:references:mime-version\n :content-disposition:in-reply-to:user-agent;\n bh=foh8SMIycjpRBDOPEkjrhcnkDbZ70mMjimIulUjuPTQ=;\n b=TbKd2eq0a+LPOoR+jiVF8ttXpol4QNOHysZikm5HB0K7u+TWquJkSWX9tcAHSOGpLe\n qtcAyynx4UuHf8WXbg2SSb4WjidDTu3YVUY1lQKOes7oUk2I72fSmVHXNZ3AzPESpkxq\n 1hPNGmi+2xFoeEsrwL0ob/e+7SqfvohsWdnSr3u93xSSqzVwDCR1zNq50xoWaUuEpFDP\n ugJZi8wnjvDftr5kxFXGQVirIVghG+NGC9wA5tHu/eIpaDW3qZOcHijiFNs17yYZM6Vp\n 1Aq826oTAaFJsZGPsYDFq1wpslg5Y1jDXDWONaY+FuY++uRjRCRG/JrVlG7zLlVW7blq\n OG+Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:in-reply-to:user-agent;\n bh=foh8SMIycjpRBDOPEkjrhcnkDbZ70mMjimIulUjuPTQ=;\n b=Kg682+kVf45CHVQhVLZkhNLqKRnpzHLldkouJnnGTK6jDTQpcBsuP5BOybGLR/rREA\n H0FtueOr3NxFmAczMxpA3qWddIQrZlbmXLqtz93n51oDDI0Ah8KgjvD/LIwHWqt9W5a/\n QFh01yxBfAwIR9EyVT0rdhjp4AEV4xZYeH00lx5TthxSYJfYgY1RgcRlKJyzmmaUwhwO\n a8ZgejTvpKzDFh4DMHvn2wkymt6yKYtKDjfHEwP0OQ+yXllBX7XWMLH+8i9jTDRVKAdN\n M3TYPizqRIiHXKGjUFItXVYtdVwG+WWsEtBY+cnAZuDCwzcj6q9pr7n7iNHR1ZpKs3EL\n LfBw==", "X-Gm-Message-State": "AOAM532f0v4mQAiqSpO8cOiEJt/1+zKZDAr0S2P5+Q8CZ0DbbEGixMAP\n TDKS6mMvl/QFHyku4O1xSGFstQ==", "X-Google-Smtp-Source": "\n ABdhPJwd8Nc2jeA15wiR2XrqpjzxRb5FyPduR2yEOQZC8Dmq0JYmqXvRXnDb3LmUfgRw2jjhN9iUnw==", "X-Received": "by 2002:a1c:5459:: with SMTP id p25mr265140wmi.148.1594651129098;\n Mon, 13 Jul 2020 07:38:49 -0700 (PDT)", "Date": "Mon, 13 Jul 2020 16:38:47 +0200", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "Fady Bader <fady@mellanox.com>", "Cc": "dev@dpdk.org, thomas@monjalon.net, tbashar@mellanox.com,\n talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com,\n harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,\n pallavi.kadam@intel.com, ranjit.menon@intel.com", "Message-ID": "<20200713143847.GQ5869@platinum>", "References": "<20200610120040.17968-1-fady@mellanox.com>\n <20200708082525.28504-1-fady@mellanox.com>\n <20200708082525.28504-2-fady@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20200708082525.28504-2-fady@mellanox.com>", "User-Agent": "Mutt/1.10.1 (2018-07-13)", "Subject": "Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in\n\tWindows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115936, "web_url": "https://patches.dpdk.org/comment/115936/", "msgid": "<VI1PR05MB58728E6AEBF8857A937EA987BF7E0@VI1PR05MB5872.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/VI1PR05MB58728E6AEBF8857A937EA987BF7E0@VI1PR05MB5872.eurprd05.prod.outlook.com", "date": "2020-07-15T06:26:22", "subject": "Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in\n\tWindows", "submitter": { "id": 1650, "url": "https://patches.dpdk.org/api/people/1650/?format=api", "name": "Fady Bader", "email": "fady@mellanox.com" }, "content": "> -----Original Message-----\n> From: Olivier Matz <olivier.matz@6wind.com>\n> Sent: Monday, July 13, 2020 5:39 PM\n> To: Fady Bader <fady@mellanox.com>\n> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Tasnim Bashar\n> <tbashar@mellanox.com>; Tal Shnaiderman <talshn@mellanox.com>; Yohad Tor\n> <yohadt@mellanox.com>; dmitry.kozliuk@gmail.com;\n> harini.ramakrishnan@microsoft.com; ocardona@microsoft.com;\n> pallavi.kadam@intel.com; ranjit.menon@intel.com\n> Subject: Re: [PATCH v3 1/3] net: fix s_addr redefinition in Windows\n> \n> Hi,\n> \n> On Wed, Jul 08, 2020 at 11:25:23AM +0300, Fady Bader wrote:\n> > s_addr in Windows is defined in windows.h so its\n> \n> Is it windows.h, or is it winsock.h or winsock2.h instead?\n\nS_addr is defined in winsock2.h which is included by windows.h.\n\n> \n> > undefined in order to be defined as part of rte_ether_hdr.\n> >\n> > Signed-off-by: Fady Bader <fady@mellanox.com>\n> > ---\n> > lib/librte_net/rte_ether.h | 9 +++++++++\n> > 1 file changed, 9 insertions(+)\n> >\n> > diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\n> > index 0ae4e75b6c..f6e37d9e5e 100644\n> > --- a/lib/librte_net/rte_ether.h\n> > +++ b/lib/librte_net/rte_ether.h\n> > @@ -23,6 +23,15 @@ extern \"C\" {\n> > #include <rte_mbuf.h>\n> > #include <rte_byteorder.h>\n> >\n> > +/*\n> > + * s_addr in windows is defined in windows.h\n> > + * it is undefined here to be defined as part of rte_ether_hdr */\n> > +#ifdef RTE_EXEC_ENV_WINDOWS #undef s_addr #endif\n> > +\n> > +\n> > #define RTE_ETHER_ADDR_LEN 6 /**< Length of Ethernet address. */\n> > #define RTE_ETHER_TYPE_LEN 2 /**< Length of Ethernet type field. */\n> > #define RTE_ETHER_CRC_LEN 4 /**< Length of Ethernet CRC. */\n> > --\n> > 2.16.1.windows.4\n> >", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A1A4CA0540;\n\tWed, 15 Jul 2020 08:26:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 88F681C0B2;\n\tWed, 15 Jul 2020 08:26:25 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63])\n by dpdk.org (Postfix) with ESMTP id B8FF91BFCD\n for <dev@dpdk.org>; Wed, 15 Jul 2020 08:26:23 +0200 (CEST)", "from VI1PR05MB5872.eurprd05.prod.outlook.com (2603:10a6:803:de::17)\n by VI1PR05MB6078.eurprd05.prod.outlook.com (2603:10a6:803:de::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Wed, 15 Jul\n 2020 06:26:22 +0000", "from VI1PR05MB5872.eurprd05.prod.outlook.com\n ([fe80::ec95:ae9e:77c8:63ae]) by VI1PR05MB5872.eurprd05.prod.outlook.com\n ([fe80::ec95:ae9e:77c8:63ae%6]) with mapi id 15.20.3174.026; Wed, 15 Jul 2020\n 06:26:22 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=OuRDfmwxS86Fln2nZWvLFQVGfvtYnrkSOukOy2GDUIvfF0bUhjTsNW4pEY0xtDl8h+/9mBfdTx+GQrKomMLYlA9m71c5s+fhn2Y1oZZa+P75B06n4+wHASByWbOBKUIM0kqAaz7Ym7MbuCF9xKmLdXS8L6Y28e+YFahfCxNEGeCqFrR2zf8LoNPL4PeRfTTJZuoU9OnRQuuyvdxEs+7uqh1miDvfA+e8gdS4Db+PCzASLXh4CVL4NLxG0d6WPEFAN3jbZ086qiFkGqTfq+hazmjfRV4UTJ5D1mh0nKKdD8wHWA8RcWxI7U5JnSVzaDkTu9iet+1ViLNpwwElZbZDYw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pXJm9lX/61MuWwZmyXSXs2P6ChtMG/yS7nwvaxozsrE=;\n b=mTz0FjL0jZuqaekbibnPs3M8NFozW5ayrcxu+K4miNB7nquxRyF0zcmqgEl1ZFQwH7Ec2hZLN7Cm5NgDN4xpllObuW2/azCVoMGlo1PZ9jbZfBVr863sbnIf/ifmfeRpH8eS8JcucIOtdOeOINq2cOtjxoR4PC+2xjrQiXozRvBgirOV+7SGmtEEb8C2LEmMVd0vb3h3YZDRLmoWH7VJ4JNd3ziHn6F/rCe4rGWjt6MdoDgEaSyW4MHtEUPZ5R0wZvwQ5k2MjsJCkll9Oz82SMX8gTGQDkfhIs9z1hF+n4Pi7n7O8zCiI7acl6sBZdnvekfoOHC5/Xvxq88SEIP4zQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pXJm9lX/61MuWwZmyXSXs2P6ChtMG/yS7nwvaxozsrE=;\n b=eCzW05IFVcKbGYXBOLFrvNcIY9/FEhj2w4hEXzchNc8oph6TV1oOoTZMbpbJip8fHwHJme5BTlw/xWMtHF2R6lQGHT+mBquxoRO4U6Tk9Lgr8Lc5loi1v8SRZHE7cOPoui2eX1fyX0jG4oe1IeLxvWpISLO//SIJA11OZGa86Ig=", "From": "Fady Bader <fady@mellanox.com>", "To": "Olivier Matz <olivier.matz@6wind.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,\n Tasnim Bashar <tbashar@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Yohad Tor <yohadt@mellanox.com>, \"dmitry.kozliuk@gmail.com\"\n <dmitry.kozliuk@gmail.com>, \"harini.ramakrishnan@microsoft.com\"\n <harini.ramakrishnan@microsoft.com>, \"ocardona@microsoft.com\"\n <ocardona@microsoft.com>, \"pallavi.kadam@intel.com\"\n <pallavi.kadam@intel.com>, \"ranjit.menon@intel.com\" <ranjit.menon@intel.com>", "Thread-Topic": "[PATCH v3 1/3] net: fix s_addr redefinition in Windows", "Thread-Index": "AQHWWSNTneB3XqrIOUuHs4mTd7yCGqkILyKw", "Date": "Wed, 15 Jul 2020 06:26:22 +0000", "Message-ID": "\n <VI1PR05MB58728E6AEBF8857A937EA987BF7E0@VI1PR05MB5872.eurprd05.prod.outlook.com>", "References": "<20200610120040.17968-1-fady@mellanox.com>\n <20200708082525.28504-1-fady@mellanox.com>\n <20200708082525.28504-2-fady@mellanox.com> <20200713143847.GQ5869@platinum>", "In-Reply-To": "<20200713143847.GQ5869@platinum>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "6wind.com; dkim=none (message not signed)\n header.d=none;6wind.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[79.177.51.194]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "1d096f98-2e23-46e4-4e1e-08d82887fe86", "x-ms-traffictypediagnostic": "VI1PR05MB6078:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <VI1PR05MB607822F647DED4E4D3A1C42CBF7E0@VI1PR05MB6078.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:281;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n yIZvN7W4p02W7n1gsaFRGCX6fbDz9L/OglL2ITjFmYCebn5ARByVR9BvRg0xvYayN24CA8sKIRCEIvuVQqlSaEwKT0LvnZjdvfDGUQktWhBPz2U5CWHkOosRkp+uu1gpQt9gaoI/ldNeNArXyDUGaqEUTyjU5Qh+VEptMeyWbTW1RCU9pyl8jBNKD6irEiLL5uNoJnNEB8dHTT0fvzEi8fIXmUy8fRSLN2Au5+rjX38cYDnvt1AFdKwVJ+ZbeEayoXVqiNzwDNo/y5Z5JwkdcW4djPlkGGvSLWg8peYBhRhfNkNy0K8TvnLRgXH3Ghc9", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:VI1PR05MB5872.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(136003)(39860400002)(376002)(366004)(396003)(346002)(54906003)(8676002)(66446008)(45080400002)(53546011)(86362001)(26005)(7696005)(8936002)(6916009)(2906002)(5660300002)(52536014)(9686003)(83380400001)(478600001)(66476007)(316002)(64756008)(66946007)(76116006)(66556008)(4326008)(186003)(6506007)(55016002)(33656002)(71200400001);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n Cl966yHeNXawdPer9cMobKlQumaXxWPpYRivCqoVOR/160rNZNy+8keb+z64kMOaaj94XE2wFjAwQh9l059Nqu43vIJLcm/4n1KJorNtpYIIU2j+4hVcWQHa8CdA4/04S6D9Ctu1rTpDO2wt2DBxOeh+CpTrHnkwoZjanWDjxk8pSjRk4nLKxnQI7qElfXoUL5BDZL7668r6KHQPq++JnfheOMGOhxua89XLXcaREcHPIIhgqbRLNc/09A/sIQlITg61/AHjUP4MlSKglgGoSSdvM4sD2FS5Odp0H9l8RjtHZymy/7dBKxFg1qWl1bogEUPmK2dUD1mSOjNqObzYjvFhHPog+Wypucc7rwyjvXS5JMXU6tjrniLW+ZZ+Hp0TIjEXa7T891FvfQrqtu64SUpQxNlVrQWcsy+l0ncwe339rTitxW5VwiXZieo5NZdS5gEwVKNPYSxsSzKsPZiN2AGs9RynrIePIda/HeDFoso=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "VI1PR05MB5872.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1d096f98-2e23-46e4-4e1e-08d82887fe86", "X-MS-Exchange-CrossTenant-originalarrivaltime": "15 Jul 2020 06:26:22.7126 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n FQ2Pb/iBHpEtg+M0vTGdwEy/ajEBjDov0ouAM0rbAp6von5p6iQOQ3P8DqxXjcNeQSSGAx104Y9bizr1U3jWLQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR05MB6078", "Subject": "Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in\n\tWindows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]