List comments

GET /api/patches/73513/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116292,
        "web_url": "https://patches.dpdk.org/comment/116292/",
        "msgid": "<039ED4275CED7440929022BC67E70611548625B6@SHSMSX103.ccr.corp.intel.com>",
        "date": "2020-07-20T10:31:06",
        "subject": "Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix\n resource\terror",
        "submitter": {
            "id": 504,
            "url": "https://patches.dpdk.org/api/people/504/",
            "name": "Zhang, Qi Z",
            "email": "qi.z.zhang@intel.com"
        },
        "content": "> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Jiang Mao\n> Sent: Thursday, July 9, 2020 3:53 AM\n> To: Ye, Xiaolong <xiaolong.ye@intel.com>\n> Cc: dev@dpdk.org; stable@dpdk.org; Jiang, MaoX <maox.jiang@intel.com>\n> Subject: [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource error\n> \n> Fdir allocating msix resource is not strictly necessary, if no resource left, print a\n> warning message.\n> \n> Fixes: 4861cde461 (i40e: new poll mode driver)\n> Cc: stable@dpdk.org\n> Signed-off-by: Jiang Mao <maox.jiang@intel.com>\n> ---\n>  drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++\n>  1 file changed, 11 insertions(+)\n> \n> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\n> index 16fcb8d..885b637 100644\n> --- a/drivers/net/i40e/i40e_ethdev.c\n> +++ b/drivers/net/i40e/i40e_ethdev.c\n> @@ -5732,6 +5732,17 @@ struct i40e_vsi *\n>  \t\t\tvsi->nb_msix = RTE_MIN(vsi->nb_qps,\n>  \t\t\t\t\t       RTE_MAX_RXTX_INTR_VEC_ID);\n>  \t\t}\n> +\t} else if (type == I40E_VSI_FDIR) {\n> +\t\tret = i40e_res_pool_alloc(&pf->msix_pool, 1);\n> +\t\tif (ret < 0) {\n> +\t\t\tPMD_DRV_LOG(WARNING, \"MSIX vectors used up, FDIR can`t\n> bind interrupt\");\n> +\t\t\tvsi->msix_intr = 0;\n> +\t\t\tvsi->nb_msix = 0;\n> +\t\t} else {\n> +\t\t\tvsi->msix_intr = ret;\n> +\t\t\tvsi->nb_msix = 1;\n> +\t\t}\n> +\n\nBetter to merge above branch into below branch and remove the \"else\" branch\n\n>  \t} else if (type != I40E_VSI_SRIOV) {\n>  \t\tret = i40e_res_pool_alloc(&pf->msix_pool, 1);\n>  \t\tif (ret < 0) {\n> --\n> 1.8.3.1",
        "headers": {
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "x-originating-ip": "[10.239.127.40]",
            "dlp-product": "dlpe-windows",
            "Content-Language": "en-US",
            "IronPort-SDR": [
                "\n fXpIG/IzSAlF/iFqqdlw4U6xsxhv0DmXL78soRnoJBhNR3z4DqORQF9LuYbjlpmnLbsd0MGdXx\n bDIlqnKiLg5w==",
                "\n juhxHEhvwbBtoBrxoeO8nNahXgRimYoy/toMJiqHWzHeUcZUnSJSO/BQZUaOAY3dxRDCXZ9/me\n 8MgPUiT8TG2Q=="
            ],
            "Thread-Topic": "[dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix\n resource\terror",
            "To": "\"Jiang, MaoX\" <maox.jiang@intel.com>, \"Ye, Xiaolong\"\n <xiaolong.ye@intel.com>",
            "Thread-Index": "AQHWPgfEz64IFRZLQ02ND9Ts0UNnjaj9wH+AgBLDnCA=",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "Message-ID": "\n <039ED4275CED7440929022BC67E70611548625B6@SHSMSX103.ccr.corp.intel.com>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "X-BeenThere": "dev@dpdk.org",
            "X-Amp-File-Uploaded": "False",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86141A0540;\n\tMon, 20 Jul 2020 12:33:52 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 302691DBB;\n\tMon, 20 Jul 2020 12:33:51 +0200 (CEST)",
                "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id F34E21AFB;\n Mon, 20 Jul 2020 12:33:48 +0200 (CEST)",
                "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 03:33:47 -0700",
                "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n by orsmga008.jf.intel.com with ESMTP; 20 Jul 2020 03:33:47 -0700",
                "from fmsmsx102.amr.corp.intel.com (10.18.124.200) by\n FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 20 Jul 2020 03:33:47 -0700",
                "from shsmsx154.ccr.corp.intel.com (10.239.6.54) by\n FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 20 Jul 2020 03:33:46 -0700",
                "from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by\n SHSMSX154.ccr.corp.intel.com ([169.254.7.32]) with mapi id 14.03.0439.000;\n Mon, 20 Jul 2020 18:31:06 +0800"
            ],
            "Date": "Mon, 20 Jul 2020 10:31:06 +0000",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "Accept-Language": "en-US",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "X-MS-TNEF-Correlator": "",
            "List-Post": "<mailto:dev@dpdk.org>",
            "dlp-version": "11.2.0.6",
            "In-Reply-To": "<20200708195239.4543-1-maox.jiang@intel.com>",
            "Precedence": "list",
            "X-ExtLoop1": "1",
            "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>",
            "X-MS-Has-Attach": "",
            "Content-Transfer-Encoding": "quoted-printable",
            "MIME-Version": "1.0",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9687\"; a=\"234737227\"",
                "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"234737227\"",
                "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"317971694\""
            ],
            "References": "<20200609022538.27665-2-maox.jiang@intel.com>\n <20200708195239.4543-1-maox.jiang@intel.com>",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "dlp-reaction": "no-action",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Subject": "Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix\n resource\terror",
            "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"stable@dpdk.org\" <stable@dpdk.org>,\n \"Jiang, MaoX\" <maox.jiang@intel.com>",
            "X-Mailman-Version": "2.1.15"
        }
    }
]