Show a patch.

GET /api/patches/73504/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 73504,
    "url": "https://patches.dpdk.org/api/patches/73504/",
    "web_url": "https://patches.dpdk.org/patch/73504/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<20200708050626.23512-1-sarosh.arif@emumba.com>",
    "date": "2020-07-08T05:06:26",
    "name": "[v2] lib/librte_timer:fix corruption with reset",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7f0b34a5e96190b32efe3ce8c3fc556cef93ebc7",
    "submitter": {
        "id": 1638,
        "url": "https://patches.dpdk.org/api/people/1638/",
        "name": "Sarosh Arif",
        "email": "sarosh.arif@emumba.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/patch/73504/mbox/",
    "series": [
        {
            "id": 10876,
            "url": "https://patches.dpdk.org/api/series/10876/",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10876",
            "date": "2020-07-08T05:06:26",
            "name": "[v2] lib/librte_timer:fix corruption with reset",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/10876/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/73504/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/73504/checks/",
    "tags": {},
    "headers": {
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "To": "rsanford@akamai.com,\n\terik.g.carrillo@intel.com,\n\tdev@dpdk.org",
        "X-Google-Smtp-Source": "\n ABdhPJy1f3EEeIEa3CYWzwdvPTH3QMPe7UISoHYZMixiH+7ik+VZTXGFXivz5VsnLD75bDN+vep6ow==",
        "Message-Id": "<20200708050626.23512-1-sarosh.arif@emumba.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "X-Gm-Message-State": "AOAM533dYi7OUefTbM3mUrgpa2+iozFr7VHnjmTk2A+1DplHu4oqC2vV\n hJ5URJI4jZmX/Y2TCwmDQiPNbA==",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=qCTl8iNKA842LjTmEJsdI9txSZowQ8+P2ueJsMOZ79s=;\n b=AOKeR9TkE5h6CzkxzewRCZg/vW531MpeJmvpYiZTKagYwbGVDQGhzDcc2Y/7WyP7Y3\n YSMdanpL0m8Wlj6Ah+eNE+eN4tj959AeYYilj5hADD8XPgeKc337gtXS4JTFW/GS55cY\n JxUpYOQ6RqzHiFeAWp2kaWZpCkjnP2wW0WqbtGAEAhBZ/b4mcarIxQooVjqfjeleuPvV\n NVa3Q6m+aQJqSOO1uRR8X/Akk1YXDVXV+RXkOdvg9PW5tj6C9frN3x6JAMxMDeCuefq3\n f2ycrwTqscVCLNvsEpz6N80jTroZM52/8s+Ae5yj1OmqQfzzRmr23SOxvE9Y1vjBU5IF\n Ohjg==",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "X-BeenThere": "dev@dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C25DA00BE;\n\tWed,  8 Jul 2020 07:08:25 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 06A201DBA1;\n\tWed,  8 Jul 2020 07:08:24 +0200 (CEST)",
            "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id C86081DB13\n for <dev@dpdk.org>; Wed,  8 Jul 2020 07:08:21 +0200 (CEST)",
            "by mail-wr1-f66.google.com with SMTP id r12so47385731wrj.13\n for <dev@dpdk.org>; Tue, 07 Jul 2020 22:08:21 -0700 (PDT)",
            "from localhost.localdomain ([39.40.116.181])\n by smtp.gmail.com with ESMTPSA id c11sm3630184wmb.45.2020.07.07.22.08.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Jul 2020 22:08:20 -0700 (PDT)"
        ],
        "Subject": "[dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset",
        "In-Reply-To": "<20200707090320.2463-1-sarosh.arif@emumba.com>",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "Cc": "stable@dpdk.org, Sarosh Arif <sarosh.arif@emumba.com>,\n h.mikita89@gmail.com",
        "Precedence": "list",
        "From": "Sarosh Arif <sarosh.arif@emumba.com>",
        "X-Received": "by 2002:adf:de12:: with SMTP id\n b18mr60917748wrm.390.1594184901444;\n Tue, 07 Jul 2020 22:08:21 -0700 (PDT)",
        "References": "<20200707090320.2463-1-sarosh.arif@emumba.com>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "Errors-To": "dev-bounces@dpdk.org",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Date": "Wed,  8 Jul 2020 10:06:26 +0500",
        "X-Mailman-Version": "2.1.15",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=qCTl8iNKA842LjTmEJsdI9txSZowQ8+P2ueJsMOZ79s=;\n b=sJXBxqVy4lYsmAeupAgNQaE8RBUNPTSYRwEDKtIgyaicjMoCoB7f4GZMs1EDG3iho5\n J/EB+J8LMdUb0v6HIvNlPXsFLN143u/7BEBCZQA0nmXFAwP2L/Oxp81QqxfBfxF6+TbG\n fjCoU5274DDqCOQnCzZ/5bBgB7SenTsN55Rka/brl7o4E+x5XpTV/IJwUzCWsJu9Et/w\n T2QTo32lP9ZCwYzth95O78406BDmCLPXfm2D4FowaAvAwhV8HsmoAZZ2V8XrLRJQPde5\n JDb+Ev4tuWqoEB27mHzBSTVBefrBBvDa9W9pz7DepX7HvJ6ie7E9ZgccbMbO3Rxln+BV\n wDVw=="
    },
    "content": "If the user tries to reset/stop some other timer in it's callback\nfunction, which is also about to expire, using \nrte_timer_reset_sync/rte_timer_stop_sync the application goes into\nan infinite loop. This happens because \nrte_timer_reset_sync/rte_timer_stop_sync loop until the timer \nresets/stops and there is check inside timer_set_config_state which\nprevents a running timer from being reset/stopped by not it's own \ntimer_cb. Therefore timer_set_config_state returns -1 due to which \nrte_timer_reset returns -1 and rte_timer_reset_sync goes into an \ninfinite loop. \n\nThe soloution to this problem is to return -1 from \nrte_timer_reset_sync/rte_timer_stop_sync in case the user tries to \nreset/stop some other timer in it's callback function.\n\nBugzilla ID: 491\nFixes: 20d159f20543 (\"timer: fix corruption with reset\")\nCc: h.mikita89@gmail.com\nSigned-off-by: Sarosh Arif <sarosh.arif@emumba.com>\n---\nv2: remove line continuations\n---\n lib/librte_timer/rte_timer.c | 25 +++++++++++++++++++++++--\n lib/librte_timer/rte_timer.h |  4 ++--\n 2 files changed, 25 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c\nindex 6d19ce469..be86385a1 100644\n--- a/lib/librte_timer/rte_timer.c\n+++ b/lib/librte_timer/rte_timer.c\n@@ -576,14 +576,24 @@ rte_timer_alt_reset(uint32_t timer_data_id, struct rte_timer *tim,\n }\n \n /* loop until rte_timer_reset() succeed */\n-void\n+int\n rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks,\n \t\t     enum rte_timer_type type, unsigned tim_lcore,\n \t\t     rte_timer_cb_t fct, void *arg)\n {\n+\tstruct rte_timer_data *timer_data;\n+\tTIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL);\n+\n+\tif (tim->status.state == RTE_TIMER_RUNNING &&\n+\t(tim->status.owner != (uint16_t)tim_lcore ||\n+\ttim != timer_data->priv_timer[tim_lcore].running_tim))\n+\t\treturn -1;\n+\n \twhile (rte_timer_reset(tim, ticks, type, tim_lcore,\n \t\t\t       fct, arg) != 0)\n \t\trte_pause();\n+\n+\treturn 0;\n }\n \n static int\n@@ -642,11 +652,22 @@ rte_timer_alt_stop(uint32_t timer_data_id, struct rte_timer *tim)\n }\n \n /* loop until rte_timer_stop() succeed */\n-void\n+int\n rte_timer_stop_sync(struct rte_timer *tim)\n {\n+\tstruct rte_timer_data *timer_data;\n+\tTIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL);\n+\tunsigned int lcore_id = rte_lcore_id();\n+\n+\tif (tim->status.state == RTE_TIMER_RUNNING &&\n+\t(tim->status.owner != (uint16_t)lcore_id ||\n+\ttim != timer_data->priv_timer[lcore_id].running_tim))\n+\t\treturn -1;\n+\n \twhile (rte_timer_stop(tim) != 0)\n \t\trte_pause();\n+\n+\treturn 0;\n }\n \n /* Test the PENDING status of the timer handle tim */\ndiff --git a/lib/librte_timer/rte_timer.h b/lib/librte_timer/rte_timer.h\nindex c6b3d450d..392ca423d 100644\n--- a/lib/librte_timer/rte_timer.h\n+++ b/lib/librte_timer/rte_timer.h\n@@ -275,7 +275,7 @@ int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n  * @param arg\n  *   The user argument of the callback function.\n  */\n-void\n+int\n rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks,\n \t\t     enum rte_timer_type type, unsigned tim_lcore,\n \t\t     rte_timer_cb_t fct, void *arg);\n@@ -314,7 +314,7 @@ int rte_timer_stop(struct rte_timer *tim);\n  * @param tim\n  *   The timer handle.\n  */\n-void rte_timer_stop_sync(struct rte_timer *tim);\n+int rte_timer_stop_sync(struct rte_timer *tim);\n \n /**\n  * Test if a timer is pending.\n",
    "prefixes": [
        "v2"
    ]
}