List comments

GET /api/patches/73490/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 115447,
        "web_url": "https://patches.dpdk.org/comment/115447/",
        "msgid": "<BN6PR11MB001710DB23E6E3D630E5379AE5670@BN6PR11MB0017.namprd11.prod.outlook.com>",
        "date": "2020-07-08T03:32:23",
        "subject": "Re: [dpdk-dev] [PATCH v4 5/5] app/testpmd: support query RSS config\n in flow query",
        "submitter": {
            "id": 522,
            "url": "https://patches.dpdk.org/api/people/522/",
            "name": "Yang, Qiming",
            "email": "qiming.yang@intel.com"
        },
        "content": "Acke-by: Qiming Yang <qiming.yang@intel.com>\n\n> -----Original Message-----\n> From: Di, ChenxuX <chenxux.di@intel.com>\n> Sent: Wednesday, July 8, 2020 09:19\n> To: dev@dpdk.org\n> Cc: Yang, Qiming <qiming.yang@intel.com>; Di, ChenxuX\n> <chenxux.di@intel.com>\n> Subject: [PATCH v4 5/5] app/testpmd: support query RSS config in flow query\n> \n> This patch support RSS action in flow query.\n> It can display the RSS configuration of the specified rule.\n> \n> For example:\n> we can create an RSS rule by command \"flow create 0 ingress pattern eth /\n> ipv4 / tcp / end actions rss types ipv4-tcp l3-src-only l4-dst-only end queues\n> end func symmetric_toeplitz  / end\" and then query it \"flow query 0 0 rss\"\n> the log will be follow\n> RSS:\n>  queues: none\n>  function: symmetric_toeplitz\n>  types:\n>   ipv4-tcp\n>   l3-src-only\n>   l4-dst-only\n> \n> Signed-off-by: Chenxu Di <chenxux.di@intel.com>\n> ---\n>  app/test-pmd/config.c | 55\n> +++++++++++++++++++++++++++++++++++++++++++\n>  1 file changed, 55 insertions(+)\n> \n> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index\n> cf14b584f..53a9b97d6 100644\n> --- a/app/test-pmd/config.c\n> +++ b/app/test-pmd/config.c\n> @@ -1395,6 +1395,56 @@ port_flow_complain(struct rte_flow_error *error)\n>  \treturn -err;\n>  }\n> \n> +static void\n> +rss_config_display(struct rte_flow_action_rss *rss_conf) {\n> +\tuint8_t i;\n> +\n> +\tif (rss_conf == NULL) {\n> +\t\tprintf(\"Invalid rule\\n\");\n> +\t\treturn;\n> +\t}\n> +\n> +\tprintf(\"RSS:\\n\"\n> +\t       \" queues: \");\n> +\tif (rss_conf->queue_num == 0)\n> +\t\tprintf(\"none\\n\");\n> +\tfor (i = 0; i < rss_conf->queue_num; i++)\n> +\t\tprintf(\"%d\\n\", rss_conf->queue[i]);\n> +\n> +\tprintf(\" function: \");\n> +\tswitch (rss_conf->func) {\n> +\tcase RTE_ETH_HASH_FUNCTION_DEFAULT:\n> +\t\tprintf(\"default\\n\");\n> +\t\tbreak;\n> +\tcase RTE_ETH_HASH_FUNCTION_TOEPLITZ:\n> +\t\tprintf(\"toeplitz\\n\");\n> +\t\tbreak;\n> +\tcase RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:\n> +\t\tprintf(\"simple_xor\\n\");\n> +\t\tbreak;\n> +\tcase RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:\n> +\t\tprintf(\"symmetric_toeplitz\\n\");\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tprintf(\"Unknown function\\n\");\n> +\t\treturn;\n> +\t}\n> +\n> +\tprintf(\" types:\\n\");\n> +\tif (rss_conf->types == 0) {\n> +\t\tprintf(\"  none\\n\");\n> +\t\treturn;\n> +\t}\n> +\tfor (i = 0; rss_type_table[i].str; i++) {\n> +\t\tif ((rss_conf->types &\n> +\t\t    rss_type_table[i].rss_type) ==\n> +\t\t    rss_type_table[i].rss_type &&\n> +\t\t    rss_type_table[i].rss_type != 0)\n> +\t\t\tprintf(\"  %s\\n\", rss_type_table[i].str);\n> +\t}\n> +}\n> +\n>  /** Validate flow rule. */\n>  int\n>  port_flow_validate(portid_t port_id,\n> @@ -1581,6 +1631,7 @@ port_flow_query(portid_t port_id, uint32_t rule,\n>  \tconst char *name;\n>  \tunion {\n>  \t\tstruct rte_flow_query_count count;\n> +\t\tstruct rte_flow_action_rss rss_conf;\n>  \t} query;\n>  \tint ret;\n> \n> @@ -1602,6 +1653,7 @@ port_flow_query(portid_t port_id, uint32_t rule,\n>  \t\treturn port_flow_complain(&error);\n>  \tswitch (action->type) {\n>  \tcase RTE_FLOW_ACTION_TYPE_COUNT:\n> +\tcase RTE_FLOW_ACTION_TYPE_RSS:\n>  \t\tbreak;\n>  \tdefault:\n>  \t\tprintf(\"Cannot query action type %d (%s)\\n\", @@ -1626,6\n> +1678,9 @@ port_flow_query(portid_t port_id, uint32_t rule,\n>  \t\t       query.count.hits,\n>  \t\t       query.count.bytes);\n>  \t\tbreak;\n> +\tcase RTE_FLOW_ACTION_TYPE_RSS:\n> +\t\trss_config_display(&query.rss_conf);\n> +\t\tbreak;\n>  \tdefault:\n>  \t\tprintf(\"Cannot display result for action type %d (%s)\\n\",\n>  \t\t       action->type, name);\n> --\n> 2.17.1",
        "headers": {
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "x-ms-office365-filtering-correlation-id": "df7471c8-0374-488e-05e1-08d822ef8761",
            "x-forefront-prvs": "04583CED1A",
            "X-BeenThere": "dev@dpdk.org",
            "x-ms-exchange-antispam-messagedata": "\n Q11jgW4kYFqJlR2hryfz1vhU61ffe7JSOobVE+T/hYAx1rGLzEPIU1ZxOh26GEVHVBMd0cuMDLuau4elnB6vrZpjxuDHqYX2ZCTSTM22/1rqo3L31Svy94wN/YClmwnjY3tCUH5o2HkL1/nI8VrzIvyYOZVJ1BE6/giJ+I+5UjE2LYpXNii15ieQ2e83FCTA2ohugycAAoF5lvwcuC6QZn5GcEG+0L/N93+VXaQdCeIM/Q0thHWa3JUBE4KfOdG1p0VNTTFryHqB+680YQMVHNeJADitO64Qpnh2NHTmCbfLKp/Tb543c2gcZaJ1/FcqdAXk5jrKhF5AvtuvZwPUBGHi+ThsaYKKqjssFxZkCbYxSrtjGitK84WsIzMEmfDlys3MWetcmL4JhXjz7jp1+z54F40Ob5ma0nlzqW3pykyZX5VibR1aahP0DfweKdyCi873QpIU25XN1M0Z7Ar3dPfUy0k9TcEiBmYv+ie/EtZVBVRPBK0XO9GyaKbLG/u2",
            "IronPort-SDR": [
                "\n Y6NO5AM2LFdUnfOe4epmxkBxkQmYPS4d/GVMtNJae0v3i/riTcnj9xCcvtZnr1YOpiuxp9/s7N\n FreQmK9Lm51g==",
                "\n pv8w3792zdN9Nbv55lO+ZQY9ZEB7RFIcB4+F3MYYs6I/yLoaaX6cweKEbN7aZikMc42YH0w8CJ\n YRemiWD7mZww=="
            ],
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Jul 2020 03:32:23.4127 (UTC)",
            "Message-ID": "\n <BN6PR11MB001710DB23E6E3D630E5379AE5670@BN6PR11MB0017.namprd11.prod.outlook.com>",
            "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr",
            "x-ms-oob-tlc-oobclassifiers": "OLM:608;",
            "x-originating-ip": "[192.102.204.38]",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 90E04A00BE;\n\tWed,  8 Jul 2020 05:32:30 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 76A7C1DDF1;\n\tWed,  8 Jul 2020 05:32:30 +0200 (CEST)",
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 527241DD46\n for <dev@dpdk.org>; Wed,  8 Jul 2020 05:32:28 +0200 (CEST)",
                "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jul 2020 20:32:27 -0700",
                "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n by fmsmga001.fm.intel.com with ESMTP; 07 Jul 2020 20:32:27 -0700",
                "from FMSEDG001.ED.cps.intel.com (10.1.192.133) by\n FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 7 Jul 2020 20:32:26 -0700",
                "from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177)\n by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id\n 14.3.439.0; Tue, 7 Jul 2020 20:32:26 -0700",
                "from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34)\n by BN7PR11MB2611.namprd11.prod.outlook.com (2603:10b6:406:aa::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Wed, 8 Jul\n 2020 03:32:23 +0000",
                "from BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3153.029; Wed, 8 Jul 2020\n 03:32:23 +0000"
            ],
            "X-Amp-File-Uploaded": "False",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n QjZLmHPzCmcLUQD40aBfjVllMJVkoNvL8PbggfRCMCURFMhMA6ioG4O93Aj4EyedHR5eqpqLAIPmw0/bfiwByQ==",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(346002)(396003)(376002)(136003)(366004)(39860400002)(5660300002)(7696005)(52536014)(6506007)(53546011)(71200400001)(186003)(26005)(8936002)(86362001)(110136005)(83380400001)(8676002)(478600001)(33656002)(316002)(66446008)(64756008)(66556008)(66946007)(2906002)(76116006)(66476007)(9686003)(55016002);\n DIR:OUT; SFP:1102;",
            "In-Reply-To": "<20200708011841.22295-6-chenxux.di@intel.com>",
            "X-ExtLoop1": "1",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "X-MS-Has-Attach": "",
            "MIME-Version": "1.0",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9675\"; a=\"165805293\"",
                "E=Sophos;i=\"5.75,326,1589266800\"; d=\"scan'208\";a=\"165805293\"",
                "E=Sophos;i=\"5.75,326,1589266800\"; d=\"scan'208\";a=\"388699808\""
            ],
            "References": "<20200611060142.75465-1-chenxux.di@intel.com>\n <20200708011841.22295-1-chenxux.di@intel.com>\n <20200708011841.22295-6-chenxux.di@intel.com>",
            "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d",
            "x-ms-traffictypediagnostic": "BN7PR11MB2611:",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n df7471c8-0374-488e-05e1-08d822ef8761",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Accept-Language": "en-US",
            "To": "\"Di, ChenxuX\" <chenxux.di@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "Content-Language": "en-US",
            "x-ms-exchange-senderadcheck": "1",
            "Thread-Topic": "[PATCH v4 5/5] app/testpmd: support query RSS config in flow\n query",
            "x-microsoft-antispam-prvs": "\n <BN7PR11MB261113F02C1293B299BD8574E5670@BN7PR11MB2611.namprd11.prod.outlook.com>",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ftp1va1N7fBIC5M2/YD01MrypnoFAsmw+rd8zCdFx8g=;\n b=SMjd29PmaHTgM+yBbG2ZRVyXNANcqXWEHhECW2OiSZ6b3lL1+V3bprARMzPWa/nup3kBUuvNGMMY+JYDGPDty0sjnJyO0+kYbCa3Hctn2yGI4zx1QMK1oQNv49i+5Dkkn1XyIqFbFl7pHHTWQrzfYCvCzX9QgLMEdW48/hQE4k0=",
            "Thread-Index": "AQHWVMhbndSAJpl0z0+sc2t1QRjtMqj9BxzQ",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Mailman-Version": "2.1.15",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Vl8d9pENYIrbstFhJ5TJWENtumNLZCccyTGkTkfKVyGArvFBT95iQusH/O/urNoVJgTPguWJpobP97pBBtq6DWheiOeuH8zFYkB/SJe1zn3ShkJf1LTKjauNe/HYr7Ju8OpJ6isLnwI6K3xTLTKaf3i9xh/8oDwPTPmIR+bY32a6sHPAWWBeRI/8ayea8T/z1i3HVWrCMxlj69DhwmN0tqhYxQFvkgtTlMETSnOCC3cFm2ze3YcmMT8XS5qcS6qSLVYrj1sg6x3WPcjSKta2NNdeeW5xOefmDkHOiL1Em+vWxEHgxq7YfxgUbJ3klrQ2IqEp0N4tUGL4pOhsVErUiA==",
            "Subject": "Re: [dpdk-dev] [PATCH v4 5/5] app/testpmd: support query RSS config\n in flow query",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN7PR11MB2611",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "X-MS-TNEF-Correlator": "",
            "X-OriginatorOrg": "intel.com",
            "X-MS-Exchange-CrossTenant-AuthSource": "BN6PR11MB0017.namprd11.prod.outlook.com",
            "Date": "Wed, 8 Jul 2020 03:32:23 +0000",
            "Precedence": "list",
            "From": "\"Yang, Qiming\" <qiming.yang@intel.com>",
            "Content-Transfer-Encoding": "quoted-printable",
            "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;",
            "x-microsoft-antispam": "BCL:0;",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "x-ms-exchange-transport-forked": "True",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "x-microsoft-antispam-message-info": "\n 8FTq/TKT7VVrmkK0vSHRz9cpQr7rfHp8aeZb62dNNpI68Z5hiJCBAKj3dDeXkdhIEZA2nn9+KlVtsDr/Gf9c+6jS1YKYX/RTQMqV9YroFkTpkFcgHrv6osvFw0nbJ0lq68i17s2Y/a7Q0Svr3G6u8s5mAlKMU04LXfELr5pJlWvGKaVVLhwVdGPc25u//GbVsy6gN3/tOLGZZQ3OBVoP/4mpL/d/hn3FiRmkzwBs3whnvwcfxoYTTx6zoKjhsRfSiEdnUep47mIctoITuaUGZNSi7Gd7cKo0HwvqD4R6NLW6McERw6iaNqq/nsXr2R5A",
            "x-ms-publictraffictype": "Email",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ftp1va1N7fBIC5M2/YD01MrypnoFAsmw+rd8zCdFx8g=;\n b=mecg7fqTvEgWl6CKK+GLdLovwMBx+1wtAbCjLr4pb8oprOpa9CcU+EMHjZuDYbnsQD4VJ6NgPts53JZIyLEUFU4w0EF4iw8a1eoe4qa0I+5HrxB9CRUQUMQJdF6dgpyTjthDKhaz/1y643c2jf42OJyEbnbPPQ+xUk4HxIN9EOHdLSx9UUUqdfZiPYabFsRn90HMK33hzQhb2Mm+ARqXnUzHgZ+A5CkGX7ZQkWWa7npVARAuYI5/PPhhfWsP7SI16oGo7ZanO45JfeB8lUg9CM9WXUaJ1O/k6T8DSDhnIOsIorxt8OuC7QTrv8fHIMM4C9grkNhTLdPSCATC5BIf1Q=="
        }
    }
]