Patch Comment List
List patch comments
GET /api/patches/73488/comments/?format=api&order=-submitter
[ { "id": 115446, "web_url": "https://patches.dpdk.org/comment/115446/", "msgid": "<BN6PR11MB00170710CB1CB2B5F91B7D19E5670@BN6PR11MB0017.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BN6PR11MB00170710CB1CB2B5F91B7D19E5670@BN6PR11MB0017.namprd11.prod.outlook.com", "date": "2020-07-08T03:31:40", "subject": "Re: [dpdk-dev] [PATCH v4 3/5] app/testpmd: re-implement commands by\n using private API", "submitter": { "id": 522, "url": "https://patches.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "content": "Acked-by: Qiming Yang <qiming.yang@intel.com>\n\n> -----Original Message-----\n> From: Di, ChenxuX <chenxux.di@intel.com>\n> Sent: Wednesday, July 8, 2020 09:19\n> To: dev@dpdk.org\n> Cc: Yang, Qiming <qiming.yang@intel.com>; Di, ChenxuX\n> <chenxux.di@intel.com>\n> Subject: [PATCH v4 3/5] app/testpmd: re-implement commands by using\n> private API\n> \n> The legacy filter API will be superseded. This patch use private api to change\n> the implementation of commands global_config <port_id> gre-key-len\n> <key_len> and show port fdir <port_id>\n> \n> Signed-off-by: Chenxu Di <chenxux.di@intel.com>\n> ---\n> app/test-pmd/cmdline.c | 4 +++\n> app/test-pmd/config.c | 57 ++++++++++++++++++++++++++++++++++----\n> ----\n> 2 files changed, 50 insertions(+), 11 deletions(-)\n> \n> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index\n> 81c87c8c3..39ad93838 100644\n> --- a/app/test-pmd/cmdline.c\n> +++ b/app/test-pmd/cmdline.c\n> @@ -9291,6 +9291,10 @@ cmd_global_config_parsed(void *parsed_result,\n> \tconf.cfg.gre_key_len = res->len;\n> \tret = rte_eth_dev_filter_ctrl(res->port_id, RTE_ETH_FILTER_NONE,\n> \t\t\t\t RTE_ETH_FILTER_SET, &conf);\n> +#ifdef RTE_LIBRTE_I40E_PMD\n> +\tif (ret == -ENOTSUP)\n> +\t\tret = rte_pmd_i40e_set_gre_key_len(res->port_id, res-\n> >len); #endif\n> \tif (ret != 0)\n> \t\tprintf(\"Global config error\\n\");\n> }\n> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index\n> 75013100f..cf14b584f 100644\n> --- a/app/test-pmd/config.c\n> +++ b/app/test-pmd/config.c\n> @@ -3746,30 +3746,65 @@ print_fdir_flow_type(uint32_t flow_types_mask)\n> \tprintf(\"\\n\");\n> }\n> \n> +static int\n> +get_fdir_info(portid_t port_id, struct rte_eth_fdir_info *fdir_info,\n> +\t\t struct rte_eth_fdir_stats *fdir_stat) {\n> +\tint ret;\n> +\n> +\tret = rte_eth_dev_filter_supported(port_id, RTE_ETH_FILTER_FDIR);\n> +\tif (!ret) {\n> +\t\trte_eth_dev_filter_ctrl(port_id, RTE_ETH_FILTER_FDIR,\n> +\t\t\t RTE_ETH_FILTER_INFO, fdir_info);\n> +\t\trte_eth_dev_filter_ctrl(port_id, RTE_ETH_FILTER_FDIR,\n> +\t\t\t RTE_ETH_FILTER_STATS, fdir_stat);\n> +\t\treturn 0;\n> +\t}\n> +\n> +#ifdef RTE_LIBRTE_I40E_PMD\n> +\tif (ret == -ENOTSUP) {\n> +\t\tret = rte_pmd_i40e_get_fdir_info(port_id, fdir_info);\n> +\t\tif (!ret)\n> +\t\t\tret = rte_pmd_i40e_get_fdir_stats(port_id,\n> fdir_stat);\n> +\t}\n> +#endif\n> +#ifdef RTE_LIBRTE_IXGBE_PMD\n> +\tif (ret == -ENOTSUP) {\n> +\t\tret = rte_pmd_ixgbe_get_fdir_info(port_id, fdir_info);\n> +\t\tif (!ret)\n> +\t\t\tret = rte_pmd_ixgbe_get_fdir_stats(port_id,\n> fdir_stat);\n> +\t}\n> +#endif\n> +\tswitch (ret) {\n> +\tcase 0:\n> +\t\tbreak;\n> +\tcase -ENOTSUP:\n> +\t\tprintf(\"\\n FDIR is not supported on port %-2d\\n\",\n> +\t\t\tport_id);\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tprintf(\"programming error: (%s)\\n\", strerror(-ret));\n> +\t\tbreak;\n> +\t}\n> +\treturn ret;\n> +}\n> +\n> void\n> fdir_get_infos(portid_t port_id)\n> {\n> \tstruct rte_eth_fdir_stats fdir_stat;\n> \tstruct rte_eth_fdir_info fdir_info;\n> -\tint ret;\n> \n> \tstatic const char *fdir_stats_border =\n> \"########################\";\n> \n> \tif (port_id_is_invalid(port_id, ENABLED_WARN))\n> \t\treturn;\n> -\tret = rte_eth_dev_filter_supported(port_id, RTE_ETH_FILTER_FDIR);\n> -\tif (ret < 0) {\n> -\t\tprintf(\"\\n FDIR is not supported on port %-2d\\n\",\n> -\t\t\tport_id);\n> -\t\treturn;\n> -\t}\n> \n> \tmemset(&fdir_info, 0, sizeof(fdir_info));\n> -\trte_eth_dev_filter_ctrl(port_id, RTE_ETH_FILTER_FDIR,\n> -\t\t\t RTE_ETH_FILTER_INFO, &fdir_info);\n> \tmemset(&fdir_stat, 0, sizeof(fdir_stat));\n> -\trte_eth_dev_filter_ctrl(port_id, RTE_ETH_FILTER_FDIR,\n> -\t\t\t RTE_ETH_FILTER_STATS, &fdir_stat);\n> +\tif (get_fdir_info(port_id, &fdir_info, &fdir_stat))\n> +\t\treturn;\n> +\n> \tprintf(\"\\n %s FDIR infos for port %-2d %s\\n\",\n> \t fdir_stats_border, port_id, fdir_stats_border);\n> \tprintf(\" MODE: \");\n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 69138A00BE;\n\tWed, 8 Jul 2020 05:31:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE39E1DD62;\n\tWed, 8 Jul 2020 05:31:52 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 6EE111DD46\n for <dev@dpdk.org>; Wed, 8 Jul 2020 05:31:51 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jul 2020 20:31:49 -0700", "from fmsmsx606.amr.corp.intel.com ([10.18.126.86])\n by fmsmga008.fm.intel.com with ESMTP; 07 Jul 2020 20:31:46 -0700", "from fmsmsx606.amr.corp.intel.com (10.18.126.86) by\n fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Tue, 7 Jul 2020 20:31:46 -0700", "from FMSEDG002.ED.cps.intel.com (10.1.192.134) by\n fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Tue, 7 Jul 2020 20:31:46 -0700", "from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by\n edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Tue, 7 Jul 2020 20:31:44 -0700", "from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34)\n by BN7PR11MB2611.namprd11.prod.outlook.com (2603:10b6:406:aa::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Wed, 8 Jul\n 2020 03:31:40 +0000", "from BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3153.029; Wed, 8 Jul 2020\n 03:31:40 +0000" ], "IronPort-SDR": [ "\n yhSdOWqKOiaAot/guOC1FKJjoV5ZdO9WmYWC5FtZd96hhpJMlJngW+aJORXW/fanX394dIKYYA\n lK7mnWujj7Kw==", "\n TQtijaWfQfSTJtRPmyX19bfCPlRYcn1Pd8ZGYzXw9vbOYOszaXX5k2pKUO/UAGHEscNRa2/lr8\n Rd29OIWvsQ/g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9675\"; a=\"135968242\"", "E=Sophos;i=\"5.75,326,1589266800\"; d=\"scan'208\";a=\"135968242\"", "E=Sophos;i=\"5.75,326,1589266800\"; d=\"scan'208\";a=\"268363353\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hVHHPDSIl7XiQZk/e7Ef5bDsPDZvnTvIqDNzYwo0/hCWwIkxbUrnWtO6sDsGXjRbGH5ia024jnHMCFmy6SnMZ8vz/jKg8nRa2+bq7E8BUDHWdyrYUacnZFP/kL3DbdfXLqHRcOCNBQyOEouF4ml7rRUfnpbmLJsECo3jBc7vfv1pg/mclABdhCe0NVSjL3Y5EGcHSA7XvHAvLBO8bin96MdbW/OYoe1lXCh48xq+kj6WhcBFu6VlnVM3fo0FKF/Gat2w8KOR6ObZ5KyEFrpzjQI2zWvBDF8oa9DcnCXANknVPMz8viiMI43YBaSiha+wSxN4SbLgFz0u8xkJydCvsw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2+2li0j9KwFBAZXJ4hWEKBWtZBt9fNjC2Dd6H2fPYkM=;\n b=HaA77aj8VRApNWt1Cg9jjvn9KgT7dMUkJKRoN6WykFF6JjoU7dO1qR9T/KiZRcCedN0rD/bvL8y2RFXhpqbYmf/6vjYvJZNzx2ZV2D0fmh2QtOImXux00GzIETEEvIQ4mkT+NbyD2SHI20ACPicTX0U8ssY6z4zPfYA2N+40lD2Zee5/I0ewBsLLtQG8eWgQUX94A9AjkPxj0o9e6xSMmj4bk7SeepzHfaJaFztlAZfQR4eMOrF0/+Zc2rkIj1MHFc4hI79xgeyjSE7rXPQzUdJ7xo4mDgt+6mjTVx7+UF3X5e/P80pf37ArcyhmrmJMslzLbXZObU3hDt7ymE7hqA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2+2li0j9KwFBAZXJ4hWEKBWtZBt9fNjC2Dd6H2fPYkM=;\n b=mJLJ2rPL2/fzva5vrDK9JzqG+RWnMHuqHdS2MMfp2Ca/LIK0h2B/anq2Jvr4x9CRfWjDIyznEOl5XYQHvsHsJcNpMFLgS1PFlmjKwQfVHgzKdPDbus66ceMxB5+2FKoyPMooC7VHQw0JeqAX+d6XWZ/VD/jjBc4zjICtHBQ7cyo=", "From": "\"Yang, Qiming\" <qiming.yang@intel.com>", "To": "\"Di, ChenxuX\" <chenxux.di@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v4 3/5] app/testpmd: re-implement commands by using\n private API", "Thread-Index": "AQHWVMhZpimzSZrUdkaIFBXsKtYpQqj9Burg", "Date": "Wed, 8 Jul 2020 03:31:40 +0000", "Message-ID": "\n <BN6PR11MB00170710CB1CB2B5F91B7D19E5670@BN6PR11MB0017.namprd11.prod.outlook.com>", "References": "<20200611060142.75465-1-chenxux.di@intel.com>\n <20200708011841.22295-1-chenxux.di@intel.com>\n <20200708011841.22295-4-chenxux.di@intel.com>", "In-Reply-To": "<20200708011841.22295-4-chenxux.di@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.102.204.38]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "9f531179-e9c1-4aae-1fc5-08d822ef6ded", "x-ms-traffictypediagnostic": "BN7PR11MB2611:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BN7PR11MB261122D1B603B84BA0099544E5670@BN7PR11MB2611.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:3276;", "x-forefront-prvs": "04583CED1A", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n 7WWRHNwJ9y+yF5+V4pyVm6dn+Vt8gsEaMvqPSMEPLUIAqvSplV0T7NXl31iUp8I/5bb59p7HLGVo2xaknrsgFP974jPdNFC3HweNE/Q8+BPYDwVRzbVybNqrje2glwdBW4XQKAIvDfbckl7f42G+FlQ6jULSvWmtCWbq6/7XfbLTYeWFUzldT3ZPpg35+w3fL4EXw55K1xvoWOoMPvhCN9jCO9HIDpcTQgvjZ60f7wpzsar+mgPs6d0t2c2Ir3irGls052DnqK9KYfrdbyYCmnmqUYNT9BlLBnt3/89EMLeiGfHH3C8VPMnjxV1dhtxhJIxfSCqFxZ4ex+1+kJaPcQ==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(346002)(396003)(376002)(136003)(366004)(39860400002)(5660300002)(7696005)(52536014)(6506007)(53546011)(71200400001)(186003)(26005)(8936002)(86362001)(110136005)(83380400001)(8676002)(478600001)(33656002)(316002)(66446008)(64756008)(66556008)(66946007)(2906002)(76116006)(66476007)(9686003)(55016002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n HQms+SmMROsCSWUX3qHRHm/AcKRcXrYSo28KHdLzxo5B0687gFaP5SXnU2utmJwPw8qIzym1hViMqSqer9uatPvvUu0/rdybE3PDdvdrCdwkfIqsK+GlMFq3NvUisdS67kUUN8dR7N7aLZcB1nxxZFtBrsUSxycP+EuOxGR1Kj8qBcp6mtxwhjhE0jp6ZRta0o0mRDtMjMX7x1gF3vG5lgE9Sw3ThQZlRDlcbzQEsJd1erGmaxdp9mkm9MtmJFssF9A+zF09rF3t1u1XT+TOM8zblvBXcXfHsdIitH7Zp3W/O2+Lv4ZvbYJSNquZc51hW3gjfwIYRIS+02bXUrnEF7fsI/U/c7gY3BxVf0VRYuwFtYsJGuUcHNB78zzHRT5Kp1bt+O0WukMeCxjsVvIz4KE00/SJJQSeszabAu2LIZeE9VgZLJvzZSYOl37y+OxJ25c4eOL5+jLwhIPd0mgtgqxCbUsDDVdL7lRLPqVwFLbSOyfez+iXtKnG2Sm5qmxc", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BN6PR11MB0017.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9f531179-e9c1-4aae-1fc5-08d822ef6ded", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Jul 2020 03:31:40.7611 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n a9hFvedSwZL3Oij7nZ+nJadkkJv28WZXUrL5reWtM5SeFmtOlHffa4Kv78+YbWTb/pSzeRf0obr2bcUAKfNCkA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN7PR11MB2611", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v4 3/5] app/testpmd: re-implement commands by\n using private API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]