Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73487/?format=api
{ "id": 73487, "url": "https://patches.dpdk.org/api/patches/73487/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200708011841.22295-3-chenxux.di@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200708011841.22295-3-chenxux.di@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200708011841.22295-3-chenxux.di@intel.com", "date": "2020-07-08T01:18:38", "name": "[v4,2/5] net/ixgbe: add private APIs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c82c147dcb470cca0b260f1ec22b6c0f680e6d04", "submitter": { "id": 1409, "url": "https://patches.dpdk.org/api/people/1409/?format=api", "name": "Chenxu Di", "email": "chenxux.di@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200708011841.22295-3-chenxux.di@intel.com/mbox/", "series": [ { "id": 10869, "url": "https://patches.dpdk.org/api/series/10869/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10869", "date": "2020-07-08T01:18:36", "name": "re-implement legacy filter functions by private API", "version": 4, "mbox": "https://patches.dpdk.org/series/10869/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73487/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6041DA00BE;\n\tWed, 8 Jul 2020 03:37:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 68D161DC71;\n\tWed, 8 Jul 2020 03:37:20 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 8AA481DBB4\n for <dev@dpdk.org>; Wed, 8 Jul 2020 03:37:17 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jul 2020 18:37:17 -0700", "from intel.sh.intel.com ([10.239.255.20])\n by orsmga002.jf.intel.com with ESMTP; 07 Jul 2020 18:37:15 -0700" ], "IronPort-SDR": [ "\n ssxDBqVG4GSBL0wVTEfUNwiRRE8XvXJfpJE9ZBH5nqyWFp56sZ4KAbi2QOxwF/hc5YiNIYYieq\n 2DaJmElAoeMQ==", "\n Qr6yxXFgFDqhxTY1MbJ7bG1y76a7N+A5NhCZgOKqWYgmJYRBweKu8byI5bhPiddLx3Gsb7ScSq\n xhBE80XXAAYA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9675\"; a=\"149235873\"", "E=Sophos;i=\"5.75,326,1589266800\"; d=\"scan'208\";a=\"149235873\"", "E=Sophos;i=\"5.75,326,1589266800\"; d=\"scan'208\";a=\"297570800\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Chenxu Di <chenxux.di@intel.com>", "To": "dev@dpdk.org", "Cc": "Yang Qiming <qiming.yang@intel.com>,\n\tChenxu Di <chenxux.di@intel.com>", "Date": "Wed, 8 Jul 2020 01:18:38 +0000", "Message-Id": "<20200708011841.22295-3-chenxux.di@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200708011841.22295-1-chenxux.di@intel.com>", "References": "<20200611060142.75465-1-chenxux.di@intel.com>\n <20200708011841.22295-1-chenxux.di@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 2/5] net/ixgbe: add private APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The legacy filter API will be superseded by rte_flow.\nThere are also several small features which can not be\nimplemented in rte_flow. This patch re-implemented these\nfeatures as private API.\nTwo APIs are added:\nrte_pmd_ixgbe_get_fdir_info.\nrte_pmd_ixgbe_get_fdir_stats.\n\nSigned-off-by: Chenxu Di <chenxux.di@intel.com>\nAcked-by: Jeff Guo <jia.guo@intel.com>\n---\n doc/guides/rel_notes/release_20_08.rst | 6 ++++\n drivers/net/ixgbe/ixgbe_ethdev.h | 4 +++\n drivers/net/ixgbe/ixgbe_fdir.c | 8 ++---\n drivers/net/ixgbe/rte_pmd_ixgbe.c | 33 +++++++++++++++++++++\n drivers/net/ixgbe/rte_pmd_ixgbe.h | 33 +++++++++++++++++++++\n drivers/net/ixgbe/rte_pmd_ixgbe_version.map | 2 ++\n 6 files changed, 80 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst\nindex 93a793299..0eec5b08a 100644\n--- a/doc/guides/rel_notes/release_20_08.rst\n+++ b/doc/guides/rel_notes/release_20_08.rst\n@@ -104,6 +104,12 @@ New Features\n * Re-implemented get_fdir_info and get_fdir_stat in private API.\n * Re-implemented set_gre_key_len in private API.\n \n+* **Updated the Intel ixgbe driver.**\n+\n+ Updated the Intel ixgbe driver with new features and improvements, including:\n+\n+ * Re-implemented get_fdir_info and get_fdir_stat in private API.\n+\n * **Updated the Intel ice driver.**\n \n Updated the Intel ice driver with new features and improvements, including:\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h\nindex 3d78b2ee2..9bdef87fb 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.h\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.h\n@@ -697,6 +697,10 @@ int ixgbe_fdir_set_flexbytes_offset(struct rte_eth_dev *dev,\n int ixgbe_fdir_filter_program(struct rte_eth_dev *dev,\n \t\t\t struct ixgbe_fdir_rule *rule,\n \t\t\t bool del, bool update);\n+void ixgbe_fdir_info_get(struct rte_eth_dev *dev,\n+\t\t\t struct rte_eth_fdir_info *fdir_info);\n+void ixgbe_fdir_stats_get(struct rte_eth_dev *dev,\n+\t\t\t struct rte_eth_fdir_stats *fdir_stats);\n \n void ixgbe_configure_dcb(struct rte_eth_dev *dev);\n \ndiff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c\nindex 166dae1e0..6faaa8f06 100644\n--- a/drivers/net/ixgbe/ixgbe_fdir.c\n+++ b/drivers/net/ixgbe/ixgbe_fdir.c\n@@ -109,10 +109,6 @@ static int ixgbe_add_del_fdir_filter(struct rte_eth_dev *dev,\n \t\t\t bool del,\n \t\t\t bool update);\n static int ixgbe_fdir_flush(struct rte_eth_dev *dev);\n-static void ixgbe_fdir_info_get(struct rte_eth_dev *dev,\n-\t\t\tstruct rte_eth_fdir_info *fdir_info);\n-static void ixgbe_fdir_stats_get(struct rte_eth_dev *dev,\n-\t\t\tstruct rte_eth_fdir_stats *fdir_stats);\n \n /**\n * This function is based on ixgbe_fdir_enable_82599() in base/ixgbe_82599.c.\n@@ -1414,7 +1410,7 @@ ixgbe_fdir_flush(struct rte_eth_dev *dev)\n }\n \n #define FDIRENTRIES_NUM_SHIFT 10\n-static void\n+void\n ixgbe_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info *fdir_info)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -1473,7 +1469,7 @@ ixgbe_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info *fdir_info\n \t\t\t(uint8_t)((info->mask.flex_bytes_mask & 0xFF00) >> 8);\n }\n \n-static void\n+void\n ixgbe_fdir_stats_get(struct rte_eth_dev *dev, struct rte_eth_fdir_stats *fdir_stats)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\ndiff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c\nindex 9bff557f9..d2f708242 100644\n--- a/drivers/net/ixgbe/rte_pmd_ixgbe.c\n+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c\n@@ -1139,3 +1139,36 @@ rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,\n \t}\n \treturn 0;\n }\n+\n+int\n+rte_pmd_ixgbe_get_fdir_info(uint16_t port, struct rte_eth_fdir_info *fdir_info)\n+{\n+\tstruct rte_eth_dev *dev;\n+\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\n+\n+\tdev = &rte_eth_devices[port];\n+\tif (!is_ixgbe_supported(dev))\n+\t\treturn -ENOTSUP;\n+\n+\tixgbe_fdir_info_get(dev, fdir_info);\n+\n+\treturn 0;\n+}\n+\n+int\n+rte_pmd_ixgbe_get_fdir_stats(uint16_t port,\n+\t\t\t struct rte_eth_fdir_stats *fdir_stats)\n+{\n+\tstruct rte_eth_dev *dev;\n+\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\n+\n+\tdev = &rte_eth_devices[port];\n+\tif (!is_ixgbe_supported(dev))\n+\t\treturn -ENOTSUP;\n+\n+\tixgbe_fdir_stats_get(dev, fdir_stats);\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h\nindex f62fd761d..8b6bb99a5 100644\n--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h\n+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h\n@@ -726,4 +726,37 @@ enum {\n __rte_experimental\n int\n rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);\n+\n+/**\n+ * Get port fdir info\n+ *\n+ * @param port\n+ * The port identifier of the Ethernet device.\n+ * @param fdir_info\n+ * The fdir info of the port\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENODEV) if *port* invalid.\n+ * - (-ENOTSUP) if operation not supported.\n+ */\n+__rte_experimental\n+int\n+rte_pmd_ixgbe_get_fdir_info(uint16_t port, struct rte_eth_fdir_info *fdir_info);\n+\n+/**\n+ * Get port fdir status\n+ *\n+ * @param port\n+ * The port identifier of the Ethernet device.\n+ * @param fdir_stats\n+ * The fdir status of the port\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENODEV) if *port* invalid.\n+ * - (-ENOTSUP) if operation not supported.\n+ */\n+__rte_experimental\n+int\n+rte_pmd_ixgbe_get_fdir_stats(uint16_t port,\n+\t\t\t struct rte_eth_fdir_stats *fdir_stats);\n #endif /* _PMD_IXGBE_H_ */\ndiff --git a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map\nindex 21534dbc3..911f8083f 100644\n--- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map\n+++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map\n@@ -38,6 +38,8 @@ DPDK_20.0 {\n EXPERIMENTAL {\n \tglobal:\n \n+\trte_pmd_ixgbe_get_fdir_info;\n+\trte_pmd_ixgbe_get_fdir_stats;\n \trte_pmd_ixgbe_mdio_lock;\n \trte_pmd_ixgbe_mdio_unlock;\n \trte_pmd_ixgbe_mdio_unlocked_read;\n", "prefixes": [ "v4", "2/5" ] }