Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7347/?format=api
{ "id": 7347, "url": "https://patches.dpdk.org/api/patches/7347/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1443701571-7000-1-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1443701571-7000-1-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1443701571-7000-1-git-send-email-harry.van.haaren@intel.com", "date": "2015-10-01T12:12:51", "name": "[dpdk-dev] ixgbe: fix 82599 / 82598 register differences", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "173b72bcda85f4dc6cea957240db93de0b77d23e", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1443701571-7000-1-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7347/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7347/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 72CE88DAC;\n\tThu, 1 Oct 2015 14:12:57 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 91DB88D90\n\tfor <dev@dpdk.org>; Thu, 1 Oct 2015 14:12:55 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP; 01 Oct 2015 05:12:54 -0700", "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby FMSMGA003.fm.intel.com with ESMTP; 01 Oct 2015 05:12:53 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,617,1437462000\"; d=\"scan'208\";a=\"572049365\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 1 Oct 2015 13:12:51 +0100", "Message-Id": "<1443701571-7000-1-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH] ixgbe: fix 82599 / 82598 register differences", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Ixgbe based 82598 and 82599 have different priority recieve link-on\nregister addresses. This is solved in base/ by providing in the\nPXONRXC and PXONXCNT as seperate macros. This patch ensures the\ncorrect address is read, avoiding reading garbage values.\n\nAlso PXON2OFFCNT doesn't exist in 82598, so it is not read for\nthat MAC.\n\nThis issue has existed since the drivers were imported into DPDK,\nbut was not easily discoverable as xstats were not available.\nTested using testpmd> show port xstats all\n\nFixes: af75078fece3 (\"first public release\")\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 20 +++++++++++++-------\n 1 file changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex ec2918c..e950a91 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2039,19 +2039,25 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \t\thw_stats->mpc[i] += mp;\n \t\t/* Running comprehensive total for stats display */\n \t\t*total_missed_rx += hw_stats->mpc[i];\n-\t\tif (hw->mac.type == ixgbe_mac_82598EB)\n+\t\tif (hw->mac.type == ixgbe_mac_82598EB) {\n \t\t\thw_stats->rnbc[i] +=\n \t\t\t IXGBE_READ_REG(hw, IXGBE_RNBC(i));\n+\t\t\thw_stats->pxonrxc[i] +=\n+\t\t\t\tIXGBE_READ_REG(hw, IXGBE_PXONRXC(i));\n+\t\t\thw_stats->pxoffrxc[i] +=\n+\t\t\t\tIXGBE_READ_REG(hw, IXGBE_PXOFFRXC(i));\n+\t\t} else {\n+\t\t\thw_stats->pxonrxc[i] +=\n+\t\t\t\tIXGBE_READ_REG(hw, IXGBE_PXONRXCNT(i));\n+\t\t\thw_stats->pxoffrxc[i] +=\n+\t\t\t\tIXGBE_READ_REG(hw, IXGBE_PXOFFRXCNT(i));\n+\t\t\thw_stats->pxon2offc[i] +=\n+\t\t\t\tIXGBE_READ_REG(hw, IXGBE_PXON2OFFCNT(i));\n+\t\t}\n \t\thw_stats->pxontxc[i] +=\n \t\t IXGBE_READ_REG(hw, IXGBE_PXONTXC(i));\n-\t\thw_stats->pxonrxc[i] +=\n-\t\t IXGBE_READ_REG(hw, IXGBE_PXONRXC(i));\n \t\thw_stats->pxofftxc[i] +=\n \t\t IXGBE_READ_REG(hw, IXGBE_PXOFFTXC(i));\n-\t\thw_stats->pxoffrxc[i] +=\n-\t\t IXGBE_READ_REG(hw, IXGBE_PXOFFRXC(i));\n-\t\thw_stats->pxon2offc[i] +=\n-\t\t IXGBE_READ_REG(hw, IXGBE_PXON2OFFCNT(i));\n \t}\n \tfor (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) {\n \t\thw_stats->qprc[i] += IXGBE_READ_REG(hw, IXGBE_QPRC(i));\n", "prefixes": [ "dpdk-dev" ] }