Patch Comment List
List patch comments
GET /api/patches/73469/comments/?format=api
[ { "id": 115434, "web_url": "https://patches.dpdk.org/comment/115434/", "msgid": "<4bcaa42f-1a72-b80e-8afa-327fddd7c7a2@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4bcaa42f-1a72-b80e-8afa-327fddd7c7a2@intel.com", "date": "2020-07-07T23:45:07", "subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n\tfor hugepages", "submitter": { "id": 1235, "url": "https://patches.dpdk.org/api/people/1235/?format=api", "name": "Menon, Ranjit", "email": "ranjit.menon@intel.com" }, "content": "On 7/7/2020 1:22 PM, Dmitry Kozlyuk wrote:\n> AdjustTokenPrivileges() succeeds even if no requested privileges have\n> been granted; this behavior is documented. Check last error code in\n> addition to return value to detect such case.\n>\n> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n> ---\n> lib/librte_eal/windows/eal_hugepages.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/lib/librte_eal/windows/eal_hugepages.c b/lib/librte_eal/windows/eal_hugepages.c\n> index 5779cd325..07a5467d0 100644\n> --- a/lib/librte_eal/windows/eal_hugepages.c\n> +++ b/lib/librte_eal/windows/eal_hugepages.c\n> @@ -41,6 +41,10 @@ hugepage_claim_privilege(void)\n> \t\tgoto exit;\n> \t}\n> \n> +\t/* AdjustTokenPrivileges() may succeed with ERROR_NOT_ALL_ASSIGNED. */\n> +\tif (GetLastError() != ERROR_SUCCESS)\n> +\t\tgoto exit;\n> +\n> \tret = 0;\n> \n> exit:\n\nWouldn't this be better if we could print a message here after \nexplicitly checking for the ERROR_NOT_ALL_ASSIGNED return value?\n\nOtherwise, the caller simply gets a -1 return value for a failure with \nno message.\n\n\nranjit m.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C110BA00BE;\n\tWed, 8 Jul 2020 01:45:14 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E241B1DE47;\n\tWed, 8 Jul 2020 01:45:13 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 25C7A1DE3E\n for <dev@dpdk.org>; Wed, 8 Jul 2020 01:45:11 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jul 2020 16:45:10 -0700", "from orsmsx101.amr.corp.intel.com ([10.22.225.128])\n by fmsmga007.fm.intel.com with ESMTP; 07 Jul 2020 16:45:10 -0700", "from [10.166.30.253] (10.166.30.253) by ORSMSX101.amr.corp.intel.com\n (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0;\n Tue, 7 Jul 2020 16:45:10 -0700" ], "IronPort-SDR": [ "\n PyRFlDtF/f+woZC8h0wjSyGI4IryvedYqBiNcJG3s3zNlu2JzgTaRicxu6h3s8N2sqP4sWiaQX\n f0b7emH3paTg==", "\n wcwkCf5BYGNW8uX0itWyTao9YFzyIJvcJo2rF6z6B+ByIbLQjNSZP5cDC0BDZFlZI161JLZDDo\n GCUaU/WaOiCw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9675\"; a=\"146778262\"", "E=Sophos;i=\"5.75,325,1589266800\"; d=\"scan'208\";a=\"146778262\"", "E=Sophos;i=\"5.75,325,1589266800\"; d=\"scan'208\";a=\"266965690\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, <dev@dpdk.org>", "CC": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Pallavi Kadam\n <pallavi.kadam@intel.com>, Tal Shnaiderman <talshn@mellanox.com>", "References": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>", "From": "Ranjit Menon <ranjit.menon@intel.com>", "Message-ID": "<4bcaa42f-1a72-b80e-8afa-327fddd7c7a2@intel.com>", "Date": "Tue, 7 Jul 2020 16:45:07 -0700", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>", "Content-Type": "text/plain; charset=\"utf-8\"; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "X-Originating-IP": "[10.166.30.253]", "Subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n\tfor hugepages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115435, "web_url": "https://patches.dpdk.org/comment/115435/", "msgid": "<20200708032031.2ceaca0b@sovereign>", "list_archive_url": "https://inbox.dpdk.org/dev/20200708032031.2ceaca0b@sovereign", "date": "2020-07-08T00:20:31", "subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n for hugepages", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "content": "On Tue, 7 Jul 2020 16:45:07 -0700, Ranjit Menon wrote:\n> On 7/7/2020 1:22 PM, Dmitry Kozlyuk wrote:\n> > AdjustTokenPrivileges() succeeds even if no requested privileges have\n> > been granted; this behavior is documented. Check last error code in\n> > addition to return value to detect such case.\n> >\n> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n> > ---\n> > lib/librte_eal/windows/eal_hugepages.c | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/lib/librte_eal/windows/eal_hugepages.c b/lib/librte_eal/windows/eal_hugepages.c\n> > index 5779cd325..07a5467d0 100644\n> > --- a/lib/librte_eal/windows/eal_hugepages.c\n> > +++ b/lib/librte_eal/windows/eal_hugepages.c\n> > @@ -41,6 +41,10 @@ hugepage_claim_privilege(void)\n> > \t\tgoto exit;\n> > \t}\n> > \n> > +\t/* AdjustTokenPrivileges() may succeed with ERROR_NOT_ALL_ASSIGNED. */\n> > +\tif (GetLastError() != ERROR_SUCCESS)\n> > +\t\tgoto exit;\n> > +\n> > \tret = 0;\n> > \n> > exit: \n> \n> Wouldn't this be better if we could print a message here after \n> explicitly checking for the ERROR_NOT_ALL_ASSIGNED return value?\n> \n> Otherwise, the caller simply gets a -1 return value for a failure with \n> no message.\n\nMessage is printed at ERR level by the caller. There's no context to add here.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF50AA00BE;\n\tWed, 8 Jul 2020 02:20:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D0AF41D9C4;\n\tWed, 8 Jul 2020 02:20:35 +0200 (CEST)", "from mail-lf1-f68.google.com (mail-lf1-f68.google.com\n [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id D6E0A1D989\n for <dev@dpdk.org>; Wed, 8 Jul 2020 02:20:34 +0200 (CEST)", "by mail-lf1-f68.google.com with SMTP id k15so25829403lfc.4\n for <dev@dpdk.org>; Tue, 07 Jul 2020 17:20:34 -0700 (PDT)", "from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id p1sm496057lji.93.2020.07.07.17.20.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Jul 2020 17:20:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=date:from:to:cc:subject:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=QtwvsG0trU46lh+7SNGK+KiULjWqJXKpz6EI2b2Fo8A=;\n b=nLCXL2hEox2M0xdUIPggvLPtxRMoGvCiVZ3BQiqflmqyU8D1MBOJk3RIRoXLT9MlUC\n NpaIaBaw9mSU3p69X+Tfo1nhaE6lzxMgEhMyoXlhAz7eRDwYhyafVAPVFOohlvbG5ZSR\n YzNdj2lRkS+JUOnDCHaCPVKlmhF3ZBCfWqix5Om/DO0DuA51uoaULJd2rEvMVQOXJheG\n lmPyQRWFGBL4B7L6o56V4oV0vY8dq9CX5XXSvRgUu9ZSlMGHJSW0jg9G1/mH6XbJwxaq\n q0N5qoghaxSplsA25jh36v8JpkXZiM9gBtsGzxHzco6zbmjHyS1hE0FlM/f4z1znP32d\n ZK8g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=QtwvsG0trU46lh+7SNGK+KiULjWqJXKpz6EI2b2Fo8A=;\n b=IbMIJUI20SSRCcKDfG8Zg64vwmqpOpPcHTwGNJbLYGz8Qpv2EOycIRLf5FrlpnOErZ\n yELkgeFfDntBF81QffapFR5Q0Fy/cNIRg27sGzJyIFgs70cDZ23gRq0RW0ZZLbu36L7f\n 4MYD6dgjQ2uJFL+v4DDh1jFZPa4Evu83Eux7yHk8r/qyx0AQ/sU9XKn3anrXd70IdOK+\n dA1uKeVm+CwgsAbtmW/MNKBnMoBfTT06pqjooV2ETCgd6oyDI09CSSQTj5PMgjScy862\n r+PLS0JHInG/JpNKJWXSWKeprkDXS7imJRZiAW3+2DZkt1lTqYN5cgW1Ur1n4VSYZ0RZ\n FtmA==", "X-Gm-Message-State": "AOAM532ukagIrN14snkGJOyNuvWFg2bBjwuEcs8WA3Rr7kp0iKBObhRH\n swo9809R0MI9Txe3yRaOlXo=", "X-Google-Smtp-Source": "\n ABdhPJxhzHouxhnR1ji0n6tJ4lzWmpWeVlNMBKW5VzBMLxoJD0gS0vSPtKJB8lGli5StEqOAB5PMdA==", "X-Received": "by 2002:ac2:46f0:: with SMTP id q16mr34708677lfo.51.1594167634202;\n Tue, 07 Jul 2020 17:20:34 -0700 (PDT)", "Date": "Wed, 8 Jul 2020 03:20:31 +0300", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "Ranjit Menon <ranjit.menon@intel.com>", "Cc": "<dev@dpdk.org>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>, Tal Shnaiderman\n <talshn@mellanox.com>", "Message-ID": "<20200708032031.2ceaca0b@sovereign>", "In-Reply-To": "<4bcaa42f-1a72-b80e-8afa-327fddd7c7a2@intel.com>", "References": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>\n <4bcaa42f-1a72-b80e-8afa-327fddd7c7a2@intel.com>", "X-Mailer": "Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu)", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n for hugepages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115457, "web_url": "https://patches.dpdk.org/comment/115457/", "msgid": "<AM0PR05MB53135E0FEC7AFD8CC16FCFA0A9670@AM0PR05MB5313.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB53135E0FEC7AFD8CC16FCFA0A9670@AM0PR05MB5313.eurprd05.prod.outlook.com", "date": "2020-07-08T06:43:57", "subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n\tfor hugepages", "submitter": { "id": 1669, "url": "https://patches.dpdk.org/api/people/1669/?format=api", "name": "Tal Shnaiderman", "email": "talshn@mellanox.com" }, "content": "> Subject: Re: [PATCH] eal/windows: detect insufficient privileges for\n> hugepages\n> \n> On Tue, 7 Jul 2020 16:45:07 -0700, Ranjit Menon wrote:\n> > On 7/7/2020 1:22 PM, Dmitry Kozlyuk wrote:\n> > > AdjustTokenPrivileges() succeeds even if no requested privileges\n> > > have been granted; this behavior is documented. Check last error\n> > > code in addition to return value to detect such case.\n> > >\n> > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n> > > ---\n> > > lib/librte_eal/windows/eal_hugepages.c | 4 ++++\n> > > 1 file changed, 4 insertions(+)\n> > >\n> > > diff --git a/lib/librte_eal/windows/eal_hugepages.c\n> > > b/lib/librte_eal/windows/eal_hugepages.c\n> > > index 5779cd325..07a5467d0 100644\n> > > --- a/lib/librte_eal/windows/eal_hugepages.c\n> > > +++ b/lib/librte_eal/windows/eal_hugepages.c\n> > > @@ -41,6 +41,10 @@ hugepage_claim_privilege(void)\n> > > \t\tgoto exit;\n> > > \t}\n> > >\n> > > +\t/* AdjustTokenPrivileges() may succeed with\n> ERROR_NOT_ALL_ASSIGNED. */\n> > > +\tif (GetLastError() != ERROR_SUCCESS)\n> > > +\t\tgoto exit;\n> > > +\n> > > \tret = 0;\n> > >\n> > > exit:\n> >\n> > Wouldn't this be better if we could print a message here after\n> > explicitly checking for the ERROR_NOT_ALL_ASSIGNED return value?\n> >\n> > Otherwise, the caller simply gets a -1 return value for a failure with\n> > no message.\n> \n> Message is printed at ERR level by the caller. There's no context to add here.\n> \n\nTested successfully on Windows server 2019.\n \nThe output in case of missing privilege is:\n\nEAL: Cannot claim hugepage privilege\nEAL: FATAL: Cannot get hugepage information\nEAL: Cannot get hugepage information\n\nDo you think this is enough or do we want to give the user further indication that configuration action from his side might be needed? Something alike \"Please verify OS Large-Page support is enabled for the current user\"\n\n> --\n> Dmitry Kozlyuk\nTested-by: Tal Shnaiderman <talshn@mellanox.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4BBDA00BE;\n\tWed, 8 Jul 2020 08:44:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F09871DC08;\n\tWed, 8 Jul 2020 08:44:00 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58])\n by dpdk.org (Postfix) with ESMTP id 4D87F1DBE6\n for <dev@dpdk.org>; Wed, 8 Jul 2020 08:43:59 +0200 (CEST)", "from AM0PR05MB5313.eurprd05.prod.outlook.com (2603:10a6:208:f2::28)\n by AM0PR05MB6450.eurprd05.prod.outlook.com (2603:10a6:208:13e::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Wed, 8 Jul\n 2020 06:43:57 +0000", "from AM0PR05MB5313.eurprd05.prod.outlook.com\n ([fe80::9da9:e159:add2:64ee]) by AM0PR05MB5313.eurprd05.prod.outlook.com\n ([fe80::9da9:e159:add2:64ee%3]) with mapi id 15.20.3174.021; Wed, 8 Jul 2020\n 06:43:57 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=b/gECEzzczzxW/FVP4krhvF6+CY98KSOel1DlnYFg2XK+ROCMMtq11+EQ8sTvgbZwWA7+oNF1S3AX42Wil9bOZoy2JricTzMgaY+uB7cF0sBUmA91VpPrKr3DKEGLlqwzddRiDs8uWWkv/BWz5qaWJKooThM7XpmY8uX+cFdDr5VxlbFjp4GfGdl4614dwcXEDELnvR7A3ZRm3flW/vWfeTHGm7SFyIBdI1sk/+IaseKYKgfC01P1deJlBelr9j1ICXhLLX2PPD00xeR2YK6qBbsJVdJvzYb0Fl+Kp8vSHwqtwhRw4la/H1TdlhLHJVeEukB5SGQkGX7HQIZJl280w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=dsomU87Oe/sHHLrOTzxitFsqm7/nh9qATCSX59F7SHE=;\n b=EzSrty2Ez+1c2qHQTlbyHAmkhXGbJxQsrju1Y0FPdFLYeTFwRkmg5kZyM/tItlrWwxFnehUgC5sr50NMA8dJ0Eg5Ih1S2SF4PZlTNQ/N+9V6B/w2W9L3TgW9JvoDfAK2QvQf1JKRALNFsQufzOkISwZqYKd/T1roJaQ9185rRRXPKuWKBbK/HrsV/JqxAHxdTq+YZUUeWWndhjoRgAzN4i7zxnGXKkSE5tLop7lnOuj8VfvN1Jwm6Vgdtvy9cIt0oGwshpJJLsCwFrbBGVztzCi2/gmQw8epz0iippjaIT7XJDzeJXiHk+SJ/B5qPeL/2tr00XSEjbsY7Ks5Q78l+A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=dsomU87Oe/sHHLrOTzxitFsqm7/nh9qATCSX59F7SHE=;\n b=pXZz74cuqKKQep/4agpoOSH4lXMglRldM0Nwjh7hpxyCbGshlIcyhE+UW381bHJJ2qNoU2jwD/UCMJPmXbwAQ6LzghAWnQ6BfKn3e5g2KbFuq8z+bAXV7QQNn1Wu7gTxC67luEmfHIzus5JVQERpWHH6x7GnP+uyGvGUSR4YmOc=", "From": "Tal Shnaiderman <talshn@mellanox.com>", "To": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Ranjit Menon\n <ranjit.menon@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Narcisa Ana Maria Vasile\n <navasile@linux.microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>", "Thread-Topic": "[PATCH] eal/windows: detect insufficient privileges for\n hugepages", "Thread-Index": "AQHWVJxO7sIr9aJEr0mTSDp3CBr+aKj8yBGAgAAJ5ICAAGaRcA==", "Date": "Wed, 8 Jul 2020 06:43:57 +0000", "Message-ID": "\n <AM0PR05MB53135E0FEC7AFD8CC16FCFA0A9670@AM0PR05MB5313.eurprd05.prod.outlook.com>", "References": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>\n <4bcaa42f-1a72-b80e-8afa-327fddd7c7a2@intel.com>\n <20200708032031.2ceaca0b@sovereign>", "In-Reply-To": "<20200708032031.2ceaca0b@sovereign>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "gmail.com; dkim=none (message not signed)\n header.d=none;gmail.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[37.142.1.17]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "98b763be-8b77-45c8-c20c-08d8230a4a6f", "x-ms-traffictypediagnostic": "AM0PR05MB6450:", "x-microsoft-antispam-prvs": "\n <AM0PR05MB6450078CCEA19E92C49C3CEBA9670@AM0PR05MB6450.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:9508;", "x-forefront-prvs": "04583CED1A", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n WN1tlxcrIRaWmXA4L3hLsXzEenm3yRCPDflZiqWdxt1nPPnlIu/t8RDlyrEYbZUFBjD4gBlE8QnLvbGfnJJWiK/qv/dzMytrKmd2z9oXUpxLbBt9hAHqbZWibMiWAa3xFQu57ysJ17jwXwjxBF7ZYzbzA0RRnptsbMKupOXPEkjoZfR/d1kDLDW3+jZZhFfoJ4DiZzsWnpBSyUjc7HPI6vYi7O8DX3IC2BiT03lbodOEDAWsy6NYaXIoYltrMmjjmezea4UV/LVkZ838JFo9GpmIAWLBqFhThkfF6Q9AwD0y1n9A7/S8NwJchyC65n1H", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB5313.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(52536014)(71200400001)(26005)(86362001)(33656002)(83380400001)(478600001)(5660300002)(8936002)(8676002)(54906003)(110136005)(316002)(66446008)(6506007)(55016002)(7696005)(64756008)(66946007)(4326008)(66556008)(76116006)(66476007)(53546011)(186003)(9686003)(2906002);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n SJw/FLDLI5tZO8WpmOcR0roR1f1eNKC8erIlkLeORiUGGi8jexK/02nZRD/PHaZGEGCrLHIlq72c8CMqnXQUYd2kGAvB/Ya6ga1udcsdVO8xjL1pcc+w57g5hopYOBSy2w3dsUwslyJ/lKNEA962UCRQ5xp3zoQwNeHVMQMU3tQDGtjZKgWywgqHsl91zucraewgNfru2PKXPXaUxI7/299vNW/xlDIk2cvgsjOxNPEQZNDqDc+GKj4tjQvgYhNcZBOukZylWfC0cbWPHzWkAroBp2aclOQr3ZUqePO41oErUgx/GEMlcLykSfWbVhxMycGJ1RNrsKVihq9af/oBAttnccSAfm6mIWCpSJ0xQPHyWJswJTRFGcjHr1foreDh6ijPCqVoNUsQrhm42Uwae2Peypz2WY4mcZbiUa0C5xwWy6gdNxfc60kdTfkluQdN+YwVfP8ac8kpRbnPvF9D+c+/y0fB57GD+VeJfcO1xsw=", "x-ms-exchange-transport-forked": "True", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB5313.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 98b763be-8b77-45c8-c20c-08d8230a4a6f", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Jul 2020 06:43:57.7059 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n iMcJJOfIPAeMWo8NQA4xgcqn8YYLF2H8vwz3BHUjIY9ldRtexlQZC3McPDAVsTU1vGnZ04EaHV+EiGGZorlSpw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB6450", "Subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n\tfor hugepages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115464, "web_url": "https://patches.dpdk.org/comment/115464/", "msgid": "<20200708104934.5e0c7ef3@sovereign>", "list_archive_url": "https://inbox.dpdk.org/dev/20200708104934.5e0c7ef3@sovereign", "date": "2020-07-08T07:49:34", "subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n for hugepages", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "content": "On Wed, 8 Jul 2020 06:43:57 +0000, Tal Shnaiderman wrote:\n[snip]\n\nThanks for the testing.\n\n> Do you think this is enough or do we want to give the user further indication that configuration action from his side might be needed? Something alike \"Please verify OS Large-Page support is enabled for the current user\"\n\nYes, troubleshooting suggestions would be useful.\n\nFrom Microsoft \"Error Message Guidelines\" [1]:\n\n\tAvoid the word \"please\". It can be interpreted to mean that a\n\trequired action is optional.\n\n[1]:\nhttps://docs.microsoft.com/en-us/windows/win32/debug/error-message-guidelines", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C6205A00BE;\n\tWed, 8 Jul 2020 09:49:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A46561DB16;\n\tWed, 8 Jul 2020 09:49:37 +0200 (CEST)", "from mail-lj1-f178.google.com (mail-lj1-f178.google.com\n [209.85.208.178]) by dpdk.org (Postfix) with ESMTP id A90F21DA4E\n for <dev@dpdk.org>; Wed, 8 Jul 2020 09:49:36 +0200 (CEST)", "by mail-lj1-f178.google.com with SMTP id r19so1971419ljn.12\n for <dev@dpdk.org>; Wed, 08 Jul 2020 00:49:36 -0700 (PDT)", "from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id m25sm712264ljj.128.2020.07.08.00.49.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Jul 2020 00:49:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=date:from:to:cc:subject:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=j38HhDOnUDkYmbdx91/uNjGHTCJ3dZpv4hisPsw89Hw=;\n b=KVVadCptisu+iOi2ruHgDkn5iZ2JbUVMe/lVUDMqh+5KnVFmIT6qMRT8izRit/AK++\n JEDtzqnjKawpwFS6BG1jDdQdtskEfuqvYatG83x5bKxeAkhW+Mfg1KVZ64e1YfhxTHW2\n +UAZotL21k3AWfvYtNK5YPDi4Bq1+SfRwhMZKF8VOIlyXJnG7vN7IXhpcjeOb/lmLP+w\n 6U5CCdlymbvmkFEpLAezlJMq+bkYFqgYiSkHJhNcDsKSV5P6YWSlNnkE5ASbPXSgSWxn\n eh6z3EbPaYnXsKjg+H6HhPScByMgZoam+UqP+eecJo1VuLz7xFDPhtil8qXRBz66CQ/L\n 3NKw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=j38HhDOnUDkYmbdx91/uNjGHTCJ3dZpv4hisPsw89Hw=;\n b=CpkxX6HDKq+8+e5W9SNGyVXx28a6H06Qd+RLKbzAwggN5PGOAlwMt1AJXp5QxGMBiV\n qhrmJi/fDHnsO3m+76PNjrZY9QCh3gu7pCHAlXiYJ6Jhhi+/1/XMHUpJOUzfYh+MSwZr\n 6Lno1BZEvERFO0oU+7ywGjfLZWW5NUPGjeV+CldvnBUpmH7IzOca1jGgR7dJOMT+z/Xl\n pd5bXM6BSrwHUI2B9oZIe6GvyjUjj3QQr9Vk1WEyLILHG/otOd5hUEvAWWVbFrHQykPX\n A/41Y0UbyUv1/jkg4QDVCrPxmjjx+mq7AGghH8W2KQSzOa9WBKpnsihfRklqc3lJb/Et\n knFw==", "X-Gm-Message-State": "AOAM530CRf3KcMO8yAZLKakRhTAZpESkrCMgUk61lvYfZlRc4tYsknxz\n eWt1aL1yufaftwWL4HWXTCg=", "X-Google-Smtp-Source": "\n ABdhPJwdIsDvo6YKUxDSsO6F/e7nsiFvFIp4az4R0uGpQvI91C6bMtMUvA61/1LFbigNbodTZ3uqwA==", "X-Received": "by 2002:a2e:7314:: with SMTP id\n o20mr22345119ljc.233.1594194576152;\n Wed, 08 Jul 2020 00:49:36 -0700 (PDT)", "Date": "Wed, 8 Jul 2020 10:49:34 +0300", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "Tal Shnaiderman <talshn@mellanox.com>", "Cc": "Ranjit Menon <ranjit.menon@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Pallavi Kadam\n <pallavi.kadam@intel.com>", "Message-ID": "<20200708104934.5e0c7ef3@sovereign>", "In-Reply-To": "\n <AM0PR05MB53135E0FEC7AFD8CC16FCFA0A9670@AM0PR05MB5313.eurprd05.prod.outlook.com>", "References": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>\n <4bcaa42f-1a72-b80e-8afa-327fddd7c7a2@intel.com>\n <20200708032031.2ceaca0b@sovereign>\n <AM0PR05MB53135E0FEC7AFD8CC16FCFA0A9670@AM0PR05MB5313.eurprd05.prod.outlook.com>", "X-Mailer": "Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu)", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges\n for hugepages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]