Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 73469,
    "url": "https://patches.dpdk.org/api/patches/73469/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200707202203.8780-1-dmitry.kozliuk@gmail.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200707202203.8780-1-dmitry.kozliuk@gmail.com",
    "date": "2020-07-07T20:22:03",
    "name": "eal/windows: detect insufficient privileges for hugepages",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "79c53906afa6225d874ba725333df21da874455d",
    "submitter": {
        "id": 1581,
        "url": "https://patches.dpdk.org/api/people/1581/?format=api",
        "name": "Dmitry Kozlyuk",
        "email": "dmitry.kozliuk@gmail.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200707202203.8780-1-dmitry.kozliuk@gmail.com/mbox/",
    "series": [
        {
            "id": 10864,
            "url": "https://patches.dpdk.org/api/series/10864/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10864",
            "date": "2020-07-07T20:22:03",
            "name": "eal/windows: detect insufficient privileges for hugepages",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/10864/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/73469/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/73469/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 94C69A00BE;\n\tTue,  7 Jul 2020 22:22:14 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B2D91DB3E;\n\tTue,  7 Jul 2020 22:22:14 +0200 (CEST)",
            "from mail-lj1-f180.google.com (mail-lj1-f180.google.com\n [209.85.208.180]) by dpdk.org (Postfix) with ESMTP id D9E531D9F5\n for <dev@dpdk.org>; Tue,  7 Jul 2020 22:22:13 +0200 (CEST)",
            "by mail-lj1-f180.google.com with SMTP id e8so17241317ljb.0\n for <dev@dpdk.org>; Tue, 07 Jul 2020 13:22:13 -0700 (PDT)",
            "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id g7sm9764313lfe.62.2020.07.07.13.22.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Jul 2020 13:22:12 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=2ak4q8pBw/G1gKqY5Kk1myvZ5nTiaA6ixGJMTyoCHe0=;\n b=oFpjAjoT3fLfrV5O9URmtFVoc+vF8fv/7fFVQ3ODhkBZ8GExpnGeDO1gBDl//Rfym5\n pT0RoKYGDGM9vgHG9IhZlhG5vqWlbeo2iowXIWFXWw7oyOC3ulopJXe7V73DPHxard+Y\n 7v3+ew1dDwaBaWrivVbwRWiJAtjpwSkv6xYAJYPFB03tmqggk6fycHB9SoBfRluGsPeW\n Qp5mIO67I7z4kqQNmKtN41tprFMOcMyTUBcUGrYi+Q7lMVjqjj3YxjePWM/Vavm4oxjX\n fMrdwLoapLy6hIlHB85wMRzPQap4off62G/ue83CfK3DFrssohKQGC1R86Bv9fA1trfC\n KjCQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=2ak4q8pBw/G1gKqY5Kk1myvZ5nTiaA6ixGJMTyoCHe0=;\n b=MijqqvYd6W49cBRoooXgevtgzqkoViBwl7ZgJUXTwbwPJPZUaWpyB+8Ub/u7HIvFrN\n pBSMG29kxuwkLdan/zrHfsk7dnO7kAqF7pCXJ1sXabflJymfgXCSIFwDMrfvh6A8EW7D\n QY87PFxjIGk8da+C9OBSq/6KdMux0pvIGhMLmcTRoE2IBBs9WT2yiYuXrX17jI9eN+5r\n Yq7Z6FJ85U+atTib5I9SOvwlEFc0fJtJMapm/KH6mSR5/l/+qqXp57d9vq/sTvbg3Ymv\n 1Hfynp8g5M09FxvdFAwUiMzc5S0WstFOaWq4dWsHbeSn55GqurdUf+teZMZ1oAqlBdlJ\n yi3g==",
        "X-Gm-Message-State": "AOAM531aQgQkkhpps5zspnrVuxjLIxyVB66BeyOgiea059b5ZDw8j2x9\n 9zkZ2KSCyA4hcb0B50y84QCWIuDkygr03g==",
        "X-Google-Smtp-Source": "\n ABdhPJx0zxobnwltLgINY9fE09GK6CAksZJ2qUke7tYG2lqivtHNX5Yy+XUN3r59HR7AKJlD8hGbEg==",
        "X-Received": "by 2002:a2e:4612:: with SMTP id\n t18mr28819596lja.212.1594153333215;\n Tue, 07 Jul 2020 13:22:13 -0700 (PDT)",
        "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Ranjit Menon <ranjit.menon@intel.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Tal Shnaiderman <talshn@mellanox.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>",
        "Date": "Tue,  7 Jul 2020 23:22:03 +0300",
        "Message-Id": "<20200707202203.8780-1-dmitry.kozliuk@gmail.com>",
        "X-Mailer": "git-send-email 2.25.4",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for\n\thugepages",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "AdjustTokenPrivileges() succeeds even if no requested privileges have\nbeen granted; this behavior is documented. Check last error code in\naddition to return value to detect such case.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n lib/librte_eal/windows/eal_hugepages.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/windows/eal_hugepages.c b/lib/librte_eal/windows/eal_hugepages.c\nindex 5779cd325..07a5467d0 100644\n--- a/lib/librte_eal/windows/eal_hugepages.c\n+++ b/lib/librte_eal/windows/eal_hugepages.c\n@@ -41,6 +41,10 @@ hugepage_claim_privilege(void)\n \t\tgoto exit;\n \t}\n \n+\t/* AdjustTokenPrivileges() may succeed with ERROR_NOT_ALL_ASSIGNED. */\n+\tif (GetLastError() != ERROR_SUCCESS)\n+\t\tgoto exit;\n+\n \tret = 0;\n \n exit:\n",
    "prefixes": []
}