Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73459/?format=api
https://patches.dpdk.org/api/patches/73459/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1594137293-22468-3-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594137293-22468-3-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594137293-22468-3-git-send-email-phil.yang@arm.com", "date": "2020-07-07T15:54:52", "name": "[v4,3/4] eventdev: remove redundant code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b134f7384ac4d78d1d2dfda467478714f8b9b063", "submitter": { "id": 833, "url": "https://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1594137293-22468-3-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 10861, "url": "https://patches.dpdk.org/api/series/10861/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10861", "date": "2020-07-07T15:54:50", "name": "[v4,1/4] eventdev: fix race condition on timer list counter", "version": 4, "mbox": "https://patches.dpdk.org/series/10861/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73459/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73459/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D79BAA00BE;\n\tTue, 7 Jul 2020 17:55:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 98D8E1DECA;\n\tTue, 7 Jul 2020 17:55:31 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id C6F9B1DEC8;\n Tue, 7 Jul 2020 17:55:28 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57B731042;\n Tue, 7 Jul 2020 08:55:28 -0700 (PDT)", "from phil-VirtualBox.arm.com (A010647.Arm.com [10.170.226.105])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0A2FB3F68F;\n Tue, 7 Jul 2020 08:55:23 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "jerinj@marvell.com,\n\tdev@dpdk.org", "Cc": "thomas@monjalon.net, erik.g.carrillo@intel.com,\n Honnappa.Nagarahalli@arm.com, drc@linux.vnet.ibm.com, Ruifeng.Wang@arm.com,\n Dharmik.Thakkar@arm.com, nd@arm.com, david.marchand@redhat.com,\n mdr@ashroe.eu, nhorman@tuxdriver.com, dodji@redhat.com, stable@dpdk.org", "Date": "Tue, 7 Jul 2020 23:54:52 +0800", "Message-Id": "<1594137293-22468-3-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1594137293-22468-1-git-send-email-phil.yang@arm.com>", "References": "<1594120403-17643-1-git-send-email-phil.yang@arm.com>\n <1594137293-22468-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH v4 3/4] eventdev: remove redundant code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no thread will access these impl_opaque data after timer\ncanceled. When new timer armed, it got refilled. So the cleanup\nprocess is unnecessary.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\n---\nv4:\nCc to stable release. (Honnappa)\n\n lib/librte_eventdev/rte_event_timer_adapter.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c\nindex 4ed3013..aa01b4d 100644\n--- a/lib/librte_eventdev/rte_event_timer_adapter.c\n+++ b/lib/librte_eventdev/rte_event_timer_adapter.c\n@@ -1167,8 +1167,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter,\n \t\trte_mempool_put(sw->tim_pool, (void **)timp);\n \n \t\tevtims[i]->state = RTE_EVENT_TIMER_CANCELED;\n-\t\tevtims[i]->impl_opaque[0] = 0;\n-\t\tevtims[i]->impl_opaque[1] = 0;\n \n \t\trte_smp_wmb();\n \t}\n", "prefixes": [ "v4", "3/4" ] }{ "id": 73459, "url": "