List comments

GET /api/patches/73445/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 115429,
        "web_url": "https://patches.dpdk.org/comment/115429/",
        "msgid": "<VI1PR04MB3168F7E42CE5AEB096F4A70EE6660@VI1PR04MB3168.eurprd04.prod.outlook.com>",
        "date": "2020-07-07T22:28:46",
        "subject": "Re: [dpdk-dev] [PATCH v5 3/3] drivers/qat: add handling of\n capabilities in multi process",
        "submitter": {
            "id": 517,
            "url": "https://patches.dpdk.org/api/people/517/",
            "name": "Akhil Goyal",
            "email": "akhil.goyal@nxp.com"
        },
        "content": "> Move qat capabilities data into a memzone where it can be\n> shared by primary and secondary processes.\n> \n> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n> ---\n\nSeries Applied to dpdk-next-crypto\n\nFixed following check patch warning while applying the patchset.\n\ndiff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex 2dcda4a06..f6f9f5bdd 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -435,18 +435,18 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,\n\n        internals->capa_mz = rte_memzone_lookup(capa_memz_name);\n        if (internals->capa_mz == NULL) {\n-       internals->capa_mz = rte_memzone_reserve(capa_memz_name,\n+               internals->capa_mz = rte_memzone_reserve(capa_memz_name,\n                capa_size,\n                rte_socket_id(), 0);\n        }\n        if (internals->capa_mz == NULL) {\n-       QAT_LOG(DEBUG,\n-               \"Error allocating memzone for capabilities, destroying PMD for %s\",\n-               name);\n-       rte_cryptodev_pmd_destroy(cryptodev);\n-       memset(&qat_dev_instance->sym_rte_dev, 0,\n-               sizeof(qat_dev_instance->sym_rte_dev));\n-       return -EFAULT;\n+               QAT_LOG(DEBUG,\n+                       \"Error allocating memzone for capabilities, destroying PMD for %s\",\n+                       name);\n+               rte_cryptodev_pmd_destroy(cryptodev);\n+               memset(&qat_dev_instance->sym_rte_dev, 0,\n+                       sizeof(qat_dev_instance->sym_rte_dev));\n+               return -EFAULT;\n        }",
        "headers": {
            "X-OriginatorOrg": "nxp.com",
            "x-ms-office365-filtering-correlation-id": "87ce80d3-dd2c-4068-475b-08d822c51d09",
            "References": "<20200707150239.13400-1-arkadiuszx.kusztal@intel.com>\n <20200707150239.13400-4-arkadiuszx.kusztal@intel.com>",
            "X-Mailman-Version": "2.1.15",
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n 0CvAIdagLa+L1gnnrQPTXHFRKtUHO4+NjrMYS4xmrLwXWVPkbRnIyhrwVCA8M7VmevGxidsYc04ED37C4KLHOg==",
            "x-ms-oob-tlc-oobclassifiers": "OLM:207;",
            "Thread-Index": "AQHWVG/D9QAu8gFMWUaDQNbbCgZJQaj8pQmA",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "CC": "\"fiona.trahe@intel.com\" <fiona.trahe@intel.com>",
            "x-microsoft-antispam": "BCL:0;",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A697A00BE;\n\tWed,  8 Jul 2020 00:28:54 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AB1091DED0;\n\tWed,  8 Jul 2020 00:28:53 +0200 (CEST)",
                "from EUR01-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr130052.outbound.protection.outlook.com [40.107.13.52])\n by dpdk.org (Postfix) with ESMTP id 649561DECD\n for <dev@dpdk.org>; Wed,  8 Jul 2020 00:28:52 +0200 (CEST)",
                "from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10)\n by VI1PR04MB3165.eurprd04.prod.outlook.com (2603:10a6:802:a::27) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.27; Tue, 7 Jul\n 2020 22:28:46 +0000",
                "from VI1PR04MB3168.eurprd04.prod.outlook.com\n ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com\n ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020\n 22:28:46 +0000"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v5 3/3] drivers/qat: add handling of\n capabilities in multi process",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=JTVejYSbmJfr/gDPpdAT9xDAXGNJxJ/95dlzX1FTF1j7QswHzreXBni33es+w1rKhM+cgQ0Oa8WPoHiiMHMae1qjrbpoxjWeFLERoJWzAi8+/djAbYIzMT+pDkymTLPEJjc78Vz/UiKVNYox8JC3pW8Sliukv62VuYCbKuYhi+eIG5Y5DSi8tCA6w4HOCP2Ig7hqYxQyxOtNQCa6E0F37It2YvgKfjqIlVrhavSwKoQYAup2srITnxWSbUtOaGIGG9qJvG9gqI8WqVORqQIuVQw5JdlhPsCh7ugiasNRZkrZG/ZqUNii3zEedmPcy1JAh9iAirGMaNnRLEgw8fjm1A==",
            "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=nxp.com;",
            "x-ms-traffictypediagnostic": "VI1PR04MB3165:",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "07 Jul 2020 22:28:46.2515 (UTC)",
            "Precedence": "list",
            "Date": "Tue, 7 Jul 2020 22:28:46 +0000",
            "x-ms-office365-filtering-ht": "Tenant",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(8676002)(52536014)(86362001)(2906002)(6506007)(9686003)(33656002)(5660300002)(316002)(110136005)(478600001)(83380400001)(55016002)(71200400001)(4326008)(7696005)(76116006)(66556008)(64756008)(26005)(66946007)(8936002)(66476007)(186003)(66446008)(44832011);\n DIR:OUT; SFP:1101;",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "x-ms-exchange-transport-forked": "True",
            "x-microsoft-antispam-prvs": "\n <VI1PR04MB31656CE481B287A466F4945DE6660@VI1PR04MB3165.eurprd04.prod.outlook.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "x-forefront-prvs": "0457F11EAF",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "Arek Kusztal <arkadiuszx.kusztal@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "x-microsoft-antispam-message-info": "\n tLgEZ5g5vqvoS6E/QjxzuYi4ZcVecHMW6nnjYVA/E0YCm509+tJkVymPn1+X/EqK/AH+ZV2a6vwJis3sdqmlA5YbDjyNvnrZ/86lWozPdKLOMzb/octvJzwiAIY3AkYa3pxHdIsKUDanvo4f6mBR5xn0cg+CMq09VcvWAb+UU0Mf8EDkkdP2fBfGM+YNYowFea6XZUxQ+RL8rB96aRfPBLq49cF90+y+eEtDhk6CvVdnl+6Jvw+LSsRun5QhIJkoIu/WBtd+cfIUR9G/6HedW8dZRwzvxi3egXo5Tdy6YCkh08Ktqs6kCR4SMdj8T4h8E6alU14b4yS3d63TkcS6YQ==",
            "MIME-Version": "1.0",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-MS-Exchange-CrossTenant-AuthSource": "VI1PR04MB3168.eurprd04.prod.outlook.com",
            "From": "Akhil Goyal <akhil.goyal@nxp.com>",
            "x-originating-ip": "[45.118.167.74]",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "x-ms-publictraffictype": "Email",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "Accept-Language": "en-IN, en-US",
            "Message-ID": "\n <VI1PR04MB3168F7E42CE5AEB096F4A70EE6660@VI1PR04MB3168.eurprd04.prod.outlook.com>",
            "x-ms-exchange-senderadcheck": "1",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 87ce80d3-dd2c-4068-475b-08d822c51d09",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635",
            "Content-Language": "en-US",
            "X-MS-Has-Attach": "",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB3165",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=5rQDzfFN1Lf8INHMMD43FoYvkcBZg3lmsbk0dz1Zahw=;\n b=qxQY5vIlgA2yknUZvyfOsIz8ymc29GA1g7GASvaJDz9ZEIZrGnt0w3X2m86Pz1v0ZO/l0Lqdo8pxiHI2tMAbi9Lz6nc9AH3j/ewyoM96W/AO7Lq58890BR4i2j9slI0EWknC0MehzMv8Ck1QXgQg10Rfu1UgaYJfAV0J8l76QeA=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Errors-To": "dev-bounces@dpdk.org",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=5rQDzfFN1Lf8INHMMD43FoYvkcBZg3lmsbk0dz1Zahw=;\n b=TeCt8ybt7YG+zrH69uOnRHqO2m/a5rTbbIGQ6jfz9vQwAGWaSgUlv2PhDYw5T0GyWD146yBfliu2U3T3UgX0iDehsuXvqEttrFuNUTzbJtHLbao407k+vxOZrszvcmAoG+jtqu0eqX3mcnz7IODO6M6GR+YSjOtsjZDtpW++xaY6jxvfb/DLyPKa1Awso7SfCbTPOASHzvEmedTD/cUImBacTjh7p94B4qOp8H49V34WFlaBKdCucjpTZ0v/HsoomP0zb3T8SVaSYSZGq9H8nSV9jF5CXy8y+KGM2pfSgxy4lguoYMHMD/jT82MP6yeve85gadv7A9SCCcHL6iOJIA==",
            "Thread-Topic": "[PATCH v5 3/3] drivers/qat: add handling of capabilities in\n multi process",
            "In-Reply-To": "<20200707150239.13400-4-arkadiuszx.kusztal@intel.com>",
            "x-ms-exchange-antispam-messagedata": "\n /FlYTFnZ5c5pImIFFUDlg4ZQWPTYPr9gYeMIKbju+ubm1wcPAs1lm0P3v0LRy5SON8CFIw1ftPemjSLKU5HoMCcrSRoAxBWsLz0HQFNLNWFHvTVcJYZOx+Xo3nNK159+b5+XbxE+BBlC/8vKgf1LS55Ik3xZ7toSMmV7kZcCYbQQxwCLYweYXeAzuQYq/oI571wjU9HObdH+BGfG8PXAejb00BhVlQKwVCbTzWLLTii3LITKgIYZU1c3HOgNyWAAxK9LifkHkv7iGnKioxGQbGY+0wFLN8AOfrwjii7sGjFnfe5JMWFHGvKfK6DDw9S0fuOPAMuHjZOg7IOWBa1Dkbrrug+KaIZJxCjH7P7gN1ptIlDIOSlBJdMKwdZ99IPcJ1dAZBHiSrHSgO0vMLvXzvsOp5CRaw+CzjB3q38zfjWuiOf6kBWl6RXTVshVlqsy5+HWHHNmmjXxrz+LvZlbcD2a1VD6QWF5uEbvDVnWGi4="
        }
    }
]