Patch Comment List
List patch comments
GET /api/patches/73420/comments/?format=api
[ { "id": 115362, "web_url": "https://patches.dpdk.org/comment/115362/", "msgid": "<BYAPR11MB31439E3827F2E116F60C16CED7660@BYAPR11MB3143.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB31439E3827F2E116F60C16CED7660@BYAPR11MB3143.namprd11.prod.outlook.com", "date": "2020-07-07T13:14:46", "subject": "Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "content": "> -----Original Message-----\n> From: Andrew Rybchenko <arybchenko@solarflare.com>\n> Sent: Tuesday, July 7, 2020 11:45 AM\n> To: dev@dpdk.org\n> Cc: Igor Romanov <igor.romanov@oktetlabs.ru>; stable@dpdk.org; Van Haaren,\n> Harry <harry.van.haaren@intel.com>\n> Subject: [PATCH v3 1/2] service: fix wrong lcore indices\n> \n> From: Igor Romanov <igor.romanov@oktetlabs.ru>\n> \n> The service core list is populated, but not used. Incorrect\n> lcore states are examined for a service.\n> \n> Use the populated list to iterate over service cores.\n> \n> Fixes: e30d d318 47d2 (\"service: add mechanism for quiescing\")\n> Cc: stable@dpdk.org\n\nI believe the original adding of quiescing did not have this exact bug (ids[] was used)?\nIt seems to have been introduced when reworking to avoid false sharing, so fixes is:\nFixes: e484ccddbe1b (\"services: avoid false sharing on core state\")\n\n\n> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\n> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n\nCode change itself: \nAcked-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n<snip patch>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0BBD2A00BE;\n\tTue, 7 Jul 2020 15:15:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B76951DDA5;\n\tTue, 7 Jul 2020 15:14:58 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id C0FE11DC89;\n Tue, 7 Jul 2020 15:14:56 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jul 2020 06:14:55 -0700", "from orsmsx602.amr.corp.intel.com ([10.22.229.15])\n by orsmga006.jf.intel.com with ESMTP; 07 Jul 2020 06:14:55 -0700", "from orsmsx612.amr.corp.intel.com (10.22.229.25) by\n ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Tue, 7 Jul 2020 06:14:55 -0700", "from ORSEDG001.ED.cps.intel.com (10.7.248.4) by\n orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Tue, 7 Jul 2020 06:14:55 -0700", "from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105)\n by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 7 Jul 2020 06:14:49 -0700", "from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32)\n by BYAPR11MB3144.namprd11.prod.outlook.com (2603:10b6:a03:8f::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Tue, 7 Jul\n 2020 13:14:46 +0000", "from BYAPR11MB3143.namprd11.prod.outlook.com\n ([fe80::9c6b:5ce:b551:8678]) by BYAPR11MB3143.namprd11.prod.outlook.com\n ([fe80::9c6b:5ce:b551:8678%4]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020\n 13:14:46 +0000" ], "IronPort-SDR": [ "\n zf6eENlYEMn542c50kb9OXnvwWXv16WAyN7ItSr4L0njphbPA15BJtYfIDyAv1cYkvew3aFY/i\n vlV+oZgwRirQ==", "\n W5u+5fECoBdo9bZ8zp0zuc3usuNCs9ZJU4Ev+gmy/mK3VkpmlK302l/wBg7DauRYzuOtAcNtoG\n DvotQ1fNjhsg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9674\"; a=\"146663138\"", "E=Sophos;i=\"5.75,323,1589266800\"; d=\"scan'208\";a=\"146663138\"", "E=Sophos;i=\"5.75,323,1589266800\"; d=\"scan'208\";a=\"283441999\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ejeTLXjUntG/mBwjWDpxqGrDs8FnEA/EqzDO0ykKtyjsVsZmBZxg5/1H5d9+Nefty3U5sI9TaTtr/xqnIrn8wdWhmnsV8vbSOhMfG40G9wqF5WTWQU69xjoKew9BqmQq07blLbMiDaAr6Zu3Ik4113CHcxvgnvcH/+8AYd2jYZTZ9SXu9t9ktuqwPwOl3RiJze5h1GdpzS/rLM873crXembIPgkaxEPS3p8EDDXHW+XA9acewcZ+q0NPUOucebtNxe1nmMJSzCpPyIFQhaF8oJSY3ptwqfNdkD09vVhsJZwNURqMf51gb/405lRHJu1tyhxY8bVtQwBdmKeshkdbyw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qEaaD+lici30/tYFoKZDctJfTKmScgykfj0QkXlCwA4=;\n b=V7+5UgaxH4/Ednn+Zi6t40H7NVEhtcIJzM1nz5RVIktOJQXXvhQGKPNvT7Es6ChAUBiX1IvBDkiu6rkeuoooBTBA1lGPdjnC608aMEkJWASVD2k5+jMPsqzwu1i6fjSQRQiVG/cR5flbXUEGrJ6E2PjeZw5DgT3awzpDS7FHP19PxhmLjS8+i5ueaYiswGhrHyKW2QIupi1MpxCqXlXLivt+nt4JLo1mxl9Pe0w3PCeVOP3kQpsJmnzX7JgUg7J5zOv2MqQxst1qcRwTapBhZai5AQiuHc3oNjJTUYpUQCvbz1XwCYeN75cWYLtDsE820v52d/mAoiYhov4ckUcT5A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qEaaD+lici30/tYFoKZDctJfTKmScgykfj0QkXlCwA4=;\n b=RwDJyNc/MRKvUs+EOf/trZBY33UeIjJdYajsXxzE8EH5H8T1vaasYJISFWnLbpgQpJB1Xt9PFbUc8tokGQlISbHIJRCZgB7YmnMi6qu1ZrQrAPJZyWsgrwvLu9cT+46GT7l/7xtemiqnh7ro5ym1X6cTtALlXy0JJnXCuE/d0yM=", "From": "\"Van Haaren, Harry\" <harry.van.haaren@intel.com>", "To": "Andrew Rybchenko <arybchenko@solarflare.com>,\n \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Igor Romanov <igor.romanov@oktetlabs.ru>, \"stable@dpdk.org\"\n <stable@dpdk.org>", "Thread-Topic": "[PATCH v3 1/2] service: fix wrong lcore indices", "Thread-Index": "AQHWVEvRWwnnNFSPKUK17f3xst6Blaj8Ffag", "Date": "Tue, 7 Jul 2020 13:14:46 +0000", "Message-ID": "\n <BYAPR11MB31439E3827F2E116F60C16CED7660@BYAPR11MB3143.namprd11.prod.outlook.com>", "References": "<1593873347-13686-1-git-send-email-arybchenko@solarflare.com>\n <1594118726-8421-1-git-send-email-arybchenko@solarflare.com>", "In-Reply-To": "<1594118726-8421-1-git-send-email-arybchenko@solarflare.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-reaction": "no-action", "dlp-version": "11.2.0.6", "authentication-results": "solarflare.com; dkim=none (message not signed)\n header.d=none;solarflare.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.198.151.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "6c14e1e8-1a53-444d-c769-08d82277b874", "x-ms-traffictypediagnostic": "BYAPR11MB3144:", "x-microsoft-antispam-prvs": "\n <BYAPR11MB3144F8661B1C4AB3F119E6B1D7660@BYAPR11MB3144.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:6430;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n hfdcUi0VTJe6gHyRupEI3/OzetPkMUZSFi6ozGNvGCEoPCKmZlYZt7lviwdkvJSrcRLRnjARdzVHIpy1/iAIz5MY5d6zPZO/2TzOvspw/kTRwFNAvlbs2sWRTarRbQK1arbcxlXitmsz3hHNGKZKf+d9G2uB1Rww9YhU47zj5PQa8Ae6dSmefQDCb5M8N1GWx8MqidhfUoBBbnYsMw1pt5AfRboOqsQU5bszvVZXnFPZ9LTlLH0JYHkhRQ/qMnPUPc4YfkKgx6xRiSpeVZR8WmLxosgv1291rEe8pZa+FQl5IlToQtYak+6ihJsjnv8j", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(186003)(66556008)(66476007)(52536014)(66446008)(64756008)(26005)(66946007)(8676002)(8936002)(76116006)(4326008)(6506007)(53546011)(4744005)(86362001)(71200400001)(54906003)(83380400001)(316002)(9686003)(33656002)(478600001)(5660300002)(110136005)(7696005)(55016002)(2906002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n Hc9gkdlHIIvSkT7NiiVfNY5dJbPAETyJ+o8br+upeFi6Ch+f62Goo3sPTaI5KA8BMLqrjSgZ7zbEvWgv/urQDNrlrLHGLXveosIQ3jL1S90hi1uV1armkBsu5k+94aduVK6Dmq4d9BPIUms403E9pZokoX01V2anLZHdaR4c6uXcQWYaqG4uj/lWqmJmAekYE7t7z5jEjF843i4jHeBrZqGpk+PXOR7HnDjjjzuVpGljL2ZSasDSa7HqBxmmTlfG7zLkXUip4IQUl6Zw+jI8oHyo4hE5BnWxoxdamGBhO3nPhtLo4LPgdYJqeKDgfa4OuVC1twCOrfPnA2LoSwHJy+A78JfbimSt8w97WGrF17YntGEOe6oAEqk6KHPP89Tu6ukeuTlbuRoe5N03UyeTi/Jps04Z+aVsj9Pxp1zsJSd7iHlgWuoB2sBZQRxjatDps8gno3lyZKkWUAE28DISGgksbGl3IeMVPGWJTa1v/rACFF39GqwUccrTOcU11Jd3", "x-ms-exchange-transport-forked": "True", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3143.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6c14e1e8-1a53-444d-c769-08d82277b874", "X-MS-Exchange-CrossTenant-originalarrivaltime": "07 Jul 2020 13:14:46.2102 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n L184gPD7lwZzzdllNOQBsZq3ioOYLa8eYOxXPN07HQ/H+KQ5ustORvMKAf6EDTc9h9NfI//e4PQeJRnRrC1l0CXPqfoPcvLwX1uTnlrW/KM=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR11MB3144", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115412, "web_url": "https://patches.dpdk.org/comment/115412/", "msgid": "<DB6PR0802MB221656C832AC241C3B20B85498660@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/DB6PR0802MB221656C832AC241C3B20B85498660@DB6PR0802MB2216.eurprd08.prod.outlook.com", "date": "2020-07-07T19:33:05", "subject": "Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices", "submitter": { "id": 1045, "url": "https://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "content": "<snip>\n\n> Subject: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices\n> \n> From: Igor Romanov <igor.romanov@oktetlabs.ru>\n> \n> The service core list is populated, but not used. Incorrect lcore states are\n> examined for a service.\n> \n> Use the populated list to iterate over service cores.\n> \n> Fixes: e30dd31847d2 (\"service: add mechanism for quiescing\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\n> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n\nLGTM\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n\n> ---\n> lib/librte_eal/common/rte_service.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/lib/librte_eal/common/rte_service.c\n> b/lib/librte_eal/common/rte_service.c\n> index 6123a2124d..e2795f857e 100644\n> --- a/lib/librte_eal/common/rte_service.c\n> +++ b/lib/librte_eal/common/rte_service.c\n> @@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)\n> \t\treturn -EINVAL;\n> \n> \tfor (i = 0; i < lcore_count; i++) {\n> -\t\tif (lcore_states[i].service_active_on_lcore[id])\n> +\t\tif (lcore_states[ids[i]].service_active_on_lcore[id])\n> \t\t\treturn 1;\n> \t}\n> \n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1A919A00BE;\n\tTue, 7 Jul 2020 21:33:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 55A131DE4F;\n\tTue, 7 Jul 2020 21:33:21 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85])\n by dpdk.org (Postfix) with ESMTP id 324D11BFB4;\n Tue, 7 Jul 2020 21:33:20 +0200 (CEST)", "from MRXP264CA0040.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::28)\n by VI1PR08MB5502.eurprd08.prod.outlook.com (2603:10a6:803:12f::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.29; Tue, 7 Jul\n 2020 19:33:18 +0000", "from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com\n (2603:10a6:500:14:cafe::37) by MRXP264CA0040.outlook.office365.com\n (2603:10a6:500:14::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21 via Frontend\n Transport; Tue, 7 Jul 2020 19:33:18 +0000", "from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by\n VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with\n Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3153.24 via Frontend Transport; Tue, 7 Jul 2020 19:33:18 +0000", "(\"Tessian outbound 4e683f4039d5:v62\");\n Tue, 07 Jul 2020 19:33:17 +0000", "from dffa14652a92.2\n by 64aa7808-outbound-1.mta.getcheckrecipient.com id\n 4C56BFE5-AB6C-4809-8C90-2D9139775663.1;\n Tue, 07 Jul 2020 19:33:12 +0000", "from EUR02-HE1-obe.outbound.protection.outlook.com\n by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id\n dffa14652a92.2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);\n Tue, 07 Jul 2020 19:33:12 +0000", "from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9)\n by DB6PR0801MB1734.eurprd08.prod.outlook.com (2603:10a6:4:31::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Tue, 7 Jul\n 2020 19:33:10 +0000", "from DB6PR0802MB2216.eurprd08.prod.outlook.com\n ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com\n ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020\n 19:33:05 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6+XtB+63LrDM/o5KW7NyTbUyh9Q8jWYsioQrS/ZS2c0=;\n b=ZoQ4yCy/Mn/Ouvwo5OHpzzCs1Ylde+xrkqwzffSJ7GYEOSAiJG6gq49HQXIx7SO8WqyRdOZitSQAj0jAP0vsr9Qi8yLqi74Ag9fBdca0EwHuy5c+J4CXS/miJuEoU8N3Q6a3TDw7Gu4hb+FFz2EOW8EhX+tO8RbPiT1mSPiuNMQ=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6+XtB+63LrDM/o5KW7NyTbUyh9Q8jWYsioQrS/ZS2c0=;\n b=ZoQ4yCy/Mn/Ouvwo5OHpzzCs1Ylde+xrkqwzffSJ7GYEOSAiJG6gq49HQXIx7SO8WqyRdOZitSQAj0jAP0vsr9Qi8yLqi74Ag9fBdca0EwHuy5c+J4CXS/miJuEoU8N3Q6a3TDw7Gu4hb+FFz2EOW8EhX+tO8RbPiT1mSPiuNMQ=" ], "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 63.35.35.123)\n smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)\n header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none\n header.from=arm.com;", "Received-SPF": "Pass (protection.outlook.com: domain of arm.com designates\n 63.35.35.123 as permitted sender) receiver=protection.outlook.com;\n client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;", "X-CR-MTA-TID": "64aa7808", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=fbGZjLcEVaBA/C1RlSLGsWIJIwyHP2Pt6VGvtQjhTQyHHg8qYBQQJSLJYM4U25hZFLa6ZA7tYOwIMzLCApNvMieC0TGLaM3zRyDGAjBviPxuviiCKxBi4yFxG1892fErCD0X9eVN6v+Qx7iIPL03zPN7s5DKAu7FRCfocNpjGHIOxE/MxDKXfkypRnR7eXSXTe2NO7eQPHgc3ecMZClioLWrNRK4mn9h246yWgoJLIPM6Iuos8mjtTDIU6wk52MVvwj14CcKtsUsG6v0S4AukaVufenGfsC+QY4jXAAME0hF9anyZewT5nS6XbT0riCGmatJjxvkmcc90gXXZ8acGQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6+XtB+63LrDM/o5KW7NyTbUyh9Q8jWYsioQrS/ZS2c0=;\n b=Vxd8Goh81r/e1QditITEySNpV1weny5NtWeINeM2UaJ7gw8Ec4JxlcZV0wvM4oIwv33Sh3XIUzwFlpofbHuazsV4/suW6rNFwepUMVKpK2JynWzt9M6KA2s6+HWqzVU58CML5KtHEHIRVcwKrb8gz+Nz8S+9SejaDrhjfBgIlk3pnkuG2I+sJVcOdeSeefY9r4lwc4nE2uT3k6rBf9d/H5eRpaAr5Yu+ft8O6Q4HjyjTDQk37Ws5tAZ5xHnKCzXAvNEUk+8FVMiRFiMq/RKkc9vxKZN14QGwbPdS/UVRJhDPtHRRXudmUYzF52Llw6TLrGgDoDoUri6padTehM5U5w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass\n header.d=arm.com; arc=none", "From": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "To": "Andrew Rybchenko <arybchenko@solarflare.com>,\n \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Igor Romanov <igor.romanov@oktetlabs.ru>, \"stable@dpdk.org\"\n <stable@dpdk.org>, Harry van Haaren <harry.van.haaren@intel.com>, nd\n <nd@arm.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd\n <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices", "Thread-Index": "AQHWVEvPC7X1sWlfz0KyBFTM4K5SCaj8gekw", "Date": "Tue, 7 Jul 2020 19:33:05 +0000", "Message-ID": "\n <DB6PR0802MB221656C832AC241C3B20B85498660@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "References": "<1593873347-13686-1-git-send-email-arybchenko@solarflare.com>\n <1594118726-8421-1-git-send-email-arybchenko@solarflare.com>", "In-Reply-To": "<1594118726-8421-1-git-send-email-arybchenko@solarflare.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-ts-tracking-id": "16c086bf-7816-4e0b-a4f6-a787e9843b05.0", "x-checkrecipientchecked": "true", "Authentication-Results-Original": "solarflare.com; dkim=none (message not\n signed) header.d=none;solarflare.com; dmarc=none action=none\n header.from=arm.com;", "x-originating-ip": "[70.112.90.121]", "x-ms-publictraffictype": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "c22ac56c-ea92-438b-8254-08d822ac99c4", "x-ms-traffictypediagnostic": "DB6PR0801MB1734:|VI1PR08MB5502:", "x-ms-exchange-transport-forked": "True", "X-Microsoft-Antispam-PRVS": "\n <VI1PR08MB55024140C9F7418FE98B755E98660@VI1PR08MB5502.eurprd08.prod.outlook.com>", "x-checkrecipientrouted": "true", "nodisclaimer": "true", "x-ms-oob-tlc-oobclassifiers": "OLM:5236;OLM:5236;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam-Untrusted": "BCL:0;", "X-Microsoft-Antispam-Message-Info-Original": "\n p6f9HD9GRdRDVbF8Rp5R7Um6J5D5+LPMHQ5UOKHZZz/M0Uk1A2nPIjxD3xIk4k4+OQtGQ1KyzJqsNS29VSzFO+N6uB8wWAA0CxZfu+KeHKN85BozH5BwqkZGUIhPmn7YGhzMoOPBLIABDiuJqYfkptk67hKSo0A1YW79D2j8NDQPUPnWL3YzRjZoCxtx7DMrD9vUA6pfJuxT2XyvmHI0JDeQ5DBmy4ejtX3eUI8rtoXrbge7AJhJYPizlMIudnX2B9dhpCYmOJd1vI2N2ofggnndWZ+fRFxmdXNDYBxAfDdeEBKSLekqtPZGz5dUppoUAGzJljkWMo74SHcGlfHnRA==", "X-Forefront-Antispam-Report-Untrusted": "CIP:255.255.255.255; CTRY:; LANG:en;\n SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com;\n PTR:; CAT:NONE; SFTY:;\n SFS:(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(66476007)(66556008)(6506007)(186003)(66946007)(52536014)(8936002)(316002)(478600001)(110136005)(8676002)(54906003)(83380400001)(86362001)(66446008)(7696005)(9686003)(55016002)(64756008)(71200400001)(2906002)(76116006)(26005)(4326008)(5660300002)(33656002);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n yhBLJKLiex0kdZDQnz0Dq91Z/I7Dm55iCzn/hWNOBP3qr0hKf3Ig03Y4nxf38EdVx0jjre60l13dQI8I5FhynDio/TAGNKcpRBjboVc8BxFZHNdHpzyFSFFrij1hwd/xV65qw1DkXaG4MlP6sjKsX8Kvzdc+yM0EDSqV9JTK5Y0RnDVbgHITuYHTad13k55iTlbmDqjs54Ysi32WFbP8ZpxwpuXnYnSZuRZBnLMxGSNfoToD8dbemDe4dYwZWl+x6GZLQnhidxxoQZ0o3OVjkQsmndW8GLWPq+3fut+6oFcmaoIq4KVIXzRKbOjSjRqNfEDCA42Z/JDzrSuNQMiQKp4ajYufO8N4UGMESerNHvWZiwjfb8uGcfXhsmwmPH8+X0+9Gbzi2M0Djn1OTDbd+oXJ1XC3ygZz1Sguoa84+HqcqmQnTfpQ4M+pSPeUPpjGkKmT36UGsOPwNBuLLlJvYBtzmcdVts9I/UU2UgNC2GQb3dwdrdaF3T8wCF8JZr6y", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": [ "DB6PR0801MB1734", "VI1PR08MB5502" ], "Original-Authentication-Results": "solarflare.com;\n dkim=none (message not signed)\n header.d=none; solarflare.com;\n dmarc=none action=none header.from=arm.com;", "X-EOPAttributedMessage": "0", "X-MS-Exchange-Transport-CrossTenantHeadersStripped": "\n VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com", "X-Forefront-Antispam-Report": "CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;\n PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;\n SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(46966005)(36906005)(81166007)(316002)(82740400003)(356005)(450100002)(54906003)(47076004)(110136005)(4326008)(70206006)(70586007)(5660300002)(7696005)(86362001)(2906002)(186003)(336012)(6506007)(52536014)(33656002)(26005)(82310400002)(478600001)(55016002)(9686003)(83380400001)(8676002)(8936002);\n DIR:OUT; SFP:1101;", "X-MS-Office365-Filtering-Correlation-Id-Prvs": "\n 38c8d509-2bda-4c8d-bb85-08d822ac9202", "X-Forefront-PRVS": "0457F11EAF", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n W+EZCVWXzdYV9rH/QsQo88kkdWXNo98kxkKQzyr8B7H+cgT94PSgRfic4sdhj7aLoEzQ4SclpMOjwPJxEafTA9K2m4QD8x2mtbK+jW74Aqk1Wa0Wn/RXE3EFoCIVoJ8APz/2jX7r5uTF2+a/kjyDND67HsmhRp7IMAQQrCkzSMwYuQIaodG00xeRcIYyABvyqskvBn4kXEmjtvgeeTlayNqmHSCMrVQDCArcwbSVkmhfLubaSb7Hs7+fJdqScIBdcj8360hl82IKfCP6ME44752QMq+d4GovEJGjXUb/sPRUeyEOFrb/6R2952D0/ynpR+LcdiaTTUZp4pdAfGkwgfed0c6+3lEwE+TdPGzCQ3tfYEdwcAtCHvGmVlczeNB4c1Xnh24ip1MGJzOMHvwyQg==", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Jul 2020 19:33:18.0954 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c22ac56c-ea92-438b-8254-08d822ac99c4", "X-MS-Exchange-CrossTenant-Id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];\n Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "Subject": "Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115425, "web_url": "https://patches.dpdk.org/comment/115425/", "msgid": "<3073906.7FGJkFTaRg@thomas>", "list_archive_url": "https://inbox.dpdk.org/dev/3073906.7FGJkFTaRg@thomas", "date": "2020-07-07T21:56:46", "subject": "Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "07/07/2020 15:14, Van Haaren, Harry:\n> From: Andrew Rybchenko <arybchenko@solarflare.com>\n> > From: Igor Romanov <igor.romanov@oktetlabs.ru>\n> > \n> > The service core list is populated, but not used. Incorrect\n> > lcore states are examined for a service.\n> > \n> > Use the populated list to iterate over service cores.\n> > \n> > Fixes: e30d d318 47d2 (\"service: add mechanism for quiescing\")\n> > Cc: stable@dpdk.org\n> \n> I believe the original adding of quiescing did not have this exact bug (ids[] was used)?\n> It seems to have been introduced when reworking to avoid false sharing, so fixes is:\n> Fixes: e484ccddbe1b (\"services: avoid false sharing on core state\")\n> \n> \n> > Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\n> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n> \n> Code change itself: \n> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>\n\nSeries applied, thanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1E6A2A00BE;\n\tTue, 7 Jul 2020 23:56:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF9BE1DD9A;\n\tTue, 7 Jul 2020 23:56:52 +0200 (CEST)", "from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com\n [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 290991DD93;\n Tue, 7 Jul 2020 23:56:51 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 0CAD2BE1;\n Tue, 7 Jul 2020 17:56:49 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Tue, 07 Jul 2020 17:56:50 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 04F5630600B2;\n Tue, 7 Jul 2020 17:56:47 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=fm1; bh=\n 16m0CUXP+JVrRd6runUsr0t7gRghi2zOZQYjjsB6bjg=; b=q+Frlfm/JfC7wnHb\n cN2//DbZhLMcwHoeClviefk/oatebWsBhUMiit96z/U+ybdOFwmVS2gI6lhOQ4wR\n f6PZU3HETO6yai/07DCMjBWu2SPOGSd8cfqTBxZXmXm89/OQJik74dF3Wwa2WlQC\n yenfNx3pFBnPuFA3SGYYq2ocjUApJTePKqgEqx+qef1gvklA1ukkQMj6ma6Hm9WW\n /t/8O5CEmohFyPY1CD6OZ9ZogJC+B6JO5x4qr0p92aV2ebmmsTH5S08C0SD/Wh0/\n OuC5BMX0U4pCHO6pFlmxKuXrhHp4CO8z+/jjDILpmCdZ3t3XHkp8ghdVtHRFpMpc\n Q+5W2A==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:content-type\n :date:from:in-reply-to:message-id:mime-version:references\n :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm3; bh=16m0CUXP+JVrRd6runUsr0t7gRghi2zOZQYjjsB6b\n jg=; b=Lb52lyyPs+iyNDAfc+O9OnsxJvHQnSaI9IUW+iZH9Q5goVHOVEc3Zpxbn\n A6mmrgRyaXqqJTIGMkAWGODZrxVm2QoLN+jJM0IIwCj5GFKxQgnjaavorFUrd4QK\n CNo+oLdPBl6yAABT4Zf7CH1rbfA8erlP7S91D8wr78Na8L/4sTH2cktkSl4GTwSx\n RE/54eusSdkvCTm+cA5QchkCQSFsISmbvKbDI3tdaqALLqoeI7g7gvHc7Re1HLlI\n +jkg+5L4frkEmipghJ+QPEHUVodjsS+Y4sK/pkyadWLJKdR1JFDVzebVyXz9ervH\n oXnDleqwdghGOvs/oN5MgQjw5ivEQ==" ], "X-ME-Sender": "<xms:oO8EX93O0ZBcbclSE9O50YEh2Rlh-NQkQwHUheSSTbJqgvRgHlbAzQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeigddtgecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei\n iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:oO8EX0G-4cqBRTGZyYQ69P0oXy0yKsCxF5LQU4pleT153yI8NqJhnQ>\n <xmx:oO8EX96_WOzMn7z1YA4wYKYE7SelPL3j06T0IB-mWCgWW74149NcXQ>\n <xmx:oO8EX62Rtgf934x0VmYK1Qf8T6eVIcvRH7N-qz26vUlom5N0KQBDoQ>\n <xmx:oe8EX6NFW_-6Qz4PqsZbGs4QmHCOeUYLHqN1NxBkzcgWji-xH1BDPg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Andrew Rybchenko <arybchenko@solarflare.com>,\n Igor Romanov <igor.romanov@oktetlabs.ru>", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, \"stable@dpdk.org\" <stable@dpdk.org>,\n \"Van Haaren, Harry\" <harry.van.haaren@intel.com>", "Date": "Tue, 07 Jul 2020 23:56:46 +0200", "Message-ID": "<3073906.7FGJkFTaRg@thomas>", "In-Reply-To": "\n <BYAPR11MB31439E3827F2E116F60C16CED7660@BYAPR11MB3143.namprd11.prod.outlook.com>", "References": "<1593873347-13686-1-git-send-email-arybchenko@solarflare.com>\n <1594118726-8421-1-git-send-email-arybchenko@solarflare.com>\n <BYAPR11MB31439E3827F2E116F60C16CED7660@BYAPR11MB3143.namprd11.prod.outlook.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]