Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73404/?format=api
{ "id": 73404, "url": "https://patches.dpdk.org/api/patches/73404/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200707092244.12791-25-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200707092244.12791-25-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200707092244.12791-25-hemant.agrawal@nxp.com", "date": "2020-07-07T09:22:39", "name": "[v2,24/29] net/dpaa2: support ndex of queue action for flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "972b695550b33f81129fe20e68a4ef0058417fe0", "submitter": { "id": 477, "url": "https://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200707092244.12791-25-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 10842, "url": "https://patches.dpdk.org/api/series/10842/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10842", "date": "2020-07-07T09:22:15", "name": "NXP DPAAx enhancements", "version": 2, "mbox": "https://patches.dpdk.org/series/10842/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73404/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/73404/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79850A00BE;\n\tTue, 7 Jul 2020 11:32:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B3DA1DE04;\n\tTue, 7 Jul 2020 11:27:36 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id 39E061DD3C\n for <dev@dpdk.org>; Tue, 7 Jul 2020 11:27:15 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 1DD561A0A4F;\n Tue, 7 Jul 2020 11:27:15 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 643D31A0A30;\n Tue, 7 Jul 2020 11:27:13 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 27EC5402A8;\n Tue, 7 Jul 2020 17:27:11 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tJun Yang <jun.yang@nxp.com>", "Date": "Tue, 7 Jul 2020 14:52:39 +0530", "Message-Id": "<20200707092244.12791-25-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200707092244.12791-1-hemant.agrawal@nxp.com>", "References": "<20200527132326.1382-1-hemant.agrawal@nxp.com>\n <20200707092244.12791-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 24/29] net/dpaa2: support ndex of queue action\n\tfor flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jun Yang <jun.yang@nxp.com>\n\nMake more sense to use RXQ index for queue distribution\n\ninstead of flow ID.\n\nSigned-off-by: Jun Yang <jun.yang@nxp.com>\n---\n drivers/net/dpaa2/dpaa2_flow.c | 27 +++++++++++++++++----------\n 1 file changed, 17 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c\nindex 6f3139f86..76f68b903 100644\n--- a/drivers/net/dpaa2/dpaa2_flow.c\n+++ b/drivers/net/dpaa2/dpaa2_flow.c\n@@ -56,7 +56,6 @@ struct rte_flow {\n \tuint8_t tc_id; /** Traffic Class ID. */\n \tuint8_t tc_index; /** index within this Traffic Class. */\n \tenum rte_flow_action_type action;\n-\tuint16_t flow_id;\n \t/* Special for IP address to specify the offset\n \t * in key/mask.\n \t */\n@@ -3141,6 +3140,7 @@ dpaa2_generic_flow_set(struct rte_flow *flow,\n \tstruct dpni_qos_tbl_cfg qos_cfg;\n \tstruct dpni_fs_action_cfg action;\n \tstruct dpaa2_dev_priv *priv = dev->data->dev_private;\n+\tstruct dpaa2_queue *rxq;\n \tstruct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;\n \tsize_t param;\n \tstruct rte_flow *curr = LIST_FIRST(&priv->flows);\n@@ -3244,10 +3244,10 @@ dpaa2_generic_flow_set(struct rte_flow *flow,\n \t\tcase RTE_FLOW_ACTION_TYPE_QUEUE:\n \t\t\tdest_queue =\n \t\t\t\t(const struct rte_flow_action_queue *)(actions[j].conf);\n-\t\t\tflow->flow_id = dest_queue->index;\n+\t\t\trxq = priv->rx_vq[dest_queue->index];\n \t\t\tflow->action = RTE_FLOW_ACTION_TYPE_QUEUE;\n \t\t\tmemset(&action, 0, sizeof(struct dpni_fs_action_cfg));\n-\t\t\taction.flow_id = flow->flow_id;\n+\t\t\taction.flow_id = rxq->flow_id;\n \t\t\tif (is_keycfg_configured & DPAA2_QOS_TABLE_RECONFIGURE) {\n \t\t\t\tdpaa2_flow_qos_table_extracts_log(priv);\n \t\t\t\tif (dpkg_prepare_key_cfg(\n@@ -3303,8 +3303,6 @@ dpaa2_generic_flow_set(struct rte_flow *flow,\n \t\t\t}\n \t\t\t/* Configure QoS table first */\n \n-\t\t\taction.flow_id = action.flow_id % priv->num_rx_tc;\n-\n \t\t\tqos_index = flow->tc_id * priv->fs_entries +\n \t\t\t\tflow->tc_index;\n \n@@ -3407,13 +3405,22 @@ dpaa2_generic_flow_set(struct rte_flow *flow,\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_RSS:\n \t\t\trss_conf = (const struct rte_flow_action_rss *)(actions[j].conf);\n+\t\t\tif (rss_conf->queue_num > priv->dist_queues) {\n+\t\t\t\tDPAA2_PMD_ERR(\n+\t\t\t\t\t\"RSS number exceeds the distrbution size\");\n+\t\t\t\treturn -ENOTSUP;\n+\t\t\t}\n+\n \t\t\tfor (i = 0; i < (int)rss_conf->queue_num; i++) {\n-\t\t\t\tif (rss_conf->queue[i] <\n-\t\t\t\t\t(attr->group * priv->dist_queues) ||\n-\t\t\t\t\trss_conf->queue[i] >=\n-\t\t\t\t\t((attr->group + 1) * priv->dist_queues)) {\n+\t\t\t\tif (rss_conf->queue[i] >= priv->nb_rx_queues) {\n+\t\t\t\t\tDPAA2_PMD_ERR(\n+\t\t\t\t\t\t\"RSS RXQ number exceeds the total number\");\n+\t\t\t\t\treturn -ENOTSUP;\n+\t\t\t\t}\n+\t\t\t\trxq = priv->rx_vq[rss_conf->queue[i]];\n+\t\t\t\tif (rxq->tc_index != attr->group) {\n \t\t\t\t\tDPAA2_PMD_ERR(\n-\t\t\t\t\t\"Queue/Group combination are not supported\\n\");\n+\t\t\t\t\t\t\"RSS RXQ distributed is not in current group\");\n \t\t\t\t\treturn -ENOTSUP;\n \t\t\t\t}\n \t\t\t}\n", "prefixes": [ "v2", "24/29" ] }