Patch Comment List
List patch comments
GET /api/patches/73379/comments/?format=api&order=id
[ { "id": 115385, "web_url": "https://patches.dpdk.org/comment/115385/", "msgid": "<20200707090918.5e909cfe@hermes.lan>", "list_archive_url": "https://inbox.dpdk.org/dev/20200707090918.5e909cfe@hermes.lan", "date": "2020-07-07T16:09:18", "subject": "Re: [dpdk-dev] [PATCH] lib/librte_timer:fix corruption with reset", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "content": "On Tue, 7 Jul 2020 14:03:20 +0500\nSarosh Arif <sarosh.arif@emumba.com> wrote:\n\n> +\tstruct rte_timer_data *timer_data;\n> +\tTIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL);\n> +\n> +\tif (tim->status.state == RTE_TIMER_RUNNING &&\t\\\n> +\t(tim->status.owner != (uint16_t)tim_lcore ||\t\\\n> +\ttim != timer_data->priv_timer[tim_lcore].running_tim))\n> +\t\treturn -1;\n> +\n\nThis is code not a macro.\nLook at checkpatch output, no \\ in code.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6938AA00BE;\n\tTue, 7 Jul 2020 18:09:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C54DD1D9D5;\n\tTue, 7 Jul 2020 18:09:29 +0200 (CEST)", "from mail-pj1-f68.google.com (mail-pj1-f68.google.com\n [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id 20BC61D8F5\n for <dev@dpdk.org>; Tue, 7 Jul 2020 18:09:28 +0200 (CEST)", "by mail-pj1-f68.google.com with SMTP id mn17so5171703pjb.4\n for <dev@dpdk.org>; Tue, 07 Jul 2020 09:09:28 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id z13sm23007876pfq.220.2020.07.07.09.09.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Jul 2020 09:09:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=date:from:to:cc:subject:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Nt4X1dF653jFpBoijQMD9y8wAXCUW7q2v3c/FNPJbJI=;\n b=ifeXR1Gx8Gm3WyTQ9lMOZlgBNM7V54KA/0GP7bG/p+RiwcRvrpD6P0ybaGiy9gjn79\n PFhGxbsUuKrPiFj0eShLonBCk7X4cH8rAn2yuPITkvfRIsgCUbq5DA39Fd5WHXUYOPif\n yDg7JObgXVq5dj951QlIIcsqgvvGgG5PCFrz8A6IYGtNwIwbhLfokS806dPQZRbKW+oY\n wZH0FVQrCNbzdihhBqOocw0sWO0nJUQiW1jr6h1rLsaToUPITwCDbO3dAzb0fJZE85aP\n 6TARmTFu76iC0vOJYopFg+CDY3xJgsZKWHGMpzQPzedk8uo8OFwlnsWH1E3z3aWZUwYC\n TmYQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Nt4X1dF653jFpBoijQMD9y8wAXCUW7q2v3c/FNPJbJI=;\n b=HN0xi1bNxwgUKr9vXbQGPhYyR3RNJfPdwV+Jy2A3kXBHG5ObaOcE1EJu2Y9hMSZti5\n Kdfuln+RxGdJCDgM5AOjvDgfCqfyQhvCbF6ht/gialEgI5tnGLA37jqj1c0mhnJo5gs6\n 1O8blbkEgB7srFBMEJ0apJBAxxwWApXL9sXSu2IRFrVRYctvJYBXEI4WaNr+Qkhv/ppY\n uICgoQo+O1pEiNl+UJzlplNpZ0TeX5ApuOJxLkEnNk4U6VSSGBLulrzwVbcX5we0r4rs\n 2x4wyZnuOHAOuZOkC3e1T0NfHLRcpBJsnlEACxXPEd4kRgCgqesxbVOQI5KaRQgpYZnk\n rezQ==", "X-Gm-Message-State": "AOAM532svlM0w+aQTvaEmHdqnU6zooNXeJKDwxFdff9EedIsVhWeCN4G\n LnF/cPDdzwSzLbhYdxzCe5W5FQ==", "X-Google-Smtp-Source": "\n ABdhPJxKuc2L9kvlED7UWp7a8uMMHMtJ3+gwL+c43zAL+gscOW+jZGkHR/PGmPZmjtyinJEepUOoqQ==", "X-Received": "by 2002:a17:90a:d684:: with SMTP id\n x4mr5048296pju.62.1594138167230;\n Tue, 07 Jul 2020 09:09:27 -0700 (PDT)", "Date": "Tue, 7 Jul 2020 09:09:18 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Sarosh Arif <sarosh.arif@emumba.com>", "Cc": "rsanford@akamai.com, erik.g.carrillo@intel.com, dev@dpdk.org,\n stable@dpdk.org, h.mikita89@gmail.com", "Message-ID": "<20200707090918.5e909cfe@hermes.lan>", "In-Reply-To": "<20200707090320.2463-1-sarosh.arif@emumba.com>", "References": "<20200707090320.2463-1-sarosh.arif@emumba.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH] lib/librte_timer:fix corruption with reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]