List comments

GET /api/patches/73376/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116110,
        "web_url": "https://patches.dpdk.org/comment/116110/",
        "msgid": "<20200716205333.GA73752@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>",
        "date": "2020-07-16T20:53:33",
        "subject": "Re: [dpdk-dev] [PATCH v2 2/2] bus/vdev: build on Windows",
        "submitter": {
            "id": 1668,
            "url": "https://patches.dpdk.org/api/people/1668/",
            "name": "Narcisa Ana Maria Vasile",
            "email": "navasile@linux.microsoft.com"
        },
        "content": "On Tue, Jul 07, 2020 at 11:48:23AM +0300, talshn@mellanox.com wrote:\n> From: Tal Shnaiderman <talshn@mellanox.com>\n> \n> current support will build vdev with empty MP functions\n> currently unsupported for Windows.\n> \n> Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>\n> ---\n>  drivers/bus/vdev/meson.build       | 6 ------\n>  lib/librte_eal/rte_eal_exports.def | 5 +++++\n>  2 files changed, 5 insertions(+), 6 deletions(-)\n\nTested-by: Narcisa Vasile <navasile@linux.microsoft.com>\nAcked-by: Narcisa Vasile <navasile@linux.microsoft.com>\n\nThanks for the instructions on system configuration, Tal.\nCompiled with mingw and clang 9.0.0. VDEV is compiled and registered successfully.\nC:\\Users\\User\\hw> .\\dpdk-helloworld.exe -l 1\nEAL: Registered [vdev] bus.\nEAL: Registered [pci] bus.\nEAL: Detected 20 lcore(s)\nEAL: Detected 2 NUMA nodes\nEAL: Multi-process support is requested, but not available.\nEAL: Cannot access virt2phys driver, PA will not be available\nEAL: WARNING: TSC frequency estimated roughly - clock timings may be less accurate.\nhello from core 1\n\nWith clang I first got a linker error, that goes away if the symbol is added in the .def file:\nbus_vdev_vdev.c.obj : error LNK2019: unresolved external symbol per_lcore__thread_id referenced in function __vdev_logtype_bus\ndrivers\\librte_bus_vdev-20.0.dll : fatal error LNK1120: 1 unresolved externals",
        "headers": {
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "To": "talshn@mellanox.com",
            "In-Reply-To": "<20200707084823.28160-3-talshn@mellanox.com>",
            "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 1889A20B4909",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1594932813;\n bh=q9z0Jw2eh7zy/GBPTJKSp//odTNfGVXsXPphy1rCDOY=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=n1xoT8ekFpD2m4y7mUJqGO7rrRQ2FzT8CPtNCvi6g/nWXWJHV7/Hh7Qe49kDirJ6L\n CVXwFoMrpiLModqm1WT/hYax/XAb/ft9Anz8L8qAG/Wp8aLFdkAnCAc9os6SPyd1UG\n e8yKYtgKthOla4hHWEbtS1ozkLm5sRn1lrGQz4Ng=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "Message-ID": "\n <20200716205333.GA73752@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>",
            "X-BeenThere": "dev@dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C8C79A0540;\n\tThu, 16 Jul 2020 22:53:35 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 340D44F9A;\n\tThu, 16 Jul 2020 22:53:35 +0200 (CEST)",
                "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by dpdk.org (Postfix) with ESMTP id F13134C7B\n for <dev@dpdk.org>; Thu, 16 Jul 2020 22:53:33 +0200 (CEST)",
                "by linux.microsoft.com (Postfix, from userid 1059)\n id 1889A20B4909; Thu, 16 Jul 2020 13:53:33 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v2 2/2] bus/vdev: build on Windows",
            "Cc": "dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com,\n dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net,\n ranjit.menon@intel.com, harini.ramakrishnan@microsoft.com,\n ocardona@microsoft.com, anatoly.burakov@intel.com",
            "Content-Disposition": "inline",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Date": "Thu, 16 Jul 2020 13:53:33 -0700",
            "Precedence": "list",
            "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>",
            "User-Agent": "Mutt/1.5.21 (2010-09-15)",
            "MIME-Version": "1.0",
            "References": "<20200624145621.26604-2-talshn@mellanox.com>\n <20200707084823.28160-1-talshn@mellanox.com>\n <20200707084823.28160-3-talshn@mellanox.com>",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Type": "text/plain; charset=us-ascii",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "X-Mailman-Version": "2.1.15"
        }
    }
]