Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73375/?format=api
{ "id": 73375, "url": "https://patches.dpdk.org/api/patches/73375/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200707084823.28160-2-talshn@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200707084823.28160-2-talshn@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200707084823.28160-2-talshn@mellanox.com", "date": "2020-07-07T08:48:22", "name": "[v2,1/2] eal/windows: add needed calls to detect vdev PMD", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b31f5d3695e603c59172f80033cd28d3edb8aca4", "submitter": { "id": 1669, "url": "https://patches.dpdk.org/api/people/1669/?format=api", "name": "Tal Shnaiderman", "email": "talshn@mellanox.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200707084823.28160-2-talshn@mellanox.com/mbox/", "series": [ { "id": 10838, "url": "https://patches.dpdk.org/api/series/10838/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10838", "date": "2020-07-07T08:48:21", "name": "Windows bus/vdev support", "version": 2, "mbox": "https://patches.dpdk.org/series/10838/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73375/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73375/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 738ABA00BE;\n\tTue, 7 Jul 2020 10:49:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AC4461DB3E;\n\tTue, 7 Jul 2020 10:48:54 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 1296C1D964\n for <dev@dpdk.org>; Tue, 7 Jul 2020 10:48:51 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n talshn@mellanox.com) with SMTP; 7 Jul 2020 11:48:46 +0300", "from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx\n [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0678mkwM021055;\n Tue, 7 Jul 2020 11:48:46 +0300" ], "From": "talshn@mellanox.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,\n david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com,\n navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com,\n ocardona@microsoft.com, anatoly.burakov@intel.com,\n Tal Shnaiderman <talshn@mellanox.com>", "Date": "Tue, 7 Jul 2020 11:48:22 +0300", "Message-Id": "<20200707084823.28160-2-talshn@mellanox.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20200707084823.28160-1-talshn@mellanox.com>", "References": "<20200624145621.26604-2-talshn@mellanox.com>\n <20200707084823.28160-1-talshn@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v2 1/2] eal/windows: add needed calls to detect\n\tvdev PMD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Tal Shnaiderman <talshn@mellanox.com>\n\nAdd needed function calls in rte_eal_init to detect vdev PMD.\n\neal_option_device_parse()\nrte_service_init()\nrte_bus_probe()\n\nSigned-off-by: Tal Shnaiderman <talshn@mellanox.com>\n---\n lib/librte_eal/common/meson.build | 1 +\n lib/librte_eal/windows/eal.c | 20 ++++++++++++++++++++\n 2 files changed, 21 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build\nindex c1d9f21488..9f32262450 100644\n--- a/lib/librte_eal/common/meson.build\n+++ b/lib/librte_eal/common/meson.build\n@@ -31,6 +31,7 @@ if is_windows\n \t\t'malloc_heap.c',\n \t\t'rte_malloc.c',\n \t\t'eal_common_timer.c',\n+\t\t'rte_service.c',\n \t)\n \tsubdir_done()\n endif\ndiff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c\nindex eb10b4ef96..cbbf67e253 100644\n--- a/lib/librte_eal/windows/eal.c\n+++ b/lib/librte_eal/windows/eal.c\n@@ -17,6 +17,7 @@\n #include <eal_filesystem.h>\n #include <eal_options.h>\n #include <eal_private.h>\n+#include <rte_service_component.h>\n #include <rte_trace_point.h>\n #include <rte_vfio.h>\n \n@@ -273,6 +274,11 @@ rte_eal_init(int argc, char **argv)\n \tif (fctret < 0)\n \t\texit(1);\n \n+\tif (eal_option_device_parse()) {\n+\t\trte_errno = ENODEV;\n+\t\treturn -1;\n+\t}\n+\n \t/* Prevent creation of shared memory files. */\n \tif (internal_conf->in_memory == 0) {\n \t\tRTE_LOG(WARNING, EAL, \"Multi-process support is requested, \"\n@@ -362,6 +368,20 @@ rte_eal_init(int argc, char **argv)\n \t\t\trte_panic(\"Cannot create thread\\n\");\n \t}\n \n+\t/* initialize services so vdevs register service during bus_probe. */\n+\tif (rte_service_init()) {\n+\t\trte_eal_init_alert(\"rte_service_init() failed\");\n+\t\trte_errno = ENOEXEC;\n+\t\treturn -1;\n+\t}\n+\n+\t/* Probe all the buses and devices/drivers on them */\n+\tif (rte_bus_probe()) {\n+\t\trte_eal_init_alert(\"Cannot probe devices\");\n+\t\trte_errno = ENOTSUP;\n+\t\treturn -1;\n+\t}\n+\n \t/*\n \t * Launch a dummy function on all slave lcores, so that master lcore\n \t * knows they are all ready when this function returns.\n", "prefixes": [ "v2", "1/2" ] }