Patch Comment List
List patch comments
GET /api/patches/73371/comments/?format=api&order=-id
[ { "id": 115324, "web_url": "https://patches.dpdk.org/comment/115324/", "msgid": "<MN2PR11MB38072DB1678EBE8A865DE89AF7660@MN2PR11MB3807.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/MN2PR11MB38072DB1678EBE8A865DE89AF7660@MN2PR11MB3807.namprd11.prod.outlook.com", "date": "2020-07-07T08:15:40", "subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: support cloud filter with L4\n\tport", "submitter": { "id": 410, "url": "https://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "content": "> -----Original Message-----\n> From: Sun, GuinanX <guinanx.sun@intel.com>\n> Sent: Tuesday, July 7, 2020 2:34 PM\n> To: dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Sun,\n> GuinanX <guinanx.sun@intel.com>\n> Subject: [PATCH v3] net/i40e: support cloud filter with L4 port\n> \n> This patch enables the filter that supports to create following two rules for\n> the same packet type:\n> One is to select source port only as input set and the other is for destination\n> port only.\n> And the supported packet types are UDP/TCP/SCTP.\n> \n> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> ---\n> v3:\n> * Add limitation to i40e.rst\n> * Rename variables.\n> * Fixed the variable assignment.\n> v2:\n> * Fixed code style and variable naming\n> ---\n> doc/guides/nics/i40e.rst | 9 +\n> doc/guides/rel_notes/release_20_08.rst | 8 +\n> drivers/net/i40e/i40e_ethdev.c | 200 +++++++++++++++++++++-\n> drivers/net/i40e/i40e_ethdev.h | 18 ++\n> drivers/net/i40e/i40e_flow.c | 223 +++++++++++++++++++++++++\n> 5 files changed, 457 insertions(+), 1 deletion(-)\n> \n> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index\n> 00c3042d5..98a5537d7 100644\n> --- a/doc/guides/nics/i40e.rst\n> +++ b/doc/guides/nics/i40e.rst\n> @@ -736,6 +736,15 @@ with DPDK, then the configuration will also impact\n> port B in the NIC with kernel driver, which don't want to use the TPID.\n> So PMD reports warning to clarify what is changed by writing global register.\n> \n> +L4 port filter\n\nPlease don't use 'L4 port filter', there's no such filter type in i40e pipeline.\n\n> +~~~~~~~~~~~~~~\n> +\n> +L4 port filter is a new type of cloud filter.\n> +It is possible to generate two filters - one to select L4 DST port and\n> +second to select L4 SRC port.\n> +If the L4 port filter is used, the cloud filter using inner Vlan and\n> +Tunnel Key will be invalid.\n> +\n> High Performance of Small Packets on 40GbE NIC\n> ----------------------------------------------\n> \n> diff --git a/doc/guides/rel_notes/release_20_08.rst\n> b/doc/guides/rel_notes/release_20_08.rst\n> index f4b858727..d7d4c4e3b 100644\n> --- a/doc/guides/rel_notes/release_20_08.rst\n> +++ b/doc/guides/rel_notes/release_20_08.rst\n> @@ -108,6 +108,14 @@ New Features\n> * Dump ``rte_flow`` memory consumption.\n> * Measure packet per second forwarding.\n> \n> +* **Updated Intel i40e driver.**\n> +\n> + Updated i40e PMD with new features and improvements, including:\n> +\n> + * Added a new type of cloud filter to support the coexistence of the\n> + following two rules. One selects L4 destination port as input set and\n> + the other one selects L4 source port. We call it L4 port filter.\nWe didn't call it L4 port filter.\n\n> + But there are limitations on using the L4 port filter.\nI think no need to mention the limitation here, since you have added in i40e.rst\n\n<snip>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B89BBA00BE;\n\tTue, 7 Jul 2020 10:15:56 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8F2441D934;\n\tTue, 7 Jul 2020 10:15:55 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id C42F81D924\n for <dev@dpdk.org>; Tue, 7 Jul 2020 10:15:53 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jul 2020 01:15:43 -0700", "from orsmsx108.amr.corp.intel.com ([10.22.240.6])\n by fmsmga002.fm.intel.com with ESMTP; 07 Jul 2020 01:15:43 -0700", "from orsmsx608.amr.corp.intel.com (10.22.229.21) by\n ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 7 Jul 2020 01:15:42 -0700", "from orsmsx608.amr.corp.intel.com (10.22.229.21) by\n ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Tue, 7 Jul 2020 01:15:42 -0700", "from ORSEDG001.ED.cps.intel.com (10.7.248.4) by\n orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Tue, 7 Jul 2020 01:15:42 -0700", "from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by\n edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Tue, 7 Jul 2020 01:15:42 -0700", "from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24)\n by MN2PR11MB3853.namprd11.prod.outlook.com (2603:10b6:208:ea::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.29; Tue, 7 Jul\n 2020 08:15:41 +0000", "from MN2PR11MB3807.namprd11.prod.outlook.com\n ([fe80::401c:b4b:31c4:98b8]) by MN2PR11MB3807.namprd11.prod.outlook.com\n ([fe80::401c:b4b:31c4:98b8%3]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020\n 08:15:41 +0000" ], "IronPort-SDR": [ "\n F4MzNs+1JirtLzmoIconOyTfU9jQkktLdOZhxdcL77cU1JVUmxXNZxlEU2fYBalqrZ2ciXflbh\n Tk0LaG4TxCtA==", "\n OeYOPVpxtsuGcmc7z0yOj0MjldtDndVT09D7gqautxu6azaUtKDVjGYFjMwe1Luqyc6sHIIlgA\n Aha4PVl4o21g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9674\"; a=\"212526301\"", "E=Sophos;i=\"5.75,323,1589266800\"; d=\"scan'208\";a=\"212526301\"", "E=Sophos;i=\"5.75,323,1589266800\"; d=\"scan'208\";a=\"315450734\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CxRFukhX2n+bMqZu8F1TwyqbkYzW67Rht5vEcUWLCOE2fG7etWvE+8himAHhoB4aqOmVLNCIfMYAV0oeMOscaREFU1t8c0iMa4Hnp2DbSoXuwe77AYpLO/gU5ijepfLyGhPtaxyv0Pf2iQLXLf5ip+jUWIEdeATsWyKSp9rBnFwIvXgz1T7Z06R04BHS+vkfb7XwL9br57Nu11LLokvjaxZ/IP6xefnSaFTPH4zkGDcIkSo7HaQqWcqsBF/THRAE3CXgSW7Wml6Sx8oLKHpWXDvATJiBv5PCgPjIM3gYlWQ2FuIVRmSTa23b4uCti+dRn//TCHwvKEIJQMBrZlQhSA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=W8jNvMRHreHoRQWOEed+rGM1fRGezVy59vRzMr2rrzQ=;\n b=YCqHOGzDIlIYZYZzbPJ5SPnSC8/jzNqqAaLrOYspEgRVFpFodzMyOJlqLCvCxgY2ByEByxFopI0eegVslw6Z7ULivix6JCH1f3anRljuSHZfXR5Bvm13i3b88pa3jO471OhHTjijvrKS9ZyR0syWYzfLmo8b+cprBMgfZoMvcHBrehIRmA8X6SeSwF9IAqe6FgFbvwEO410u8WBolDEPNdDwnoxoXCmQm1XJ3Q7zUyf4umCAzppOzF/4AMkmZ3MEJ2lQ5DymuBWYf5bXVkvj+tNYhrez4ovv551Tg8lfrW5zNJkvxUKPs0xdmS6pvq3Ee44CiKQhcJb5TJxscg7gGw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=W8jNvMRHreHoRQWOEed+rGM1fRGezVy59vRzMr2rrzQ=;\n b=nJ3+4Ts8Gewtmok5El/Tw20Q5nUNGWZkgvspjMv47JovYTQYuIrsIlXI7DkG7aTTeGi31yiFIyHQsrjDbtqsZaYmJlK5O7rW48XWj78ebfHjBgGXTibH39CZJaH1kAkL663hCdIgHEahFV++ZTG0PQVCBWASN/2ht8uyFBuHY5U=", "From": "\"Xing, Beilei\" <beilei.xing@intel.com>", "To": "\"Sun, GuinanX\" <guinanx.sun@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Guo, Jia\" <jia.guo@intel.com>", "Thread-Topic": "[PATCH v3] net/i40e: support cloud filter with L4 port", "Thread-Index": "AQHWVCnM1XUSq2t0JUi2nJLsplU1z6j7tRGg", "Date": "Tue, 7 Jul 2020 08:15:40 +0000", "Message-ID": "\n <MN2PR11MB38072DB1678EBE8A865DE89AF7660@MN2PR11MB3807.namprd11.prod.outlook.com>", "References": "<20200611052416.14592-1-guinanx.sun@intel.com>\n <20200707063333.56791-1-guinanx.sun@intel.com>", "In-Reply-To": "<20200707063333.56791-1-guinanx.sun@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.102.204.38]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "197d8e04-c286-446f-151d-08d8224df02b", "x-ms-traffictypediagnostic": "MN2PR11MB3853:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <MN2PR11MB3853B9C69E9ED76B875A3844F7660@MN2PR11MB3853.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:7691;", "x-forefront-prvs": "0457F11EAF", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n HMais9j2/W4wTp9AldmQg0R5DRDLtldUI6P+cpyWynLBRrhipEv9zlPujUpoU9sATAoFiRHWv866xyJY/1Rlzv+/VRww8erpHavrUVxhqIEXdQlwqv81sHmOFgD3LB0ZhTZUqu84lA2/VzP8g9OB4JHYdelIF9NHWoXRcRNKcQAFApogflW3yWS6HW4ojmtQImVRT8UZ3O2iHNzFxtCUTXSVlRktIW7MgCFkEJRfyrgKVmujXJKEeDmTuurg4gzzFD0dJCQB5kvgpEYMUqvXFoLl7DgdipaaL+mN2JkNlcEHH+jMt0pPNttK/eRs0mnE", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(33656002)(5660300002)(9686003)(86362001)(52536014)(186003)(55016002)(26005)(478600001)(66556008)(66476007)(107886003)(64756008)(110136005)(8676002)(7696005)(83380400001)(6506007)(2906002)(8936002)(4326008)(66446008)(76116006)(316002)(66946007)(53546011)(71200400001);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n Qt2PhB747tH3eSmQdIQD+jXqKQa0D9Wt2EW8J4jaqoSozyV/2WxWwKWnI/E0hwN9Nvdvt5BBjqc1kEh4oOcQ36TUTU96NxnFVb3lpGlmIB3NvzG35p1sW/944gN9EpymgSSwtzeZgHrbXVFALchQUBKI8fzanqT3VzCEUAcJWHmU4Cg/u1IWiS/VdZMz6VCi+J6CGPfTOsBlt/AmBWoHx/WGC1RhzwAoG5dJo/HyqFkrVaNzPIe3EfgCyYhpAutpFIPcyotQdAeir8mD2RF9VjHO4GPba7rvWT+x+hwCYR0Mpp3Ey7//HuiechuNdCVm4Y6RShnw+GKMxWRzXmrBcC53F6C3YgBAs7KT9U66UZ7DnYlT4aP3BZs1P1bEAkDRS2XZU19gdTnqY4tr2SZZO5y8cjZxlivHUjMr5F7Yn/EKpqk93SYkLig+aX3A7FmXznxqaigFAcPxBTpAi5sj68piDposq78jH1Y95+F5l6pWgcK6BvjQb7naEIhcM7Nj", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "MN2PR11MB3807.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 197d8e04-c286-446f-151d-08d8224df02b", "X-MS-Exchange-CrossTenant-originalarrivaltime": "07 Jul 2020 08:15:40.8697 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n NtaXE2ASYEWFDy4buiCcXJldTMJehv/+nquxv7G3NyyzZC1XqpgO96yla91oUYVC7J47fs+TioE3bBu/+JVkyA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR11MB3853", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: support cloud filter with L4\n\tport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]