Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73369/?format=api
https://patches.dpdk.org/api/patches/73369/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200707052546.14151-4-jia.guo@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200707052546.14151-4-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200707052546.14151-4-jia.guo@intel.com", "date": "2020-07-07T05:25:45", "name": "[v5,3/4] net/ice: enable new input set for rss hash", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6042cc3c128b9646abd58e453cc93e246c7f677c", "submitter": { "id": 507, "url": "https://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200707052546.14151-4-jia.guo@intel.com/mbox/", "series": [ { "id": 10834, "url": "https://patches.dpdk.org/api/series/10834/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10834", "date": "2020-07-07T05:25:42", "name": "enable new hash flow for pf", "version": 5, "mbox": "https://patches.dpdk.org/series/10834/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73369/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73369/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8B711A00C5;\n\tTue, 7 Jul 2020 07:27:05 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 27AC31DAD8;\n\tTue, 7 Jul 2020 07:26:43 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id C65771DA8C\n for <dev@dpdk.org>; Tue, 7 Jul 2020 07:26:40 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2020 22:26:40 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by fmsmga007.fm.intel.com with ESMTP; 06 Jul 2020 22:26:38 -0700" ], "IronPort-SDR": [ "\n EbBfVvmBsQsJ1H/U1QtUZo8iDDf1l0xzaUyl6u1VDpnhvqrJvj9ngAsWPfyTWiGQP1rJ8bJJrw\n 5WGnaaa5ENOQ==", "\n Wlz3ag/A9xfY+mCjPtNgJ/zwy+8mTfhndX63qJblfTN6NyhqGfaMNuuSxZFOnZnTunDNZKqB1d\n sbvWw4wDbbyA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9674\"; a=\"145640342\"", "E=Sophos;i=\"5.75,321,1589266800\"; d=\"scan'208\";a=\"145640342\"", "E=Sophos;i=\"5.75,321,1589266800\"; d=\"scan'208\";a=\"266727855\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jeff Guo <jia.guo@intel.com>", "To": "qi.z.zhang@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, jingjing.wu@intel.com, junfeng.guo@intel.com,\n beilei.xing@intel.com, simei.su@intel.com, jia.guo@intel.com", "Date": "Tue, 7 Jul 2020 13:25:45 +0800", "Message-Id": "<20200707052546.14151-4-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200707052546.14151-1-jia.guo@intel.com>", "References": "<20200621140927.20602-2-jia.guo@intel.com>\n <20200707052546.14151-1-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [dpdk-dev v5 3/4] net/ice: enable new input set for rss\n\thash", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "PF could add or delete a RSS rule base on the PF's hash capability.\nSome new rss input set will be supported, the protocols as below:\neth/vlan/l2tpv3/esp/ah/pfcp.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\nv5->v4:\nfix checkpatch issue\nrefine for eth/vlan hash\n---\n drivers/net/ice/ice_hash.c | 146 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 146 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex 2aacd70ec..f23cc9517 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -124,6 +124,45 @@ struct rss_type_match_hdr hint_eth_pppoes_ipv4_tcp = {\n struct rss_type_match_hdr hint_eth_pppoes_ipv4_sctp = {\n \tICE_FLOW_SEG_HDR_PPPOE,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_SCTP};\n+struct rss_type_match_hdr hint_eth_ipv4_esp = {\n+\tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_ESP,\n+\tETH_RSS_ETH | ETH_RSS_IPV4 | ETH_RSS_ESP};\n+struct rss_type_match_hdr hint_eth_ipv4_udp_esp = {\n+\tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_NAT_T_ESP,\n+\tETH_RSS_ETH | ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_ESP};\n+struct rss_type_match_hdr hint_eth_ipv4_ah = {\n+\tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_AH,\n+\tETH_RSS_ETH | ETH_RSS_IPV4 | ETH_RSS_AH};\n+struct rss_type_match_hdr hint_eth_ipv4_l2tpv3 = {\n+\tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_L2TPV3,\n+\tETH_RSS_ETH | ETH_RSS_IPV4 | ETH_RSS_L2TPV3};\n+struct rss_type_match_hdr hint_eth_ipv4_pfcp = {\n+\tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_PFCP_SESSION,\n+\tETH_RSS_ETH | ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_PFCP};\n+struct rss_type_match_hdr hint_eth_vlan_ipv4 = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER,\n+\tETH_RSS_ETH | ETH_RSS_IPV4 | ETH_RSS_C_VLAN};\n+struct rss_type_match_hdr hint_eth_vlan_ipv4_udp = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_UDP,\n+\tETH_RSS_ETH | ETH_RSS_C_VLAN |\n+\tETH_RSS_NONFRAG_IPV4_UDP};\n+struct rss_type_match_hdr hint_eth_vlan_ipv4_tcp = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP,\n+\tETH_RSS_ETH | ETH_RSS_C_VLAN |\n+\tETH_RSS_NONFRAG_IPV4_TCP};\n+struct rss_type_match_hdr hint_eth_vlan_ipv4_sctp = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV4 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP,\n+\tETH_RSS_ETH | ETH_RSS_C_VLAN |\n+\tETH_RSS_NONFRAG_IPV4_SCTP};\n struct rss_type_match_hdr hint_eth_ipv6 = {\n \tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER,\n \tETH_RSS_ETH | ETH_RSS_IPV6};\n@@ -139,6 +178,45 @@ struct rss_type_match_hdr hint_eth_ipv6_sctp = {\n \tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n \tICE_FLOW_SEG_HDR_SCTP,\n \tETH_RSS_ETH | ETH_RSS_NONFRAG_IPV6_SCTP};\n+struct rss_type_match_hdr hint_eth_ipv6_esp = {\n+\tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_ESP,\n+\tETH_RSS_ETH | ETH_RSS_IPV6 | ETH_RSS_ESP};\n+struct rss_type_match_hdr hint_eth_ipv6_udp_esp = {\n+\tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_NAT_T_ESP,\n+\tETH_RSS_ETH | ETH_RSS_NONFRAG_IPV6_UDP | ETH_RSS_ESP};\n+struct rss_type_match_hdr hint_eth_ipv6_ah = {\n+\tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_AH,\n+\tETH_RSS_ETH | ETH_RSS_IPV6 | ETH_RSS_AH};\n+struct rss_type_match_hdr hint_eth_ipv6_l2tpv3 = {\n+\tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_L2TPV3,\n+\tETH_RSS_ETH | ETH_RSS_IPV6 | ETH_RSS_L2TPV3};\n+struct rss_type_match_hdr hint_eth_ipv6_pfcp = {\n+\tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER |\n+\tICE_FLOW_SEG_HDR_PFCP_SESSION,\n+\tETH_RSS_ETH | ETH_RSS_NONFRAG_IPV6_UDP | ETH_RSS_PFCP};\n+struct rss_type_match_hdr hint_eth_vlan_ipv6 = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER,\n+\tETH_RSS_ETH | ETH_RSS_IPV6 | ETH_RSS_C_VLAN};\n+struct rss_type_match_hdr hint_eth_vlan_ipv6_udp = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_UDP,\n+\tETH_RSS_ETH | ETH_RSS_C_VLAN |\n+\tETH_RSS_NONFRAG_IPV6_UDP};\n+struct rss_type_match_hdr hint_eth_vlan_ipv6_tcp = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP,\n+\tETH_RSS_ETH | ETH_RSS_C_VLAN |\n+\tETH_RSS_NONFRAG_IPV6_TCP};\n+struct rss_type_match_hdr hint_eth_vlan_ipv6_sctp = {\n+\tICE_FLOW_SEG_HDR_VLAN | ICE_FLOW_SEG_HDR_IPV6 |\n+\tICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP,\n+\tETH_RSS_ETH | ETH_RSS_C_VLAN |\n+\tETH_RSS_NONFRAG_IPV6_SCTP};\n struct rss_type_match_hdr hint_eth_pppoes_ipv6 = {\n \tICE_FLOW_SEG_HDR_PPPOE,\n \tETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_IPV6};\n@@ -196,6 +274,24 @@ static struct ice_pattern_match_item ice_hash_pattern_list_comms[] = {\n \t\t&hint_eth_pppoes_ipv4_tcp},\n \t{pattern_eth_pppoes_ipv4_sctp,\t ICE_INSET_NONE,\n \t\t&hint_eth_pppoes_ipv4_sctp},\n+\t{pattern_eth_ipv4_esp,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv4_esp},\n+\t{pattern_eth_ipv4_udp_esp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv4_udp_esp},\n+\t{pattern_eth_ipv4_ah,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv4_ah},\n+\t{pattern_eth_ipv4_l2tp,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv4_l2tpv3},\n+\t{pattern_eth_ipv4_pfcp,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv4_pfcp},\n+\t{pattern_eth_vlan_ipv4,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv4},\n+\t{pattern_eth_vlan_ipv4_udp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv4_udp},\n+\t{pattern_eth_vlan_ipv4_tcp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv4_tcp},\n+\t{pattern_eth_vlan_ipv4_sctp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv4_sctp},\n \t{pattern_eth_ipv6,\t\t ICE_INSET_NONE,\n \t\t&hint_eth_ipv6},\n \t{pattern_eth_ipv6_udp,\t\t ICE_INSET_NONE,\n@@ -204,6 +300,24 @@ static struct ice_pattern_match_item ice_hash_pattern_list_comms[] = {\n \t\t&hint_eth_ipv6_tcp},\n \t{pattern_eth_ipv6_sctp,\t\t ICE_INSET_NONE,\n \t\t&hint_eth_ipv6_sctp},\n+\t{pattern_eth_ipv6_esp,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv6_esp},\n+\t{pattern_eth_ipv6_udp_esp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv6_udp_esp},\n+\t{pattern_eth_ipv6_ah,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv6_ah},\n+\t{pattern_eth_ipv6_l2tp,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv6_l2tpv3},\n+\t{pattern_eth_ipv6_pfcp,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_ipv6_pfcp},\n+\t{pattern_eth_vlan_ipv6,\t\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv6},\n+\t{pattern_eth_vlan_ipv6_udp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv6_udp},\n+\t{pattern_eth_vlan_ipv6_tcp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv6_tcp},\n+\t{pattern_eth_vlan_ipv6_sctp,\t ICE_INSET_NONE,\n+\t\t&hint_eth_vlan_ipv6_sctp},\n \t{pattern_eth_pppoes_ipv6,\t ICE_INSET_NONE,\n \t\t&hint_eth_pppoes_ipv6},\n \t{pattern_eth_pppoes_ipv6_udp,\t ICE_INSET_NONE,\n@@ -221,11 +335,34 @@ static struct ice_pattern_match_item ice_hash_pattern_list_comms[] = {\n * the second member is hash fields.\n */\n struct ice_hash_match_type ice_hash_type_list[] = {\n+\t{ETH_RSS_L2_SRC_ONLY,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA)},\n+\t{ETH_RSS_L2_DST_ONLY,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ETH_DA)},\n+\t{ETH_RSS_ETH | ETH_RSS_L2_SRC_ONLY,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA)},\n+\t{ETH_RSS_ETH | ETH_RSS_L2_DST_ONLY,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ETH_DA)},\n+\t{ETH_RSS_ETH,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA) |\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ETH_DA)},\n \t{ETH_RSS_PPPOE,\n \t\tICE_FLOW_HASH_PPPOE_SESS_ID},\n \t{ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_L2_SRC_ONLY,\n \t\tICE_FLOW_HASH_PPPOE_SESS_ID |\n \t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ETH_SA)},\n+\t{ETH_RSS_C_VLAN,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_C_VLAN)},\n+\t{ETH_RSS_S_VLAN,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_S_VLAN)},\n+\t{ETH_RSS_ESP,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_ESP_SPI)},\n+\t{ETH_RSS_AH,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_AH_SPI)},\n+\t{ETH_RSS_L2TPV3,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_L2TPV3_SESS_ID)},\n+\t{ETH_RSS_PFCP,\n+\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_PFCP_SEID)},\n \t/* IPV4 */\n \t{ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY,\n \t\tBIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_SA)},\n@@ -602,6 +739,15 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n \t\t\t\t}\n \t\t\t}\n \n+\t\t\t/* update hash field for nat-t esp. */\n+\t\t\tif (rss_type == ETH_RSS_ESP &&\n+\t\t\t (m->eth_rss_hint & ETH_RSS_NONFRAG_IPV4_UDP)) {\n+\t\t\t\thash_meta->hash_flds &=\n+\t\t\t\t~(BIT_ULL(ICE_FLOW_FIELD_IDX_ESP_SPI));\n+\t\t\t\thash_meta->hash_flds |=\n+\t\t\t\tBIT_ULL(ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI);\n+\t\t\t}\n+\n \t\t\t/* update hash field for gtpu-ip and gtpu-eh. */\n \t\t\tif (rss_type != ETH_RSS_GTPU)\n \t\t\t\tbreak;\n", "prefixes": [ "v5", "3/4" ] }{ "id": 73369, "url": "