Patch Comment List
List patch comments
GET /api/patches/73367/comments/?format=api
[ { "id": 115371, "web_url": "https://patches.dpdk.org/comment/115371/", "msgid": "<d9d4e9f1-a0a5-c15f-dc81-46c9e8e7aef9@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d9d4e9f1-a0a5-c15f-dc81-46c9e8e7aef9@intel.com", "date": "2020-07-07T14:24:57", "subject": "Re: [dpdk-dev] [dpdk-dev v5 1/4] net/ice: refactor for pf hash flow", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 7/7/2020 6:25 AM, Jeff Guo wrote:\n> Refactor hash flow by change the action parser and clean some code.\n> \n> Signed-off-by: Jeff Guo <jia.guo@intel.com>\n\n<...>\n\n> @@ -333,46 +507,24 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n> \t\tswitch (action_type) {\n> \t\tcase RTE_FLOW_ACTION_TYPE_RSS:\n> \t\t\trss = action->conf;\n> -\t\t\trss_hf = rss->types;\n> -\n> -\t\t\t/**\n> -\t\t\t * Check simultaneous use of SRC_ONLY and DST_ONLY\n> -\t\t\t * of the same level.\n> -\t\t\t */\n> -\t\t\trss_hf = rte_eth_rss_hf_refine(rss_hf);\n> +\t\t\trss_type = rss->types;\n> \n> -\t\t\t/* Check if pattern is empty. */\n> +\t\t\t/* Check hash function and save it to rss_meta. */\n> \t\t\tif (pattern_match_item->pattern_list !=\n> -\t\t\t\tpattern_empty && rss->func ==\n> -\t\t\t\tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR)\n> +\t\t\t pattern_empty && rss->func ==\n> +\t\t\t RTE_ETH_HASH_FUNCTION_SIMPLE_XOR) {\n> \t\t\t\treturn rte_flow_error_set(error, ENOTSUP,\n> \t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n> \t\t\t\t\t\"Not supported flow\");\n> -\n> -\t\t\tif ((rss_hf & ETH_RSS_ETH) && (rss_hf & ~ETH_RSS_PPPOE))\n> -\t\t\t\tm->eth_rss_hint = ETH_RSS_ETH;\n> -\t\t\telse if ((rss_hf & ETH_RSS_PPPOE) && (rss_hf & ~ETH_RSS_ETH))\n> -\t\t\t\tm->eth_rss_hint = ETH_RSS_PPPOE;\n> -\t\t\telse if ((rss_hf & ETH_RSS_ETH) && (rss_hf & ETH_RSS_PPPOE))\n> -\t\t\t\tm->eth_rss_hint = ETH_RSS_ETH | ETH_RSS_PPPOE;\n> -\n> -\t\t\t/* Check if rss types match pattern. */\n> -\t\t\tif (rss->func != RTE_ETH_HASH_FUNCTION_SIMPLE_XOR) {\n> -\t\t\t\tif (((rss_hf & ETH_RSS_IPV4) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_IPV6) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_ETH) != m->eth_rss_hint) &&\n> -\t\t\t\t((rss_hf & ETH_RSS_PPPOE) != m->eth_rss_hint) &&\n> -\t\t\t\t(((rss_hf & (ETH_RSS_ETH | ETH_RSS_PPPOE)) !=\n> -\t\t\t\t\t\t\t\t\tm->eth_rss_hint)))\n> -\t\t\t\t\treturn rte_flow_error_set(error,\n> -\t\t\t\t\tENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,\n> -\t\t\t\t\taction, \"Not supported RSS types\");\n> +\t\t\t} else if (rss->func ==\n> +\t\t\t\t RTE_ETH_HASH_FUNCTION_SIMPLE_XOR){\n> +\t\t\t\t((struct rss_meta *)*meta)->hash_function =\n> +\t\t\t\tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR;\n> +\t\t\t\treturn 0;\n> +\t\t\t} else if (rss->func ==\n> +\t\t\t\t RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {\n> +\t\t\t\t((struct rss_meta *)*meta)->hash_function =\n> +\t\t\t\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ;\n> \t\t\t}\n> \n> \t\t\tif (rss->level)\n> @@ -390,42 +542,38 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n> \t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n> \t\t\t\t\t\"a non-NULL RSS queue is not supported\");\n> \n> -\t\t\t/* Check hash function and save it to rss_meta. */\n> -\t\t\tif (rss->func ==\n> -\t\t\t\tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR)\n> -\t\t\t\t((struct rss_meta *)*meta)->hash_function =\n> -\t\t\t\tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR;\n> +\t\t\t/**\n> +\t\t\t * Check simultaneous use of SRC_ONLY and DST_ONLY\n> +\t\t\t * of the same level.\n> +\t\t\t */\n> +\t\t\trss_type = rte_eth_rss_hf_refine(rss_type);\n> \n> -\t\t\tif (rss->func ==\n> -\t\t\t\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)\n> -\t\t\t\t((struct rss_meta *)*meta)->hash_function =\n> -\t\t\t\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ;\n> +\t\t\tuint64_t combine_type = ETH_RSS_L2_SRC_ONLY |\n> +\t\t\t\t\tETH_RSS_L2_DST_ONLY |\n> +\t\t\t\t\tETH_RSS_L3_SRC_ONLY |\n> +\t\t\t\t\tETH_RSS_L3_DST_ONLY |\n> +\t\t\t\t\tETH_RSS_L4_SRC_ONLY |\n> +\t\t\t\t\tETH_RSS_L4_DST_ONLY;\n\n\nDeclaring and initializing a varible in switch case causing warning with icc\n[1], I will fix this while mergin by moving declaration out of switch.\n\n[1]\n.../dpdk/drivers/net/ice/ice_hash.c(672):\n warning #589: transfer of control bypasses initialization of:\n variable \"combine_type\" (declared at line 716)\n switch (action_type) {\n ^\n\n<...>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 78C06A00BE;\n\tTue, 7 Jul 2020 16:25:06 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C4A4E1DDF4;\n\tTue, 7 Jul 2020 16:25:05 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 778A31DD05\n for <dev@dpdk.org>; Tue, 7 Jul 2020 16:25:03 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jul 2020 07:25:01 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.213.248.101])\n ([10.213.248.101])\n by FMSMGA003.fm.intel.com with ESMTP; 07 Jul 2020 07:24:59 -0700" ], "IronPort-SDR": [ "\n vlWbWvA0GoUxo0eyHTm8MC4oOF72bDVquWwq4okVpMUBK7Hpco3TxvnCvl2Vx8Q+CRJ98De+GM\n GoWb7yM5KyNw==", "\n 2UZmUe//8Lvq3x+11xXeY6K+XIoXkOzAq8u7ST7WkP7tOktHNjlJ9pR4yzuQtmjt8LJzeyfhC7\n hu6NMXSLSRkg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9674\"; a=\"147616118\"", "E=Sophos;i=\"5.75,324,1589266800\"; d=\"scan'208\";a=\"147616118\"", "E=Sophos;i=\"5.75,324,1589266800\"; d=\"scan'208\";a=\"322674148\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Jeff Guo <jia.guo@intel.com>, qi.z.zhang@intel.com, qiming.yang@intel.com", "Cc": "dev@dpdk.org, jingjing.wu@intel.com, junfeng.guo@intel.com,\n beilei.xing@intel.com, simei.su@intel.com", "References": "<20200621140927.20602-2-jia.guo@intel.com>\n <20200707052546.14151-1-jia.guo@intel.com>\n <20200707052546.14151-2-jia.guo@intel.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK\n CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl\n eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk\n UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT\n PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO\n lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC\n ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2\n 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H\n 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo\n cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx\n Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp\n e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59\n gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES\n YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai\n bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD\n UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/\n 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj\n sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc\n q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7\n 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB\n VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI\n 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC\n GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b\n cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz\n EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H\n o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2\n 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA\n WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA\n 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T\n GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n\n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv\n ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae\n dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ==", "Message-ID": "<d9d4e9f1-a0a5-c15f-dc81-46c9e8e7aef9@intel.com>", "Date": "Tue, 7 Jul 2020 15:24:57 +0100", "MIME-Version": "1.0", "In-Reply-To": "<20200707052546.14151-2-jia.guo@intel.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [dpdk-dev v5 1/4] net/ice: refactor for pf hash flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]