Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7336/?format=api
{ "id": 7336, "url": "https://patches.dpdk.org/api/patches/7336/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1443635297-13106-3-git-send-email-ehkinzie@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1443635297-13106-3-git-send-email-ehkinzie@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1443635297-13106-3-git-send-email-ehkinzie@gmail.com", "date": "2015-09-30T17:48:15", "name": "[dpdk-dev,v5,2/4] bond mode 4: do not ignore multicast", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fa7153883268a3671c32154b05400796367c42ee", "submitter": { "id": 208, "url": "https://patches.dpdk.org/api/people/208/?format=api", "name": "Eric Kinzie", "email": "ehkinzie@gmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1443635297-13106-3-git-send-email-ehkinzie@gmail.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7336/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3C00A8E68;\n\tWed, 30 Sep 2015 19:48:38 +0200 (CEST)", "from mail-ig0-f174.google.com (mail-ig0-f174.google.com\n\t[209.85.213.174]) by dpdk.org (Postfix) with ESMTP id ADD5A8E58\n\tfor <dev@dpdk.org>; Wed, 30 Sep 2015 19:48:34 +0200 (CEST)", "by igbkq10 with SMTP id kq10so111113032igb.0\n\tfor <dev@dpdk.org>; Wed, 30 Sep 2015 10:48:34 -0700 (PDT)", "from buildhost2.vyatta.com. ([144.49.197.22])\n\tby smtp.gmail.com with ESMTPSA id\n\tb10sm753288igb.9.2015.09.30.10.48.32\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Sep 2015 10:48:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Z6yYmSGaFigf2qJGeEIwSoeEwwtdIYq3A+DJm/Z23IQ=;\n\tb=G9ocLg6vl6zkwJc4jP1hDTR3+VUZRuBW9wXIdrMgT9SmAM4Aco2/3OHgh8sDhV03U4\n\t1fIRud1CFXp8mQEWAMpBR86v8UAGU7mTpwGK/7uz5Vqgfso3VrvLJZ4zlGeaHfYnOe6G\n\tGv0VpZEbV8pFCz+vVyUT2KfyGXlRUzwxphU7NfABZ9q/p+b5Eq7DPFfO0LNLT3IKtHxk\n\tK9daotS78zGItUs8iFCXxnbexF9KbTG7vAlNjSLNot789QPcBP9pwGWR5gpbF8GipSOd\n\t5COObCNH+sWAp1m8W8v4rvRqIU27jmuVJ0fK/oHLiVAMfH5h6yv3dcOHy95fxG3QR3ug\n\t4z9A==", "X-Received": "by 10.50.142.73 with SMTP id ru9mr6635899igb.84.1443635314165;\n\tWed, 30 Sep 2015 10:48:34 -0700 (PDT)", "From": "Eric Kinzie <ehkinzie@gmail.com>", "To": "dev@dpdk.org", "Date": "Wed, 30 Sep 2015 10:48:15 -0700", "Message-Id": "<1443635297-13106-3-git-send-email-ehkinzie@gmail.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1443635297-13106-1-git-send-email-ehkinzie@gmail.com>", "References": "<1443635297-13106-1-git-send-email-ehkinzie@gmail.com>", "Cc": "Eric Kinzie <ekinzie@brocade.com>", "Subject": "[dpdk-dev] [PATCH v5 2/4] bond mode 4: do not ignore multicast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Eric Kinzie <ekinzie@brocade.com>\n\nThe bonding PMD in mode 4 puts all enslaved interfaces into promiscuous\nmode in order to receive LACPDUs and must filter unwanted packets\nafter the traffic has been \"collected\". Allow broadcast and multicast\nthrough so that ARP and IPv6 neighbor discovery continue to work.\n\nFixes: 46fb43683679 (\"bond: add mode 4\")\n\nSigned-off-by: Eric Kinzie <ehkinzie@gmail.com>\n---\n app/test/test_link_bonding_mode4.c | 7 +++++--\n drivers/net/bonding/rte_eth_bond_pmd.c | 1 +\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c\nindex 460539d..d785393 100644\n--- a/app/test/test_link_bonding_mode4.c\n+++ b/app/test/test_link_bonding_mode4.c\n@@ -749,8 +749,11 @@ test_mode4_rx(void)\n \trte_eth_macaddr_get(test_params.bonded_port_id, &bonded_mac);\n \tether_addr_copy(&bonded_mac, &dst_mac);\n \n-\t/* Assert that dst address is not bonding address */\n-\tdst_mac.addr_bytes[0]++;\n+\t/* Assert that dst address is not bonding address. Do not set the\n+\t * least significant bit of the zero byte as this would create a\n+\t * multicast address.\n+\t */\n+\tdst_mac.addr_bytes[0] += 2;\n \n \t/* First try with promiscuous mode enabled.\n \t * Add 2 packets to each slave. First with bonding MAC address, second with\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 5cc6372..733022b 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -170,6 +170,7 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,\n \t\t\t * mode and packet address does not match. */\n \t\t\tif (unlikely(hdr->ether_type == ether_type_slow_be ||\n \t\t\t\t!collecting || (!promisc &&\n+\t\t\t\t\t!is_multicast_ether_addr(&hdr->d_addr) &&\n \t\t\t\t\t!is_same_ether_addr(&bond_mac, &hdr->d_addr)))) {\n \n \t\t\t\tif (hdr->ether_type == ether_type_slow_be) {\n", "prefixes": [ "dpdk-dev", "v5", "2/4" ] }