Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73356/?format=api
{ "id": 73356, "url": "https://patches.dpdk.org/api/patches/73356/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1594085898-138749-1-git-send-email-simei.su@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594085898-138749-1-git-send-email-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594085898-138749-1-git-send-email-simei.su@intel.com", "date": "2020-07-07T01:38:18", "name": "net/ice: fix GTPU/PPPoE packets with no hash value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fe001c339fcbb6dc50831c1204b5410e4896abdd", "submitter": { "id": 1298, "url": "https://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1594085898-138749-1-git-send-email-simei.su@intel.com/mbox/", "series": [ { "id": 10829, "url": "https://patches.dpdk.org/api/series/10829/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10829", "date": "2020-07-07T01:38:18", "name": "net/ice: fix GTPU/PPPoE packets with no hash value", "version": 1, "mbox": "https://patches.dpdk.org/series/10829/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73356/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE4F3A00BE;\n\tTue, 7 Jul 2020 03:39:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BBC911DBD9;\n\tTue, 7 Jul 2020 03:39:24 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id CF8D61DB94\n for <dev@dpdk.org>; Tue, 7 Jul 2020 03:39:22 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2020 18:39:21 -0700", "from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com)\n ([10.67.110.178])\n by orsmga003.jf.intel.com with ESMTP; 06 Jul 2020 18:39:19 -0700" ], "IronPort-SDR": [ "\n UEDIKFTnXpcOK5vKm6elx1U4MKW9lfCD9wjVOJKOb1LB/aS6c4u4d7iAAOp3JhLGzThGgTVIVz\n opcgdq85/ZTg==", "\n kMd5Sy6wfVVSllWti8vbPJvP0Qfmw/SRJ35ZCrBUsRxXvlwhLuaum3ib3zDEUTD7cVvexVIFYX\n mrfpkPoofgEg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9674\"; a=\"147535747\"", "E=Sophos;i=\"5.75,321,1589266800\"; d=\"scan'208\";a=\"147535747\"", "E=Sophos;i=\"5.75,321,1589266800\"; d=\"scan'208\";a=\"279449716\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, wei.zhao1@intel.com, junyux.jiang@intel.com,\n nannan.lu@intel.com, Simei Su <simei.su@intel.com>", "Date": "Tue, 7 Jul 2020 09:38:18 +0800", "Message-Id": "<1594085898-138749-1-git-send-email-simei.su@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] net/ice: fix GTPU/PPPoE packets with no hash\n\tvalue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When RSS init, because of profile overlap, the GTPU_IPV4 packets\ndon't hit GTPU_INNER_IPV4 profile which causes no hash value. Because\nof no PPPoE profile, the PPPoE packets also has no hash value. This\npatch solves this issue by pulling GTPU_IPV4 profile into inner ipv4\ngroup and creating related PPPoE profile at the same time.\n\nFixes: 8cadc41294c6 (\"net/ice: initialize and update RSS based on user config\")\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 80 ++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 80 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 0af9405..85b9eb4 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2533,6 +2533,86 @@ static int ice_parse_devargs(struct rte_eth_dev *dev)\n \t\t\tPMD_DRV_LOG(ERR, \"%s SCTP_IPV6 rss flow fail %d\",\n \t\t\t\t __func__, ret);\n \t}\n+\n+\tif (rss_hf & ETH_RSS_IPV4) {\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_FLOW_HASH_IPV4,\n+\t\t\t\tICE_FLOW_SEG_HDR_GTPU_IP, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s GTPU_IPV4 rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_FLOW_HASH_IPV4,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV4 rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n+\n+\tif (rss_hf & ETH_RSS_IPV6) {\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_FLOW_HASH_IPV6,\n+\t\t\t\tICE_FLOW_SEG_HDR_GTPU_IP, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s GTPU_IPV6 rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_FLOW_HASH_IPV6,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV6 rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n+\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) {\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_UDP_IPV4,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV4_UDP rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n+\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) {\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_UDP_IPV6,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV6_UDP rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n+\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) {\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_TCP_IPV4,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV4_TCP rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n+\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) {\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_TCP_IPV6,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV6_TCP rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n+\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) {\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_SCTP_IPV4,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV4_SCTP rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n+\n+\tif (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) {\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s GTPU_IPV6_SCTP rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\n+\t\tret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_SCTP_IPV6,\n+\t\t\t\tICE_FLOW_SEG_HDR_PPPOE, 0);\n+\t\tif (ret)\n+\t\t\tPMD_DRV_LOG(ERR, \"%s PPPoE_IPV6_SCTP rss flow fail %d\",\n+\t\t\t\t __func__, ret);\n+\t}\n }\n \n static int ice_init_rss(struct ice_pf *pf)\n", "prefixes": [] }