Patch Comment List
List patch comments
GET /api/patches/73345/comments/?format=api
[ { "id": 154227, "web_url": "https://patches.dpdk.org/comment/154227/", "msgid": "<98CBD80474FA8B44BF855DF32C47DC35D8747E@smartserver.smartshare.dk>", "list_archive_url": "https://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D8747E@smartserver.smartshare.dk", "date": "2022-11-03T09:02:09", "subject": "RE: [dpdk-dev] [PATCH v6 06/10] eal: register non-EAL threads as\n lcores", "submitter": { "id": 591, "url": "https://patches.dpdk.org/api/people/591/?format=api", "name": "Morten Brørup", "email": "mb@smartsharesystems.com" }, "content": "> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand\n> Sent: Monday, 6 July 2020 22.53\n> \n> DPDK allows calling some part of its API from a non-EAL thread but this\n> has some limitations.\n> OVS (and other applications) has its own thread management but still\n> want to avoid such limitations by hacking RTE_PER_LCORE(_lcore_id) and\n> faking EAL threads potentially unknown of some DPDK component.\n> \n> Introduce a new API to register non-EAL thread and associate them to a\n> free lcore with a new NON_EAL role.\n> This role denotes lcores that do not run DPDK mainloop and as such\n> prevents use of rte_eal_wait_lcore() and consorts.\n> \n> Multiprocess is not supported as the need for cohabitation with this\n> new\n> feature is unclear at the moment.\n> \n> Signed-off-by: David Marchand <david.marchand@redhat.com>\n> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>\n> Acked-by: Thomas Monjalon <thomas@monjalon.net>\n> ---\n\nFollowing up on a two+ years old patch series, triggered by the discussion [1] about statistics counters in the mempool library...\n\nThe rte_lcore_role_t enum values are missing the RTE_ prefix, and the meanings of the four values should be documented with comments in the source code.\n\nAlso, the documentation [2] could benefit from some elaboration about the lcore roles. I had to read the source code in depth to understand that each \"registered non-EAL thread\" has a unique lcore_id, which is not used by any other EAL or non-EAL thread.\n\n[1]: http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D8747D@smartserver.smartshare.dk/T/#u\n[2]: http://doc.dpdk.org/guides/prog_guide/env_abstraction_layer.html#multiple-pthread", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD975A00C2;\n\tThu, 3 Nov 2022 10:02:12 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3D60140694;\n\tThu, 3 Nov 2022 10:02:12 +0100 (CET)", "from smartserver.smartsharesystems.com\n (smartserver.smartsharesystems.com [77.243.40.215])\n by mails.dpdk.org (Postfix) with ESMTP id 43EDD40693\n for <dev@dpdk.org>; Thu, 3 Nov 2022 10:02:10 +0100 (CET)" ], "X-MimeOLE": "Produced By Microsoft Exchange V6.5", "Content-class": "urn:content-classes:message", "MIME-Version": "1.0", "Content-Type": "text/plain;\n\tcharset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "Subject": "RE: [dpdk-dev] [PATCH v6 06/10] eal: register non-EAL threads as\n lcores", "Date": "Thu, 3 Nov 2022 10:02:09 +0100", "Message-ID": "<98CBD80474FA8B44BF855DF32C47DC35D8747E@smartserver.smartshare.dk>", "In-Reply-To": "<20200706205234.8040-7-david.marchand@redhat.com>", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "Thread-Topic": "[dpdk-dev] [PATCH v6 06/10] eal: register non-EAL threads as\n lcores", "Thread-Index": "AdZT15JJTJ1qhSNvQn6m3Jkgp/8qboU3EYQg", "References": "<20200610144506.30505-1-david.marchand@redhat.com>\n <20200706205234.8040-1-david.marchand@redhat.com>\n <20200706205234.8040-7-david.marchand@redhat.com>", "From": "=?iso-8859-1?q?Morten_Br=F8rup?= <mb@smartsharesystems.com>", "To": "\"David Marchand\" <david.marchand@redhat.com>,\n <andrew.rybchenko@oktetlabs.ru>, <thomas@monjalon.net>, <dev@dpdk.org>", "Cc": "<mattias.ronnblom@ericsson.com>, <jerinjacobk@gmail.com>,\n <bruce.richardson@intel.com>, <mdr@ashroe.eu>, <ktraynor@redhat.com>,\n <ian.stokes@intel.com>, <i.maximets@ovn.org>, <olivier.matz@6wind.com>,\n <konstantin.ananyev@intel.com>, \"John McNamara\" <john.mcnamara@intel.com>,\n \"Marko Kovacevic\" <marko.kovacevic@intel.com>,\n \"Anatoly Burakov\" <anatoly.burakov@intel.com>,\n \"Neil Horman\" <nhorman@tuxdriver.com>,\n \"Harini Ramakrishnan\" <harini.ramakrishnan@microsoft.com>,\n \"Omar Cardona\" <ocardona@microsoft.com>,\n \"Pallavi Kadam\" <pallavi.kadam@intel.com>,\n \"Ranjit Menon\" <ranjit.menon@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }, { "id": 154229, "web_url": "https://patches.dpdk.org/comment/154229/", "msgid": "<12730205.ZYm5mLc6kN@thomas>", "list_archive_url": "https://inbox.dpdk.org/dev/12730205.ZYm5mLc6kN@thomas", "date": "2022-11-03T10:15:37", "subject": "Re: [dpdk-dev] [PATCH v6 06/10] eal: register non-EAL threads as\n lcores", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "03/11/2022 10:02, Morten Brørup:\n> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand\n> > Sent: Monday, 6 July 2020 22.53\n> > \n> > DPDK allows calling some part of its API from a non-EAL thread but this\n> > has some limitations.\n> > OVS (and other applications) has its own thread management but still\n> > want to avoid such limitations by hacking RTE_PER_LCORE(_lcore_id) and\n> > faking EAL threads potentially unknown of some DPDK component.\n> > \n> > Introduce a new API to register non-EAL thread and associate them to a\n> > free lcore with a new NON_EAL role.\n> > This role denotes lcores that do not run DPDK mainloop and as such\n> > prevents use of rte_eal_wait_lcore() and consorts.\n> > \n> > Multiprocess is not supported as the need for cohabitation with this\n> > new\n> > feature is unclear at the moment.\n> > \n> > Signed-off-by: David Marchand <david.marchand@redhat.com>\n> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>\n> > Acked-by: Thomas Monjalon <thomas@monjalon.net>\n> > ---\n> \n> Following up on a two+ years old patch series, triggered by the discussion [1] about statistics counters in the mempool library...\n> \n> The rte_lcore_role_t enum values are missing the RTE_ prefix, and the meanings of the four values should be documented with comments in the source code.\n> \n> Also, the documentation [2] could benefit from some elaboration about the lcore roles. I had to read the source code in depth to understand that each \"registered non-EAL thread\" has a unique lcore_id, which is not used by any other EAL or non-EAL thread.\n\nYou probably have the best point of view to improve the documentation.\nFeel free to work on a patch.\n\n> [1]: http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D8747D@smartserver.smartshare.dk/T/#u\n> [2]: http://doc.dpdk.org/guides/prog_guide/env_abstraction_layer.html#multiple-pthread", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 44B7AA00C2;\n\tThu, 3 Nov 2022 11:15:47 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 23ECE40694;\n\tThu, 3 Nov 2022 11:15:47 +0100 (CET)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id D126940693\n for <dev@dpdk.org>; Thu, 3 Nov 2022 11:15:44 +0100 (CET)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n by mailout.nyi.internal (Postfix) with ESMTP id 73F065C01EA;\n Thu, 3 Nov 2022 06:15:42 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute4.internal (MEProxy); Thu, 03 Nov 2022 06:15:42 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Thu,\n 3 Nov 2022 06:15:39 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:date:date:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to; s=fm3; t=1667470542; x=\n 1667556942; bh=PNyAd1IliSZhDPjppYiyAvCEEgRvECs3BKtRnow7VUg=; b=g\n 4v73SkVNSQ3yc+FtD0h0SL3gwaDtwMIYgq6Ib8SnCzbpxxz8qGHhH0xitouogm+x\n 00PVkw46CvUYyrROgjiCNz5cUBivit8/RJsAbAM9i3njsw+yK+FtzHWHlML9YFwJ\n yuwJZHpZbHBo8aSOPgMeGZTPgQcG6ejQMrR4F4RZ+dODd20qSlnDrshueWNDp2co\n 8gFsMB7aZKjaupiT66kZQYPLylWSzwY2XdNUrcnMIqarr7QyqSfLXYbAvyVgH5qq\n jFIoGY33HQrRtO4exGAsuKEoS+BKovbGm2rk5f0i9O2oFW/5ybWkAkalcHNRiJG1\n QeFlkcpbaxVJE7TNbD3Pg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667470542; x=\n 1667556942; bh=PNyAd1IliSZhDPjppYiyAvCEEgRvECs3BKtRnow7VUg=; b=a\n bFYiqebQI9kqrS2ouAQHWIO0hizW9fyQ7FGvOwbtzSSsTDzAxbGXkkWZF4k0peuM\n UcdZt7FLdT4RVvOtY8Drv0NqSfmObZCQVatP+Gh15nX3fbFE12sJmhWzoIav1rUV\n weS1fOIVtScRyOmjsT8SGDyVIdYj5qUB6z77Uicj7sWRxhozTRoFWzBBAXmo+g/M\n hppsSLfGyYGC3tijjL3XF3X3T/vr0QmLJd0iXevddcW1f6hnJAGaohi/YN3GhbUf\n q/BrE75LgiS5fFq7IVD6Gj5Fnom8Jx2fMneMSL6CfZFcBiOYWJasxlXqaBpEE01D\n 2oBi6upVJF9Xi2SjucPRw==" ], "X-ME-Sender": "<xms:zZRjY-qrbygiaP-cRjPyj6s0BRb0Mx9va5RZq0mDr1tXx7YJTlR6ZA>\n <xme:zZRjY8qKrjtpAQfR6oXDj9y66RbJR8MagapQJjZVp-aw9XpxQrx2jQdrAZ0EMnqxk\n 1TuLNtnvO6Wb78Hug>", "X-ME-Received": "\n <xmr:zZRjYzPsmk9iaarh2baf9eQ-__3VEbArInwyuEczUr2PnPm0NazEYKnwvglMFvjTNDYRKM_cx3v5AyhSyuiuxA0jxA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvgedrudelgddtkecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepgeejiedvleehudfhuefgfeevgfehieetgeeigffggfffffeiuefg\n ueektdeffeevnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii\n gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn\n rdhnvght", "X-ME-Proxy": "<xmx:zZRjY97PE1O2Wc60pf5b4LkrTCFWjlGlbwKLqJhjnnsdyGoj167Tug>\n <xmx:zZRjY965HI0wVIRoVg6O3dRaEkSYjilZ2Wo6SLTaQMRNCjPhIw9Q_g>\n <xmx:zZRjY9gzx0GjuEqMEuxuSfnrX8dxIatuRZbp9rx5SXWL49x3KIwRLg>\n <xmx:zpRjY_u48jcb0ii03HOjsWqzf_zbeYrEtNyPAHHxBZMj4MP97HKaWw>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Morten =?iso-8859-1?q?Br=F8rup?= <mb@smartsharesystems.com>", "Cc": "David Marchand <david.marchand@redhat.com>, andrew.rybchenko@oktetlabs.ru,\n dev@dpdk.org, mattias.ronnblom@ericsson.com, jerinjacobk@gmail.com,\n bruce.richardson@intel.com, mdr@ashroe.eu, ktraynor@redhat.com,\n ian.stokes@intel.com, i.maximets@ovn.org, olivier.matz@6wind.com,\n konstantin.ananyev@intel.com, John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Neil Horman <nhorman@tuxdriver.com>,\n Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,\n Omar Cardona <ocardona@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Ranjit Menon <ranjit.menon@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH v6 06/10] eal: register non-EAL threads as\n lcores", "Date": "Thu, 03 Nov 2022 11:15:37 +0100", "Message-ID": "<12730205.ZYm5mLc6kN@thomas>", "In-Reply-To": "\n <98CBD80474FA8B44BF855DF32C47DC35D8747E@smartserver.smartshare.dk>", "References": "<20200610144506.30505-1-david.marchand@redhat.com>\n <20200706205234.8040-7-david.marchand@redhat.com>\n <98CBD80474FA8B44BF855DF32C47DC35D8747E@smartserver.smartshare.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null } ]