Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73344/?format=api
{ "id": 73344, "url": "https://patches.dpdk.org/api/patches/73344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200706205234.8040-6-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200706205234.8040-6-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200706205234.8040-6-david.marchand@redhat.com", "date": "2020-07-06T20:52:29", "name": "[v6,05/10] eal: move lcore role code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f8772f10ef952ce49b65cd716b7d1018c6ac975e", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200706205234.8040-6-david.marchand@redhat.com/mbox/", "series": [ { "id": 10826, "url": "https://patches.dpdk.org/api/series/10826/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10826", "date": "2020-07-06T20:52:25", "name": "Register non-EAL threads as lcore", "version": 6, "mbox": "https://patches.dpdk.org/series/10826/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73344/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64D9CA00C5;\n\tMon, 6 Jul 2020 22:53:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 07F0A1DDCB;\n\tMon, 6 Jul 2020 22:53:19 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81])\n by dpdk.org (Postfix) with ESMTP id 9699D1DDB2\n for <dev@dpdk.org>; Mon, 6 Jul 2020 22:53:16 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-17-AnpXXKGrOSW0jv0XcyCXRQ-1; Mon, 06 Jul 2020 16:53:14 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC843107ACCA;\n Mon, 6 Jul 2020 20:53:12 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.195.188])\n by smtp.corp.redhat.com (Postfix) with ESMTP id EF98C10013D7;\n Mon, 6 Jul 2020 20:53:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594068796;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Y5UmPDetSguFHR7+Q6HgUR9fIKdBU6knHAb/1PE6gVg=;\n b=ZHW949MJq+UDCzT5Xqj9tOMyOqolKsAHsNizVI3jsq+KIFaAU0Kzwqqhz3avCr0N32EPZ0\n DGXJJqkHULY7MPoV3rCE0tRKUCGtHB7mUVCSG6SFw6FIGxj3cuRdDHkDQ1hNFWEy3QPpeT\n URMTgJ+EFQ+wt4eeaxc7B/fVSLK8HQg=", "X-MC-Unique": "AnpXXKGrOSW0jv0XcyCXRQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "jerinjacobk@gmail.com, bruce.richardson@intel.com, mdr@ashroe.eu,\n thomas@monjalon.net, arybchenko@solarflare.com, ktraynor@redhat.com,\n ian.stokes@intel.com, i.maximets@ovn.org, olivier.matz@6wind.com,\n konstantin.ananyev@intel.com", "Date": "Mon, 6 Jul 2020 22:52:29 +0200", "Message-Id": "<20200706205234.8040-6-david.marchand@redhat.com>", "In-Reply-To": "<20200706205234.8040-1-david.marchand@redhat.com>", "References": "<20200610144506.30505-1-david.marchand@redhat.com>\n <20200706205234.8040-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 05/10] eal: move lcore role code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For consistency sake, move all lcore role code in the dedicated\ncompilation unit / header.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nReviewed-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_eal/common/eal_common_lcore.c | 11 +++++++\n lib/librte_eal/common/eal_common_thread.c | 11 -------\n lib/librte_eal/include/rte_eal.h | 9 ------\n lib/librte_eal/include/rte_lcore.h | 37 ++++++++++++++---------\n 4 files changed, 34 insertions(+), 34 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c\nindex 5404922a87..86d32a3dd7 100644\n--- a/lib/librte_eal/common/eal_common_lcore.c\n+++ b/lib/librte_eal/common/eal_common_lcore.c\n@@ -63,6 +63,17 @@ rte_eal_lcore_role(unsigned int lcore_id)\n \treturn cfg->lcore_role[lcore_id];\n }\n \n+int\n+rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)\n+{\n+\tstruct rte_config *cfg = rte_eal_get_configuration();\n+\n+\tif (lcore_id >= RTE_MAX_LCORE)\n+\t\treturn -EINVAL;\n+\n+\treturn cfg->lcore_role[lcore_id] == role;\n+}\n+\n int rte_lcore_is_enabled(unsigned int lcore_id)\n {\n \tstruct rte_config *cfg = rte_eal_get_configuration();\ndiff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c\nindex 6d1c87b1c2..b1b69ea58c 100644\n--- a/lib/librte_eal/common/eal_common_thread.c\n+++ b/lib/librte_eal/common/eal_common_thread.c\n@@ -33,17 +33,6 @@ unsigned rte_socket_id(void)\n \treturn RTE_PER_LCORE(_socket_id);\n }\n \n-int\n-rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)\n-{\n-\tstruct rte_config *cfg = rte_eal_get_configuration();\n-\n-\tif (lcore_id >= RTE_MAX_LCORE)\n-\t\treturn -EINVAL;\n-\n-\treturn cfg->lcore_role[lcore_id] == role;\n-}\n-\n static int\n eal_cpuset_socket_id(rte_cpuset_t *cpusetp)\n {\ndiff --git a/lib/librte_eal/include/rte_eal.h b/lib/librte_eal/include/rte_eal.h\nindex 2edf8c6556..0913d1947c 100644\n--- a/lib/librte_eal/include/rte_eal.h\n+++ b/lib/librte_eal/include/rte_eal.h\n@@ -31,15 +31,6 @@ extern \"C\" {\n /* Maximum thread_name length. */\n #define RTE_MAX_THREAD_NAME_LEN 16\n \n-/**\n- * The lcore role (used in RTE or not).\n- */\n-enum rte_lcore_role_t {\n-\tROLE_RTE,\n-\tROLE_OFF,\n-\tROLE_SERVICE,\n-};\n-\n /**\n * The type of process in a linux, multi-process setup\n */\ndiff --git a/lib/librte_eal/include/rte_lcore.h b/lib/librte_eal/include/rte_lcore.h\nindex 5c1d1926e9..3968c40693 100644\n--- a/lib/librte_eal/include/rte_lcore.h\n+++ b/lib/librte_eal/include/rte_lcore.h\n@@ -24,6 +24,15 @@ extern \"C\" {\n \n RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread \"lcore id\". */\n \n+/**\n+ * The lcore role (used in RTE or not).\n+ */\n+enum rte_lcore_role_t {\n+\tROLE_RTE,\n+\tROLE_OFF,\n+\tROLE_SERVICE,\n+};\n+\n /**\n * Get a lcore's role.\n *\n@@ -34,6 +43,20 @@ RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread \"lcore id\". */\n */\n enum rte_lcore_role_t rte_eal_lcore_role(unsigned int lcore_id);\n \n+/**\n+ * Test if the core supplied has a specific role\n+ *\n+ * @param lcore_id\n+ * The identifier of the lcore, which MUST be between 0 and\n+ * RTE_MAX_LCORE-1.\n+ * @param role\n+ * The role to be checked against.\n+ * @return\n+ * Boolean value: positive if test is true; otherwise returns 0.\n+ */\n+int\n+rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role);\n+\n /**\n * Return the Application thread ID of the execution unit.\n *\n@@ -283,20 +306,6 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,\n \t\tconst pthread_attr_t *attr,\n \t\tvoid *(*start_routine)(void *), void *arg);\n \n-/**\n- * Test if the core supplied has a specific role\n- *\n- * @param lcore_id\n- * The identifier of the lcore, which MUST be between 0 and\n- * RTE_MAX_LCORE-1.\n- * @param role\n- * The role to be checked against.\n- * @return\n- * Boolean value: positive if test is true; otherwise returns 0.\n- */\n-int\n-rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role);\n-\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "v6", "05/10" ] }