Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73341/?format=api
{ "id": 73341, "url": "https://patches.dpdk.org/api/patches/73341/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200706205234.8040-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200706205234.8040-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200706205234.8040-3-david.marchand@redhat.com", "date": "2020-07-06T20:52:26", "name": "[v6,02/10] eal: fix multiple definition of per lcore thread id", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9d7fa848c9ec61782743ed217642dc25acfcbfb8", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200706205234.8040-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 10826, "url": "https://patches.dpdk.org/api/series/10826/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10826", "date": "2020-07-06T20:52:25", "name": "Register non-EAL threads as lcore", "version": 6, "mbox": "https://patches.dpdk.org/series/10826/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73341/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/73341/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CFD2BA00C5;\n\tMon, 6 Jul 2020 22:53:15 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0B41C1DD98;\n\tMon, 6 Jul 2020 22:53:04 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 9C1931DDA0\n for <dev@dpdk.org>; Mon, 6 Jul 2020 22:53:02 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-299-IN6uaA1vPLOOI3q_PAocJg-1; Mon, 06 Jul 2020 16:52:58 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C96619057A1;\n Mon, 6 Jul 2020 20:52:56 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.195.188])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 73B1610013D7;\n Mon, 6 Jul 2020 20:52:52 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594068782;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=IjQH3o5vrTe6Zpd/Fs4V4CyF2gqsWVvqVq9M2ax0z+o=;\n b=F/M3S6a1AqbmQLc1lJ3NfJkhGX4HWFAFJkHxKw3/VcJukznujn137oScMUN+jcAMPxe/SE\n 6mrPdPXjjAM2m7Ab7ieM6A/a1liVwGFrcuO4BRh4oV3HyW1QLhWFYYG+mYCRKe76xMfFv+\n CO5CYkOmppzdwPcZ5XjTCoMm5DxMXSQ=", "X-MC-Unique": "IN6uaA1vPLOOI3q_PAocJg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "jerinjacobk@gmail.com, bruce.richardson@intel.com, mdr@ashroe.eu,\n thomas@monjalon.net, arybchenko@solarflare.com, ktraynor@redhat.com,\n ian.stokes@intel.com, i.maximets@ovn.org, olivier.matz@6wind.com,\n konstantin.ananyev@intel.com, Neil Horman <nhorman@tuxdriver.com>,\n Cunming Liang <cunming.liang@intel.com>", "Date": "Mon, 6 Jul 2020 22:52:26 +0200", "Message-Id": "<20200706205234.8040-3-david.marchand@redhat.com>", "In-Reply-To": "<20200706205234.8040-1-david.marchand@redhat.com>", "References": "<20200610144506.30505-1-david.marchand@redhat.com>\n <20200706205234.8040-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 02/10] eal: fix multiple definition of per\n\tlcore thread id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Because of the inline accessor + static declaration in rte_gettid(),\nwe end up with multiple symbols for RTE_PER_LCORE(_thread_id).\nEach compilation unit will pay a cost when accessing this information\nfor the first time.\n\n$ nm build/app/dpdk-testpmd | grep per_lcore__thread_id\n0000000000000054 d per_lcore__thread_id.5037\n0000000000000040 d per_lcore__thread_id.5103\n0000000000000048 d per_lcore__thread_id.5259\n000000000000004c d per_lcore__thread_id.5259\n0000000000000044 d per_lcore__thread_id.5933\n0000000000000058 d per_lcore__thread_id.6261\n0000000000000050 d per_lcore__thread_id.7378\n000000000000005c d per_lcore__thread_id.7496\n000000000000000c d per_lcore__thread_id.8016\n0000000000000010 d per_lcore__thread_id.8431\n\nMake it global as part of the DPDK_21 stable ABI.\n\nFixes: ef76436c6834 (\"eal: get unique thread id\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Ray Kinsella <mdr@ashroe.eu>\nReviewed-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_eal/common/eal_common_thread.c | 1 +\n lib/librte_eal/include/rte_eal.h | 3 ++-\n lib/librte_eal/rte_eal_version.map | 7 +++++++\n 3 files changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c\nindex 7be80c292e..fd13453fee 100644\n--- a/lib/librte_eal/common/eal_common_thread.c\n+++ b/lib/librte_eal/common/eal_common_thread.c\n@@ -22,6 +22,7 @@\n #include \"eal_thread.h\"\n \n RTE_DEFINE_PER_LCORE(unsigned int, _lcore_id) = LCORE_ID_ANY;\n+RTE_DEFINE_PER_LCORE(int, _thread_id) = -1;\n static RTE_DEFINE_PER_LCORE(unsigned int, _socket_id) =\n \t(unsigned int)SOCKET_ID_ANY;\n static RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset);\ndiff --git a/lib/librte_eal/include/rte_eal.h b/lib/librte_eal/include/rte_eal.h\nindex 2f9ed298de..2edf8c6556 100644\n--- a/lib/librte_eal/include/rte_eal.h\n+++ b/lib/librte_eal/include/rte_eal.h\n@@ -447,6 +447,8 @@ enum rte_intr_mode rte_eal_vfio_intr_mode(void);\n */\n int rte_sys_gettid(void);\n \n+RTE_DECLARE_PER_LCORE(int, _thread_id);\n+\n /**\n * Get system unique thread id.\n *\n@@ -456,7 +458,6 @@ int rte_sys_gettid(void);\n */\n static inline int rte_gettid(void)\n {\n-\tstatic RTE_DEFINE_PER_LCORE(int, _thread_id) = -1;\n \tif (RTE_PER_LCORE(_thread_id) == -1)\n \t\tRTE_PER_LCORE(_thread_id) = rte_sys_gettid();\n \treturn RTE_PER_LCORE(_thread_id);\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 196eef5afa..0d42d44ce9 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -221,6 +221,13 @@ DPDK_20.0 {\n \tlocal: *;\n };\n \n+DPDK_21 {\n+\tglobal:\n+\n+\tper_lcore__thread_id;\n+\n+} DPDK_20.0;\n+\n EXPERIMENTAL {\n \tglobal:\n \n", "prefixes": [ "v6", "02/10" ] }